On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor out security code to helper class >> - Print aliases. Order Provider type/service output. > > src/java.base/share/classes/sun/launcher/LauncherHelper.java line 276: > >> 274: first = false; >> 275: } else { // following lines prefix with indents >> 276: ostream.println(TWOINDENT + s); > > I assume these changes are be reverted now. > @AlanBateman - I was planning to keep this trivial change. Does it not read > better ? It would be better if the name is shortened to printSecuritySettings and it takes an indent parameter, that avoid needing to change the accessibility of INDENT. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1234287743