On Thu, 6 Jul 2023 21:03:29 GMT, Naoto Sato wrote:
> Removing the IDE specific `@SuppressWarnings` attached to
> `java.util.Calendar#equals()`. `equals()` implementation now checks the type
> of the other instance for this.
Marked as reviewed by lancea (Reviewer).
-
PR Review: ht
On Thu, 6 Jul 2023 19:32:09 GMT, Justin Lu wrote:
>> Please review this PR which refactors additional tests in Locale to use
>> JUnit.
>>
>> If a test was named bugNNN.java, it was renamed to something more
>> descriptive.
>>
>> Below is a list of all the changes
>>
>> - Refactor and Ren
On Wed, 5 Jul 2023 14:51:31 GMT, Roger Riggs wrote:
> Source code cleanup.
> Add @since, remove unused imports and remove unnecessary SuppressWarnings of
> deprecation.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14775#pullrequestreview-1
On Mon, 3 Jul 2023 11:12:32 GMT, Pavel Rappo wrote:
> Please review this PR to use modern APIs and language features to simplify
> `equals` and `hashCode` in the java.text area.
>
> * Some changes to `equals` and `hashCode` are refactoring rather than
> modernization. Such changes can be as tr
On Fri, 30 Jun 2023 16:49:22 GMT, Justin Lu wrote:
>> Please review this PR which refactors Currency tests to use JUnit.
>>
>> The most significant change occurs in `ValidateISO4217.java`. Other changes
>> to this file excluding the JUnit refactoring include
>>
>> - Tests are no longer depende
On Fri, 30 Jun 2023 09:06:20 GMT, Daniel Fuchs wrote:
> Please find here a trivial doc fix to add a missing `@since 1.4` to the
> java.util.logging.ErrorManager class.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14725#pullrequestreview-15
On Tue, 27 Jun 2023 19:55:02 GMT, Roger Riggs wrote:
> Fix a test bug when run on aarch64, it was supposed to confirm it was not
> running on Arm.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14685#pullrequestreview-1501766576
On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which adds the `@since` javadoc tag to the
> various ` java.sql `and `java.sql.rowset` packages.
>
> Best
> Lance
This pull request has now been integrated.
Chang
On Tue, 27 Jun 2023 16:11:43 GMT, Jim Laskey wrote:
> The nested class is incorrectly marked as protected.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14681#pullrequestreview-1501494580
On Tue, 27 Jun 2023 03:39:30 GMT, Naoto Sato wrote:
>> Replacing the ambiguous `dash` with `hyphen-minus` for more clarity. There
>> are other locations than `ISO_LOCAL_DATE` that have the same description.
>> Those are corrected too.
>
> Naoto Sato has updated the pull request incrementally wi
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499179572
Hi all,
Please review this trivial change which adds the `@since` javadoc tag to the
various ` java.sql `and `java.sql.rowset` packages.
Best
Lance
-
Commit messages:
- Remove empty line
- Add @since to package-info.java
Changes: https://git.openjdk.org/jdk/pull/14652/files
Web
On Fri, 23 Jun 2023 20:00:12 GMT, Glavo wrote:
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15
On Fri, 23 Jun 2023 23:23:07 GMT, Brian Burkhalter wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified
>> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional comm
On Thu, 22 Jun 2023 19:00:58 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/lang/Readable.java line 49:
>>
>>> 47: * @param cb the buffer to read characters into
>>> 48: * @return The number of {@code char} values added to the buffer,
>>> 49: * possibly z
On Thu, 22 Jun 2023 18:22:35 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `java.lang.Readable` when the specified
> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/
On Thu, 22 Jun 2023 18:22:35 GMT, Brian Burkhalter wrote:
> Clarify the behavior of `java.lang.Readable` when the specified
> `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
src/java.base/share/classes/java/lang/Readable.java line 49:
> 47: * @param cb the buf
On Thu, 22 Jun 2023 01:08:30 GMT, Justin Lu wrote:
> Please review this PR as apart of
> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
> some tests in Locale to use JUnit. Other cleanup and small changes are
> included as well. More refactoring in Locale tests will
On Thu, 22 Jun 2023 18:25:24 GMT, Justin Lu wrote:
>> Please review this PR as apart of
>> [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors
>> some tests in Locale to use JUnit. Other cleanup and small changes are
>> included as well. More refactoring in Locale tests
On Fri, 16 Jun 2023 20:51:42 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/time/Duration.java line 1422:
>>
>>> 1420: *
>>> 1421: * @param otherDuration the other duration to compare to, not null
>>> 1422: * @return the comparator value is less than zero if the other
On Wed, 14 Jun 2023 20:35:54 GMT, Roger Riggs wrote:
> In java.time packages, clarify timeline order javadoc to mention "before" and
> "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positiv
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a special character
> - [
On Tue, 13 Jun 2023 18:08:55 GMT, Raffaello Giulietti
wrote:
> Trivial fix to working but unsupported use of {@inheritDoc}
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14452#pullrequestreview-1477810928
On Wed, 31 May 2023 21:09:57 GMT, Joe Wang wrote:
>> Add a system property, jdk.xml.config.file, to return the path to a custom
>> JAXP configuration file. The current configuration file, jaxp.properties,
>> that the JDK supports will become the default configuration file.
>>
>> CSR: https://b
On Wed, 10 May 2023 14:52:58 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Apologies fo
On Wed, 10 May 2023 14:41:02 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 232:
>>
>>> 230: * JDKGregorianCalendarAndDurationSerData.java files.
>>> 231: * @param baos
>>> 232: */
>>
>> I think there needs to be a general comm
On Fri, 12 May 2023 12:47:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which addresses the issue
> noted in https://bugs.openjdk.org/browse/JDK-8307403?
>
> When we recently did a change in https://bugs.openjdk.org/browse/JDK-8299748,
> there was a oversight
On Fri, 12 May 2023 17:56:12 GMT, Justin Lu wrote:
> Please review this trivial fix which updates the IANA data to version
> 5/11/2023. As the update only includes variant sub-tags, there is no impact
> to JDK tests. The update can be found
> [here](https://mm.icann.org/pipermail/ietf-language
On Fri, 12 May 2023 17:52:29 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Console.java line 124:
>>
>>> 122: * if (con != null) {
>>> 123: * Scanner sc = new Scanner(con.reader());
>>> 124: * ...
>>
>> I'm not sure how you fe
On Thu, 11 May 2023 20:39:57 GMT, Justin Lu wrote:
>> Please review this javadoc only change which uses `@snippet` and
>> `@linkplain` in i18n related util packages.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review: Mov
On Tue, 9 May 2023 20:39:19 GMT, Justin Lu wrote:
> Please review this PR which adds an example snippet to
> `java.time.temporal.WeekFields.of(Locale locale)`
>
> The snippet demonstrates how to create a Locale that has English Locale
> qualities with an ISO-8601 first day of the week.
>
> T
On Wed, 3 May 2023 14:12:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Move the pseudo code generation part from setup
On Tue, 2 May 2023 14:05:03 GMT, Mahendra Chhipa wrote:
>> test/jdk/javax/xml/jaxp/datatype/8033980/SerializationTest.java line 85:
>>
>>> 83:
>>> 84: // Generates the Java Pseudo code for base64 encoded string
>>> that can be cut & pasted into the test
>>> 85: final StringBuil
On Thu, 27 Apr 2023 17:35:12 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
test/jdk/jav
On Fri, 28 Apr 2023 17:28:47 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which allows the` jdbc.drivers` system
> property to be searchable.
>
> Best.
> Lance
This pull request has now been integrated.
Changeset: bb7608ba
Author:
On Fri, 28 Apr 2023 18:43:01 GMT, Eirik Bjorsnos wrote:
> Somewhat unrelated perhaps, but I found the example value given for
> `jdbc.drivers` in `DriverManager` javadocs to be a bit funky.
>
> `jdbc.drivers=foo.bah.Driver:wombat.sql.Driver:bad.taste.ourDriver`
>
> I know, I know, coming up wi
Hi all,
Please review this trivial change which allows the` jdbc.drivers` system
property to be searchable.
Best.
Lance
-
Commit messages:
- Update copyright year
- Update copyright year
- Allow the jdbc.drivers system property to be searchable
Changes: https://git.openjdk.org/
On Thu, 27 Apr 2023 18:36:53 GMT, Stuart Marks wrote:
> …
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13698#pullrequestreview-1406240035
On Fri, 28 Apr 2023 09:58:59 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array
>> which is responsible for storing the compressed data is insufficient. And
>> being unable to write whole compressed data on array, on s390 whole data
>> can't be re
On Tue, 25 Apr 2023 23:58:59 GMT, Justin Lu wrote:
>> Please review changes to the IntlTest (test framework) class.
>>
>> These changes include
>> - Logging the actual exception + stack trace. Previously, the test framework
>> would throw `InvocationTargetException` but hide the actual underly
On Tue, 25 Apr 2023 19:04:10 GMT, Brian Burkhalter wrote:
>> When appending a `CharBuffer`, perform a specific check for buffer overflow
>> before invoking `put()`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 83066
On Mon, 24 Apr 2023 23:47:05 GMT, Justin Lu wrote:
>> This PR fixes an intermittent failure (that only occurs on Windows) in
>> _DateFormatRegression.java_.
>>
>> With the integration of
>> [JDK-8304982](https://bugs.openjdk.org/browse/JDK-8304982),
>> _LocaleProviderAdapter.java_ now emits a
On Thu, 20 Apr 2023 16:20:18 GMT, Daniel Fuchs wrote:
> > The original version of this test was validating serialization
> > compatibility with previous releases.
> > The current changes seems to have removed that validation in the re-write
> > of the test
> > One option is to convert the vario
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comment.
The original
On Fri, 14 Apr 2023 20:24:00 GMT, Lance Andersen wrote:
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
&g
On Tue, 18 Apr 2023 18:40:03 GMT, Naoto Sato wrote:
> The upgrade to CLDR v43 was missing the license-related file updates. Here
> are the supplemental updates.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13517#pullrequestreview-139074270
On Tue, 18 Apr 2023 18:24:01 GMT, Eirik Bjorsnos wrote:
> > Do you know how the Zip in question is being created, is it via
> > ApacheCommons and could there be an issue there?
>
> Currently investigating. The Tomcat build is using the Ant `jar` task to
> create the `tomcat-embed-core.jar`, bu
On Wed, 29 Mar 2023 10:48:57 GMT, Eirik Bjorsnos wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data de
On Sun, 16 Apr 2023 08:39:32 GMT, Alan Bateman wrote:
>> added validation for other file being null but also kept the existing
>> validation of the message
>
> Okay, although I assume this test will fail if it throws a more general
> IOException (it's allowed to do that) or there is any adjustm
On Sat, 15 Apr 2023 05:43:09 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> re-arrage assertEquals params
>
> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMess
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance
On Fri, 14 Apr 2023 21:30:40 GMT, Eirik Bjorsnos wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address additional feedback
>
> test/jdk/jdk/nio/zipfs/ZipFSDirectoryExceptionMess
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance
On Fri, 14 Apr 2023 21:07:37 GMT, Naoto Sato wrote:
> Looks good, Lance. Nit: copyright year -> 2023
Geez, working in too many workspaces. Thank you, just pushed the update
-
PR Comment: https://git.openjdk.org/jdk/pull/13482#issuecomment-1509300245
On Fri, 14 Apr 2023 21:08:28 GMT, Christian Stein wrote:
> Looks good to me.
Thank you Christian
-
PR Comment: https://git.openjdk.org/jdk/pull/13482#issuecomment-1509301103
> Please review this trivial change when ZipFS returns the wrong
> java.nio.file.FileSystemException message due the the parameters being
> reversed.
>
> I also included a simple junit test as part of the fix.
>
> Mach5 tiers1-3 are clean
>
> Best
> Lance
Lance
Please review this trivial change when ZipFS returns the wrong
java.nio.file.FileSystemException message due the the parameters being reversed.
I also included a simple junit test as part of the fix.
Mach5 tiers1-3 are clean
Best
Lance
-
Commit messages:
- (zipfs) Opening a direc
On Sat, 8 Apr 2023 10:33:48 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this MR which updates the jar man page to to indicate that
> --generate-index/-I are deprecated and may be removed in a future release
>
> Support for JAR Index is being removed via JDK-8
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
> Hi all,
>
> Please review this MR which updates the jar man page to to indicate that
> --generate-index/-I are deprecated and may be removed in a future release
>
> Support for JAR Index is being removed via JDK-8302819.
Lance Andersen has updated the pull request incr
On Sat, 8 Apr 2023 15:53:17 GMT, Alan Bateman wrote:
> I assume you didn't mean to edit this.
Updated, thank you.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13400#discussion_r1161603585
On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementat
On Sat, 8 Apr 2023 11:53:50 GMT, Eirik Bjorsnos wrote:
> The JBS issue name should be updated to use a lowercase `-i` and this PR's
> title should be updated to match the JBS title.
Lack of coffee and doing this before 7am this morning is my only excuse
> Is the `compiler` label appropriate f
Hi all,
Please review this MR which updates the jar man page to to indicate that
--generate-index/-I are deprecated and may be removed in a future release
Support for JAR Index is being removed via JDK-8302819.
-
Commit messages:
- Update the man page to indicate -i/--generate-fi
On Mon, 3 Apr 2023 17:16:26 GMT, Andrey Turbanov wrote:
> `LinkedHashMap` `ZipFileSystem.inodes` contains only
> non-null values. It means instead of separate `containsKey`+`get` calls, we
> can use single `LinkedHashMap.get` call and then compare result with `null`.
> Result code is a bit simp
On Wed, 5 Apr 2023 07:05:11 GMT, Eirik Bjorsnos wrote:
> > The new test that was planned for testing `JarFile` and `JarInputStream`
> > when dealing with a jar containing a `META-INF/INDEX.LIST`, is that
> > something that you want to be done as a separate PR/task? It's fine with me
> > if you
On Tue, 4 Apr 2023 19:22:48 GMT, Roger Riggs wrote:
> With the addition of `jdk.internal.util.OperatingSystem` references to the
> system property `os.name` can be replaced.
> This PR exports jdk.internal.util to:
> - java.prefs,
> - java.security.jgss,
> - java.smartcardio,
> - jdk.charsets
On Thu, 30 Mar 2023 14:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR removes the JAR index feature from the runtime:
>>
>> - `URLClassPath` is updated to remove the `enableJarIndex` system property
>> and any code which would be called when this property was `true`
>> - The `JarIndex` implementa
On Tue, 4 Apr 2023 18:37:34 GMT, Alan Bateman wrote:
> > I have drafted CSR https://bugs.openjdk.org/browse/JDK-8305597, but I'm not
> > sure what to put in the _Specification_ section.
> > What is the specification change in this PR? The removal of the system
> > property? The adding of the wa
On Fri, 31 Mar 2023 19:59:10 GMT, Eirik Bjorsnos wrote:
>> CorruptedZipFiles could benefit from some spring cleaning and a conversion
>> to junit:
>>
>> - The actual tests are moved into their own `@Test` methods, given more
>> meaningful names and a Javadoc comment explaining the constraint b
On Fri, 31 Mar 2023 19:58:24 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java line 192:
>>
>>> 190: /*
>>> 191: * Validate that a ZipException is thrown when the 'End of Central
>>> Directory'
>>> 192: * (END) header has a CEN offset incoherent w
On Fri, 31 Mar 2023 13:51:22 GMT, Eirik Bjorsnos wrote:
>> CorruptedZipFiles could benefit from some spring cleaning and a conversion
>> to junit:
>>
>> - The actual tests are moved into their own `@Test` methods, given more
>> meaningful names and a Javadoc comment explaining the constraint b
On Fri, 31 Mar 2023 10:33:50 GMT, Lance Andersen wrote:
> Hi Jon,
>
> This looks fine. I was wondering if we should do the same for java.util.zip
> and the PKWare Zip Spec or where java.sql references the JDBC Spec?
Well, I must need coffee this morning as obviously JDBC is in
On Thu, 30 Mar 2023 20:45:08 GMT, Jonathan Gibbons wrote:
>> Please review a change to add `@spec` tags (and remove some equivalent
>> `@see` tags) to the main "core-libs" packages in `java.base` module.
>>
>> This is similar to, and a subset of, PR #11073. That PR was withdrawn, and
>> base
On Wed, 29 Mar 2023 22:51:12 GMT, Justin Lu wrote:
> Small typo fix in Locale.lookupTag
>
> _tangs_ should be _tags_
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13235#pullrequestreview-1364100110
On Wed, 29 Mar 2023 15:21:04 GMT, Lance Andersen wrote:
>>> High level comment: these days we usually try to use junit 5 / jupiter
>>> instead of TestNG.
>>
>> I think my choice of testNG here might have been influenced by other ZIP
>> area tests usin
On Wed, 29 Mar 2023 13:30:21 GMT, Eirik Bjorsnos wrote:
> > High level comment: these days we usually try to use junit 5 / jupiter
> > instead of TestNG.
>
> I think my choice of testNG here might have been influenced by other ZIP area
> tests using testNG. I guess a rewrite to junit should be
On Tue, 28 Mar 2023 21:48:23 GMT, Lance Andersen wrote:
> Please review this trivial change which removes a redundant `-` from an
> `@param` and cleans up the formatting for the `isValid` method.
>
>
> It looks like there is some additional formatting clean up that can be don
On Sun, 12 Feb 2023 15:41:55 GMT, Eirik Bjorsnos wrote:
> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
> number of compressed or uncompressed bytes read from the inflater is larger
> than the Zip64 magic value.
>
> While the ZIP format mandates that the data descrip
On Tue, 14 Feb 2023 17:46:21 GMT, Eirik Bjorsnos wrote:
> CorruptedZipFiles could benefit from some spring cleaning and a conversion to
> testNG:
>
> - The actual tests are moved into their own `@Test` methods, given more
> meaningful names and a Javadoc comment explaining the constraint being
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png";>
>
> After:
> src="https:/
Please review this trivial change which removes a redundant `-` from an
`@param` and cleans up the formatting for the `invalid` method.
It looks like there is some additional formatting clean up that can be done but
I will handle that under a separate PR.
-
Commit messages:
- Re
On Sat, 25 Mar 2023 09:35:56 GMT, Alan Bateman wrote:
> > I see that Alan suggested that we take up the `jar -i` deprecation in a
> > separate PR. I think that simplifies the work in this PR.
>
> Yes, there are options for `jar -i` that include "leave it as is", have the
> option create the in
On Tue, 28 Mar 2023 08:06:48 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change that addresses
> https://bugs.openjdk.org/browse/JDK-8304989?
>
> I ran `make docs-image` with this change and the generated javadocs look fine.
Marked as reviewed by lancea (Revie
On Sat, 25 Mar 2023 12:12:21 GMT, Eirik Bjorsnos wrote:
>> The TestTooManyEntries test was originally added to validate that ZIP64
>> files with CEN sizes exceeding what ZipFile supports are rejected with a
>> ZipException. The test does this by creating a large ZIP file (several
>> gigabytes
On Sat, 25 Mar 2023 11:18:32 GMT, Lance Andersen wrote:
>> Thanks, I've added `@throws IOException if an error occurs` to all methods
>> throwing `IOException`.
>>
>> For the record, let me state my personal (rather strong) opinion:
>>
>> I think this
On Sat, 25 Mar 2023 11:07:24 GMT, Eirik Bjorsnos wrote:
>> Please add them back before pushing with `@throws IOException if an error
>> occurs`
>>
>> Yes I understand they do not add much value but it will reduce noise from
>> IDEs and if/when we add more checks for missing javadoc tags, it wi
On Sat, 25 Mar 2023 06:46:22 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 120:
>>
>>> 118: /**
>>> 119: * Validate that an end of central directory record with a
>>> 120: * CEN size which exceeds the position of the EOC record is
>>> re
On Sat, 25 Mar 2023 06:50:16 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 139:
>>
>>> 137: * Validate that an end of central directory record with a CEN
>>> offset which
>>> 138: * is larger than the EOC position minus the CEN size is rejec
On Thu, 26 Jan 2023 18:49:47 GMT, Eirik Bjorsnos wrote:
> The TestTooManyEntries test was originally added to validate that ZIP64 files
> with CEN sizes exceeding what ZipFile supports are rejected with a
> ZipException. The test does this by creating a large ZIP file (several
> gigabytes) wi
On Fri, 24 Mar 2023 08:05:19 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 177:
>>
>>> 175: Path zip) throws IOException
>>> {
>>> 176:
>>> 177: Files.deleteIfExists(zip);
>>
>> Is this needed? I th
On Thu, 26 Jan 2023 18:49:47 GMT, Eirik Bjorsnos wrote:
> The TestTooManyEntries test was originally added to validate that ZIP64 files
> with CEN sizes exceeding what ZipFile supports are rejected with a
> ZipException. The test does this by creating a large ZIP file (several
> gigabytes) wi
On Thu, 26 Jan 2023 18:49:47 GMT, Eirik Bjorsnos wrote:
> The TestTooManyEntries test was originally added to validate that ZIP64 files
> with CEN sizes exceeding what ZipFile supports are rejected with a
> ZipException. The test does this by creating a large ZIP file (several
> gigabytes) wi
On Thu, 23 Mar 2023 07:16:32 GMT, Eirik Bjorsnos wrote:
> > The example code works without setting the compressed size on the entry?
>
> Yes, this is the minimal code required and is also how the `jar` tool does it.
>
> The current behaviour does feel a bit underspecified though. In the
> `Zip
On Sun, 19 Mar 2023 14:50:41 GMT, Eirik Bjorsnos wrote:
>> ZipOutputStream currently writes directory entries using the DEFLATED
>> compression method. This does not strictly comply with the APPNOTE.TXT
>> specification and is also about 10x slower than using the STORED compression
>> method.
On Tue, 7 Mar 2023 07:46:25 GMT, Eirik Bjorsnos wrote:
> ZipOutputStream currently writes directory entries using the DEFLATED
> compression method. This does not strictly comply with the APPNOTE.TXT
> specification and is also about 10x slower than using the STORED compression
> method.
>
>
On Thu, 16 Mar 2023 21:30:04 GMT, Naoto Sato wrote:
>> This is a blocker for
>> [JDK-8294972](https://bugs.openjdk.org/browse/JDK-8294972). The fix is to
>> weed out non-class files for calling `ClassReader` by checking the file
>> extension. Regression tests are not provided as it is not poss
301 - 400 of 656 matches
Mail list logo
