This PR proposes to reject paths provided to the
`SymbolLookup.libraryLookup(Path path, Arena arena)` method if a path is not in
the default file system.
-
Commit messages:
- Fix logic
- Reject paths not in the default file system
Changes: https://git.openjdk.org/jdk/pull/16944/f
On Tue, 28 Nov 2023 13:03:48 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1404:
>>
>>> (failed to retrieve contents of file, check the PR for context)
>> Is there a more scalable way to express the major class version? The current
>> approach me
On Mon, 27 Nov 2023 10:01:50 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Tue, 12 Sep 2023 19:59:57 GMT, Andrey Turbanov wrote:
> A few classes in `jdk.internal.util.xml.impl` package have non-final fields
> which could easily be marked `final`.
>
> Also fixed a few typos and incorrect javadoc links.
src/java.base/share/classes/jdk/internal/util/xml/impl/XMLStrea
On Tue, 12 Sep 2023 19:59:57 GMT, Andrey Turbanov wrote:
> A few classes in `jdk.internal.util.xml.impl` package have non-final fields
> which could easily be marked `final`.
>
> Also fixed a few typos and incorrect javadoc links.
There are also some typo fixes. I think this could be mentioned
On Thu, 16 Nov 2023 17:08:58 GMT, Naoto Sato wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316557: Make fields final in 'sun.util' package
>>
>> rename 'firstDay' to 'firstDays' to match 'minDays' naming
On Wed, 15 Nov 2023 08:18:31 GMT, Per Minborg wrote:
> This PR proposes to fix a failing test on big endian architectures like AIX.
This pull request has now been integrated.
Changeset: 4f4d00fa
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/com
On Wed, 15 Nov 2023 09:27:45 GMT, Jaikiran Pai wrote:
>> This PR proposes to fix a failing test on big endian architectures like AIX.
>
> test/jdk/java/foreign/TestLayouts.java line 223:
>
>> 221: public void testSequenceLayoutWithZeroLength() {
>> 222: SequenceLayout layout = Memory
This PR proposes to fix a failing test on big endian architectures like AIX.
-
Commit messages:
- Fix AIX test issue
Changes: https://git.openjdk.org/jdk/pull/16672/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16672&range=00
Issue: https://bugs.openjdk.org/browse/JDK-83
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
LGTM. See comments though.
src/java.base/share/classes/sun/util/locale/StringTokenIterator.java line 33:
> 31: package sun.util.locale;
On Thu, 14 Sep 2023 08:58:56 GMT, Andrey Turbanov wrote:
> A few classes in `sun.util` package have non-final fields which could easily
> be marked `final`.
src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java
line 48:
> 46: public class CLDRCalendarDataProviderImpl ext
> This PR proposes to use unnamed variables now that they have become available
> in Java.
>
> There is also a cosmetic cleanup making a switch rake smaller and where
> variables are pre-calculated rather than spreading expressions around.
Per Minborg has updated the pull reques
On Fri, 10 Nov 2023 07:19:42 GMT, Per Minborg wrote:
> This PR proposes to use unnamed variables now that they have become available
> in Java.
>
> There is also a cosmetic cleanup making a switch rake smaller and where
> variables are pre-calculated rather than spreading exp
On Fri, 10 Nov 2023 09:31:29 GMT, Per Minborg wrote:
> This PR proposes to fix a problem where a sequence layout contains an element
> of `byteSize()` zero.
This pull request has now been integrated.
Changeset: c9657cad
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
This PR proposes to fix a problem where a sequence layout contains an element
of `byteSize()` zero.
-
Commit messages:
- Fix toString problem
Changes: https://git.openjdk.org/jdk/pull/16599/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16599&range=00
Issue: https://bugs
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
This PR proposes to use unnamed variables now that they have become available
in Java.
There is also a cosmetic cleanup making a switch rake smaller and where
variables are pre-calculated rather than spreading expressions around.
-
Commit messages:
- Use unnamed variables
Changes
On Mon, 6 Nov 2023 07:41:46 GMT, Per Minborg wrote:
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
&
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Chang
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
-
On Thu, 9 Nov 2023 09:39:16 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 535:
>>
>>> 533: */
>>> 534: @ForceInline
>>> 535: static Integrator of(Integrator
>>> integrator) {
>>
>> While this idiom is very convenient, ther
On Thu, 9 Nov 2023 09:33:54 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherer.java line 261:
>>
>>> 259: /**
>>> 260: * Returns an initializer which is the default initializer of a
>>> Gatherer.
>>> 261: * The returned initializer identifies that th
On Thu, 9 Nov 2023 11:46:55 GMT, Daniel Fuchs wrote:
>> Yeah, I agree with @amaembo, I think it is important to keep the contract
>> close to the caller.
>
> I don't mind either way - just wanted to note that the notion of blanket
> statements for `NullPointerException` is used in several areas
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now con
On Wed, 8 Nov 2023 09:03:12 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in th
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Thu, 9 Nov 2023 08:27:26 GMT, Per Minborg wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the r
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Thu, 9 Nov 2023 07:54:39 GMT, Per Minborg wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Addressing review feedback
>> - Make Gatherer.andThen take a wildcard for the r
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make Gatherer.an
On Sun, 24 Sep 2023 13:17:05 GMT, Chen Liang wrote:
> 1. Primitive array VHs are now singletons and no longer need to record their
> array base and offset in their object themselves.
> 2. Moved Unsafe offset calculation to a utility method, like `index` in
> VarHandleByteArrayView.
Sharing cod
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
On Mon, 6 Nov 2023 21:05:58 GMT, Per Minborg wrote:
> This PR proposes to remove two `permits` declarations where the line
> overflows the stipulated maximum column with. Also, it proposes to harmonize
> the layout of `permit` formatting so they are the the same throughout the API.
but I think it nice to get
> consistency across the API now that we go final.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Revert some foramtting
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16528/fi
On Tue, 7 Nov 2023 11:41:06 GMT, Per Minborg wrote:
>> This PR proposes to remove two `permits` declarations where the line
>> overflows the stipulated maximum column with. Also, it proposes to harmonize
>> the layout of `permit` formatting so they are the the same thro
On Mon, 6 Nov 2023 21:00:10 GMT, Per Minborg wrote:
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
This pull request has now been integrated.
Changeset: 134c38
> This PR proposes to reformat some method parameters in the FFM API. The
> proposed changes are a bit opinion based eve though there are some underlying
> principles.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now con
On Tue, 7 Nov 2023 09:31:11 GMT, Per Minborg wrote:
> This PR proposes to improve the language used in the FFM specification. There
> is a relatively small number of corrections.
>
> One peculiarity with the English language is the distinction between "that"
> (to
On Mon, 6 Nov 2023 21:07:22 GMT, Per Minborg wrote:
> This PR proposes to reformat a small number of code line for better
> appearance.
This pull request has now been integrated.
Changeset: 42f43c52
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
but I think it nice to get
> consistency across the API now that we go final.
Per Minborg has updated the pull request incrementally with two additional
commits since the last revision:
- Remove redundandt space
- Use permits reformatting only when needed
-
Chang
(to be used in a
> non-restrictive clause). Here is a reference:
> https://preply.com/en/blog/when-to-use-which-or-that-the-most-common-cases
>
> Another source for updates is the difference between BE and AE where most of
> us Europeans were taught BE but we should use AE in the
On Tue, 7 Nov 2023 10:36:00 GMT, Per Minborg wrote:
> This PR proposes to fix a compilation error in the TestLoadSegmentVarious
> class
This pull request has now been integrated.
Changeset: ac0ee20a
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/
This PR proposes to fix a compilation error in the TestLoadSegmentVarious class
-
Commit messages:
- Fix compiler error in benchmark
Changes: https://git.openjdk.org/jdk/pull/16537/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16537&range=00
Issue: https://bugs.openjdk.o
On Wed, 25 Oct 2023 13:08:06 GMT, Per Minborg wrote:
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
This pul
This PR proposes to improve the language used in the FFM specification. There
is a relatively small number of corrections.
One peculiarity with the English language is the distinction between "that" (to
be used in a restrictive clause) and "which" (to be used in a non-restrictive
clause). Here
This PR proposes to reformat a small number of code line for better appearance.
-
Commit messages:
- Reformat some code
Changes: https://git.openjdk.org/jdk/pull/16529/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16529&range=00
Issue: https://bugs.openjdk.org/browse/JDK
This PR proposes to remove two `permits` declarations where the line overflows
the stipulated maximum column with. Also, it proposes to harmonize the layout
of `permit` formatting so they are the the same throughout the API.
This PR might be perceived as over worked but I think it nice to get
c
This PR proposes to reformat some method parameters in the FFM API. The
proposed changes are a bit opinion based eve though there are some underlying
principles.
-
Commit messages:
- Harmonize method parameter layouts
Changes: https://git.openjdk.org/jdk/pull/16527/files
Webrev:
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last rev
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revi
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last re
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revisi
On Mon, 6 Nov 2023 11:41:23 GMT, Maurizio Cimadamore
wrote:
> You might also want to look into the MethodHandles XYZCoordinates combinators
> (as they have also been added as part of FFM). And, also,
> `ModuleLayer::Controller::enableNativeAccess`,
> `Module::isNativeAccessEnabled` and `FileC
On Mon, 6 Nov 2023 13:27:40 GMT, Jorn Vernee wrote:
> FWIW, I've been sticking to a soft 120 character limit per line when writing
> javadoc. Why should we use 90 columns specifically?
>
> > It is also customary to use double spaces when starting a new sentence.
>
> I thought this was the exce
On Fri, 3 Nov 2023 18:16:17 GMT, Jorn Vernee wrote:
>> - Add linker note about packed structs.
>> - Relax language a bit to avoid implying that only listed layouts are
>> supported.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit since the last revision:
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Upda
ngth of 90 characters.
>
> The FFM API currently has javadoc lines that exceed 135 characters per line.
> It is also customary to use double spaces when starting a new sentence.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev e
This PR proposes to reformat all the JavaDocs for the FFM API. This would bring
the FFM API docs more in line with the existing Java documentation (see below).
Occasional drive-by fixes are also included in this PR (such as spelling and
capitalization).
I am aware this PR will (if approved) ma
On Thu, 2 Nov 2023 14:46:49 GMT, Per Minborg wrote:
> This PR proposes to harmonize the @throws tags in the javadocs for the FFM
> API.
>
> The @throws tags are using a bit different principles with respect to
> formatting and ending with a period or not.
>
> Looking a
This PR proposes to harmonize the @throws tags in the javadocs for the FFM API.
The @throws tags are using a bit different principles with respect to
formatting and ending with a period or not.
Looking at some prominent Java classes like `List` and `Stream`, they:
1) Indent such that multi-line
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote:
> This PR proposes to fix a number of JavaDoc typos in the
> `MemorySegment::getAtIndex` and `::setAtIndex`.
This pull request has now been integrated.
Changeset: cb20a3e7
Author: Per Minborg
URL:
https://git.openjdk.o
On Thu, 2 Nov 2023 07:40:52 GMT, Per Minborg wrote:
> This PR proposes to fix a number of JavaDoc typos in the
> `MemorySegment::getAtIndex` and `::setAtIndex`.
src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2014:
> 2012: * @throws IllegalArgumentExc
This PR proposes to fix a number of JavaDoc typos in the
`MemorySegment::getAtIndex` and `::setAtIndex`.
-
Commit messages:
- Fix typos in the JavaDocs for MemorySegment
Changes: https://git.openjdk.org/jdk/pull/16469/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16469&ra
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one a
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one a
On Thu, 26 Oct 2023 09:17:25 GMT, Per Minborg wrote:
>> This PR proposes removing the restriction that only heap `MemorySegment`
>> wrapping a `byte` array can be accessed by Vectors. Now any array type can
>> be used provided the element alignment constraints are respecte
On Tue, 17 Oct 2023 08:05:09 GMT, Per Minborg wrote:
> This PR proposes to add a number of "capturing factories" in classes in the
> `java.util.function` package.
>
> The PR additionally (an optionally) proposes to add a new function
> `UnaryOperator::andThenUnary` t
On Wed, 25 Oct 2023 16:35:30 GMT, Chris Hegarty wrote:
>> test/jdk/jdk/incubator/vector/AbstractVectorLoadStoreTest.java line 118:
>>
>>> 116: private static boolean canBeConverted(IntFunction
>>> function, ValueLayout elementLayout) {
>>> 117: // Create a sample to analyze
>>> 118:
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one a
This PR proposes removing the restriction that only heap `MemorySegment`
wrapping a `byte` array can be accessed by Vectors. Now any array type can be
used provided the element alignment constraints are respected.
-
Commit messages:
- Vector access on heap MemorySegments for all ar
On Wed, 11 Oct 2023 07:52:54 GMT, Per Minborg wrote:
> This PR proposes to Add @sealedGraph to `Thread.Builder`.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/16138
On Wed, 11 Oct 2023 07:52:54 GMT, Per Minborg wrote:
> This PR proposes to Add @sealedGraph to `Thread.Builder`.
I will close this PR as the taglet was not deemed to be helpful here.
-
PR Comment: https://git.openjdk.org/jdk/pull/16138#issuecomment-1774522674
On Wed, 11 Oct 2023 07:45:17 GMT, Per Minborg wrote:
> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants.
This pull request has now been integrated.
Changeset: ffadd635
Author: Per Minborg
URL:
https://git.openjdk.org/jdk/com
On Thu, 19 Oct 2023 20:49:13 GMT, Maurizio Cimadamore
wrote:
>> The 21 iteration of the FFM API used to contain a method, namely
>> `ValueLayout::arrayElementVarHandle`. This var handle factory was useful
>> when accessing elements in a flat array of variable size.
>>
>> In 22, this method ha
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
On Thu, 19 Oct 2023 06:18:18 GMT, Per Minborg wrote:
> This PR suggests a fix for a failing test on platforms with big endian.
>
> The PR also contains a drive-by removal of an unused import.
This pull request has now been integrated.
Changeset: defc7e0f
Author:Per Min
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
On Wed, 18 Oct 2023 09:00:09 GMT, Per Minborg wrote:
>> This PR proposes to add a number of "capturing factories" in classes in the
>> `java.util.function` package.
>>
>> The PR additionally (an optionally) proposes to add a new function
>> `UnaryOper
This PR suggests a fix for a failing test on platforms with big endian.
The PR also contains a drive-by removal of an unused import.
-
Commit messages:
- Remove unused imports
- Fix problem with endianness
Changes: https://git.openjdk.org/jdk/pull/16259/files
Webrev: https://webr
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 55:
> 53: public class HBShaper {
> 54:
> 55: /*
Nice with the original C struct as a comment.
src/java.des
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
On Fri, 22 Sep 2023 15:31:13 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 524:
>>
>>> 522: protected Object clone() throws CloneNotSupportedException {
>>> 523: AbstractMap result = (AbstractMap)super.clone();
>>> 524: return result;
>
On Tue, 19 Sep 2023 23:48:07 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/AbstractMap.java line 375:
>>
>>> 373: */
>>> 374: public Collection values() {
>>> 375: return new AbstractCollection<>() {
>>
>> Note that this causes `m.values().equals(m.values())`
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
oved
> because the JVM is probably able to optimize away object creation anyway via
> escape analysis. Also, all maps will occupy less space as we get rid of a
> number of objects and references stored for each map.
>
> We need to benchmark this solution to better understand its
On Wed, 18 Oct 2023 09:22:39 GMT, Per Minborg wrote:
>> Just curious, do we have any idea how extensively `UnaryOperator` is used as
>> a parameter type in user code compared to plain `Function`? If it's
>> not preferred over `Function`, this new method might
On Wed, 18 Oct 2023 09:12:23 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/function/UnaryOperator.java line 68:
>>
>>> 66: * @see Function#andThen(Function)
>>> 67: */
>>> 68: default UnaryOperator andThenUnary(UnaryOperator after) {
>>
>> What are your comments
real code. Users that prefers having a
> normal type declaration can still do that.
>
> Note: Functional interfaces of primitives have not been considered (in this
> round). Otherwise, functional interfaces that might be ambiguous or that
> supports composition have been included. Hence,
real code. Users that prefers having a
> normal type declaration can still do that.
>
> Note: Functional interfaces of primitives have not been considered (in this
> round). Otherwise, functional interfaces that might be ambiguous or that
> supports composition have been included. Hence,
301 - 400 of 781 matches
Mail list logo
