> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
> launche
On Tue, 28 Mar 2023 06:28:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Tue, 28 Mar 2023 06:28:17 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>>
>> The `jlink` command allows a `--endian` option to specify the byte order in
>> the generated imag
On Tue, 28 Mar 2023 10:57:36 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use test.jdk system property in test
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 39:
>
On Tue, 28 Mar 2023 11:02:46 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use test.jdk system property in test
>
> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 97:
>
>> 95:
On Wed, 29 Mar 2023 01:47:35 GMT, Jaikiran Pai wrote:
>> test/jdk/tools/jlink/plugins/CDSPluginTest.java line 97:
>>
>>> 95:// separate --module-path will force the JLink task to read
>>> the ModuleTarget from
>>> 96:// the java.base module-info.class to identify the tar
On Tue, 4 Apr 2023 11:09:24 GMT, Alan Bateman wrote:
>> Early on during this PR, we decided and implemented to read the
>> `ModuleTarget` only if the java.base module's file path doesn't match that
>> of the current platform's file path. If we remove that check and instead
>> always read the M
