On Thu, 27 Apr 2023 07:42:29 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Wed, 26 Apr 2023 18:15:34 GMT, Alan Bateman wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed prefixes from name methods
>
> src/java.base/share/classes/java/lang/constant/ConstantUtils.java line 133:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Wed, 26 Apr 2023 10:46:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Wed, 26 Apr 2023 06:18:10 GMT, Per Minborg wrote:
> Have we considered moving the Impl classes into a non-public area such as
> `jdk.internal` to improve encapsulation and reduce perceived footprint?
I don't see much of a problem to keep the non-public classes in
`java.lang.constant` since
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 21:53:44 GMT, Mandy Chung wrote:
> I wonder if `packageName()` and `packageInternalName()` methods can simply be
> `name()` and `internalName()` as the type name is `PackageDesc` and `package`
> prefix seems to be unnecessary. Similarly, `moduleName()` can be `name()`.
> Ha
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 21:45:57 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update ModuleDesc.java
>> - Update PackageDesc.java
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java
On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Tue, 25 Apr 2023 19:43:29 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 16:26:01 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added custom toString() methods
>
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 44:
>
>> 42:
On Mon, 24 Apr 2023 22:05:18 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 43:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Mon, 24 Apr 2023 20:56:03 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/PackageDesc.java line 30:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Mon, 24 Apr 2023 21:59:29 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc fixes + added null and empty tests
>
> src/java.base/share/classes/java/lang/constant/ModuleDesc.java line 30:
>
>>
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 08:11:24 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Mon, 24 Apr 2023 16:26:02 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Tue, 25 Apr 2023 07:38:41 GMT, Adam Sotona wrote:
> Note that other `*Impl` classes in `java.lang.constant` perform validation in
> their constructors and provide custom `toString()` formatting and they also
> don’t use records.
BTW: for example `ClassDesc:of(String name)` performs repeated
On Mon, 24 Apr 2023 16:33:58 GMT, Chen Liang wrote:
> Note that other `*Impl` classes in `java.lang.constant` perform validation in
> their constructors and provide custom `toString()` formatting and they also
> don’t use records.
Performing validation in constructors I see as a blocker for po
On Mon, 24 Apr 2023 16:26:02 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Mon, 24 Apr 2023 16:27:28 GMT, ExE Boss wrote:
> Note that other `*Impl` classes in `java.lang.constant` perform validation in
> their constructors and provide custom `toString()` formatting and they also
> don’t use records.
Records were only added in Java 16; the constant API was added in
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Mon, 24 Apr 2023 14:35:30 GMT, Roger Riggs wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added links to JVMS and utility methods moved to ConstantUtils
>
> src/java.base/share/classes/java/lang/constant/package
On Mon, 24 Apr 2023 14:30:46 GMT, Roger Riggs wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added links to JVMS and utility methods moved to ConstantUtils
>
> src/java.base/share/classes/java/lang/constant/Constan
On Mon, 24 Apr 2023 13:18:09 GMT, Adam Sotona wrote:
>> Constants API already provides models for all loadable constants to help
>> programs manipulating class files and modelling bytecode instructions.
>> However no models of module and package constants are provided by Constants
>> API. Ever
On Mon, 24 Apr 2023 12:28:37 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added links to JVMS and utility methods moved to ConstantUtils
>
> src/java.base/share/classes/java/lang/constant/PackageD
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every program manipulating class files must implement own model
On Mon, 24 Apr 2023 11:59:03 GMT, Adam Sotona wrote:
> Constants API already provides models for all loadable constants to help
> programs manipulating class files and modelling bytecode instructions.
> However no models of module and package constants are provided by Constants
> API. Every pr
Constants API already provides models for all loadable constants to help
programs manipulating class files and modelling bytecode instructions. However
no models of module and package constants are provided by Constants API. Every
program manipulating class files must implement own models and va
40 matches
Mail list logo
