[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Thu, Aug 22, 2019 at 4:59 AM Matt B wrote: >> >> I believe S3 resume path is PSP assisted. When x86 core reset is deasserted >> some parts of the memory controller PHY have already been programmed by PSP >> or SMU firmwares. > > (No PSP present on the G505s) Perhaps my commentary was not so

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Matt B
> > I believe S3 resume path is PSP assisted. When x86 core reset is > deasserted some parts of the memory controller PHY have already been > programmed by PSP or SMU firmwares. (No PSP present on the G505s) > You should consider binaryPI mostly broken for the purpose of S3 > suspend/resume. >

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 7:52 PM Raul Rangel wrote: > > You can grep for commits containing b:65442212 or b:111610455 to see the work > required to remove AGESA from bootblock. Thanks! Some of that seems very SoC or hardware specific. I think we will go ahead with a bootblock that does nothing

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Raul Rangel
You can grep for commits containing b:65442212 or b:111610455 to see the work required to remove AGESA from bootblock. On Wed, Aug 21, 2019 at 10:22 AM Kyösti Mälkki wrote: > On Wed, Aug 21, 2019 at 6:53 PM Michal Zygowski > wrote: > >> I get the overall idea of C bootblock. The most fun is

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 6:53 PM Michal Zygowski wrote: >> I get the overall idea of C bootblock. The most fun is about the > assembly to setup CAR early. But what about S3 suspend/resume for APU2 > for example? It is not supported by the platform and does not seem to be > needed at all there (it

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Michal Zygowski
On 8/21/19 8:59 AM, Kyösti Mälkki wrote: > On Wed, Aug 21, 2019 at 9:23 AM Michal Zygowski > wrote: >> Hello Kyösti, >> >> Giving such a "credit" to give a little more time to bring the platform >> to release requirements sounds like a good idea. >> >> 3mdeb will surely approach to implement

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 9:23 AM Michal Zygowski wrote: > > Hello Kyösti, > > Giving such a "credit" to give a little more time to bring the platform > to release requirements sounds like a good idea. > > 3mdeb will surely approach to implement those changes based on family > 14h apu1, as well as

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Michal Zygowski
Hello Kyösti, Giving such a "credit" to give a little more time to bring the platform to release requirements sounds like a good idea. 3mdeb will surely approach to implement those changes based on family 14h apu1, as well as for binary PI familty 16h based on apu2 (postcar support already