[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Thu, Aug 22, 2019 at 4:59 AM Matt B wrote: >> >> I believe S3 resume path is PSP assisted. When x86 core reset is deasserted >> some parts of the memory controller PHY have already been programmed by PSP >> or SMU firmwares. > > (No PSP present on the G505s) Perhaps my commentary was not so

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Matt B
> > I believe S3 resume path is PSP assisted. When x86 core reset is > deasserted some parts of the memory controller PHY have already been > programmed by PSP or SMU firmwares. (No PSP present on the G505s) > You should consider binaryPI mostly broken for the purpose of S3 > suspend/resume. > A

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 7:52 PM Raul Rangel wrote: > > You can grep for commits containing b:65442212 or b:111610455 to see the work > required to remove AGESA from bootblock. Thanks! Some of that seems very SoC or hardware specific. I think we will go ahead with a bootblock that does nothing e

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Raul Rangel
You can grep for commits containing b:65442212 or b:111610455 to see the work required to remove AGESA from bootblock. On Wed, Aug 21, 2019 at 10:22 AM Kyösti Mälkki wrote: > On Wed, Aug 21, 2019 at 6:53 PM Michal Zygowski > wrote: > >> I get the overall idea of C bootblock. The most fun is abo

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 6:53 PM Michal Zygowski wrote: >> I get the overall idea of C bootblock. The most fun is about the > assembly to setup CAR early. But what about S3 suspend/resume for APU2 > for example? It is not supported by the platform and does not seem to be > needed at all there (it i

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Michal Zygowski
On 8/21/19 8:59 AM, Kyösti Mälkki wrote: > On Wed, Aug 21, 2019 at 9:23 AM Michal Zygowski > wrote: >> Hello Kyösti, >> >> Giving such a "credit" to give a little more time to bring the platform >> to release requirements sounds like a good idea. >> >> 3mdeb will surely approach to implement thos

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-21 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 9:23 AM Michal Zygowski wrote: > > Hello Kyösti, > > Giving such a "credit" to give a little more time to bring the platform > to release requirements sounds like a good idea. > > 3mdeb will surely approach to implement those changes based on family > 14h apu1, as well as f

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-20 Thread Michal Zygowski
Hello Kyösti, Giving such a "credit" to give a little more time to bring the platform to release requirements sounds like a good idea. 3mdeb will surely approach to implement those changes based on family 14h apu1, as well as for binary PI familty 16h based on apu2 (postcar support already slowly

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-20 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 5:43 AM Matt B wrote: > > Is a lack of C bootblock support common to all family 15h platforms? > (Including the G505s and any others?) > In other words, would it only need to be implemented once for all of these > systems? > It's not really a CPU family thing at all, but

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-20 Thread Kyösti Mälkki
On Wed, Aug 21, 2019 at 5:57 AM Thierry Laurion - Insurgo Technologies Libres / Open Technologies wrote: > > I could provide such resume logs for kgpe-d16. > > How do I produce them? > Cold boot, enter OS, enter S3 suspsnd. Wake up (probably toggle power button, moving mouse or anykey might not d

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-20 Thread Thierry Laurion - Insurgo Technologies Libres / Open Technologies
I could provide such resume logs for kgpe-d16. How do I produce them? On August 21, 2019 2:43:44 AM UTC, Matt B wrote: >Is a lack of C bootblock support common to all family 15h platforms? >(Including the G505s and any others?) >In other words, would it only need to be implemented once for all o

[coreboot] Re: Final calls for S3 suspend support on amdfam10-15

2019-08-20 Thread Matt B
Is a lack of C bootblock support common to all family 15h platforms? (Including the G505s and any others?) In other words, would it only need to be implemented once for all of these systems? Sincerely, -Matthew Bradley On Thu, Aug 15, 2019 at 11:50 AM Kyösti Mälkki wrote: > Hi > > The decis