Re: Features of the JUnit test execution harness

2006-02-03 Thread Andreas Korneliussen
Myrna van Lunteren wrote: On 2/2/06, *Andreas Korneliussen* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: I think the work currently done on DERBY-874 was mainly to improve the DerbyJUnitTest's JavaDoc, and to log exceptions. So I would not throw that away. However I do

Re: Features of the JUnit test execution harness

2006-02-03 Thread Deepa Remesh
So I guess what you are saying is that if the test framework provides a common mechanism to give a Connection to a derby database, it should go through a DataSource, instead of using DriverManager ? I think we will need both mechanisms to get connection - using DataSource and DriverManager.

Re: Features of the JUnit test execution harness

2006-02-03 Thread Daniel John Debrunner
Deepa Remesh wrote: So I guess what you are saying is that if the test framework provides a common mechanism to give a Connection to a derby database, it should go through a DataSource, instead of using DriverManager ? I think we will need both mechanisms to get connection - using

Re: Features of the JUnit test execution harness

2006-02-03 Thread Kristian Waagan
Deepa Remesh wrote: So I guess what you are saying is that if the test framework provides a common mechanism to give a Connection to a derby database, it should go through a DataSource, instead of using DriverManager ? I think we will need both mechanisms to get connection - using DataSource

Re: Features of the JUnit test execution harness

2006-02-02 Thread Andreas Korneliussen
Myrna van Lunteren wrote: On 1/31/06, *Kristian Waagan* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Differences in output should be irrelevant. Although not what you mentioned above, the issue of (execution) control is very relevant. The logic for running the tests multiple

Re: Features of the JUnit test execution harness

2006-02-02 Thread Myrna van Lunteren
On 2/2/06, Andreas Korneliussen [EMAIL PROTECTED] wrote: I think the work currently done on DERBY-874 was mainly to improve theDerbyJUnitTest's JavaDoc, and to log exceptions. So I would not throw that away.However I do propose to change DerbyJUnitTest to move out everythingabout configuration

Re: Features of the JUnit test execution harness

2006-02-01 Thread Myrna van Lunteren
On 1/31/06, Kristian Waagan [EMAIL PROTECTED] wrote: Differences in output should be irrelevant. Although not what youmentioned above, the issue of (execution) control is very relevant. The logic for running the tests multiple times, each time with a differentsetup/environment must be located

Re: Features of the JUnit test execution harness

2006-01-31 Thread Myrna van Lunteren
On 1/24/06, Kristian Waagan [EMAIL PROTECTED] wrote: Kristian Waagan wrote:4) Should it be possible to run single JUnit test/suite from the command line 2 yeahs snipped, 3rd: (Dan:) I think it's essential that a single test can be run. I don't think it's essential that it is from test's main

Re: Features of the JUnit test execution harness

2006-01-31 Thread Myrna van Lunteren
Silly question(s): with the Junit testsij is not used? if not, and we're going to convert all tests to junit, should there be a new test to test the tool ij specifically (at some point) ? Myrna

Re: Features of the JUnit test execution harness

2006-01-31 Thread Rick Hillegas
Hi Myrna, I don't think we've discussed yet how or when we would convert existing tests to JUnit. I agree that ij needs to continue to be tested. Regards, -Rick Myrna van Lunteren wrote: Silly question(s): with the Junit tests ij is not used? if not, and we're going to convert all tests to

Re: Features of the JUnit test execution harness

2006-01-31 Thread Kristian Waagan
Myrna van Lunteren wrote: On 1/24/06, *Kristian Waagan* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Kristian Waagan wrote: 4) Should it be possible to run single JUnit test/suite from the command line 2 yeahs snipped, 3rd: (Dan:) I think it's essential that a single test

Re: Features of the JUnit test execution harness

2006-01-26 Thread Kristian Waagan
Rick Hillegas wrote: Kristian Waagan wrote: 2) Should we support setting up a shared test fixture for a set of tests? This is a common issue with JUnit, and there are mechanisms to handle it. For instance, we could let tests that require this to wrap itself in a TestSetup instance (as

Re: Features of the JUnit test execution harness

2006-01-26 Thread David W. Van Couvering
I think there's a lot of value in having a suite-level setup mechanism, I totally agree that doing setup for each test can be overkill and I am often finding ways to work around it. David Kristian Waagan wrote: Rick Hillegas wrote: Kristian Waagan wrote: 2) Should we support setting

Re: Features of the JUnit test execution harness

2006-01-26 Thread Rick Hillegas
Thanks, Kristian. This is indeed helpful. My takeaway is that our JUnit primer should recommend something like this as the pattern if developers need to move the setup()/teardown() brackets outside a cluster of tests. Regards, -Rick Kristian Waagan wrote: Rick Hillegas wrote: Kristian

Re: Features of the JUnit test execution harness

2006-01-25 Thread Bernt M. Johnsen
Daniel John Debrunner wrote (2006-01-24 20:23:27): The other issue is that we have a great opportunity to start out with JUnit tests that follow a consistent pattern and provide a great example for others to follow. +1 -- Bernt Marius Johnsen, Database Technology Group, Staff Engineer,

Re: Features of the JUnit test execution harness

2006-01-25 Thread David W. Van Couvering
I have to agree we're missing a well-defined pattern and associated guidebook on how to do this right. And I agree we should get this done before too many more JUnit tests are written. David Daniel John Debrunner wrote: Daniel John Debrunner wrote: David W. Van Couvering wrote: I

Re: Features of the JUnit test execution harness

2006-01-25 Thread Rick Hillegas
I apologize for the radio silence on this topic. I have been on the road and unable to address these concerns. Today I will put some effort into beefing up the comments in DerbyJUnitTest and handling the swallowed exceptions. I agree that we need a primer for writing JUnit tests. I can mock

Re: Features of the JUnit test execution harness

2006-01-25 Thread Kathey Marsden
Daniel John Debrunner wrote: Daniel John Debrunner wrote: David W. Van Couvering wrote: I agree with you that is disconcerting, but can't JUnit tests be written that extend DerbyJUnitTest in parallel with getting DerbyJUnitTest cleaned up to everyone's satisfaction? Depends,

Re: Features of the JUnit test execution harness

2006-01-25 Thread Deepa Remesh
One thing that would be great is if there was a well defined way to have tests handle jvm specific, framework specific or version specific logic, since there will have to be some replacement for the many properties in the test harness and the individual test checks for framework that we have

Re: Features of the JUnit test execution harness

2006-01-25 Thread Rick Hillegas
Hi Deepa, Thanks for bringing this up. I agree that being able to run JUnit tests on the small device configuration would be a good idea. Regards, -Rick Deepa Remesh wrote: One thing that would be great is if there was a well defined way to have tests handle jvm specific, framework

Re: Features of the JUnit test execution harness

2006-01-24 Thread Daniel John Debrunner
David W. Van Couvering wrote: Kristian Waagan wrote: 4) Should it be possible to run single JUnit test/suite from the command line by simply invoking the main method? Personally, I think this should be possible. This require us to remove the current use of main for running a test in the

Re: Features of the JUnit test execution harness

2006-01-24 Thread Kristian Waagan
Daniel John Debrunner wrote: David W. Van Couvering wrote: Kristian Waagan wrote: 4) Should it be possible to run single JUnit test/suite from the command line by simply invoking the main method? Personally, I think this should be possible. This require us to remove the current use of

Re: Features of the JUnit test execution harness

2006-01-24 Thread Kristian Waagan
David W. Van Couvering wrote: Hi, Kristian, thanks for your questions. My one overriding thought is we should take this in incremental steps -- do all of these questions need to be answered before we can rewrite a single old canon-based test to a JUnit test? Can some of these questions be

Re: Features of the JUnit test execution harness

2006-01-24 Thread Francois Orsini
On 1/24/06, Kristian Waagan [EMAIL PROTECTED] wrote: David W. Van Couvering wrote: Hi, Kristian, thanks for your questions.My one overriding thought is we should take this in incremental steps -- do all of these questions need to be answered before we can rewrite a single old canon-based test to

Re: Features of the JUnit test execution harness

2006-01-24 Thread Daniel John Debrunner
Francois Orsini wrote: On 1/24/06, *Kristian Waagan* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: David W. Van Couvering wrote: Hi, Kristian, thanks for your questions. My one overriding thought is we should take this in incremental steps -- do all of these

Re: Features of the JUnit test execution harness

2006-01-24 Thread David W. Van Couvering
I agree with you that is disconcerting, but can't JUnit tests be written that extend DerbyJUnitTest in parallel with getting DerbyJUnitTest cleaned up to everyone's satisfaction? BTW, if you don't like the rampant catching and ignoring, is anything preventing you from going in and fixing it?

Re: Features of the JUnit test execution harness

2006-01-24 Thread Daniel John Debrunner
David W. Van Couvering wrote: I agree with you that is disconcerting, but can't JUnit tests be written that extend DerbyJUnitTest in parallel with getting DerbyJUnitTest cleaned up to everyone's satisfaction? Depends, at some point you put the potential burden of fixing all those new tests on

Re: Features of the JUnit test execution harness

2006-01-24 Thread Daniel John Debrunner
Daniel John Debrunner wrote: David W. Van Couvering wrote: I agree with you that is disconcerting, but can't JUnit tests be written that extend DerbyJUnitTest in parallel with getting DerbyJUnitTest cleaned up to everyone's satisfaction? Depends, at some point you put the potential