Re: Building on Java 11

Emmanuel suggested this: https://stackoverflow.com/questions/53055564/unable-to-compile-in-intellij-errorjava-exporting-a-package-from-system-modu?noredirect=1&lq=1 Which would seem to line up with your error below. Per the PR [1] the maven build specifically isn't using the --release flag as alth

Re: Building on Java 11

I can't open the project on Idea. It says something weird as: "Error: java: exporting a package from system module jdk.unsupported is not allowed with --release" (mind I had to retype it.. as i can't copy and paste from the error screen) Does anyone know how to get past this? On Fri, Jun 5, 20

Re: Building on Java 11

Thanks Le 05/06/2020 à 16:51, Robbie Gemmell a écrit : > Building the javadoc wouldnt work for me on OpenJDK 11, probably for > the reasons I covered at > https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127 > > I have since prepared fixes for all the errors however to now

Re: Building on Java 11

Building the javadoc wouldnt work for me on OpenJDK 11, probably for the reasons I covered at https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127 I have since prepared fixes for all the errors however to now get it to do so. They build on Emmanuel's changes a little so I wo

Re: Building on Java 11

what's nice about this, is that even compatibility tests are running... (think about that the compatibility tests is mixing a mesh that includes even old hornetq clients against artemis master, and these were built with older JDK). I was afraid old versions of netty woudln't be compatible on the n

Re: Building on Java 11

I am able to build with adoptopenjdk 11, but not with 13. a lot of errors on javadoc. We would need to fix those to be able to be flexible enough? or is there any magic settings perhaps to relax this? On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell wrote: > > Going back to the error-prone dep bei

Re: Building on Java 11

Going back to the error-prone dep being added to all the modules, if those need to stay I think it would be good for the scope+optional elements be added as well? I see its being governed in the dependencyManagement addition, but the various modules appear to have those elements for their existing

Re: Building on Java 11

Can I ask again about the seemingly broken errorprone-javac config on the branch, which looks to be using a non-existent javac.version property config: "-J-Xbootclasspath/p:${settings.localRepository}/com/google/errorprone/javac/${javac.version}/javac-${javac.version}.jar Looking at https://errorp

Re: Building on Java 11

: Clebert Suconic Date: 02/06/2020 18:23 (GMT+00:00) To: Emmanuel Hugonnet Cc: dev@activemq.apache.org Subject: Re: Building on Java 11 that's coolwe should move forward then!On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet wrote:>> error-prone 2.4.0 has been released with JD

Re: Building on Java 11

that's cool we should move forward then! On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet wrote: > > error-prone 2.4.0 has been released with JDK 14 and 15 support. > > This might answer your question :) > > Emmanuel > > Le 02/06/2020 à 18:31, Clebert Suconic a écrit : > > But I think it sho

Re: Building on Java 11

error-prone 2.4.0 has been released with JDK 14 and 15 support. This might answer your question :) Emmanuel Le 02/06/2020 à 18:31, Clebert Suconic a écrit : > But I think it should be on anything 11+ > > I would rather avoid having to re-address this again in the future, > and be generic enough.

Re: Building on Java 11

But I think it should be on anything 11+ I would rather avoid having to re-address this again in the future, and be generic enough. What's holding the build on JDK 13? is it error prone for sure or something else? On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet wrote: > > Hello, > > I' ve upd

Re: Building on Java 11

Hello, I' ve updated my branch and rebased on current master from clebert's branch. It passes a simple build on java 11.0.6 Cheers, Emmanuel Le 08/05/2020 à 19:47, Clebert Suconic a écrit : > Oh wow.. that's awesome. > > > Can we do the migration after the 2.13.0 release? I have pretty much >

Re: Building on Java 11

Ok, shame. I'd probably ditch it for now given that and the other issues with newer JDKs. Or maybe it could be profile'd so it only worked on JDK 8 with the older minimal config, and just ensure it runs in CI? Save covering every module with dep bits for it. Regardless, point still stands about th

Re: Building on Java 11

But I wouldn’t hold jdk upgrade over it. Just setting out priorities. On Fri, May 29, 2020 at 12:56 PM Emmanuel Hugonnet wrote: > Well it discovers some issues like > > activemq-artemis/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java:[104,55] > [FormatS

Re: Building on Java 11

Well it discovers some issues like activemq-artemis/artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/check/QueueCheck.java:[104,55] [FormatString] extra format arguments: used 0, provided 1 [ERROR] (see https://errorprone.info/bugpattern/FormatString) Le 29/05/2020 à 18:36,

Re: Building on Java 11

I agree 100% on ditching error prone if it's blocking us. Justin On Fri, May 29, 2020 at 11:34 AM Clebert Suconic wrote: > I'm not in love with error prone. if it's blocking us to move to a > newer JDK i say it goes away (at least for now).. if at a later point > it's again compatible we put i

Re: Building on Java 11

I'm not in love with error prone. if it's blocking us to move to a newer JDK i say it goes away (at least for now).. if at a later point it's again compatible we put it back on. On Fri, May 29, 2020 at 12:21 PM Emmanuel Hugonnet wrote: > > Hello, > > Alas yes as otherwise you need to configure th

Re: Building on Java 11

Hello, Alas yes as otherwise you need to configure the compilation with error-prone and jboss logging annotation processor., and future annotation processors. It was the less intrusive way from my point of view. Emmanuel Le 29/05/2020 à 18:10, Robbie Gemmell a écrit : > Is it really necessary

Re: Building on Java 11

https://github.com/google/error-prone/issues/1106 *cushon * commented 2 days ago As of 746c15f ,

Re: Building on Java 11

Is it really necessary to add error-prone definition to almost every module? Presumably theres some module it isnt defined in. No other workarounds for that? I also wonder about this bit: https://github.com/apache/activemq-artemis/compare/master...clebertsuconic:java_11#diff-600376dffeb79835ede4a0

Re: Building on Java 11

I used OpenJDK 11.0.6, didn't try OpenJDK 14. Maybe we should remove error prone for JDK > 11. Emmanuel Le 29/05/2020 à 17:58, Clebert Suconic a écrit : > I have JDK 13 on my mac.. I just tried with the rebase and I got this: > > [ERROR] at > org.codehaus.plexus.classworlds.launcher.Launcher.ma

Re: Building on Java 11

Excellent to see some work on this! Whilst I obviously have Java 8 around since most components target it currently and so its my main build env, I do also have envs that default to 11 and as you later said its really annoying having to tweak the env back to 8 just to build a given component there

Re: Building on Java 11

No worries... I am just making the ball rolling, perhaps someone else will also be interested on helping out here. On Fri, May 29, 2020 at 11:57 AM Emmanuel Hugonnet wrote: > > I'm a bit overloaded today. I will take a look Tuesday (since Monday is a > public holiday). > > Cheers, > > Emmanuel >

Re: Building on Java 11

I have JDK 13 on my mac.. I just tried with the rebase and I got this: [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) [ERROR] Caused by: java.lang.NoSuchMethodException: com.sun.tools.javac.comp.Resolve.findIdent(com.sun.tools.javac.comp.Env,com.sun.tools.ja

Re: Building on Java 11

I'm a bit overloaded today. I will take a look Tuesday (since Monday is a public holiday). Cheers, Emmanuel Le 29/05/2020 à 17:55, Clebert Suconic a écrit : > @Emmanuel: I rebased your branch here: > https://github.com/clebertsuconic/activemq-artemis/tree/java_11 > > Perhaps you may want to tak

Re: Building on Java 11

@Emmanuel: I rebased your branch here: https://github.com/clebertsuconic/activemq-artemis/tree/java_11 Perhaps you may want to take a look. On Fri, May 29, 2020 at 11:54 AM Clebert Suconic wrote: > > so, if we switched to JDK 11 on the CI, those would still work with > the trick you used? > > On

Re: Building on Java 11

Yes, you should be able to build with both JDK 8 and 11. Emmanuel Le 29/05/2020 à 17:54, Clebert Suconic a écrit : > so, if we switched to JDK 11 on the CI, those would still work with > the trick you used? > > On Fri, May 29, 2020 at 11:39 AM Emmanuel Hugonnet > wrote: >> I changed the way the

Re: Building on Java 11

so, if we switched to JDK 11 on the CI, those would still work with the trick you used? On Fri, May 29, 2020 at 11:39 AM Emmanuel Hugonnet wrote: > > I changed the way the classloaders where working with JDK 11 using the > plateform classloader as the parent instead of null so that I could > acc

Re: Building on Java 11

I changed the way the classloaders where working with JDK 11 using the plateform classloader as the parent instead of null so that I could access the required modules. Emmanuel Le 29/05/2020 à 17:37, Clebert Suconic a écrit : > We should come back into this... > > > How did you fix the compatibi

Re: Building on Java 11

We should come back into this... How did you fix the compatibility tests with JDK 11? do you need JDK 8 to run the compatibility tests? On Fri, May 8, 2020 at 3:19 PM Emmanuel Hugonnet wrote: > > No relation to WildFly, just for the 'fun' of it and because switching my > JAVA_HOME and PATH eac

Re: Building on Java 11

No relation to WildFly, just for the 'fun' of it and because switching my JAVA_HOME and PATH each time I wxanted to build was itching me too much ;) It can wait and get some baking :) Emmanuel Le 08/05/2020 à 19:47, Clebert Suconic a écrit : > Oh wow.. that's awesome. > > > Can we do the migra

Re: Building on Java 11

Oh wow.. that's awesome. Can we do the migration after the 2.13.0 release? I have pretty much everything ready to go (besides a few changes we have to make next week). doing this migration now would probably delay the release. Or you have some requirement for Wildfly that you must do this now?

Building on Java 11

Hello, When i need to work on Apache ActiveMQ Artemis I need to switch my local environement to use OpenJDK 8 instead of the default OpenJDK 11 which I use to develop. I have started a branch https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds on OpenJDK 8 and 11 with the fa