Re: [VOTE] March 2024 PR of the Month

2024-03-25 Thread Amogh Desai
My vote goes to #36755 Great teamwork, given that it wasn't so easy since so many providers were involved. Kudos! Thanks & Regards, Amogh Desai On Tue, Mar 26, 2024 at 5:46 AM Jarek Potiuk wrote: > +1 on Python 3.12 (#36755) - with the note that it's been a joint effort > of quite a few

Re: [VOTE] Airflow Providers prepared on March 25, 2024

2024-03-25 Thread Amogh Desai
+1 non binding Installed airflow from main with fab rc1 and I was able to create a few test users with various roles, check their rights on the elements, and run a few simple dags. Works fine from my end. Btw, @Elad Kalif there's a typo: *This release is only for FAB provider to be tested

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Rahul Vats
+1 (non-binding) Regards, Rahul Vats 9953794332 On Mon, 25 Mar 2024 at 22:46, Jed Cunningham wrote: > Hello Airflow Community, > > I would like to start a vote on AIP-64: Keep TaskInstance try history. > > You can find the AIP here: > >

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Vikram Koka
+1 binding On Mon, Mar 25, 2024 at 6:19 PM Mehta, Shubham wrote: > +1 (non-binding). > > Shubham > > On 2024-03-25, 5:10 PM, "Wei Lee" weilee...@gmail.com>> wrote: > > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Mehta, Shubham
+1 (non-binding). Shubham On 2024-03-25, 5:10 PM, "Wei Lee" mailto:weilee...@gmail.com>> wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. AVERTISSEMENT: Ce

Re: [VOTE] March 2024 PR of the Month

2024-03-25 Thread Jarek Potiuk
+1 on Python 3.12 (#36755) - with the note that it's been a joint effort of quite a few people - Andrey, Bolke, Gopal Dirisao who contributed to it in Airflow, but also a number people who are maintainers of our dependencies: Israel Fruchter and Bret McGuire from Cassandra, Andreas Poehlmann

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Wei Lee
+1 (non-binding), looking forward to it! Best, Wei > On Mar 26, 2024, at 6:17 AM, Jarek Potiuk wrote: > > +1 (binding) > > On Mon, Mar 25, 2024 at 10:51 PM Scheffler Jens (XC-AS/EAE-ADA-T) > wrote: > >> +1 binding >> >> Sent from Outlook for iOS >>

Re: [VOTE] March 2024 PR of the Month

2024-03-25 Thread Wei Lee
+1 for #36755 Best, Wei > On Mar 26, 2024, at 5:50 AM, Scheffler Jens (XC-AS/EAE-ADA-T) > wrote: > > My vote is +1 for #36755 - mainly because it was really a long - runner and > important we made it! > > Sent from Outlook for iOS > >

[ANNOUNCE] Apache Airflow 2.8.4 Released

2024-03-25 Thread Jed Cunningham
Dear Airflow community, I'm happy to announce that Airflow 2.8.4 was just released. The released sources and packages can be downloaded via https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-sources.html Other installation methods are described in

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Jarek Potiuk
+1 (binding) On Mon, Mar 25, 2024 at 10:51 PM Scheffler Jens (XC-AS/EAE-ADA-T) wrote: > +1 binding > > Sent from Outlook for iOS > > From: Pierre Jeambrun > Sent: Monday, March 25, 2024 9:19:36 PM > To: dev@airflow.apache.org > Subject:

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Scheffler Jens (XC-AS/EAE-ADA-T)
+1 binding Sent from Outlook for iOS From: Pierre Jeambrun Sent: Monday, March 25, 2024 9:19:36 PM To: dev@airflow.apache.org Subject: Re: [VOTE] AIP-64: Keep TaskInstance try history +1 (binding) On Mon 25 Mar 2024 at 19:32, Igor

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Kaxil Naik
+1 (binding) On Mon, 25 Mar 2024 at 20:19, Pierre Jeambrun wrote: > +1 (binding) > > On Mon 25 Mar 2024 at 19:32, Igor Kholopov > wrote: > > > +1 (non-binding) > > > > On Mon, Mar 25, 2024 at 7:28 PM Tzu-ping Chung > > > wrote: > > > > > +1 binding. > > > > > > This is something we should

Re: [VOTE] March 2024 PR of the Month

2024-03-25 Thread Scheffler Jens (XC-AS/EAE-ADA-T)
My vote is +1 for #36755 - mainly because it was really a long - runner and important we made it! Sent from Outlook for iOS From: Briana Okyere Sent: Monday, March 25, 2024 8:53:32 PM To: dev@airflow.apache.org Subject: [VOTE] March 2024

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Pierre Jeambrun
+1 (binding) On Mon 25 Mar 2024 at 19:32, Igor Kholopov wrote: > +1 (non-binding) > > On Mon, Mar 25, 2024 at 7:28 PM Tzu-ping Chung > wrote: > > > +1 binding. > > > > This is something we should just do even outside of the DAG versioning > > context (which we also should do, to be clear). > >

[ANNOUNCE] Apache Airflow Helm Chart version 1.13.1 Released

2024-03-25 Thread Jed Cunningham
Dear Airflow community, I am pleased to announce that we have released Apache Airflow Helm chart 1.13.1   The source release, as well as the "binary" Helm Chart release, are available:  Official Sources:

[RESULT][VOTE] Release Airflow 2.8.4 from 2.8.4rc1

2024-03-25 Thread Jed Cunningham
Hello, Apache Airflow 2.8.4 (based on RC1) has been accepted. 4 "+1" binding votes received: - Jed Cunningham - Jarek Potiuk - Hussein Awala - Andrey Anshin 3 "+1" non-binding votes received: - Rahul Vats - Amogh Desai - Wei Lee Vote thread:

Re: [VOTE] Release Airflow 2.8.4 from 2.8.4rc1

2024-03-25 Thread Jed Cunningham
Hey Andrey, If you reimport from KEYS, I've already updated the expiration date a while back :). But yes, that would be problematic otherwise. Jed On Sat, Mar 23, 2024 at 10:41 AM Andrey Anshin wrote: > +1 binding > > Checked files, licences, signatures and also my changes. > > One small nit

Re: [VOTE] March 2024 PR of the Month

2024-03-25 Thread Andrey Anshin
+1 for #36755 Python3.12 On Mon, 25 Mar 2024 at 23:54, Briana Okyere wrote: > Hey All, > > It’s once again time to vote for the PR of the Month! > > With the help of the `get_important_pr_candidates` script in dev/stats, > we've identified the following candidates: > > PR #37937: refactor:

[VOTE] March 2024 PR of the Month

2024-03-25 Thread Briana Okyere
Hey All, It’s once again time to vote for the PR of the Month! With the help of the `get_important_pr_candidates` script in dev/stats, we've identified the following candidates: PR #37937: refactor: Refactored __new__ magic method of BaseOperatorMeta to avoid bad mixing classic and decorated

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Igor Kholopov
+1 (non-binding) On Mon, Mar 25, 2024 at 7:28 PM Tzu-ping Chung wrote: > +1 binding. > > This is something we should just do even outside of the DAG versioning > context (which we also should do, to be clear). > > TP > > > > On Mar 26, 2024, at 02:12, Aritra Basu wrote: > > > > +1

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Tzu-ping Chung
+1 binding. This is something we should just do even outside of the DAG versioning context (which we also should do, to be clear). TP > On Mar 26, 2024, at 02:12, Aritra Basu wrote: > > +1 (non-binding) > This is quite good, I'd thought in passing that it'd be useful to have. > > -- >

Re: [VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Aritra Basu
+1 (non-binding) This is quite good, I'd thought in passing that it'd be useful to have. -- Regards, Aritra Basu On Mon, Mar 25, 2024, 10:46 PM Jed Cunningham wrote: > Hello Airflow Community, > > I would like to start a vote on AIP-64: Keep TaskInstance try history. > > You can find the AIP

[RESULT][VOTE] Release Apache Airflow Helm Chart 1.13.1 based on 1.13.1rc1

2024-03-25 Thread Jed Cunningham
Hello all, The vote to release Apache Airflow Helm Chart version 1.13.1 based on 1.13.1rc1 is now closed. The vote PASSED with 3 binding "+1", 1 non-binding "+1" and 0 "-1" votes: "+1" Binding votes: - Jed Cunningham - Jarek Potiuk - Hussein Awala "+1" Non-Binding votes: - Amogh

[VOTE] AIP-64: Keep TaskInstance try history

2024-03-25 Thread Jed Cunningham
Hello Airflow Community, I would like to start a vote on AIP-64: Keep TaskInstance try history. You can find the AIP here: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-64%3A+Keep+TaskInstance+try+history Discussion Thread:

Re: [VOTE] Airflow Providers prepared on March 25, 2024

2024-03-25 Thread Jarek Potiuk
+1 (binding): checked signatures, checksums, licences, reproducibility. I build latest main `airflow` (that will become b2) as `2.9.0rc1` package and installed it together with apache-airflow-providers-fab `1.0.2rc1` and they work nicely together. I was able to create users, authenticate, login

[VOTE] Airflow Providers prepared on March 25, 2024

2024-03-25 Thread Elad Kalif
Hey all, I have just cut the new wave Airflow Providers packages. This email is calling a vote on the release, which will last for 72 hours - which means that it will end on March 28, 2024 13:55 PM UTC and until 3 binding +1 votes have been received. Consider this my (binding) +1. This release

Re: [VOTE] Release Airflow 2.8.4 from 2.8.4rc1

2024-03-25 Thread Wei Lee
+1 (non-binding) Ran a few example DAGs and worked fine. Best, Wei > On Mar 25, 2024, at 3:30 PM, Amogh Desai wrote: > > +1 non binding > > Verified my changes, and ran a few example DAGs. I see no regressions. > > Thanks & Regards, > Amogh Desai > > > On Sat, Mar 23, 2024 at 8:11 PM

Re: [DISCUSS] Applying D105 rule for our codebase ("undocumented magic methods") ?

2024-03-25 Thread Jarek Potiuk
PR to remove it https://github.com/apache/airflow/pull/38452 On Mon, Mar 25, 2024 at 10:14 AM Jarek Potiuk wrote: > Ok. Seems we have a consensus :) > > On Mon, Mar 25, 2024 at 7:13 AM Wei Lee wrote: > >> +1 for removing this rule. If docstring is needed for some cases, we can >> still do that

Re: [DISCUSS] Applying D105 rule for our codebase ("undocumented magic methods") ?

2024-03-25 Thread Jarek Potiuk
Ok. Seems we have a consensus :) On Mon, Mar 25, 2024 at 7:13 AM Wei Lee wrote: > +1 for removing this rule. If docstring is needed for some cases, we can > still do that or add comments to PRs. > > Best, > Wei > > > On Mar 25, 2024, at 1:31 PM, Amogh Desai > wrote: > > > > After reading the

Re: [VOTE] Release Airflow 2.8.4 from 2.8.4rc1

2024-03-25 Thread Amogh Desai
+1 non binding Verified my changes, and ran a few example DAGs. I see no regressions. Thanks & Regards, Amogh Desai On Sat, Mar 23, 2024 at 8:11 PM Andrey Anshin wrote: > +1 binding > > Checked files, licences, signatures and also my changes. > > One small nit that I've found is that the key

Re: [DISCUSS] Applying D105 rule for our codebase ("undocumented magic methods") ?

2024-03-25 Thread Wei Lee
+1 for removing this rule. If docstring is needed for some cases, we can still do that or add comments to PRs. Best, Wei > On Mar 25, 2024, at 1:31 PM, Amogh Desai wrote: > > After reading the emails in this thread, I too think that this rule is not > generally very useful, but we should have