Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-04 8:32 GMT+02:00 Jan Matèrne (jhm) : > Changing Ants own test to use JUnit5 does not mean we have to change Ant > itself and don't have to cut a release. > > What do you want to move to "ant-legacy"? > You're right, JUnit 5 puts no new requirements on Ant. Should we

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

2018-05-05 17:58 GMT+02:00 Stefan Bodewig : > What is the benefit of changing tests that currently pass when neither > the test itself nor the code under test is changed? > That would be avoiding repetitive code => lucidity. Eg, for every simple executeTarget("test") there

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

On 2018-05-03, Gintautas Grigelionis wrote: > 2018-05-03 11:06 GMT+02:00 Stefan Bodewig : >> I'm still not sure I understand which benefit you see by retrofitting >> tests that have been written before @Parameterized was invented. They do >> contain way too many asserts in a

AW: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

erstag, 3. Mai 2018 20:46 > An: Ant Developers List > Betreff: Re: Parameterized Tests (was Re: ant git commit: Inline > buildfile names, make search easier) > > IMHO that would mean putting parts of Ant core into ant-legacy.jar > > Gintas > > 2018-05-03 19:03 GMT+02:00 M

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

IMHO that would mean putting parts of Ant core into ant-legacy.jar Gintas 2018-05-03 19:03 GMT+02:00 Matt Sicker : > Yes, I'm definitely suggesting/hyping JUnit 5. :) >

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

Yes, I'm definitely suggesting/hyping JUnit 5. :) On 3 May 2018 at 12:01, Gintautas Grigelionis wrote: > My focus was on maximising the use of JUnit 4 idioms. > Are you suggesting a switch to JUnit 5 instead? > Sounds like Ant 1.11 :-) > > Gintas > > 2018-05-03 17:12

Re: Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

My focus was on maximising the use of JUnit 4 idioms. Are you suggesting a switch to JUnit 5 instead? Sounds like Ant 1.11 :-) Gintas 2018-05-03 17:12 GMT+02:00 Matt Sicker : > I've started using JUnit 5 in a personal project and found that it has a > lot more useful features

Parameterized Tests (was Re: ant git commit: Inline buildfile names, make search easier)

On 2018-04-30, Gintautas Grigelionis wrote: > 2018-04-30 13:13 GMT+00:00 Stefan Bodewig : >> On 2018-04-30, Gintautas Grigelionis wrote: >>> the overarching goal, however, is to reduce verbosity, because >>> verbosity makes it easier to hide mistakes. >> This is your goal

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 13:13 GMT+00:00 Stefan Bodewig : > On 2018-04-30, Gintautas Grigelionis wrote: > > the overarching goal, however, is to reduce verbosity, because > > verbosity makes it easier to hide mistakes. > > This is your goal and we should have decided together whether we

AW: ant git commit: Inline buildfile names, make search easier

> > In my eyes most of the committers don't like these "code style" > changes. > > So please stop these changes and invest your energy more productive. > > > > I don't think it would be helpful if another committer starts > > reverting the changes because of a different preference ... > > > With

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 10:45 GMT+00:00 Jan Matèrne (jhm) : > In my eyes most of the committers don't like these "code style" changes. > So please stop these changes and invest your energy more productive. > > I don't think it would be helpful if another committer starts reverting the >

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 10:43 GMT+00:00 Jaikiran Pai : > > On 30/04/18 12:52 PM, Gintautas Grigelionis wrote: > >> My apologies for offending anyone; just one last silly question: why >> uniformity is not a requirement? >> > I think it has already been explained in the other thread

AW: ant git commit: Inline buildfile names, make search easier

> > Changes like these are random personal preferences. > > Right. > > > The fact that these are being done even after the mail discussions we > > recently had, indicates that the request to not do such changes have > > been ignored. This is going down the route of a being some kind of a > >

Re: ant git commit: Inline buildfile names, make search easier

On 30/04/18 12:52 PM, Gintautas Grigelionis wrote: My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? I think it has already been explained in the other thread why it's not a necessity for a project as large and as old as this one, especially

Re: ant git commit: Inline buildfile names, make search easier

> Le 30 avr. 2018 à 11:58, Stefan Bodewig a écrit : > > On 2018-04-30, Jaikiran Pai wrote: > >> Changes like these are random personal preferences. > > Right. > >> The fact that these are being done even after the mail discussions we >> recently had, indicates that the

Re: ant git commit: Inline buildfile names, make search easier

On 30/04/18 3:52 PM, Gintautas Grigelionis wrote: 2018-04-30 9:55 GMT+00:00 Stefan Bodewig : On 2018-04-30, Gintautas Grigelionis wrote: My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? Who's uniformity do you pick?

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 9:55 GMT+00:00 Stefan Bodewig : > On 2018-04-30, Gintautas Grigelionis wrote: > > > My apologies for offending anyone; just one last silly question: why > > uniformity is not a requirement? > > Who's uniformity do you pick? There are so many choices that only depend

Re: ant git commit: Inline buildfile names, make search easier

On 2018-04-30, Jaikiran Pai wrote: > Changes like these are random personal preferences. Right. > The fact that these are being done even after the mail discussions we > recently had, indicates that the request to not do such changes have > been ignored. This is going down the route of a being

Re: ant git commit: Inline buildfile names, make search easier

On 2018-04-30, Gintautas Grigelionis wrote: > My apologies for offending anyone; just one last silly question: why > uniformity is not a requirement? Who's uniformity do you pick? There are so many choices that only depend on taste. assertEquals(x, y) vs assertThat(y, equalTo(x)) amd many many

Re: ant git commit: Inline buildfile names, make search easier

My apologies for offending anyone; just one last silly question: why uniformity is not a requirement? I believe that even one language that espoused TMTOWDI has moved to TIMTOWTDIBSCINABTE? Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai : > > On 30/04/18 11:12 AM,

Re: ant git commit: Inline buildfile names, make search easier

On 30/04/18 11:12 AM, Gintautas Grigelionis wrote: Names of buildfiles used in tests can be found by "grep configureProject"? Why is that even a requirement? I think I am just repeating myself again and again in different mails. Changes like these are random personal preferences. The fact

Re: ant git commit: Inline buildfile names, make search easier

What purpose is this change serving? -Jaikiran On 30/04/18 10:08 AM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 0add85310 -> f3dfb7779 Inline buildfile names, make search easier Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: