[jira] [Commented] (ATLAS-4046) Use Jetty BOM to simplify dependency management

2020-11-23 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237756#comment-17237756 ] Na Li commented on ATLAS-4046: -- [~krisden] you can ask Atlas team to trigger a pre-co

[jira] [Resolved] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li resolved ATLAS-3712. -- Resolution: Fixed > Add 'isAppendOnPartialUpdate' option in ML model to a

[jira] [Commented] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072137#comment-17072137 ] Na Li commented on ATLAS-3712: -- [~amestry] Do we need to commit this to branch 2.0 as

Review Request 72294: ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates

2020-03-31 Thread Na Li via Review Board
rning/4010-ml_model.json to append updates using this new feature introduced in ATLAS-3700. Diffs - addons/models/4000-MachineLearning/4010-ml_model.json c4ba729b87cf581e7f9b23925968b275ae4a688b Diff: https://reviews.apache.org/r/72294/diff/1/ Testing --- Thanks, Na Li

[jira] [Updated] (ATLAS-3700) added option to append value to array, map type attributes

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3700: - Summary: added option to append value to array, map type attributes (was: Partial update to Atlas overwrite map

[jira] [Updated] (ATLAS-3712) Add 'isAppendOnPartialUpdate' option in ML model to append updates

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3712: - Summary: Add 'isAppendOnPartialUpdate' option in ML model to append updates (

[jira] [Updated] (ATLAS-3712) Added 'isAppendOnPartialUpdate' option in ML model to append updates

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3712: - Summary: Added 'isAppendOnPartialUpdate' option in ML model to append updates (

[jira] [Updated] (ATLAS-3712) Added 'isAppendOnPartialUpdate' option in ML model to attend updates

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3712: - Description: Atlas adds a new feature to allow client to append attributes during partial-update operation in

[jira] [Updated] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3700: - Description: *Details:* 1) The model definition is in "https://github.com/apache/atlas/blob/master/a

[jira] [Updated] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

2020-03-31 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3700: - Description: *Details:* 1) The model definition is in "https://github.com/apache/atlas/blob/master/a

[jira] [Created] (ATLAS-3712) Added 'isAppendOnPartialUpdate' option in ML model to attend updates

2020-03-31 Thread Na Li (Jira)
Na Li created ATLAS-3712: Summary: Added 'isAppendOnPartialUpdate' option in ML model to attend updates Key: ATLAS-3712 URL: https://issues.apache.org/jira/browse/ATLAS-3712 Project: Atlas

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

2020-03-31 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72288/#review220156 --- Ship it! Ship It! - Na Li On March 31, 2020, 8:13 a.m

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

2020-03-31 Thread Na Li via Review Board
/v2/EntityGraphMapper.java Lines 1357 (patched) <https://reviews.apache.org/r/72288/#comment308478> do we want to remove duplication? - Na Li On March 31, 2020, 8:13 a.m., Madhan Neethiraj wrote: > > --- > This is a

[jira] [Updated] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3700: - Attachment: ATLAS-3700.004.patch > Partial update to Atlas overwrite map entry with different k

[jira] [Assigned] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li reassigned ATLAS-3700: Assignee: Sarath Subramanian (was: Na Li) > Partial update to Atlas overwrite map entry with differ

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
r-api/src/main/java/org/apache/atlas/RequestContext.java 282a66f1d466d58bce7a590513bc92f99733ba81 webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 3f1ea05e17cded3433d050f891c807d55bdd022a Diff: https://reviews.apache.org/r/72278/diff/4/ Changes: https://reviews.apache.org/r/72278/diff/3-4/ Testing --- add new test case for map attribute for partial update Thanks, Na Li

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
st - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/#review220127 --- On March 30, 2020, 11:52 p.m., Na Li wrote: > &g

[jira] [Updated] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3700: - Attachment: ATLAS-3700.003.patch > Partial update to Atlas overwrite map entry with different k

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
r-api/src/main/java/org/apache/atlas/RequestContext.java 282a66f1d466d58bce7a590513bc92f99733ba81 webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 3f1ea05e17cded3433d050f891c807d55bdd022a Diff: https://reviews.apache.org/r/72278/diff/3/ Changes: https://reviews.apache.org/r/72278/diff/2-3/ Testing --- add new test case for map attribute for partial update Thanks, Na Li

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
his change > > allow the flexibility to specify that? > > Na Li wrote: > The behavior is controled by the message type: > EntityPartialUpdateRequestV2. If the message type is EntityUpdateRequestV2, > overwriting will happen. > > Madhan Neethiraj wro

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
t; // currVal becomes the merged map. > > currVal.putAll(newVal); > > ctx.getReferringVertex().setProperty(propertyName, currVal); > > ``` > > > > > > https://docs.oracle.com/javase/8/docs/api/java/util/HashMap.html#putAll-java.util

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
til.Map- currVal could be null - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/#review220114 --- On March 30, 2020, 3:58 p.m., Na

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/#review220113 --- On March 30, 2020, 3:58 p.m., Na Li wrote: > > --- > This is an automatically genera

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-30 Thread Na Li via Review Board
75b016cca04801c4c1512c1527453fd59a11a6c4 repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java 225b72cbef20b2329b36f550da60c1bbe1f95efa Diff: https://reviews.apache.org/r/72278/diff/2/ Changes: https://reviews.apache.org/r/72278/diff/1-2/ Testing --- add new test case for map attribute for partial update Thanks, Na Li

Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

2020-03-27 Thread Na Li via Review Board
rc/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java 225b72cbef20b2329b36f550da60c1bbe1f95efa Diff: https://reviews.apache.org/r/72278/diff/1/ Testing --- add new test case for map attribute for partial update Thanks, Na Li

[jira] [Created] (ATLAS-3700) Partial update to Atlas overwrite map entry with different keys

2020-03-27 Thread Na Li (Jira)
Na Li created ATLAS-3700: Summary: Partial update to Atlas overwrite map entry with different keys Key: ATLAS-3700 URL: https://issues.apache.org/jira/browse/ATLAS-3700 Project: Atlas Issue Type

[jira] [Resolved] (ATLAS-3432) Add Machine Learning Governance integration

2019-10-24 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li resolved ATLAS-3432. -- Resolution: Won't Fix > Add Machine Learning Governance int

[jira] [Resolved] (ATLAS-3466) Implement ML Hook API for Atlas

2019-10-24 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li resolved ATLAS-3466. -- Resolution: Won't Fix > Implement ML Hook API f

[jira] [Resolved] (ATLAS-3465) Define the ML Hook API that an Atlas addon will implement

2019-10-24 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li resolved ATLAS-3465. -- Resolution: Won't Fix > Define the ML Hook API that an Atlas addon will i

[jira] [Resolved] (ATLAS-3440) Get ML metadata from ML service using HTTP client

2019-10-24 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li resolved ATLAS-3440. -- Resolution: Won't Fix > Get ML metadata from ML service using HTT

[jira] [Resolved] (ATLAS-3435) Handle all fields of User entity from ML Governance Hook input

2019-10-24 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li resolved ATLAS-3435. -- Resolution: Won't Fix > Handle all fields of User entity from ML Governance Ho

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-23 Thread Na Li via Review Board
is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218374 --- On Oct. 23, 2019, 9:22 p.m., Na Li wrote: > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-23 Thread Na Li via Review Board
/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/11/ Changes: https://reviews.apache.org/r/71619/diff/10-11/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-23 Thread Na Li via Review Board
/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/10/ Changes: https://reviews.apache.org/r/71619/diff/9-10/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
/-Area0/0012-base_model.json PRE-CREATION addons/models/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/9/ Changes: https://reviews.apache.org/r/71619/diff/8-9/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218339 ----------- On Oct. 22, 2019, 9:58 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
have a first class entity called "User" > > defined in base model and you have ml_user extend from it. what do you say? > > Na Li wrote: > what is parent for the entity "user"? Made the changes 1) define "AtlasUser" in base, derived from "Asset

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
/-Area0/0010-base_model.json 2f5fdaf addons/models/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/8/ Changes: https://reviews.apache.org/r/71619/diff/7-8/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
ase model and you have ml_user extend from it. what do you say? what is parent for the entity "user"? - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#revie

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/7/ Changes: https://reviews.apache.org/r/71619/diff/6-7/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
https://reviews.apache.org/r/71619/#review218328 ----------- On Oct. 22, 2019, 3:42 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ >

Review Request 71648: ATLAS-3465: Define the ML Hook API that an Atlas addon will implement

2019-10-22 Thread Na Li via Review Board
Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
eviews.apache.org/r/71619/#review218322 ------- On Oct. 22, 2019, 3:42 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-22 Thread Na Li via Review Board
/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/6/ Changes: https://reviews.apache.org/r/71619/diff/5-6/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-21 Thread Na Li via Review Board
/4000-MachineLearning/4010-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/5/ Changes: https://reviews.apache.org/r/71619/diff/4-5/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-21 Thread Na Li via Review Board
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218305 --- On Oct. 21, 2019, 6:51 p.m., Na Li wrote: > > ---

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-20 Thread Na Li via Review Board
/1000-Hadoop/-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/4/ Changes: https://reviews.apache.org/r/71619/diff/3-4/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-20 Thread Na Li via Review Board
deployment statuses for now: > > https://github.infra.cloudera.com/Sense/cloudera-sense/blob/master/services/proto/common.proto#L55 > > Na Li wrote: > do you mean to change > > ml_model_deployment_status from > > "elementDefs": [ >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-18 Thread Na Li via Review Board
": "deployed", "ordinal": 1 }, { "value": "stopping", "ordinal": 2 }, { "value": "stopped", "ordinal": 3 } ] ? - Na --

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
-Hadoop/-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/3/ Changes: https://reviews.apache.org/r/71619/diff/2-3/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
/1000-Hadoop/-ml_model.json PRE-CREATION Diff: https://reviews.apache.org/r/71619/diff/2/ Changes: https://reviews.apache.org/r/71619/diff/1-2/ Testing --- verified it is valid json file Thanks, Na Li

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
_process. This is relationship between ml_user and ml_project_create_process > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 480 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line480> > > > > What's t

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
tally different purpose. We do need to have a type for user. - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218235 --- On Oct. 16

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 51 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line51> > > > > Those fields are optional. So if some projects ca

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
ould be an enum or equivalent in Atlas. changed to enum > On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 323 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
emerge. replace those attributes by { "name": "metadata", "description": "Contains key-value pairs that provide project metadata", "typeName": "map", "cardinality": "SIN

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
this attribute, and user "qualifiedName", which must be unique. - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218231 --------

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-17 Thread Na Li via Review Board
> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 10 (patched) > > <https://reviews.apache.org/r/71619/diff/1/?file=2169131#file2169131line10> > > > > "DataSet" in A

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-16 Thread Na Li via Review Board
e response to help caller process the response. addons/models/1000-Hadoop/-ml_model.json Lines 268 (patched) <https://reviews.apache.org/r/71619/#comment305874> We should. I intended to do that, but missed this one. Thanks! - Na Li On Oct. 16, 2019, 12:30 a.m., Na Li wrote: >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-16 Thread Na Li via Review Board
em in customAttributes, which is system property. We cannot see what keys are used in customAttributes at model files. it is set by whoever creates the Atlas entity. - Na Li On Oct. 16, 2019, 12:30 a.m., Na Li wrote: > > -

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-15 Thread Na Li via Review Board
Diff: https://reviews.apache.org/r/71619/diff/1/ Testing --- verified it is valid json file Thanks, Na Li

Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

2019-10-15 Thread Na Li via Review Board
, Na Li

[jira] [Created] (ATLAS-3466) Implement ML Hook API for Atlas

2019-10-15 Thread Na Li (Jira)
Na Li created ATLAS-3466: Summary: Implement ML Hook API for Atlas Key: ATLAS-3466 URL: https://issues.apache.org/jira/browse/ATLAS-3466 Project: Atlas Issue Type: Task Components: atlas

[jira] [Created] (ATLAS-3465) Define the ML Hook API that an Atlas addon will implement

2019-10-15 Thread Na Li (Jira)
Na Li created ATLAS-3465: Summary: Define the ML Hook API that an Atlas addon will implement Key: ATLAS-3465 URL: https://issues.apache.org/jira/browse/ATLAS-3465 Project: Atlas Issue Type: Task

[jira] [Created] (ATLAS-3464) Define Entities stored in Atlas for ML Governance

2019-10-15 Thread Na Li (Jira)
Na Li created ATLAS-3464: Summary: Define Entities stored in Atlas for ML Governance Key: ATLAS-3464 URL: https://issues.apache.org/jira/browse/ATLAS-3464 Project: Atlas Issue Type: Task

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
Diff: https://reviews.apache.org/r/71568/diff/3/ Changes: https://reviews.apache.org/r/71568/diff/2-3/ Testing --- add integration tests Thanks, Na Li

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
1568/diff/1/?file=2167631#file2167631line40> > > > > nit: style for this method is inconsistent now in compressed style. > On Oct. 3, 2019, 12:10 a.m., Austin Nobis wrote: > > addons/ml-bridge/src/test/resources/users-credentials.properties &g

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
> On Oct. 3, 2019, 12:10 a.m., Austin Nobis wrote: > > pom.xml > > Lines 766 (patched) > > <https://reviews.apache.org/r/71568/diff/1/?file=2167655#file2167655line766> > > > > I would avoid using lombok if it is not already present in the project. >

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
essContext` as _output_. changed the signature. - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/#review218040 --- On Oct.

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-04 Thread Na Li via Review Board
> > > > This comment is confusing. What is the ML Governance server? I think > > that's an internal CDSW detail. > > Na Li wrote: > Does this comment works for you "This class is used to convert machine > learning metadata to lineage notifications

[jira] [Created] (ATLAS-3440) Get ML metadata from ML service using HTTP client

2019-10-04 Thread Na Li (Jira)
Na Li created ATLAS-3440: Summary: Get ML metadata from ML service using HTTP client Key: ATLAS-3440 URL: https://issues.apache.org/jira/browse/ATLAS-3440 Project: Atlas Issue Type: Task

[jira] [Updated] (ATLAS-3432) Add Machine Learning Governance integration

2019-10-04 Thread Na Li (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3432: - Description: Managing machine learning models and its deployments are getting more important over time. Adding

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Na Li via Review Board
-2/ Testing --- add integration tests Thanks, Na Li

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Na Li via Review Board
gt; Lines 1568 (patched) > > <https://reviews.apache.org/r/71568/diff/1/?file=2167655#file2167655line1568> > > > > I don't think we should call this "ml-hook-api". This is specifically > > targeting one product (CDSW) and so we should call this th

[jira] [Created] (ATLAS-3435) Handle all fields of User entity from ML Governance Hook input

2019-10-02 Thread Na Li (Jira)
Na Li created ATLAS-3435: Summary: Handle all fields of User entity from ML Governance Hook input Key: ATLAS-3435 URL: https://issues.apache.org/jira/browse/ATLAS-3435 Project: Atlas Issue Type

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-02 Thread Na Li via Review Board
m to Atlas."? If not, what's your suggestion? - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/#review218027 ---------

Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

2019-10-01 Thread Na Li via Review Board
/MethodType.java PRE-CREATION addons/models/1000-Hadoop/1110-ml_model.json PRE-CREATION pom.xml ce7d6fb Diff: https://reviews.apache.org/r/71568/diff/1/ Testing --- add integration tests Thanks, Na Li

[jira] [Created] (ATLAS-3432) Add Machine Learning Governance integration

2019-10-01 Thread Na Li (Jira)
Na Li created ATLAS-3432: Summary: Add Machine Learning Governance integration Key: ATLAS-3432 URL: https://issues.apache.org/jira/browse/ATLAS-3432 Project: Atlas Issue Type: New Feature

[jira] [Commented] (ATLAS-3290) Impala Hook should get database name and table name from vertex metadata

2019-06-18 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867103#comment-16867103 ] Na Li commented on ATLAS-3290: -- pre-commit test at https://builds.apache.org/view/A/

[jira] [Updated] (ATLAS-3290) Impala Hook should get database name and table name from vertex metadata

2019-06-18 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3290: - Attachment: ATLAS-3290.001.patch > Impala Hook should get database name and table name from vertex metad

Review Request 70880: ATLAS-3290: Impala Hook should get database name and table name from vertex metadata

2019-06-18 Thread Na Li via Review Board
ImpalaLineageToolIT.testCreateTableAsSelectVertexIdNoTableNameFromFile for this scenario Thanks, Na Li

[jira] [Updated] (ATLAS-3290) Impala Hook should get database name and table name from vertex metadata

2019-06-18 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3290: - Summary: Impala Hook should get database name and table name from vertex metadata (was: Impala Hook: Get

[jira] [Updated] (ATLAS-3290) Impala Hook: Get database name and table name from vertex metadata

2019-06-18 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3290: - Description: The column name in Impala lineage record may not contain its database name and its table name

[jira] [Created] (ATLAS-3290) Impala Hook: Get database name and table name from vertex metadata

2019-06-18 Thread Na Li (JIRA)
Na Li created ATLAS-3290: Summary: Impala Hook: Get database name and table name from vertex metadata Key: ATLAS-3290 URL: https://issues.apache.org/jira/browse/ATLAS-3290 Project: Atlas Issue Type

[jira] [Updated] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-06-11 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3226: - Description: ATLAS-3197 introduced a new feature on Hive integration. It introduced new model called

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-06-03 Thread Na Li via Review Board
/models/1000-Hadoop/1030-hive_model.json 417c4c5 Diff: https://reviews.apache.org/r/70759/diff/5/ Changes: https://reviews.apache.org/r/70759/diff/4-5/ Testing --- add check for ddl entities in integration tests Thanks, Na Li

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-06-03 Thread Na Li via Review Board
line727> > > > > type should still be "hive_table_ddl" done > On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1030-hive_model.json > > Line 746 (original), 712 (patched) > > <https:

[jira] [Updated] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3226: - Attachment: ATLAS-3226.004.patch > Add QueryText for hive_table and hive_db for Impala integrat

[jira] [Commented] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853474#comment-16853474 ] Na Li commented on ATLAS-3226: -- patch 4 pre-test at https://builds.apache.org/view/A/

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li via Review Board
/ Changes: https://reviews.apache.org/r/70759/diff/3-4/ Testing --- add check for ddl entities in integration tests Thanks, Na Li

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li via Review Board
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215623 ------- On May 31, 2019, 4:02 a.m., Na Li wrote: > > -

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-31 Thread Na Li via Review Board
le2147403line93> > > > > Please align '=' to match the code-style. and please check other > > places. -Thanks. done - Na --- This is an automatically generated e-mail. To reply, visit: https://reviews.apac

[jira] [Commented] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852660#comment-16852660 ] Na Li commented on ATLAS-3226: -- patch 3 pre-test succeeded at https://builds.apache

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li via Review Board
nal), 712 (patched) <https://reviews.apache.org/r/70759/#comment302357> the endpoint of the relationship has to be the common type of hive_db_ddl and impala_db_ddl in order for Atlas server to update the "ddlQueries" of a hive_db for both hive_db_ddl and impala_db_ddl - Na Li

[jira] [Updated] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3226: - Attachment: ATLAS-3226.003.patch > Add QueryText for hive_table and hive_db for Impala integrat

[jira] [Commented] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852634#comment-16852634 ] Na Li commented on ATLAS-3226: -- patch 3 pre-commit test at https://builds.apache.org/

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li via Review Board
24eb5db Diff: https://reviews.apache.org/r/70759/diff/3/ Changes: https://reviews.apache.org/r/70759/diff/2-3/ Testing --- add check for ddl entities in integration tests Thanks, Na Li

[jira] [Commented] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852362#comment-16852362 ] Na Li commented on ATLAS-3226: -- pre-commit test in 1152 failed at hive hook test. res

[jira] [Commented] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852086#comment-16852086 ] Na Li commented on ATLAS-3226: -- patch 2 pre-commit test https://builds.apache.org/vi

[jira] [Updated] (ATLAS-3226) Add QueryText for hive_table and hive_db for Impala integration

2019-05-30 Thread Na Li (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Na Li updated ATLAS-3226: - Attachment: ATLAS-3226.002.patch > Add QueryText for hive_table and hive_db for Impala integrat

  1   2   3   >