Re: [DISCUSS] Proposal to Backport `dbStorage_readAheadCacheBatchBytesSize` to BookKeeper 4.16.x

2024-07-08 Thread Hang Chen
shoothzj > Wechat: shoothzj > > On Fri, Jun 28, 2024 at 12:01 AM Matteo Merli wrote: > > > > Sounds good to me. This won't add any new risk. > > -- > > Matteo Merli > > > > > > > > On Thu, Jun 27, 2024 at 4:30 PM Hang Chen wrote: >

[DISCUSS] Proposal to Backport `dbStorage_readAheadCacheBatchBytesSize` to BookKeeper 4.16.x

2024-06-27 Thread Hang Chen
Hi team, I would like to discuss the potential backporting of a recently introduced feature from the BookKeeper 4.17.0 release to the 4.16.x branch, which is used in Pulsar 3.0 LTS. The feature in question is the `dbStorage_readAheadCacheBatchBytesSize` configuration option, added through PR [1].

Re: [DISCUSS] BookKeeper 4.17.1 release

2024-06-11 Thread Hang Chen
+1 Thanks, Hang ZhangJian He 于2024年6月11日周二 07:52写道: > > I have done cherry-pick, no pr in > https://github.com/apache/bookkeeper/pulls?q=is%3Apr+label%3Arelease%2F4.17.1+is%3Amerged+-label%3Acherry-picked%2Fbranch-4.17 > . > > I'll start preparing for the RC as soon as I can. > > Thanks >

Re: [DISCUSS] Introducing Typo CI Check to Apache BookKeeper

2024-05-25 Thread Hang Chen
+1 We need to keep an eye on the public methods and configurations. Best, Hang Andrey Yegorov 于2024年5月22日周三 02:15写道: > > > Awesome idea, thank you for tackling this. > > We need to keep an eye on changes in config parameter names in yaml/configs > to avoid unexpected breaks. > So far I

Re: [VOTE] Release 4.17.0, release candidate #0

2024-04-11 Thread Hang Chen
+1 (binding) - Verified signatures and checksums - Build from the source code with JDK 17, Maven 3.8.6 on M3 macbook - All the StreamNative tests are passed - Build Pulsar branch-3.2 with the staging packages - Run Pulsar cluster with one broker, one bookie and one zookeeper, verified: -

Re: [VOTE] Release 4.16.5, release candidate #1

2024-04-09 Thread Hang Chen
+1 (binding) - Verified signatures and checksums - Build from the source code with JDK 17, Maven 3.8.6 on M3 macbook - All the StreamNative tests are passed - Build Pulsar branch-3.0 with the staging packages - Run Pulsar cluster with one broker, one bookie and one zookeeper, verified: -

Re: [DISCUSS] Bookkeeper 4.17.0 release

2024-03-04 Thread Hang Chen
would be happy to be the release manager for this cycle > > Enrico > > Il Mer 21 Feb 2024, 07:37 Hang Chen ha scritto: > > > Hi Community, > >Bookkeeper 4.16.0 has been released for more than 9 months, and we > > have introduced batch read support [1] for

[DISCUSS] Bookkeeper 4.17.0 release

2024-02-20 Thread Hang Chen
Hi Community, Bookkeeper 4.16.0 has been released for more than 9 months, and we have introduced batch read support [1] for entry reading and many important bug fixes[2] and improvements[3][4][5]. I would like to start to discuss releasing 4.17.0. All the PRs in 4.17.0 can be found at

Re: [VOTE] Release 4.16.4, release candidate #0

2024-01-28 Thread Hang Chen
The vote is now closed, and the release was approved with 4 +1s(4 bindings). I will continue with the following steps. Binding votes: * Enrico Olivelli * Andrey Yegorov * Jia Zhai * Hang Chen Thank you all for verifying and voting! Thanks, Hang Andrey Yegorov 于2024年1月27日周六 03:43写道: > &

Re: [VOTE] Release 4.16.4, release candidate #0

2024-01-26 Thread Hang Chen
lt locally on Mac, JDK11 > > Thanks > Enrico > > Il giorno ven 19 gen 2024 alle ore 03:08 Hang Chen > ha scritto: > > > > Hi everyone, > > Please review and vote on the release candidate #0 for version 4.16.4, > > as follows: > > [ ] +1, Approve the

[VOTE] Release 4.16.4, release candidate #0

2024-01-18 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #0 for version 4.16.4, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Re: [DISCUSS] BookKeeper 4.16.4 release

2024-01-18 Thread Hang Chen
ve. > > I've come across the bug quite a few times when experimenting with Pulsar > > on Mac M3 hardware. > > > > Are we ready to start the 4.16.4 release? > > > > -Lari > > > > On 2023/12/25 03:43:16 Hang Chen wrote: > > > Hi everyone, > &

[DISCUSS] BookKeeper 4.16.4 release

2023-12-24 Thread Hang Chen
Hi everyone, BookKeeper 4.16.3 was released more than three months ago, and I would like to discuss the starting 4.16.4 release to include some critical bug fixes and improvements, such as [1] and [2] Here are the PRs for 4.16.4:

Re: [VOTE] Release 4.15.5, release candidate #0

2023-12-13 Thread Hang Chen
https://github.com/zymap/pulsar/pull/53 > > On Wed, 13 Dec 2023 at 22:50, Hang Chen wrote: > > > Hi Yong, > > Thank you for driving this release effort. I have submitted a > > pull request [1] to upgrade the Pulsar branch-2.11 BookKeeper > > dependency to vers

Re: [VOTE] Release 4.15.5, release candidate #0

2023-12-13 Thread Hang Chen
Hi Yong, Thank you for driving this release effort. I have submitted a pull request [1] to upgrade the Pulsar branch-2.11 BookKeeper dependency to version 4.15.5 for testing. Currently, I am awaiting the completion of CI checks. Thanks, Hang [1] https://github.com/apache/pulsar/pull/21720

[DISCUSS] New label type: category/*

2023-09-11 Thread Hang Chen
Hi all, I would like to start a discussion about adding a new label type category/* There are three labels are supposed to be added - category/functionality - category/reliability - category/performance It could be a good improvement to the labeling system that BookKeeper has today. Now,

Re: [VOTE] Release 4.14.8, release candidate #0

2023-09-07 Thread Hang Chen
The vote is now closed, and the release was approved with 5+1s(4 bindings and 1 non-binding), and I will continue with the following steps. Binding votes: * Enrico Olivelli * Andrey Yegorov * Jia Zhai * Hang Chen Non-Binding votes: * Yong Zhang Thank you all for verifying and voting! Thanks

Re: [VOTE] Release 4.14.8, release candidate #0

2023-09-04 Thread Hang Chen
lone and simpletest with the bookie-all package > > > > Thanks, > > Yong > > > > On Fri, 18 Aug 2023 at 17:28, Hang Chen wrote: > > > > > Hi everyone, > > > Please review and vote on the release candidate #0 for version 4.14.8, > > > as follows:

Re: [VOTE] Release 4.16.3, release candidate #0

2023-09-04 Thread Hang Chen
All unit tests passed when the BookKeeper dependency of the Pulsar master branch was upgraded to 4.16.3. [1] [1] https://github.com/zymap/pulsar/pull/52 Regards, Hang Hang Chen 于2023年9月5日周二 09:34写道: > > +1 (binding) > > - Verified signatures and checksums > - Build from source

Re: [VOTE] Release 4.16.3, release candidate #0

2023-09-04 Thread Hang Chen
+1 (binding) - Verified signatures and checksums - Build from source code (MacOS jdk 11, maven 3.8.6) - Build BookKeeper with Pulsar master (MacOS JDK 17, Maven 3.8.6) - Build Pulsar master code with this staging dependency and start Pulsar cluster with one Zookeeper, one Bookie and one Broker.

Re: [DISCUSS] BookKeeper 4.16.3 release

2023-08-29 Thread Hang Chen
+1 for the new release. Please include the following two PRs to 4.16.3, thanks. https://github.com/apache/bookkeeper/pull/4041 https://github.com/apache/bookkeeper/pull/4058 Thanks, Hang Yong Zhang 于2023年8月29日周二 15:09写道: > > Hi everyone, > > Because the last release was published with arm, it

Re: Force to use linux/amd64 to build release

2023-08-28 Thread Hang Chen
+1 The BookKeeper 4.16.2 is released based on ARM platform and the direct IO can't be enabled in 4.16.2. Best, Hang Enrico Olivelli 于2023年8月28日周一 16:46写道: > > +1 > > Thanks > We should cut a new release as soon as possible > > Enrico > > Il Lun 28 Ago 2023, 10:34 Yong Zhang ha > scritto: > >

Re: BP62-New API for batched reads

2023-08-20 Thread Hang Chen
+1 Looking forward to this feature. Thanks, Hang Enrico Olivelli 于2023年8月20日周日 21:24写道: > > Hello, > The proposal is well written, I have no questions. > We have been waiting for this feature for long time. > > I am supporting it > > Thanks > Enrico > > Il Mar 15 Ago 2023, 04:28 horizonzy ha

Re: Remove UnderReplicatedLedgersChangedCb in Auditor

2023-08-20 Thread Hang Chen
+1 The interface introduces a heavy load on Zookeeper, and we need to remove it. For branch-4.15 and branch-4.16, we can keep the interface and remove the implementation and remove the interface on the master branch. Thanks, Hang Enrico Olivelli 于2023年8月20日周日 21:24写道: > > +1 > > Enrico > > Il

[VOTE] Release 4.14.8, release candidate #0

2023-08-18 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #0 for version 4.14.8, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Re: Data loss problem when DefaultEntryLogger switch to DirectEntryLogger, then switch back to DefaultEntryLogger.

2023-08-09 Thread Hang Chen
>You should start a new bookie with the new configuration. If the DirectEntryLogger needs to set up a separate bookie service, it would be hard for users to switch from the DefaultEntryLogger to DriectEntryLogger. >It is not generally possible to guarantee compatibility between different

Re: [DISCUSS] BookKeeper 4.14.8 release

2023-07-14 Thread Hang Chen
:22写道: > > +1 > > Thanks, > Xiaoyu Hou > > Hang Chen 于2023年5月30日周二 17:09写道: > > > Hi everyone, > > > > BookKeeper 4.14.7 was released more than 3 months, and I would like to > > discuss the starting 4.14.8 release to include some critical bu

Re: [VOTE] Release 4.16.2, release candidate #1

2023-06-28 Thread Hang Chen
+1 (binding) - Verified signatures and checksums - Build from source code (MacOS jdk 11, maven 3.8.6) - Tested local bookie - Run bkperf journal test - Build BookKeeper with Pulsar (MacOS JDK 17, Maven 3.8.6) - Build Pulsar master code with this staging dependency and start Pulsar cluster with one

[DISCUSS] Upgrade RocksDB version to 6.29.4.1 for branch-4.14

2023-06-25 Thread Hang Chen
Hi guys, More than one year ago, we had a discussion[1] about reverting the RocksDB version for branch-4.14, and the main concern is that RocksDB 6.17.3 breaks runtime compatibility with older versions and it requires the code to be recompiled. Lari did a great investigation and you can find more

Re: [DISCUSS] BookKeeper 4.16.2 release

2023-06-14 Thread Hang Chen
ps://github.com/apache/bookkeeper/pull/3979 that issue was > > > introduced in bookkeeper-4.16.0 by > > > https://github.com/apache/bookkeeper/pull/3847, > > > and in pulsar-3.0. 0 version introduced bk-4.16.1. > > > > > > Our online business runs a pulsar-3.0.0 cl

[DISCUSS] BookKeeper 4.16.2 release

2023-06-12 Thread Hang Chen
Hi everyone, We have found one critical bug[1] in BookKeeper 4.16.1, and I would like to discuss the starting 4.16.2 release to include some critical bug fixes and improvements, such as [1] and [2] Here are the PRs for 4.16.2:

Re: Bookkeeper decommission may be blocked by ledgers that cannot be replicated

2023-06-03 Thread Hang Chen
ay you can decomm bookie with ledgers > created with write quorum = 1. > > HTH. > > On Sun, Mar 26, 2023 at 9:27 PM Hang Chen wrote: > > > Hi guys, I found the BookKeeper decommission may be blocked by ledgers > > that cannot be replicated. > > > > Curren

[DISCUSS] BookKeeper 4.14.8 release

2023-05-30 Thread Hang Chen
Hi everyone, BookKeeper 4.14.7 was released more than 3 months, and I would like to discuss the starting 4.14.8 release to include some critical bug fixes and improvements, such as [1] and [2] Here are the PRs for 4.14.8:

Re: 回复:[Discuss] Bookie may lose data even though we turn on fsync for the journal

2023-05-15 Thread Hang Chen
Mark value will be persisted to the file, but > > the lastMark value will not be updated. > > The lastMark value is updated only when the ForceWriteRequest completes. So > > when the flush is triggered here, the position of lastMark is not 100MB's > > offset > > > > > >

[ANNOUNCE] Apache BookKeeper 4.16.1 released

2023-05-02 Thread Hang Chen
The Apache BookKeeper team is proud to announce Apache BookKeeper version 4.16.1. Apache BookKeeper is a scalable, fault-tolerant, and low-latency storage service optimized for real-time workloads. It has been used for a fundamental service to build reliable services. It is also the log segment

[ANNOUNCE] Apache BookKeeper 4.16.0 released

2023-05-02 Thread Hang Chen
The Apache BookKeeper team is proud to announce Apache BookKeeper version 4.16.0. Apache BookKeeper is a scalable, fault-tolerant, and low-latency storage service optimized for real-time workloads. It has been used for a fundamental service to build reliable services. It is also the log segment

Re: [VOTE] Release 4.16.1, release candidate #0

2023-04-18 Thread Hang Chen
eviewed release notes > > > > * built from tag, Mac/Java 11 > > > > * checked signatures (ok) and checksums (ok) > > > > * bin/bookkeeper standalone starts (from packaged binaries) > > > > * bin/bookkeeper localbookie 3 starts (from package

[VOTE] Release 4.16.1, release candidate #0

2023-04-14 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #0 for the version 4.16.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

[DISCUSS] BookKeeper 4.16.1 release

2023-04-14 Thread Hang Chen
Hi guys, We found one critical regression [1] on the BookKeeper 4.16.0 release, and we has one PR [2] to fix it. Due to the BookKeeper 4.16.0 has the critical regression, I would like to discuss starting 4.16.1 release for this critical bug. In 4.16.1, we will only include. this PR [2].

Re: [VOTE] Release 4.16.0, release candidate #2

2023-04-09 Thread Hang Chen
` before > > running the tests > > > > of course. > > > > as listed above: > > $ git checkout v4.16.0-rc2 > > $ mvn clean install -DskipTests > > $ mvn test > > > > On Fri, Mar 31, 2023 at 8:19 PM Hang Chen wrote: > > > > > > I a

Re: [VOTE] Release 4.16.0, release candidate #2

2023-03-31 Thread Hang Chen
rch: "x86_64", family: "mac" @Andrey Have you ever run `mvn clean insteall -DskipTests` before running the tests? Thanks, Hang Matteo Merli 于2023年4月1日周六 01:32写道: > > +1 binding > > * Checked signatures > * Check localbookie and local perf tool > >

Re: [VOTE] Release 4.16.0, release candidate #2

2023-03-31 Thread Hang Chen
; done > > * bin/bookkeeper standalone starts (from packaged binaries) > > * bin/bookkeeper localbookie 3 starts (from built binaries) > > * compared gzipped source with sources at tag (ok) > > * built from gzipped sources (didn't run the tests) > > > On Wed, M

Re: [VOTE] Release 4.16.0, release candidate #2

2023-03-29 Thread Hang Chen
I have created one PR[1] to upgrade the BookKeeper dependency to 4.16.0 for Apache Pulsar, and all the tests have been passed. Thanks, Hang [1] https://github.com/hangc0276/pulsar/pull/15 Hang Chen 于2023年3月29日周三 22:06写道: > > Hi everyone, > Please review and vote on the release can

Re: [VOTE] Release 4.16.0, release candidate #1

2023-03-29 Thread Hang Chen
t time I launch them !!) > - Verified signatures and checksums > - Run some smoke tests on JDK11/Mac M1 > > > Enrico > > Il giorno lun 27 mar 2023 alle ore 03:41 Hang Chen > ha scritto: > > > > I have created one PR[1] to upgrade the BookKeeper dependency to > &

[VOTE] Release 4.16.0, release candidate #2

2023-03-29 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #2 for version 4.16.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Bookkeeper decommission may be blocked by ledgers that cannot be replicated

2023-03-26 Thread Hang Chen
Hi guys, I found the BookKeeper decommission may be blocked by ledgers that cannot be replicated. Current bookie decommissions process. - Step 1: Use the command `bin/bookkeeper shell listunderreplicated` to check whether there are some ledgers in the under-replicated state - Step 2: After

Re: [VOTE] Release 4.16.0, release candidate #1

2023-03-26 Thread Hang Chen
I have created one PR[1] to upgrade the BookKeeper dependency to 4.16.0 for Apache Pulsar, and all the tests have been passed. Thanks, Hang [1] https://github.com/hangc0276/pulsar/pull/14 Hang Chen 于2023年3月26日周日 13:26写道: > > Hi everyone, > Please review and vote on the release can

[VOTE] Release 4.16.0, release candidate #1

2023-03-25 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #1 for version 4.16.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Re: [VOTE] Release 4.16.0, release candidate #0

2023-03-25 Thread Hang Chen
I found one critical bug [1], which will cause the writing entry to fail when skipping the journal. I close this vote and send out a new candidate soon. Thanks, Hang [1] https://github.com/apache/bookkeeper/pull/3884 Hang Chen 于2023年3月23日周四 16:05写道: > > Hi everyone, > Please review

[VOTE] Release 4.16.0, release candidate #0

2023-03-23 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #0 for version 4.16.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Re: [DISCUSS] Bookkeeper 4.16.0 release

2023-03-21 Thread Hang Chen
%3A4.16.0 If no more PRs need to be included in 4.16.0, I will start the release. Thanks, Hang Hang Chen 于2023年1月11日周三 09:59写道: > > I will start to release 4.16.0 this week. Do you have any other > issues/tickets to add > for 4.16.0? > > Thanks, > Hang > > steve

[VOTE] BP-62: Streamline batch add requests

2023-03-20 Thread Hang Chen
This is the vote for BP-62. ### Motivation The bookie server process add-entry requests pipeline: - Get one request from the Netty socket channel - Choose one thread to process the written request - Write the entry into the target ledger entry logger's write cache(memory table) - Put the entry

Re: [DISCUSS] Streamline batch add requests

2023-03-20 Thread Hang Chen
If there are no objections, I will send out the vote. Thanks, Hang Hang Chen 于2023年3月16日周四 10:15写道: > > ### Motivation > The bookie server process add-entry requests pipeline: > - Get one request from the Netty socket channel > - Choose one thread to process the written re

[DISCUSS] Streamline batch add requests

2023-03-15 Thread Hang Chen
### Motivation The bookie server process add-entry requests pipeline: - Get one request from the Netty socket channel - Choose one thread to process the written request - Write the entry into the target ledger entry logger's write cache(memory table) - Put the entry into the journal's pending

Re: [VOTE] Release 4.15.4, release candidate #0

2023-03-05 Thread Hang Chen
+1 (non-binding) Thank Yong for driving this release. Overall it looks good. - Verified signatures and checksums - Build from source code (MacOS jdk 11, maven 3.8.6) - Tested local bookie - Tested standalone bookie - Build Pulsar master code with this staging dependency and start Pulsar

Re: [DISCUSS] BookKeeper 4.15.4 release

2023-02-21 Thread Hang Chen
4.15. > > > https://github.com/apache/bookkeeper/commits/branch-4.15 > > > Because that PIP is still in discussion, I will revert them from > > branch-4.15 > > > > Good idea ! > > > > Enrico > > > > > first. > > > > > >

[VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

2023-02-20 Thread Hang Chen
Hi, All After a fascinating discussion, I would start the vote for BP-61. We will replace the `ReferenceCountUtil.safeRelease()` with `ReferenceCountUtil.release()`. Please leave +1/-1 in this thread to join the vote. And feel free to leave any concerns. Thanks to you guys. Best, Hang

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-02-20 Thread Hang Chen
ffers. > so naturally for the netty's ByteBuf entry has to be copied into nio buffer: > "memTable.addEntry(ledgerId, entryId, entry.nioBuffer(), this)" > And after getEntry() it is wrapped into netty's ByteBuf. > I wonder if switching it to ByteBuf would improve performance / re

Re: The CI tests didn't cover bookkeeper V2 protocol.

2023-02-20 Thread Hang Chen
+1 for Yong's suggestion. Thanks, Hang Yan Zhao 于2023年2月20日周一 16:55写道: > > > According to the original PR's motivation > > , we wrapped a Netty > > allocator > > and want to configure something through bookkeeper. > > So the user will use our

Re: CI shows successfully but the tests actually has errors

2023-02-20 Thread Hang Chen
Hi Yong, Thanks for finding this critical issue. I think it's dangerous to merge new PRs before the CI is fixed, because we can't ensure whether the new PRs introduces bugs. Thanks, Hang Yong Zhang 于2023年2月21日周二 09:15写道: > > Hi folks, > > I found our CI may have some problems. > > In the

[ANNOUNCE] Apache BookKeeper 4.14.7 released

2023-02-20 Thread Hang Chen
The Apache BookKeeper team is proud to announce Apache BookKeeper version 4.14.7. Apache BookKeeper is a scalable, fault-tolerant, and low-latency storage service optimized for real-time workloads. It has been used for a fundamental service to build reliable services. It is also the log segment

Re: [VOTE] Release 4.14.7, release candidate #1

2023-02-19 Thread Hang Chen
> - run simple test with localbookie > > > > - built from sources > > > > > > > > Yong > > > > > > > > On Tue, 14 Feb 2023 at 23:32, Enrico Olivelli > > > wrote: > > > > > > > > > +1 (binding) > &g

Re: The CI tests didn't cover bookkeeper V2 protocol.

2023-02-18 Thread Hang Chen
Hi horizonzy, Thanks for raising this discussion. > the netty jvm param `-Dio.netty.leakDetection.level` didn't work, it will be overridden by our custom config. > In our tests, we config `-Dio.netty.leakDetection.level=paranoid`, but it will be overridden by `disabled`. IMO, this is

Re: [VOTE] Release 4.14.7, release candidate #1

2023-02-13 Thread Hang Chen
I opened one PR[1] to upgrade BookKeeper dependency to 4.14.7 for Pulsar branch-2.10 and all tests passed. Please help verify this candidate. Thanks a lot. Thanks, Hang [1] https://github.com/hangc0276/pulsar/pull/9 Hang Chen 于2023年2月13日周一 21:17写道: > > Hi everyone, > Please review

Re: [DISCUSS] BookKeeper 4.15.4 release

2023-02-13 Thread Hang Chen
+1 - As we discussed in [2], For the PRs list in [1], I think we can skip cherry-pick first. - For PR [3], I removed label `release/4.15.4` due to [4] Thanks, Hang [1] https://github.com/apache/bookkeeper/issues/3686 [2] https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc [3]

[VOTE] Release 4.14.7, release candidate #1

2023-02-13 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #1 for version 4.14.7, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Re: [VOTE] Release 4.14.7, release candidate #0

2023-02-12 Thread Hang Chen
/bookkeeper/issues/3751 [2] https://github.com/apache/bookkeeper/pull/3528 [3] https://github.com/apache/bookkeeper/pull/3560 Wenbing Shen 于2023年2月9日周四 16:53写道: > > +1 > > * built from sources (mac 11.3.1, intel), ran some tests > * ran bookkeeper standalone > > Thanks. > Wenbing

Re: [VOTE] Release 4.14.7, release candidate #0

2023-02-08 Thread Hang Chen
I opened one PR[1] to upgrade BookKeeper dependency to 4.14.7 for Pulsar branch-2.10 and all tests passed. Please help verify this candidate. Thanks a lot. Thanks, Hang [1] https://github.com/hangc0276/pulsar/pull/9 Hang Chen 于2023年2月9日周四 10:45写道: > > Hi everyone, > Please review

[VOTE] Release 4.14.7, release candidate #0

2023-02-08 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #0 for version 4.14.7, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

[DISCUSS] BookKeeper 4.14.7 release

2023-02-07 Thread Hang Chen
Hi everyone, One core dump issue[1] related to RocksDB was introduced by [2] and released in BookKeeper 4.14.6. To fix the RocksDB core dump issue, I pushed one PR [3] to revert the [2] to make branch-4.14 stable. Due to BookKeeper 4.14.6 having the risk of stability, I would like to discuss

Re: [DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-02-01 Thread Hang Chen
ys to write release in current pulsar and bookkeeper > > >> projects: > > >> 1.ByteBuf.release: Call release directly without handling any exceptions; > > >> 2.ReferenceCountUtil.release: return processing status; > > >> 3. ReferenceCountUtil.safeReleas

[DISCUSS] BP-61: Revert BP-59 to release ByteBuf using ByteBuf.release() instead of ReferenceCountUtil.safeRelease()

2023-01-29 Thread Hang Chen
Hi guys, In BP-59, which was not discussed in the dev mail list and without a vote, refactored the ByteBuf release method by ReferenceCountUtil.safeRelease() instead of ByteBuf.release(). In the `ReferenceCountUtil.safeRelease()`, it catches the release exception. This change can make the

[Discuss] BookKeeper upgrade the RocksDB version to 7.9.x

2023-01-29 Thread Hang Chen
Hi guys, When we introduced `deleteRange` for ledger index deletion, we found a segment fault in ledger index deletion [1]. I suggest upgrading the RocksDB version to the latest 7.9.x to see if the RocksDB deleteRange segment fault bug has been fixed. I have tested upgrading the RocksDB

Re: BP-60:Change PCBC limitStatsLogging default value to true

2023-01-10 Thread Hang Chen
+1 Thanks, Hang Andrey Yegorov 于2023年1月10日周二 06:15写道: > > +1 > > On Mon, Jan 9, 2023 at 4:50 AM Enrico Olivelli wrote: > > > I agree with the change. > > I have never used those metrics > > > > Enrico > > > > > > Il giorno lun 26 dic 2022 alle ore 10:29 Wenbing Shen > > ha scritto: > > > > >

Re: [DISCUSS] Bookkeeper 4.16.0 release

2023-01-10 Thread Hang Chen
I will start to release 4.16.0 this week. Do you have any other issues/tickets to add for 4.16.0? Thanks, Hang steven lu 于2022年7月28日周四 14:20写道: > > ok, I see , thanks > > Hang Chen 于2022年7月28日周四 10:29写道: > > > Hi Steven, > > Those Prs are in the 4.16.0 mile

Re: [VOTE] Release 4.14.6, release candidate #1

2023-01-08 Thread Hang Chen
> On Fri, Dec 30, 2022 at 2:55 PM steven lu wrote: > > > +1 non binding > > > > Hang Chen 于2022年12月19日周一 13:15写道: > > > > > Hi everyone, > > > Please review and vote on the release candidate #1 for version 4.14.6, > > > as follows: > >

Re: [VOTE] Release 4.14.6, release candidate #1

2022-12-19 Thread Hang Chen
I opened one PR[1] to upgrade BookKeeper dependency to 4.14.6 for Pulsar branch-2.10, and all tests passed. Please help verify this candidate. Thanks, Hang [1] https://github.com/hangc0276/pulsar/pull/8 Hang Chen 于2022年12月19日周一 13:14写道: > > Hi everyone, > Please review and vote on th

Re: [VOTE] Release 4.14.6, release candidate #0

2022-12-18 Thread Hang Chen
wrote: > > > > > +1 (binding) > > > > > > * ran bookkeeper standalone > > > * ran bookkeeper localbookie > > > * built from sources (mac, intel), ran some tests > > > * spot-checked maven repo > > > > > > @Yong - as I under

Re: [ANNOUNCE] Apache BookKeeper 4.15.3 released

2022-11-23 Thread Hang Chen
Thank you a lot for driving this release! Best, Hang Andrey Yegorov 于2022年11月24日周四 02:21写道: > > Thank you for driving this release! > > On Wed, Nov 16, 2022 at 7:01 PM Yong Zhang wrote: > > > The Apache BookKeeper team is proud to announce Apache BookKeeper > > version 4.15.3. > > > > Apache

[VOTE] Release 4.14.6, release candidate #0

2022-11-21 Thread Hang Chen
Hi everyone, Please review and vote on the release candidate #0 for version 4.14.6, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] * The

Re: [VOTE] Release 4.15.3, release candidate #1

2022-11-11 Thread Hang Chen
+1 (non-binding) - Build from source code (JDK8, maven 3.8.6 on MacOs) - Verified checksums and signatures - Verified the licenses - Run bkperf to test journal write - Integrate with Pulsar master code and Pulsar unit tests passed (https://github.com/hangc0276/pulsar/pull/7) Thanks Yong for

Introduce entry log file size checking during garbage collection

2022-11-10 Thread Hang Chen
Hi guys, When we use TransactionalEntryLogCompactor to compact the entry log files in garbage collection, it will generate a lot of small entry log files, and for those files, the file usage is usually greater than 90%, which can not be compacted unless the file usage decreased. As time goes

Re: Release 4.15.3, release candidate #0

2022-11-08 Thread Hang Chen
-1 (non-binding) - Build from source code (jdk8 on MacOs) - Verified checksums and signatures - Checked the licenses - Run journal perf produce - Integrate with Pulsar master code and Pulsar unit tests passed >From the license checking, I found the following license mismatch. ```

[DISCUSS] BookKeeper 4.14.6 release

2022-11-06 Thread Hang Chen
Hi everyone, BookKeeper 4.14.5 has been released for 6 months and I would like to discuss the starting 4.14.6 release to include some bug fixes and improvements. Here are the PRs for 4.14.6: https://github.com/apache/bookkeeper/pulls?q=is%3Aopen+is%3Apr+label%3Arelease%2F4.14.6 If you have PRs

Re: [DISCUSS] BookKeeper 4.15.3 release

2022-11-03 Thread Hang Chen
+1 Thanks for your great work! Thanks, Hang Yong Zhang 于2022年11月3日周四 16:28写道: > > If no one objected, I will start to release 4.15.3 soon. > > On Wed, 26 Oct 2022 at 09:23, Yong Zhang wrote: > > > Hi everyone, > > > > I want to discuss starting 4.15.3 release to including some > >

Re: [DISCUSS] BP-57 Add a public API for creating embeddable servers

2022-10-17 Thread Hang Chen
+1 Great feature! I support this feature. Thanks, Hang steven lu 于2022年9月19日周一 15:47写道: > > +1 > this idea seems really useful > > Diego Salvi 于2022年9月18日周日 21:02写道: > > > Hi BookKeepers, > > I've added a new BP to add a public API for creating embeddable servers: > > BP-57

Re: [DISCUSS] BookKeeper RocksDB configuration changed default blockCacheSize since 4.15.0

2022-10-17 Thread Hang Chen
; > conf/entry_location_rocksdb.conf, or I also mention a pr to make a scheme > > comparison ? Or make this function a switch to choose the implementation > > > > > > On 2022/10/09 15:03:01 Hang Chen wrote: > > > I found the PR https://github.com/apache

[DISCUSS] BookKeeper versions on the website.

2022-10-16 Thread Hang Chen
Hi guys, On the BookKeeper website, we only show the latest patch release version document, for example, we have BookKeeper versions [4.14.0, 4.14.1, 4.14.2, 4.14.3, 4.14.4, 4.14.5] and we only show 4.14.5's document in the website. It is reasonable because the path release version only contains

Re: [DISCUSS] BookKeeper RocksDB configuration changed default blockCacheSize since 4.15.0

2022-10-10 Thread Hang Chen
gt; > > Great idea > > Enrico > > > > Yong > > > > > > > > > > On Sun, 9 Oct 2022 at 23:20, Enrico Olivelli wrote: > > > > > Il Dom 9 Ott 2022, 17:03 Hang Chen ha scritto: > > > > > > > I found the PR ht

[DISCUSS] BookKeeper RocksDB configuration changed default blockCacheSize since 4.15.0

2022-10-09 Thread Hang Chen
I found the PR https://github.com/apache/bookkeeper/pull/3056 has changed the rocksDB default cache size from 10% of direct memory to 206150041(196MB), which will lead to entry read performance decrease when there are huge number of entries stored in the ledger directory. It will have a huge

Re: [VOTE] Release 4.15.2, release candidate #0

2022-10-08 Thread Hang Chen
Hi Yong, Sorry for -1(non-binding) I found the PR https://github.com/apache/bookkeeper/pull/3056 has changed the rocksDB default cache size from 10% of direct memory to 206150041(196MB), which will lead to entry read performance decrease when there are huge number of entries stored in the

Re: [DISCUSS] End-Of-Life for some release lines

2022-09-27 Thread Hang Chen
I Agree. > I propose to declare end-of-life on all the release lines prior to 4.14. I think we should have a clear end-of-life policy for BookKeeper. > For me having two release lines is acceptable. We'd better not define the end-of-life policy based on the release lines number. Thanks, Hang

Re: [VOTE] Release 4.15.1, release candidate #3

2022-08-30 Thread Hang Chen
Hi Yong, thanks for your great work! +1 (non-binding) Verified the following list. - Verified the license and checksum - Build from the source code with JDK17 - Run bin/bkperf to check journal writing - Integrate with Pulsar branch-2.11 - build from the source code with BookKeeper 4.15.1

Re: [DISCUSS] Bookkeeper 4.16.0 release

2022-07-27 Thread Hang Chen
ve a look https://github.com/apache/bookkeeper/issues/3419 > > Hang Chen 于2022年7月20日周三 10:24写道: > > > Andrey, thanks for your noticing. > > > > I'm happy to be a volunteer for the version 4.16.0 release. > > I have created an issue to track the Prs to be includ

Re: [DISCUSS] Bookkeeper 4.16.0 release

2022-07-19 Thread Hang Chen
e/pulsar/pull/15142), e.g. > > older Pulsar versions (2.10 and below) could benefit from 4.14 release. > > > > Btw, why https://bookkeeper.apache.org/docs/4.14.5/overview/ says "Apache > > BookKeeper 4.14.5, which is no longer actively maintained"? > > I thought 4.14

[DISCUSS] Bookkeeper 4.16.0 release

2022-07-14 Thread Hang Chen
Hi Community, Bookkeeper 4.15.0 has been released for 2 months, and we have introduced Direct IO support[1] for ledger and many important bug fixes, such as fixing memory leaks [2][3], applying back pressure for v2 protocol[4], and so on. I would like to start to discuss releasing 4.16.0.

[Discuss] Bookie may lose data even though we turn on fsync for the journal

2022-05-29 Thread Hang Chen
We found one place where the bookie may lose data even though we turn on fsync for the journal. Condition: - One journal disk, and turn on fsync for the journal - Configure two ledger disks, ledger1, and ledger2 Assume we write 100MB data into one bookie, 70MB data written into ledger1's write

Re: [ANNOUNCE] New committer ZhangJian He (shoothzj)

2022-05-04 Thread Hang Chen
Congrats Zhangjian! Thanks, Hang Andrey Yegorov 于2022年5月4日周三 23:52写道: > > Congrats! > > On Wed, May 4, 2022 at 5:36 AM Enrico Olivelli wrote: > > > The Project Management Committee (PMC) for Apache BookKeeper > > has invited ZhangJian He to become a committer and we are pleased > > to

Re: Revert RocksDB upgrade on BookKeeper branch 4.14?

2022-04-05 Thread Hang Chen
+1 Thanks, Hang Enrico Olivelli 于2022年4月5日周二 16:35写道: > > Nicolò, > sorry for the late reply. > I thought I had answered. > > Il giorno ven 1 apr 2022 alle ore 15:15 Nicolò Boschi > ha scritto: > > > > Hi all, > > > > this is a follow-up discussion about the RocksDB upgrade that happened at >

Re: [VOTE] Release 4.15.0, release candidate #0

2022-04-01 Thread Hang Chen
Hi Andrey, I download the source code and build it by multi cpu cores, it failed occasionally. I opened an issue to track it. https://github.com/apache/bookkeeper/issues/3174 It maybe an old issue, and it is not the blocker for this release. Thanks, Hang Andrey Yegorov 于2022年4月1日周五

  1   2   >