[GitHub] michaelmior merged pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

michaelmior merged pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260662520 ## File path:

[GitHub] danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260650033 ## File path:

[GitHub] danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260650033 ## File path:

[GitHub] zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260648418 ## File path:

[GitHub] zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260646220 ## File path:

[GitHub] zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

zhztheplayer commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier URL: https://github.com/apache/calcite/pull/958#discussion_r260646220 ## File path:

[GitHub] asfgit merged pull request #1042: [CALCITE-2878] Avoid use of new RuntimeException(e) in tests

asfgit merged pull request #1042: [CALCITE-2878] Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042 This is an automated message from the Apache Git Service. To respond to the

[GitHub] vlsi commented on issue #1042: Avoid use of new RuntimeException(e) in tests

vlsi commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-467729795 @kgyrtkirk , oh, let me merge that. Apparently it received no objections.

[GitHub] julianhyde commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public

julianhyde commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1055#issuecomment-467720535 Well, it's a bad idea for some other reasons that someone else raised.

[GitHub] chadasa opened a new pull request #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

chadasa opened a new pull request #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071 [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

[GitHub] godfreyhe commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public

godfreyhe commented on issue #1055: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1055#issuecomment-467701432 I had reverted some changes, only make non-deprecated constructor as public

[GitHub] XuQianJin-Stars commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function

XuQianJin-Stars commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#issuecomment-467685627 hi @michaelmior I have already rebase that change and the others into a single commit. best qianjin

[GitHub] beikov closed pull request #526: [CALCITE-1965] Support outer joins for materialized views

beikov closed pull request #526: [CALCITE-1965] Support outer joins for materialized views URL: https://github.com/apache/calcite/pull/526 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] beikov commented on issue #526: [CALCITE-1965] Support outer joins for materialized views

beikov commented on issue #526: [CALCITE-1965] Support outer joins for materialized views URL: https://github.com/apache/calcite/pull/526#issuecomment-467524517 Yeah, totally fine This is an automated message from the Apache

[GitHub] kgyrtkirk commented on issue #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix

kgyrtkirk commented on issue #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix URL: https://github.com/apache/calcite/pull/954#issuecomment-467511558 I completely missed this - there was another PR for CALCITE-2722 I'll just close this now...

[GitHub] kgyrtkirk closed pull request #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix

kgyrtkirk closed pull request #954: [CALCITE-2722] - SqlImplementor createLeftCall StackOverflowError fix URL: https://github.com/apache/calcite/pull/954 This is an automated message from the Apache Git Service. To respond

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257630221 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257633928 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma

kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV Adapter does not handle - Empty and malformed csv lines, space before or after comma URL: https://github.com/apache/calcite/pull/1032#discussion_r257631585 ## File path:

[GitHub] kgyrtkirk commented on issue #1042: Avoid use of new RuntimeException(e) in tests

kgyrtkirk commented on issue #1042: Avoid use of new RuntimeException(e) in tests URL: https://github.com/apache/calcite/pull/1042#issuecomment-467508536 I thinked this was merged already. @vlsi do you plan to do any more changes?

[GitHub] michaelmior merged pull request #979: [CALCITE-2750] PI operator incorrectly identified as dynamic function

michaelmior merged pull request #979: [CALCITE-2750] PI operator incorrectly identified as dynamic function URL: https://github.com/apache/calcite/pull/979 This is an automated message from the Apache Git Service. To

[GitHub] michaelmior merged pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG

michaelmior merged pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG URL: https://github.com/apache/calcite/pull/1061 This is an automated message from the Apache Git Service. To respond to

[GitHub] michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

michaelmior commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-467501655 What is the `with wapper` here? This is an automated message from the

[GitHub] michaelmior commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function

michaelmior commented on issue #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#issuecomment-467500637 I noted one minor correction that should be made and if you can also rebase that change and the others into a single commit, this should

[GitHub] michaelmior commented on a change in pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

michaelmior commented on a change in pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067#discussion_r260360783 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -2712,6 +2714,48

[GitHub] XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070 ``` JSON_LENGTH(**json_doc**[, *path*]) ``` Returns the length of a JSON document, or, if a *path* argument is given, the length of the

[GitHub] XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

XuQianJin-Stars opened a new pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070 ``` JSON_LENGTH(**json_doc**[, *path*]) ``` Returns the length of a JSON document, or, if a *path* argument is given, the length of the

[GitHub] stutigupta028 closed pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor dual table

stutigupta028 closed pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor dual table URL: https://github.com/apache/calcite/pull/1052

[GitHub] chunweilei opened a new pull request #1069: [CALCITE-2875] fix some misspellings in RelOptListener

chunweilei opened a new pull request #1069: [CALCITE-2875] fix some misspellings in RelOptListener URL: https://github.com/apache/calcite/pull/1069 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asereda-gs opened a new pull request #1068: [CALCITE-2863] ElasticSearch Adapter. "select *" may return empty tionary

asereda-gs opened a new pull request #1068: [CALCITE-2863] ElasticSearch Adapter. "select *" may return empty tionary URL: https://github.com/apache/calcite/pull/1068 In some circumstances (eg. order by clause) `select *` would return `{}`.

[GitHub] XuQianJin-Stars opened a new pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function

XuQianJin-Stars opened a new pull request #1067: [CALCITE-2864]Add the JSON_DEPTH function URL: https://github.com/apache/calcite/pull/1067 Returns the maximum depth of a JSON document. Returns NULL if the argument is NULL. An error occurs if the argument is not a valid JSON document.

[GitHub] hsyuan commented on a change in pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way

hsyuan commented on a change in pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way URL: https://github.com/apache/calcite/pull/1048#discussion_r260093386 ## File path:

[GitHub] kgyrtkirk merged pull request #1064: [CALCITE-2839] Simplify comparisions against boolean literals

kgyrtkirk merged pull request #1064: [CALCITE-2839] Simplify comparisions against boolean literals URL: https://github.com/apache/calcite/pull/1064 This is an automated message from the Apache Git Service. To respond to the

[GitHub] kgyrtkirk closed pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way

kgyrtkirk closed pull request #1048: [CALCITE-2722] Rewrite createLeftCall in iterative way instead of recursive way URL: https://github.com/apache/calcite/pull/1048 This is an automated message from the Apache Git Service.

[GitHub] jh3507 commented on a change in pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

jh3507 commented on a change in pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner URL: https://github.com/apache/calcite/pull/1058#discussion_r259709165 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

[GitHub] zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259641994 ## File path:

[GitHub] MGelbana opened a new pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::'

MGelbana opened a new pull request #1066: [CALCITE-2843] Babel parser should support PostgreSQL casting operator '::' URL: https://github.com/apache/calcite/pull/1066 Initial support for PostgreSQL OID types (oid, regproc, repoper..etc) is also included in the form of two test cases and

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259602022 ## File path:

[GitHub] julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259599740 ## File path:

[GitHub] zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259598356 ## File path:

[GitHub] asereda-gs merged pull request #1065: [CALCITE-2863] ElasticSearch Adapter. select * and predicates on _MAP fail

asereda-gs merged pull request #1065: [CALCITE-2863] ElasticSearch Adapter. select * and predicates on _MAP fail URL: https://github.com/apache/calcite/pull/1065 This is an automated message from the Apache Git Service. To

[GitHub] asereda-gs opened a new pull request #1065: [CALCITE-2863] ElasticSearch Adapter. select * and predicates on _MAP fail

asereda-gs opened a new pull request #1065: [CALCITE-2863] ElasticSearch Adapter. select * and predicates on _MAP fail URL: https://github.com/apache/calcite/pull/1065 Fix handling of `select *` in projections. Example of failing query: ```sql select * from elastic where

[GitHub] kgyrtkirk merged pull request #1044: [CALCITE-2838] Simplification: Remove redundant IS TRUE/IS NOT FALSE …

kgyrtkirk merged pull request #1044: [CALCITE-2838] Simplification: Remove redundant IS TRUE/IS NOT FALSE … URL: https://github.com/apache/calcite/pull/1044 This is an automated message from the Apache Git Service. To

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259567401 ## File path:

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259567401 ## File path:

[GitHub] kgyrtkirk opened a new pull request #1064: [CALCITE-2839] Simplify comparisions against boolean literals

kgyrtkirk opened a new pull request #1064: [CALCITE-2839] Simplify comparisions against boolean literals URL: https://github.com/apache/calcite/pull/1064 This patch enables to simplify x=true to x and x=false to not(x) It also handles inequalities which are probably less frequent.

[GitHub] kgyrtkirk commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs

kgyrtkirk commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs URL: https://github.com/apache/calcite/pull/1053#discussion_r259525126 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ##

[GitHub] julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259516689 ## File path:

[GitHub] kgyrtkirk closed pull request #1047: [CALCITE-2841] Simplification: push negation into Case expression

kgyrtkirk closed pull request #1047: [CALCITE-2841] Simplification: push negation into Case expression URL: https://github.com/apache/calcite/pull/1047 This is an automated message from the Apache Git Service. To respond to

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259513062 ## File path:

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259513062 ## File path:

[GitHub] julianhyde commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs

julianhyde commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs URL: https://github.com/apache/calcite/pull/1053#discussion_r259510833 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ##

[GitHub] julianhyde commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs

julianhyde commented on a change in pull request #1053: [CALCITE-2852] Simplification: traverse calculations and unknown UDFs URL: https://github.com/apache/calcite/pull/1053#discussion_r259508694 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ##

[GitHub] julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259507731 ## File path:

[GitHub] vineetgarg02 opened a new pull request #1063: CALCITE-1513 : Correlated NOT IN query throws AssertionError(Vineet G…

vineetgarg02 opened a new pull request #1063: CALCITE-1513 : Correlated NOT IN query throws AssertionError(Vineet G… URL: https://github.com/apache/calcite/pull/1063 …arg) This is an automated message from the Apache Git

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259476211 ## File path:

[GitHub] julianhyde commented on issue #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag…

julianhyde commented on issue #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag… URL: https://github.com/apache/calcite/pull/1025#issuecomment-466500691 Please change the commit comment to not start with 'fix'. Just provide the description of the bug being

[GitHub] julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

julianhyde commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259454491 ## File path:

[GitHub] zhztheplayer closed pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer closed pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259446058 ## File path:

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259446058 ## File path:

[GitHub] zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259442924 ## File path:

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259431543 ## File path:

[GitHub] kgyrtkirk commented on a change in pull request #1056: CALCITE-2858

kgyrtkirk commented on a change in pull request #1056: CALCITE-2858 URL: https://github.com/apache/calcite/pull/1056#discussion_r259429721 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java ## @@ -391,13 +385,17 @@ RexNode toRex(RelInput

[GitHub] zabetak merged pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak merged pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898 This is an automated message from the Apache

[GitHub] zhztheplayer commented on issue #1004: [CALCITE-2786][CALCITE-2787] Add order by clause support for JSON_ARRAYAGG; Json aggregate calls with different null clause get in…

zhztheplayer commented on issue #1004: [CALCITE-2786][CALCITE-2787] Add order by clause support for JSON_ARRAYAGG; Json aggregate calls with different null clause get in… URL: https://github.com/apache/calcite/pull/1004#issuecomment-466460271 Thanks @michaelmior! 2 new PRs opened:

[GitHub] zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

zabetak commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259417514 ## File path:

[GitHub] zhztheplayer closed pull request #1004: [CALCITE-2786][CALCITE-2787] Add order by clause support for JSON_ARRAYAGG; Json aggregate calls with different null clause get in…

zhztheplayer closed pull request #1004: [CALCITE-2786][CALCITE-2787] Add order by clause support for JSON_ARRAYAGG; Json aggregate calls with different null clause get in… URL: https://github.com/apache/calcite/pull/1004

[GitHub] asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis

asereda-gs commented on a change in pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950#discussion_r259409005 ## File path:

[GitHub] yuqi1129 opened a new pull request #1062: [CALCITE-2861] Exception occurs when do +-*/ between decimal and othe…

yuqi1129 opened a new pull request #1062: [CALCITE-2861] Exception occurs when do +-*/ between decimal and othe… URL: https://github.com/apache/calcite/pull/1062 …r numeric types This is an automated message from the Apache

[GitHub] zhztheplayer opened a new pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG

zhztheplayer opened a new pull request #1061: [CALCITE-2786] Add order by clause support for JSON_ARRAYAGG URL: https://github.com/apache/calcite/pull/1061 The JIRA issue: https://issues.apache.org/jira/browse/CALCITE-2786

[GitHub] zhztheplayer opened a new pull request #1060: [CALCITE-2787] Json aggregate calls with different null clause get in…

zhztheplayer opened a new pull request #1060: [CALCITE-2787] Json aggregate calls with different null clause get in… URL: https://github.com/apache/calcite/pull/1060 …correctly merged during converting from SQL to relational algebra The JIRA issue:

[GitHub] zabetak commented on issue #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak commented on issue #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#issuecomment-466410857 @rubenada thanks for taking care of all the comments. The PR looks great:) Can you please

[GitHub] michaelmior commented on issue #1004: [CALCITE-2786][CALCITE-2787] Add order by clause support for JSON_ARRAYAGG; Json aggregate calls with different null clause get in…

michaelmior commented on issue #1004: [CALCITE-2786][CALCITE-2787] Add order by clause support for JSON_ARRAYAGG; Json aggregate calls with different null clause get in… URL: https://github.com/apache/calcite/pull/1004#issuecomment-466387868 These seem to be two separate issues. Could you

[GitHub] zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r259330299 ## File path:

[GitHub] michaelmior commented on issue #1016: [CALCITE-2803] ProjectTransposeJoinRule messes INDF expressions

michaelmior commented on issue #1016: [CALCITE-2803] ProjectTransposeJoinRule messes INDF expressions URL: https://github.com/apache/calcite/pull/1016#issuecomment-466386868 @laurentgo Could you fix the import order issue that's causing checkstyle to fail? (See the Travis tests.)

[GitHub] zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r259328399 ## File path:

[GitHub] zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r259328901 ## File path:

[GitHub] michaelmior commented on a change in pull request #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag…

michaelmior commented on a change in pull request #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag… URL: https://github.com/apache/calcite/pull/1025#discussion_r259329347 ## File path:

[GitHub] zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r259329627 ## File path:

[GitHub] michaelmior commented on issue #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag…

michaelmior commented on issue #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag… URL: https://github.com/apache/calcite/pull/1025#issuecomment-466386448 @asereda-gs Do you mind having a look at this?

[GitHub] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r259329092 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] stutigupta028 commented on a change in pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor

stutigupta028 commented on a change in pull request #1052: CALCITE-2833- Select without from support & CALCITE-2834-Support for values clause for dialects which neither have values clause nor dual table URL: https://github.com/apache/calcite/pull/1052#discussion_r259298635 ## File

[GitHub] zabetak opened a new pull request #1059: [CALCITE-2859] Centralize Calcite system properties

zabetak opened a new pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059 This is an automated message from the Apache Git Service. To respond to the

[GitHub] vlsi commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

vlsi commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r259274565 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r259272042 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466288322 hi @zhztheplayer I'm on the train. I'll deal with this at night. Thank you for your understanding. best qianjin

[GitHub] zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466271735 @XuQianJin-Stars Could you please solve the conflicts and squash your commits into a single commit?

[GitHub] XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466263911 hi @zhztheplayer Thank you very much. I have added `JSON_TYPE`into the non-reserved keyword according to your help. best

[GitHub] zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466253345 @XuQianJin-Stars, following is details about how you can make `JSON_TYPE` non-reserved: 1. Add `JSON_TYPE` to list

[GitHub] XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259195950 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259193931 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259192979 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259192155 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] XuQianJin-Stars edited a comment on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars edited a comment on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-465945517 hi @zhztheplayer I have addressed all comments. Can you continue to review? best qianjin

[GitHub] godfreyhe commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public

godfreyhe commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1050#issuecomment-466240468 thanks for your suggestion @michaelmior This is an automated

[GitHub] michaelmior merged pull request #1049: CALCITE-2856-Emulating Cross Join For SparkSqlDialect

michaelmior merged pull request #1049: CALCITE-2856-Emulating Cross Join For SparkSqlDialect URL: https://github.com/apache/calcite/pull/1049 This is an automated message from the Apache Git Service. To respond to the

[GitHub] michaelmior commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public

michaelmior commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1050#issuecomment-466229817 @godfreyhe In the future, no need to create a new PR. Just change the commit and force push to the same branch and the PR will

[GitHub] michaelmior commented on a change in pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

michaelmior commented on a change in pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner URL: https://github.com/apache/calcite/pull/1058#discussion_r259177109 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

<    1   2   3   4   >