Can someone please review
https://github.com/apache/calcite-avatica/pull/138 ? We are very close
to making rc0 available for voting as we just need to get this reviewed
and merged.
I also saw that https://github.com/apache/calcite-avatica/pull/140 was
opened, but it looks like it might need
Can someone please review
https://github.com/apache/calcite-avatica/pull/138?
Once the PR is merged, I will start the voting process for Avatica 1.18.0.
Francis
On 25/02/2021 5:30 am, Alessandro Solimando wrote:
Hi all,
quick update, I have added some unit-tests to CALCITE-2489:
Hi all,
quick update, I have added some unit-tests to CALCITE-2489:
https://github.com/apache/calcite-avatica/pull/138 because we were relying
on calcite tests for that part of the code, I have added at least some
tests covering what is affected by this PR (which is supposed to be
iso-functional).
Thanks for working on this, Alessandro and many thanks to Stamatis and
Julian for reviewing.
I will build 1.18.0 rc0 and make it available for voting as soon as 3163
and 2489 are merged.
Francis
On 23/02/2021 7:06 pm, Alessandro Solimando wrote:
Hi,
regarding CALCITE-2489:
Hi,
regarding CALCITE-2489: https://github.com/apache/calcite-avatica/pull/138
I have improved the PR description with a more detailed walkthrough of the
changes, hoping it will make it smoother to review.
If you can think of anything I can do to help more please let me know.
Best regards,
Hi Francis, all,
I saw Stamatis' comment under
https://github.com/apache/calcite-avatica/pull/105 (CALCITE-3163) asking to
add unit-tests to avoid regressions, I have added them and opened a
complementing PR which you can find here
https://github.com/apache/calcite-avatica/pull/139.
Best regards,
Hi Alessandro,
Thanks! That would be really awesome!
Francis
On 19/02/2021 5:47 pm, Alessandro Solimando wrote:
Hi,
I can review and open a new PR for
https://github.com/apache/calcite-avatica/pull/105 (CALCITE-3163) if a
committer can then help me merging it.
Best regards,
Alessandro
Il
Hi,
I can review and open a new PR for
https://github.com/apache/calcite-avatica/pull/105 (CALCITE-3163) if a
committer can then help me merging it.
Best regards,
Alessandro
Il Ven 19 Feb 2021, 00:45 Julian Hyde ha scritto:
> I'll take PR 121, [CALCITE-3881].
>
> On Thu, Feb 18, 2021 at 2:19
I'll take PR 121, [CALCITE-3881].
On Thu, Feb 18, 2021 at 2:19 PM Francis Chuang wrote:
>
> A quick update on the release progress for 1.18.0:
> - Waiting for CALCITE-2489:
> https://github.com/apache/calcite-avatica/pull/138
>
> There are a few smaller PRs that could be potentially carried:
> -
A quick update on the release progress for 1.18.0:
- Waiting for CALCITE-2489:
https://github.com/apache/calcite-avatica/pull/138
There are a few smaller PRs that could be potentially carried:
- https://github.com/apache/calcite-avatica/pull/105
-
I use my PR #135 for testing stuff using the CI infrastructure. It
does not need to go into 1.18 (or any release).
On Tue, Feb 16, 2021 at 6:59 AM Josh Elser wrote:
>
> No, I wouldn't wait around for #132. When I left this off, I was
> debugging some JVM internals to understand why stuff didn't
No, I wouldn't wait around for #132. When I left this off, I was
debugging some JVM internals to understand why stuff didn't work :)
Thanks for asking!
I'll try to find some time to help on the other PR's you mentioned.
On 2/15/21 4:54 PM, Francis Chuang wrote:
Hey Everyone,
I am planning
Hey Everyone,
I am planning to make rc0 available for voting in the next few days.
I think #129 is pretty much ready for merging. Danny, can you please
take a look?
- https://github.com/apache/calcite-avatica/pull/129
Julian and Josh, do you guys think you will be able to get your PRs into
Hi Francis,
thanks for your guidance, I have amended the commit message and opened a
new PR: https://github.com/apache/calcite-avatica/pull/136
Best regards,
Alessandro
On Thu, 4 Feb 2021 at 23:47, Francis Chuang
wrote:
> Hey Alessandro,
>
> Thanks so much for reviewing CALCITE-3401. The tests
Hey Alessandro,
Thanks so much for reviewing CALCITE-3401. The tests on your rebased
branch look good.
Can you open a new PR with your rebased version? The commit message
should also be updated to the correct format:
[CALCITE-3401] Assume empty keystore passwords by default (Istvan Toth,
Hi Francis,
I had a look at https://github.com/apache/calcite-avatica/pull/115, LGTM, I
haven't done a review on the PR itself as I have nothing I'd change, if you
think my approval can help I will mark it as such.
I noticed that the PR has conflicts with master, I rebased it and run all
tests
Hey everyone,
It's been around 7 months since the last Avatica release. There has been
some push to get 1.18.0 out before the Calcite 1.27.0 release, so that
the fixes in 1.18.0 can make it into the Calcite release.
I saw a few open PRs on Github that could be potentially merged for this
17 matches
Mail list logo