The latest commits look good.
Only a few cosmetic changes that would be nice to do
- Add missing/fix javadoc to ExecutorServiceManager (its a SPI
interface so full javadoc shows professionalism)
- Add missing/fix javadoc to ThreadPoolFactory (its a SPI interface so
full javadoc shows
Committed the changes.
I even built before I committed to show extra professionalism :-)
Christian
Am 19.08.2011 10:00, schrieb Claus Ibsen:
The latest commits look good.
Only a few cosmetic changes that would be nice to do
- Add missing/fix javadoc to ExecutorServiceManager (its a SPI
On Fri, Aug 19, 2011 at 2:22 PM, Christian Schneider
ch...@die-schneider.net wrote:
Committed the changes.
I even built before I committed to show extra professionalism :-)
Ah that is maybe too professional. Sometimes you have to leave easy
mistakes in for others to fix :)
Christian
Am
Like the one here:
http://svn.apache.org/viewvc?view=revisionrevision=1159323
@Christian please don't blame me posting here as I simply couldn't stop
myself commenting on this.
--
View this message in context:
http://camel.465427.n5.nabble.com/HEADS-UP-Adjustments-to-ExecutorServiceManager
Hi Claus,
sorry for getting back this is so late but I had to work on other
projects in the mean time.
2.9
Your ideas for camel 3.0 are rather small changes that can mostly be
done in 2.9.
We could move ThreadPoolProfile from org.apache.camel.spi to
org.apache.camel and have it in the
Hi Claus,
I just saw that you also changed the ThreadPoolFactory interface to not
use the profiles and instead have several methods again. This completely
defeats the purpose of having a small factory interface.
I will revert that back.
I worked on these changes quite a long time so the fact
On Thu, Aug 18, 2011 at 1:25 PM, Christian Schneider
ch...@die-schneider.net wrote:
Hi Claus,
I just saw that you also changed the ThreadPoolFactory interface to not use
the profiles and instead have several methods again. This completely defeats
the purpose of having a small factory
On Thu, Aug 18, 2011 at 1:50 PM, Claus Ibsen claus.ib...@gmail.com wrote:
On Thu, Aug 18, 2011 at 1:25 PM, Christian Schneider
ch...@die-schneider.net wrote:
Hi Claus,
I just saw that you also changed the ThreadPoolFactory interface to not use
the profiles and instead have several methods
Am 18.08.2011 13:50, schrieb Claus Ibsen:
On Thu, Aug 18, 2011 at 1:25 PM, Christian Schneider
ch...@die-schneider.net wrote:
Hi Claus,
I just saw that you also changed the ThreadPoolFactory interface to not use
the profiles and instead have several methods again. This completely defeats
the
On Thu, Aug 18, 2011 at 2:07 PM, Christian Schneider
ch...@die-schneider.net wrote:
Am 18.08.2011 13:50, schrieb Claus Ibsen:
On Thu, Aug 18, 2011 at 1:25 PM, Christian Schneider
ch...@die-schneider.net wrote:
Hi Claus,
I just saw that you also changed the ThreadPoolFactory interface to
On Thu, Aug 18, 2011 at 2:07 PM, Christian Schneider
ch...@die-schneider.net wrote:
Am 18.08.2011 13:50, schrieb Claus Ibsen:
On Thu, Aug 18, 2011 at 1:25 PM, Christian Schneider
ch...@die-schneider.net wrote:
Hi Claus,
I just saw that you also changed the ThreadPoolFactory interface to
I am -1 on your last changes (CAMEL-4298). You effectively rolled back
most of my changes from CAMEL-4244.
I intend to make the ThreadPoolProfile the main configuration method for
thread pools. This makes working with defaults much more natural than
with the more JDK style API. Your change
On Sat, Aug 13, 2011 at 11:20 AM, Christian Schneider
ch...@die-schneider.net wrote:
I am -1 on your last changes (CAMEL-4298). You effectively rolled back most
of my changes from CAMEL-4244.
I intend to make the ThreadPoolProfile the main configuration method for
thread pools. This makes
I took the liberty of adding some notes to the Camel 3.0 roadmap
https://cwiki.apache.org/confluence/display/CAMEL/Camel+3.0+-+Roadmap
See the section - Improvements to ThreadPoolProfile for thread management
In fact I think we could possible make a compromise with the changes
from Christian and
Hi
Recently the ExecutorServiceStrategy had a bigger refactor
(https://issues.apache.org/jira/browse/CAMEL-4244)
Such as renaming the class to a better name ExecutorServiceManager.
Also introducing a ThreadPoolFactory, ThreadFactory among others. The
ThreadPoolFactory is a great addition, which
15 matches
Mail list logo
