RE: [ANNOUNCE] New Committer: Vijay Bhamidipati

2013-08-11 Thread Saksham Srivastava
Congrats Vijay :) From: Prasanna Santhanam [t...@apache.org] Sent: Saturday, August 10, 2013 10:30 AM To: CloudStack Dev Subject: [ANNOUNCE] New Committer: Vijay Bhamidipati The Project Management Committee (PMC) for Apache CloudStack has asked Vijay Bhamid

Review Request 13495: CLOUDSTACK-4189: [UI] In multi zone setup, dedicating a single zone to a domain, shows other zones dedicated as well

2013-08-12 Thread Saksham Srivastava
/DedicatedResourceDaoImpl.java 6c91ce7 Diff: https://reviews.apache.org/r/13495/diff/ Testing --- list dedicatedzone with zoneid now returns correct dedicated zone. Thanks, Saksham Srivastava

Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

2013-08-14 Thread Saksham Srivastava
/test_explicit_dedication.py bd97551 tools/marvin/marvin/integration/lib/common.py 4f5acef Diff: https://reviews.apache.org/r/13560/diff/ Testing --- test runs successfully whenever an empty host is found. Thanks, Saksham Srivastava

Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

2013-08-19 Thread Saksham Srivastava
a single pool in the cluster, the test is skipped. If multiple suitable hosts are found, the test passes. Thanks, Saksham Srivastava

Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources

2013-08-22 Thread Saksham Srivastava
/integration/component/test_explicit_dedication.py bd97551 tools/marvin/marvin/integration/lib/common.py 4f5acef Diff: https://reviews.apache.org/r/13560/diff/ Testing --- test runs successfully whenever an empty host is found. Thanks, Saksham Srivastava

RE: [Doc] Please review: Dedicated pod, cluster, host doc

2013-08-28 Thread Saksham Srivastava
) Thanks, Saksham -Original Message- From: Radhika Puthiyetath Sent: Wednesday, August 28, 2013 2:29 PM To: us...@cloudstack.apache.org; dev@cloudstack.apache.org; Saksham Srivastava; deepti dohare (deeptidoh...@gmail.com) Cc: Sudha Ponnaganti; Devdeep Singh; Radhika Nair Subject: RE

Review Request 13911: CLOUDSTACK-4572: findHostsForMigration API does not return correct host list

2013-08-30 Thread Saksham Srivastava
/ManagementServerImpl.java 3341c05 Diff: https://reviews.apache.org/r/13911/diff/ Testing --- UI/API displays the correct host list now. Thanks, Saksham Srivastava

Re: Review Request 10882: CLOUDSTACK-2178 : "Add guest network" button is not responding

2013-09-02 Thread Saksham Srivastava
> On May 4, 2013, 8:48 p.m., Pranav Saxena wrote: > > Review comment on the corresponding JIRA ticket to verify if its actually a > > valid bug . If yes , then we'll definitely proceed with validating the fix > > . Thanks ! Hi Issac, CLOUDSTACK-2178 is marked closed as invalid. Do we still ne

RE: [ANNOUNCE] New PMC member: Ilya Musayev

2013-09-05 Thread Saksham Srivastava
Congratulations Ilya. Regards, Saksham -Original Message- From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, September 05, 2013 12:22 PM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New PMC member: Ilya Musayev The Project Management Committee (PMC) for Apache CloudStack has as

RE: Change network functionality?

2013-09-05 Thread Saksham Srivastava
In 4.2, UI functionality for adding/removing and updating default NIC has been added. You may find it in the NIC tab of an instance. I haven't explicitly tried the APIs on 4.1.1, but the APIs should be present there also. Thanks, Saksham -Original Message- From: France [mailto:mailingl

RE: [ANNOUNCE] New Committer: Dave Cahill

2013-09-07 Thread Saksham Srivastava
Congrats Dave. -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Saturday, September 7, 2013 7:51 AM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New Committer: Dave Cahill The Project Management Committee (PMC) for Apache CloudStack has asked Dave Cahill t

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-11 Thread Saksham Srivastava
t itself will fail, it will be good to skip the test in that case. test/integration/component/test_ip_reservation.py <https://reviews.apache.org/r/14079/#comment50860> Adding an addition check of None will prevent future NPEs - Saksham Srivastava On Sept. 11, 2013, 10:09 a.

Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier

2013-09-13 Thread Saksham Srivastava
eImpl.java 4169d42 utils/src/com/cloud/utils/net/NetUtils.java 05b485b utils/test/com/cloud/utils/net/NetUtilsTest.java 3cfc98f Diff: https://reviews.apache.org/r/14124/diff/ Testing --- Added unit test for the utility. Tested locally. Build is successful. Patch applies cleanly. Thanks

Re: Review Request 14079: marvin tests for IP Address reservation within a network

2013-09-15 Thread Saksham Srivastava
patch. - Saksham Srivastava On Sept. 12, 2013, 11:13 a.m., Anshul Gangwar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

RE: [ANNOUNCE] New committer: Rajesh Battala

2013-09-24 Thread Saksham Srivastava
Congrats Rajesh. -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, September 24, 2013 9:00 PM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New committer: Rajesh Battala The Project Management Committee (PMC) for Apache CloudStack has asked Raje

Re: Review Request 14451: Some test for NetUtils

2013-10-03 Thread Saksham Srivastava
m/cloud/utils/net/NetUtilsTest.java <https://reviews.apache.org/r/14451/#comment51906> Can you add few negative test cases like (15, "00:00:00:00:00:ff") in each of these methods. - Saksham Srivastava On Oct. 2, 2013

Re: Review Request 14451: Some test for NetUtils

2013-10-03 Thread Saksham Srivastava
uot;)); Just a few such cases will suffice. - Saksham Srivastava On Oct. 2, 2013, 9:19 p.m., Laszlo Hornyak wrote: > > --- > This is an automatically generated e-mail. To rep

RE: Wiki access

2013-10-04 Thread Saksham Srivastava
Please provide me edit permissions, username: saksham Regards, Saksham -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Friday, October 04, 2013 10:46 AM To: dev@cloudstack.apache.org Subject: Re: Wiki access Mike, Tuna, Srinivas, Go, done. On 10/3/1

RE: Wiki access

2013-10-04 Thread Saksham Srivastava
Thanks Daan. -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, October 04, 2013 2:52 PM To: dev Subject: Re: Wiki access On Fri, Oct 4, 2013 at 11:17 AM, Saksham Srivastava < saksham.srivast...@citrix.com> wrote: > saksham you're in

Re: Review Request 14451: Some test for NetUtils

2013-10-04 Thread Saksham Srivastava
> On Oct. 4, 2013, 6:43 a.m., Saksham Srivastava wrote: > > utils/test/com/cloud/utils/net/NetUtilsTest.java, line 225 > > <https://reviews.apache.org/r/14451/diff/1/?file=360598#file360598line225> > > > > What I am suggesting is that add a method something

Review Request 14647: CLOUDSTACK-3583: Management server stop is not removing the PID

2013-10-15 Thread Saksham Srivastava
://reviews.apache.org/r/14647/diff/ Testing --- Tested locally : The status is now as #service cloudstack-management status cloudstack-management is stopped Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-04 Thread Saksham Srivastava
, Saksham Srivastava

RE: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-05 Thread Saksham Srivastava
Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, June 05, 2013 12:40 AM To: dev@cloudstack.apache.org; Chiradeep Vittal Cc: Kishan Kavala; Saksham Srivastava; cloudstack Subject: Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 t

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-06-05 Thread Saksham Srivastava
/20 => Existing Reservation is not affected. Added UnitTest testIsSameIpRange() Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

2013-06-07 Thread Saksham Srivastava
-29c8c91c24d3 Enabled 480-504;910-914;916-918;920-923;925-934;936-940 VLAN Build passes successfully. Thanks, Saksham Srivastava

RE: [ANNOUNCE] New committer: Jayapal Reddy Uradi

2013-06-17 Thread Saksham Srivastava
Congrats Jayapal. -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Monday, June 17, 2013 9:00 PM To: dev@cloudstack.apache.org Subject: [ANNOUNCE] New committer: Jayapal Reddy Uradi The Project Management Committee (PMC) for Apache CloudStack has asked Jaya

Re: Review Request: CLOUDSTACK-2167: The Vlan ranges displayed are not in ascending order.

2013-06-19 Thread Saksham Srivastava
is now enhanced: 1 49e5cdfc-2c14-415a-9dd3-38ac2fdeef54 Physical Network 1 ZONE 0bd17058-2931-479b-98b5-29c8c91c24d3 Enabled 480-504;910-914;916-918;920-923;925-934;936-940 VLAN Build passes successfully. Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-3064: Able to create VM from different account of the same domain without using Affinity group even the Zone is dedicated to an Account.

2013-06-21 Thread Saksham Srivastava
/DeploymentPlanningManagerImpl.java 4ef2152 Diff: https://reviews.apache.org/r/12028/diff/ Testing --- Tested dedicating zone, then deploying vms from other accounts, it fails now. Also if no affinity group is chosen for the same account, vm deployment fails. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-24 Thread Saksham Srivastava
://reviews.apache.org/r/11627/diff/ Testing --- Tested on local setup. Build successful. Thanks, Saksham Srivastava

Re: Review Request 11627: CLOUDSTACK-1012:Encrypt system.vm.password for 4.0 to 4.1 upgrades

2013-06-28 Thread Saksham Srivastava
--- Tested on local setup. Build successful. Thanks, Saksham Srivastava

Review Request 12326: CLOUDSTACK-3094: Adding a shared network to already deployed VM is failing.

2013-07-08 Thread Saksham Srivastava
://reviews.apache.org/r/12326/diff/ Testing --- Created a shared network. Added the NIC to a vm with error state, causing a NIC entry in db but removed as not null. Added the same network again without error state, the network gets added. Thanks, Saksham Srivastava

Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-12 Thread Saksham Srivastava
://reviews.apache.org/r/12510/diff/ Testing --- If domain has dedicated resources, cleanup=true will release dedication and delete the domain. cleanup=false will not release dedication and will not delete the domain. Thanks, Saksham Srivastava

Re: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-12 Thread Saksham Srivastava
- Saksham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12510/#review23089 --- On July 12, 2013, 2:01 p.m., Saksham Sr

Re: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-12 Thread Saksham Srivastava
the domain. Thanks, Saksham Srivastava

Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-18 Thread Saksham Srivastava
server/src/com/cloud/vm/UserVmManagerImpl.java 9968690 Diff: https://reviews.apache.org/r/12720/diff/ Testing --- Migrated VMs across explicitly dedicated hosts and alerts are generated. Migrated VMs across implicitly dedicated hosts and alerts are generated. Thanks, Saksham Srivastava

RE: Review Request 12510: CLOUDSTACK 3476 : deleteDomain api should fail when release dedicated resource to that domain fails:

2013-07-18 Thread Saksham Srivastava
The fix should qualify for 4.1.1 Thanks, Saksham -Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Thursday, July 18, 2013 6:41 AM To: dev@cloudstack.apache.org; Alena Prokharchyk; Devdeep Singh Cc: Saksham Srivastava; cloudstack Subject: RE: Review Request 12510

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-19 Thread Saksham Srivastava
implicitly dedicated hosts and alerts are generated. Thanks, Saksham Srivastava

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-19 Thread Saksham Srivastava
ws.apache.org/r/12720/#review23372 --- On July 19, 2013, 11:52 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-22 Thread Saksham Srivastava
generated. Thanks, Saksham Srivastava

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-22 Thread Saksham Srivastava
implicitly dedicated hosts and alerts are generated. Thanks, Saksham Srivastava

Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-22 Thread Saksham Srivastava
--- Thanks, Saksham Srivastava

Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-23 Thread Saksham Srivastava
creating template with virtual size. Thanks, Saksham Srivastava

Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes

2013-07-23 Thread Saksham Srivastava
/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava

RE: Git Push Summary

2013-07-24 Thread Saksham Srivastava
Not there in 4.2? -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working on re-factoring the dedication UI code in these d

Re: Review Request 12811: CLOUDSTACK-3612: 3.0.6 to ASF 4.2 Upgrade: Database Schema Inconsistencies on the Upgraded Setup

2013-07-24 Thread Saksham Srivastava
/schema-410to420.sql f9417a0 Diff: https://reviews.apache.org/r/12811/diff/ Testing --- Thanks, Saksham Srivastava

Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-26 Thread Saksham Srivastava
| ++-++-+-+-+---+-+-+--+---+---+--+ Build passed. Patch applies cleanly. Thanks, Saksham Srivastava

Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation

2013-07-27 Thread Saksham Srivastava
://reviews.apache.org/r/12993/diff/ Testing --- Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
--------- On July 26, 2013, 12:42 p.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12968/ >

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
<https://reviews.apache.org/r/12968/#comment47832> Min, I have created a new patch addressing all the concerns, also removed extra checks. - Saksham Srivastava On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote: > > ---

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-27 Thread Saksham Srivastava
| ++-++-+-+-+---+-+-+--+---+---+--+ Build passed. Patch applies cleanly. Thanks, Saksham Srivastava

Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or implicit dedication doesn't generate a usage even

2013-07-29 Thread Saksham Srivastava
type: XenServer processed: 0 virtual_size: NULL Build passed. Patch applies cleanly. Thanks, Saksham Srivastava

RE: Git Push Summary

2013-07-30 Thread Saksham Srivastava
Isaac, I tried some of your changes. Looks good. Regards, Saksham -Original Message- From: Isaac Chiang [mailto:isaacchi...@gmail.com] Sent: Wednesday, July 24, 2013 3:12 PM To: Pranav Saxena Cc: dev@cloudstack.apache.org Subject: Re: Git Push Summary Hi all, I've been working

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24049 --- On July 27, 2013, 6:58 p.m., Saksham Srivastava w

Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.

2013-07-30 Thread Saksham Srivastava
, you should just generate usage event for this > > zone. > > Saksham Srivastava wrote: > The reason I do it is because, this part of code will be executed only > once even when template is cross zone. > If I do not generate all the events here, only the first template that &

Review Request 13266: CLOUDSTACK-3925: Allow Root Admin to deploy VMs on Zone dedicated to any domain/account

2013-08-05 Thread Saksham Srivastava
server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java 10e23d7 Diff: https://reviews.apache.org/r/13266/diff/ Testing --- Root admin is now able to deploy vms on a zone dedicated to a sub domain. Build is successful. Thanks, Saksham Srivastava

RE: Reverting 17267794adb2bab923fb20515a7b943780d61921

2013-08-05 Thread Saksham Srivastava
; Saksham Srivastava Subject: RE: Reverting 17267794adb2bab923fb20515a7b943780d61921 +1. Provided git allows to make a specific file as read-only. > -Original Message- > From: Nitin Mehta [mailto:nitin.me...@citrix.com] > Sent: Monday, August 05, 2013 12:01 PM > To: dev@cloudstac

Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group "Explicit Dedication"

2013-08-06 Thread Saksham Srivastava
to account/domain and do not use affinity group of type Explicit Dedication -> VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication -> VM deployment passes. Build passes. Thanks, Saksham Srivastava

RE: [Doc] IP Address Reservation is Ready for Review

2013-08-07 Thread Saksham Srivastava
CIDR, not the range. * Please mention that feature is not supported in shared networks. Thanks, Saksham From: Radhika Puthiyetath Sent: Friday, August 02, 2013 5:44 PM To: us...@cloudstack.apache.org; dev@cloudstack.apache.org; Saksham Srivastava; Abhinav Roy Subject: [Doc] IP Address Reservation

Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

2013-08-07 Thread Saksham Srivastava
If there are no empty hosts present, the test returns without further dedication or deploying vms. If there is a single empty host present, the host is dedicated and vm is deployed. Thanks, Saksham Srivastava

Re: Review Request 13377: CLOUDSTACK-4021: [Automation] TestExplicitDedication.test_01_deploy_vm_with_explicit_dedication failed to deploy VM

2013-08-07 Thread Saksham Srivastava
py e1991ac Diff: https://reviews.apache.org/r/13377/diff/ Testing --- If there are no empty hosts present, the test returns without further dedication or deploying vms. If there is a single empty host present, the host is dedicated and vm is deployed. Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well

2013-03-22 Thread Saksham Srivastava
CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255) Reserved Range: 10.1.1.64-10.1.1.254 Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-1786: While reserving IPs in guest network, if guestvmcidr is a subset of network cidr but not a subset of cidr, exception is thrown.

2013-03-22 Thread Saksham Srivastava
becomes 10.1.1.0/26 Thanks, Saksham Srivastava

What should be the expected behaviour when VM is deployed (not through CloudStack) on CloudStack managed hosts? Was" [IP Reservation] Is VM creation using the reserved IPs on cloudstack managed hosts

2013-04-12 Thread Saksham Srivastava
Changing the subject and reposting. -Original Message- From: Abhinav Roy [mailto:abhinav@citrix.com] Sent: Tuesday, April 02, 2013 10:36 AM To: dev@cloudstack.apache.org Subject: RE: [IP Reservation] Is VM creation using the reserved IPs on cloudstack managed hosts supported? Hi,

[Add/Remove Network to VM] Multiple NICs on same Guest Network

2013-04-13 Thread Saksham Srivastava
Hi, Using addNicToVirtualMachine API user can add multiple NICs to a VM I am also able to add multiple NICs to a VM on the same isolated guest network. Is this a valid scenario?? If yes what could be the use case for the same? Thanks, Saksham

Re: What should be the expected behaviour when VM is deployed (not through CloudStack) on CloudStack managed hosts? Was" [IP Reservation] Is VM creation using the reserved IPs on cloudstack managed h

2013-04-14 Thread Saksham Srivastava
not clear :( > Can you give a detailed step by step procedure of > "creation of VMs using the reserved IP (after doing IP reservation) on > cloudstack managed hosts supported?" > > On 4/12/13 8:00 AM, "Saksham Srivastava" > wrote: > >> Changing the sub

RE: [Add/Remove Network to VM] Multiple NICs on same Guest Network

2013-04-15 Thread Saksham Srivastava
r NIC). Should we allow only one of them, as they both tend to serve the same purpose, or am I missing something? Thanks, Saksham From: Marcus Sorensen [shadow...@gmail.com] Sent: Saturday, April 13, 2013 9:03 PM To: Saksham Srivastava Cc: dev@cloudstack.apache.org Subjec

Add/Remove Network for VM : VMware Support

2013-04-15 Thread Saksham Srivastava
Following the discussion on bug: https://issues.apache.org/jira/browse/CLOUDSTACK-645 , there needs to be some work done for enhancing VMware support for the feature Add/Remove Network on VM. I will be updating the FS soon and will send out for review. Thanks, Saksham

Re: Add/Remove Network for VM : VMware Support

2013-04-17 Thread Saksham Srivastava
FS is available at : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Add+Remove+Networks+to+VMs+%28Enhanced%29 Thanks, Saksham On Monday 15 April 2013 11:11 PM, Saksham Srivastava wrote: > Following the discussion on bug: > https://issues.apache.org/jira/browse/CLOUDSTACK-645 ,

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-04-19 Thread Saksham Srivastava
fected. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-04-19 Thread Saksham Srivastava
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10005/#review19396 ----------- On April 19, 2013, 9:45 a.m., Saksham Srivastava wrote: > > ---

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-04-23 Thread Saksham Srivastava
/20, guestVmCidr : 10.0.151.0/20 => Existing Reservation is not affected. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-1647: IP Reservation should not happen if the guest-vm cidr and network cidr is not same but their start ip and end ip are same.

2013-04-23 Thread Saksham Srivastava
://reviews.apache.org/r/10005/diff/ Testing --- CIDR : 10.0.144.0/20, Network CIDR : null, guestVmCidr : 10.0.151.0/20 => Reservation is not applied. CIDR : 10.0.144.0/21, Network CIDR : 10.0.144.0/20, guestVmCidr : 10.0.151.0/20 => Existing Reservation is not affected. Thanks, Saksham Srivastava

Re: Guest Network in Advance.

2013-04-23 Thread Saksham Srivastava
Yes creating multiple vlans with different CIDRs is possible. Thanks, Saksham On Tuesday 23 April 2013 05:14 PM, Sean Truman wrote: > All, > > Is it possible for me to define a guest network lets say 10.8.0.x/24 Tagged > with VLAN of 500 and then another guest network with 10.9.0.x/24 with VLAN >

Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well

2013-04-30 Thread Saksham Srivastava
10:04 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10078/ > --- > > (Upd

RE: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well

2013-05-02 Thread Saksham Srivastava
roadcast IP (10.1.1.255) for the entire network. Am I missing something? Regards, Saksham From: Sateesh Chodapuneedi Sent: Thursday, May 02, 2013 3:55 PM To: Saksham Srivastava; Murali Reddy Cc: cloudstack Subject: RE: Review Request: CLOUDSTACK-1748: IP Reservation

Fix for CLOUDSTACK-2277

2013-05-09 Thread Saksham Srivastava
Hi Mice , I just saw your commit for https://issues.apache.org/jira/browse/CLOUDSTACK-2277 So I recently picked this bug, marked it as "in progress" as I was working on it and was about to submit the patch for the same, but then I saw that you already fixed it :) A quick comment : The fix ma

Re: Fix for CLOUDSTACK-2277

2013-05-09 Thread Saksham Srivastava
after a > reboot, can you confirm it in your env? > > Regards > Mice > > -Original Message- > From: Saksham Srivastava [mailto:saksham.srivast...@citrix.com] > Sent: Thursday, May 09, 2013 4:37 PM > To: Mice Xia; dev@cloudstack.apache.org > Subject: Fix for CLOU

Template not getting downloaded on latest master

2013-05-10 Thread Saksham Srivastava
Hi, I did a fresh setup of CloudStack master, Both the system vms are running fine and the secondary storage is also shown enabled. But the built-in template is not getting downloaded. ISO Registration happens but the ISO download is not initiated. I keep on getting this message in the logs: 20

RE: Template not getting downloaded on latest master

2013-05-10 Thread Saksham Srivastava
elated to CLOUDSTACK-2064 On 10-May-2013, at 7:20 PM, "Saksham Srivastava" wrote: > Hi, > > I did a fresh setup of CloudStack master, > Both the system vms are running fine and the secondary storage is also > shown enabled. > But the built-in template is not getting down

RE: [ANNOUNCE] New committer: Devdeep Singh

2013-05-14 Thread Saksham Srivastava
Congratulations Devdeep :) -Original Message- From: Abhinav Roy [mailto:abhinav@citrix.com] Sent: Tuesday, May 14, 2013 8:50 PM To: dev@cloudstack.apache.org Cc: Devdeep Singh Subject: RE: [ANNOUNCE] New committer: Devdeep Singh Congratulations Devdeep :) -Original Message-

Review Request: CLOUDSTACK-2130: UpdateDefaultNicForVirtualMachine api should also create usage events for updating new default network

2013-05-14 Thread Saksham Srivastava
Diff: https://reviews.apache.org/r/11156/diff/ Testing --- Tested manually. Rat build passed. Rebased to latest master. Thanks, Saksham Srivastava

Re: [ANNOUNCE] New committer: Venkata Swamy

2013-05-23 Thread Saksham Srivastava
Congrats Swamy. On Friday 24 May 2013 02:51 AM, Chip Childers wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Venkata Swamy to become a committer and we are pleased to > announce that they have accepted. > > Being a committer allows many contributors to contribute

Re: [ANNOUNCE] New committer: Sailaja Mada

2013-05-23 Thread Saksham Srivastava
Congrats Sailaja :) On Friday 24 May 2013 02:50 AM, Chip Childers wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Sailaja Mada to become a committer and we are pleased to > announce that they have accepted. > > Being a committer allows many contributors to contrib

Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-24 Thread Saksham Srivastava
plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

2013-05-24 Thread Saksham Srivastava
Successful. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-24 Thread Saksham Srivastava
the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-24 Thread Saksham Srivastava
iption to be > > specific not generic ("release the dedication") Fixed for all resources. - Saksham --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11379/#review2

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-27 Thread Saksham Srivastava
f/ Testing --- Unittest: For the new APIs and Service, added unit tests under : plugins/dedicated-resources/test/org/apache/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

2013-05-27 Thread Saksham Srivastava
is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

2013-05-28 Thread Saksham Srivastava
affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-28 Thread Saksham Srivastava
d on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Review Request: CLOUDSTACK-2130:UpdateDefaultNicForVirtualMachine api should also create usage events for updating new default network

2013-05-29 Thread Saksham Srivastava
| | 28 | NETWORK.OFFERING.ASSIGN | 2 | 2013-05-29 12:31:58 | 1 | 3 | 8 | 8 |NULL | 0 | NULL | 0 | Thanks, Saksham Srivastava

Re: Review Request: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host.

2013-05-29 Thread Saksham Srivastava
edicated host. Rat Build Successful. Thanks, Saksham Srivastava

Re: Review Request: Patch 2: CLOUDSTACK-681: Dedicated Resources - Explicit Dedication, Private zone, pod, cluster or host

2013-05-30 Thread Saksham Srivastava
/cloudstack/dedicated/DedicatedApiUnitTest.java Marvin Test: To dedicate host, create affinity group, deploy-vm, check if vm is deployed on the dedicated host. Rat Build Successful. Thanks, Saksham Srivastava

Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range

2014-03-03 Thread Saksham Srivastava
ver/src/com/cloud/configuration/ConfigurationManagerImpl.java d2e5aaa Diff: https://reviews.apache.org/r/18683/diff/ Testing --- Adding new guest IP range passes smoothly. Adding new public IP ranges passes smoothly. Thanks, Saksham Srivastava

Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-03-03 Thread Saksham Srivastava
volume without tags attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava

RE: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range

2014-03-04 Thread Saksham Srivastava
Marcus, as a committer can you kindly commit it too. -Original Message- From: Marcus Sorensen [mailto:nore...@reviews.apache.org] On Behalf Of Marcus Sorensen Sent: Monday, March 3, 2014 10:09 PM To: Marcus Sorensen; Sateesh Chodapuneedi Cc: Saksham Srivastava; cloudstack Subject: Re

RE: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range

2014-03-04 Thread Saksham Srivastava
Thanks, I am still not there :) -Original Message- From: Marcus [mailto:shadow...@gmail.com] Sent: Wednesday, March 5, 2014 10:48 AM To: Saksham Srivastava Cc: dev@cloudstack.apache.org; Sateesh Chodapuneedi Subject: Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared

Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-03-05 Thread Saksham Srivastava
attaching local volume with different tags attaching shared volume Build passes successfully. Patch applies cleanly. Thanks, Saksham Srivastava

Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-03-05 Thread Saksham Srivastava
--- Thanks, Saksham Srivastava

  1   2   >