Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162647475
@wilderrodrigues I think we're fine. That test also passes here:
```
Test redundant router internals ... === TestName:
test_02_RVR_Network_FW_PF_SSH
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162631636
* Environment
- Hardware required: TRUE
- Management Server + MySQL on CentOS 7.1
- One KVM Host on CentOS 7.1
- Agent + Common R
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162624822
Ping @remibergsma @miguelaferreira @DaanHoogland
Test passed as expected!
```
Test redundant router internals ... === TestName:
test_0
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162616151
LGTM based on these tests:
```
test_01_vpc_privategw_acl
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_01_vpc_priv
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162614546
Went through the code. Looks Good To Me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162611887
Although it worked manually, I'm running the test again... in an brand new
DC.
```
nosetests --with-marvin
--marvin-config=/data/shared/marvin/
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162598613
Ping @remibergsma @DaanHoogland @miguelaferreira @borisroman
Deployed another DC and followed the same step as the test, but did it
manually:
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162574201
Ping @remibergsma @miguelaferreira @DaanHoogland @borisroman
Problem with my PR! I havenât seen that one failing before. Will
investigate.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162548576
Jenkins known issue:
---
If your p
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1184#issuecomment-162527902
Ping @DaanHoogland @remibergsma @borisroman
I will continue the tests, but PR is ready to be reviewed.
* Environment
- Hardware requi
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1184
CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway
feature fixed
This PR contains the same fixes from PR #1179, which was created against
the master branch.
Github user wilderrodrigues closed the pull request at:
https://github.com/apache/cloudstack/pull/1179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162460207
@remibergsma @DaanHoogland
I'm closing this PR and will create a new one against 4.6.
Cheers,
Wilder
---
If your project is set up fo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162342338
Run this test: `nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true smoke/test_privategw_acl.py`
Result:
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162341294
@DaanHoogland Yes, sir! See linked PR above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162324443
@remibergsma I think I am being captain obvious (as my new colleagues like
to call each other) but let's add them to the standard run.
---
If your project is
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46771839
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46769848
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final L
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46769789
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162287415
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46767881
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final Net
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162262512
More tests... On the same environment, but with hardware TRUE.
```
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46765516
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46765484
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network netwo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162243159
Wilder can this one be on 4.6 please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761996
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761989
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761973
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761967
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761965
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -765,18 +773,23 @@ public boolean saveSSHKey(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761947
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -656,20 +660,22 @@ public static String getHAProxyStickinessCapabilit
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761941
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761920
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -509,10 +512,11 @@ public boolean applyIps(final Network network, fin
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761916
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(fin
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761845
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final Net
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162237998
@DaanHoogland
Agree... ;) Sometimes I find difficult to wear different hats, although I
could do it just fine. Should I change the title here and o
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761835
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761808
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -445,13 +446,14 @@ public boolean applyIps(final Network
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162237710
I like the scrum style title but just to be nitpicking: isn't this more of
a network engineer feature instead of a developer tool?
---
If your project is set
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162233742
Ping @remibergsma @DaanHoogland @bhaisaab @karuturi @borisroman
@miguelaferreira
Could you please review this PR? I will execute more tests now.
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1179
CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway
feature fixed
This PR fixes the Private Gateway feature when using Redundant VPCs.
In order to get it
42 matches
Mail list logo
