Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-06-28 Thread Marcus Sorensen
Anything special required to do this POST? Just read this thread when searching for userdata 2k and noticed that POST is supposed to be supported, but if I run the following it doesn't work: curl --request POST 'http://localhost:8096/client/api' --data 'command=listVirtualMachines' On Wed, Apr

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-24 Thread Prasanna Santhanam
On Tue, Apr 23, 2013 at 02:08:09PM -0700, Vijayendra Bhamidipati wrote: Hi Prasanna, Thanks for catching the absence of license in the new file - I'll make the required changes. Regarding the POST, the whole query needs to be sent in as a POST query and not only the userdata as POST

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-24 Thread Prasanna Santhanam
On Tue, Apr 23, 2013 at 02:08:09PM -0700, Vijayendra Bhamidipati wrote: Hi Prasanna, Thanks for catching the absence of license in the new file - I'll make the required changes. Regarding the POST, the whole query needs to be sent in as a POST query and not only the userdata as POST

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-24 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19680 --- Ship it! Ship It! - Min Chen On April 23, 2013, 9:45 p.m.,

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-23 Thread Prasanna Santhanam
Vijay - Min applied the patch in the branch http_post. I made changes to your test to make it use libraries from marvin appropriately. Don't hesitate to go change marvin if it makes sense to next time. What I'm seeing is that in your examples you've attached - you send all the request for

RE: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-23 Thread Vijayendra Bhamidipati
Hi Prasanna, Thanks for catching the absence of license in the new file - I'll make the required changes. Regarding the POST, the whole query needs to be sent in as a POST query and not only the userdata as POST data, because CS APIs are supposed to work with either GET or POST. The doGet()

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-22 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:52 a.m.) Review request for cloudstack, Chip

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-22 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:55 a.m.) Review request for cloudstack, Chip

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-22 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 23, 2013, 1:57 a.m.) Review request for cloudstack, Chip

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-17 Thread Prasanna Santhanam
On Wed, Apr 17, 2013 at 11:10:01AM +0530, Rohit Yadav wrote: If it does not cost much, let's introduce a new dependency for requesting stuff (get or post etc.) using requests [1] for both marvin and cloudmonkey. Vijay, you can write your own requester, as it's not much effort required to

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-17 Thread Prasanna Santhanam
On Wed, Apr 17, 2013 at 11:52:08AM +0530, Prasanna Santhanam wrote: On Wed, Apr 17, 2013 at 11:10:01AM +0530, Rohit Yadav wrote: If it does not cost much, let's introduce a new dependency for requesting stuff (get or post etc.) using requests [1] for both marvin and cloudmonkey.

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-17 Thread Chiradeep Vittal
Would be great if it passes pep8 also.(just my nitpicky self) On 4/17/13 6:49 AM, prasanna t...@apache.org wrote: On 17 April 2013 17:10, Prasanna Santhanam t...@apache.org wrote: On Wed, Apr 17, 2013 at 11:52:08AM +0530, Prasanna Santhanam wrote: On Wed, Apr 17, 2013 at 11:10:01AM +0530,

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-17 Thread prasanna
On 17 April 2013 23:13, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Would be great if it passes pep8 also.(just my nitpicky self) Done - I'll clean up the rest of the marvin modules gradually.

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-16 Thread Venkata Siva Vijayendra Bhamidipati
On April 16, 2013, 4:31 a.m., Prasanna Santhanam wrote: tools/marvin/marvin/cloudstackConnection.py, line 61 https://reviews.apache.org/r/10294/diff/4/?file=281521#file281521line61 How and when does marvin decide to use POST? Which commands will call the POST httpmethod? May be

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-16 Thread Rohit Yadav
On Wed, Apr 17, 2013 at 11:00 AM, Venkata Siva Vijayendra Bhamidipati vijayendra.bhamidip...@citrix.com wrote: On April 16, 2013, 4:31 a.m., Prasanna Santhanam wrote: tools/marvin/marvin/cloudstackConnection.py, line 61

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-16 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 17, 2013, 5:44 a.m.) Review request for cloudstack, Chip

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-15 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 16, 2013, 2:53 a.m.) Review request for cloudstack, Chip

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-15 Thread Venkata Siva Vijayendra Bhamidipati
On April 11, 2013, 8:55 p.m., Min Chen wrote: In your description, you mentioned that it is not extensively tested yet. Is this still true? If not, please revise your description to avoid confusing people. Not true anymore - apologies for the confusion. I'll put in details of all

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-11 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19030 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-11 Thread Min Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19032 --- In your description, you mentioned that it is not extensively

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-11 Thread Venkata Siva Vijayendra Bhamidipati
On April 11, 2013, 8:54 p.m., Min Chen wrote: server/src/com/cloud/vm/UserVmManagerImpl.java, line 2581 https://reviews.apache.org/r/10294/diff/3/?file=280319#file280319line2581 Based on your comment, for GET, maxBytes = 4K, for POST, maxBytes = 32K. Why not define these

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-10 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 10, 2013, 9:59 p.m.) Review request for cloudstack, Chip

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-08 Thread Venkata Siva Vijayendra Bhamidipati
On April 5, 2013, 5:46 p.m., Rohit Yadav wrote: As long as we have query based API, the overall base64 encoded payload in the url cannot exceed this limit as per a RFC (I recall discussing this issue on ML when I applied this feature from previous ports). If we handle POST request

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-06 Thread Rohit Yadav
On April 5, 2013, 5:46 p.m., Rohit Yadav wrote: As long as we have query based API, the overall base64 encoded payload in the url cannot exceed this limit as per a RFC (I recall discussing this issue on ML when I applied this feature from previous ports). If we handle POST request

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-05 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review18704 --- Is there any automated testing of this feature today? Marvin tests

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-05 Thread Venkata Siva Vijayendra Bhamidipati
On April 5, 2013, 4:03 p.m., Chip Childers wrote: Is there any automated testing of this feature today? Marvin tests of the HTTP service? Unit tests? If not, now seems like a good time to add some. I realize you are just updating the size of the data field, but IMO we should

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-05 Thread Venkata Siva Vijayendra Bhamidipati
On April 5, 2013, 5:46 p.m., Rohit Yadav wrote: As long as we have query based API, the overall base64 encoded payload in the url cannot exceed this limit as per a RFC (I recall discussing this issue on ML when I applied this feature from previous ports). If we handle POST request

Re: Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-05 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- (Updated April 5, 2013, 10:22 p.m.) Review request for cloudstack, Chip

Review Request: Remove 2k limitation for user data on a deployVMCmd issued as an HTTP POST request

2013-04-04 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ --- Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and