[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-10-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-151047344 Changes LGTM. I haven't tested it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151047752 @borisroman yes this is real :) . I think this might exist in 4.5 as well. Haven't tested it there. I rebased with the current master --- If your project is se

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42965130 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +// License

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151049279 @ustcweizhou Can you please share FS or design document for this work? It'd help greatly in reviewing this patch. Thanks. --- If your project is

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151050165 The erros, travis and Jenkins report are due to missing mysql connector jar. Shall I make Travis build with the developer profile (i.e. `-Pdeveloper`)? Or ju

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151050842 @sateesh-chodapuneedi Thanks for your comment, I will fix it soon. This is an implementation of vm snapshot for KVM. You may find the FS at:https://cwiki

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42966249 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +// License

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42966399 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1702,6 +1705,18 @@ protected boolean checkVmOnHost(fin

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151054893 @ustcweizhou I think it's handy to include account access checks for the backup snapshot from vm snapshot. --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42966712 --- Diff: api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java --- @@ -0,0 +1,191 @@ +// Licensed to the

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151055701 Can't we include it as dependency? Or are there licencing issues? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Load mysql driver before connecting to db

2015-10-26 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/950#issuecomment-151057998 It's already included as a dependency in the `noredist` profile. This PR includes it as a dependency in the `developer` profile, and forces the MySQL driver

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-26 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-151068985 @pvr9711 can you please review this PR? I have made changes as per the review comments and rebased it with master. --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-26 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-151070859 LGTM, I have tested this on a private setup and is working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8975:skip test case if niciraN...

2015-10-26 Thread pvr9711
Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/960#issuecomment-151071811 +1 move this test out of BVTs - this was brought up on almost 3-4 weeks ago. @runseb - I guess, my understanding is - we need 100% passrate on all BVTs - we can

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151081518 @remibergsma @borisroman - I'm starting tests now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151083526 Code look good to me, no rocket science involved. I will test it with XenServer 6.5, but I might need help figuring out how to get it covered.

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Fix KVM snap to vol and ...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/962#issuecomment-151086437 @snuf @NuxRo KVMGuru and LXCGuru are defined at https://github.com/apache/cloudstack/blob/master/server/resources/META-INF/cloudstack/server-compute/spring-server-co

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Wido den Hollander
On 25-10-15 10:52, Milamber wrote: > > > On 25/10/2015 07:05, Sebastien Goasguen wrote: >> Folks, >> >> We have been using GitHub for PR now for a while, it seems to work >> despite the fact that we still have to get used to the workflow. >> We lack some privileges on the mirror to be able to u

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151087205 guys, CS UI is broken by this commit on my env. I am using Chrome (Version 46.0.2490.80 m) It works after reverting this commit. --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/978 CLOUDSTACK-8990: start a stopped machine on a specific determinable host on UI You can merge this pull request into a Git repository by running: $ git pull https://github.com/ustcweiz

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975057 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3388,4 +3419,83 @@ public String mapRbdDevice(

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975005 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreVMSnapshotCommandWrapper.java --- @@ -0,0 +1,121 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/977#discussion_r42975042 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -3388,4 +3419,83 @@ public String mapRbdDevice(

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/979 CLOUDSTACK-8989 test_ps_limits.py tests can also be run on a "basic" setup. The tests in the test_ps_limits.py file can all be run on a "basic" setup. This PR adds that functionality. You ca

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151089307 @remibergsma @karuturi I tested this PR with the changes in #979. Results: ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-k

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151090163 @wido I agree with you. The ideal solution is to implement the features in libvirt-java. At this moment, I do not know how long it will take and when it will

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151091001 Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change be to rename the files s3xen to s3xenserver and swiftxen to swiftxenserver in scripts

ACS 4.5.2 Error while Implementation PVLAN

2015-10-26 Thread Keerthiraja SJ
Hi All, Today I tried to create Advance Zone I added new network with using of vlan primary 41 secondary vlan 42 all the basic necessary been done on switch. While I create a VM I could see error as nw-label: cloudstack, isolated-pvlan: 42, op: add, primary-pvlan: 41, due to There was a failure

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151092704 Ping @runseb. Is there a handle/userid for Tim Mackey? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151094003 @ustcweizhou It's just a matter of sending patches to RedHat and they will accept it. You can also request a new release of the bindings when you need to. It se

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096159 @karuturi Jenkins failed; [ERROR] Error in Cobertura Report generation: Unable to execute Cobertura. Could maybe force push again? --- If your p

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151096712 3rd attempt. I hope it succeeds this time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-10-26 Thread insom
Github user insom commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-151097482 @remibergsma Hi, rebased and pushed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-26 Thread K0zka
Github user K0zka commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151102999 @ustcweizhou could you share some details about the problem? Are you not able to login? --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151104185 Good point, @koushik-das. @remibergsma: do you agree on that one as well? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151104355 thanks for the tests, @karuturi! I will test this PR. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-151105807 @K0zka the page is blank. I tried sometimes with the same result (blank page with this commit, works without this commit). --- If your project is set up for it

Re: TransactionContextInterceptor Keeps Releasing My Lock

2015-10-26 Thread Jeff Hair
I have narrowed it down to multithreading being the cause. I have a set of workers running through an executor service, and it seems cglib is not respecting the @DB annotation on the method being called by the thread. I can force the lock to be acquired if the entire method is executed in a transa

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Rohit Yadav
I like the idea. Few issues I can think of; - Project will become dependent on Github (but luckily, there is a migration path from Github to Gitlab, in case anything goes wrong in future) - Github issues and wiki are quite limited, compared to JIRA and confluence - Possible split brain issues, wh

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151115178 @ustcweizhou Thanks for implementing this feature. I've got 1 comment, could you select the first host available instead of none? See image. ![screenshot

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151115265 @remibergsma @karuturi I've run the following tests: ``` --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151115822 @borisroman None means cloudstack will allocate the host to start the vm. I think it is also needed for users. Not everyone wants to specify a host, right? ---

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/920#issuecomment-151115924 @runseb Could you rebase and push again? If so, and Travis and Jenkins are green, we can merge. Ping @remibergsma @karuturi --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151116076 @ustcweizhou Oke! Though can you make that visible to the user? Now it seems like you "have to" select a host, like you're forced to do so. --- If your project i

RE: BVT report - 10/22

2015-10-26 Thread Raja Pullela
Cool, BTW, The reason for failure for the following tests is downloading of templates/ISOs is taking a long time to download 1) integration.smoke.test_vm_life_cycle.TestVMLifeCycle.test_10_attachAndDetach_iso 2) integration.smoke.test_internal_lb.TestInternalLb.test02_internallb_haproxy_sta

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151116939 Jenkins failed due to the following tests: ``` org.apache.cloudstack.utils.hypervisor.HypervisorUtilsTest.checkVolumeFileForActivityTest ``` https

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-151120955 @remibergsma, I've rebased against current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151127784 @borisroman sorry my comment made you confused. The users I meant is one who use cloudstack for deployment. This window is only visible for root admins. For

[GitHub] cloudstack pull request: CLOUDSTACK-8917 : Instance tab takes long...

2015-10-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/894#issuecomment-151130113 LGTM, based on a set of tests that I run on this branch: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardwa

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151130476 @wido good to know it, thanks. I will implement some features in libvirt-java. I would like to keep current command line and merge it to cs 4.7, and change i

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151131758 @ustcweizhou By "user" I meant the root admin. So my question is: Could you adjust the dialog you created to show something like "Default" instead of an empty lab

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151133235 @borisroman yes, sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/978#issuecomment-151136095 change default host from empty to 'Default'. done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-8992 Allow 32 disks to be atta...

2015-10-26 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/980 CLOUDSTACK-8992 Allow 32 disks to be attached to a KVM VM. Tested manually. Added 32 disks to a VM, booted the VM, formatted all disks and mounted them all. Also created volume group

[GitHub] cloudstack pull request: CLOUDSTACK-8989 test_ps_limits.py tests c...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151145630 Hi @borisroman Although my first round of tests failed, after looking into the test code it seems to be environment related: ``` Test a

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-26 Thread serbaut
GitHub user serbaut opened a pull request: https://github.com/apache/cloudstack/pull/981 CLOUDSTACK-8993: DHCP fails with "no address available" when an IP is… … reused Repopulate /etc/dhcphosts.txt to remove old entries with the same IP address. You can merge this pul

Re: ACS 4.5.2 Error while Implementation PVLAN

2015-10-26 Thread Keerthiraja SJ
Can someone help me how to set the community vlan in cloudstack I can see only options as SecondaryVLAN id. Thanks, Keerthi On Mon, Oct 26, 2015 at 3:54 PM, Keerthiraja SJ wrote: > Hi All, > > Today I tried to create Advance Zone I added new network with using of > vlan primary 41 secondary vla

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151153457 @ustcweizhou I understand the reasoning and that you want this feature in 4.7, but there is no guarantee it will be fixed afterwards. Once the feature is in there nobod

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151155683 @wido it depends on which is more important for us, more features in cloudstack or removing virsh from cloudstack? we know "virsh" provides more features than li

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Rene Moser
Hi On 10/26/2015 10:59 AM, Wido den Hollander wrote: >> But, I thinks that would be better to keep the control of the source >> code repo. This is the core of your work. >> > > Agree. I love Github and it works great, but make it THE primary source > for the source code and go away from ASF? Well

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread xenserverarmy
Github user xenserverarmy commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151157372 @koushik-das One of the goals of a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 was to ensure that we have clarity in which hypervisor we support since Xen != XenSer

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Nux!
+1 what Wido said. -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - > From: "Wido den Hollander" > To: [email protected] > Sent: Monday, 26 October, 2015 09:59:18 > Subject: Re: [DISCUSS] Move to GitHub > On 25-10-15 10:52, Milamber wr

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151160292 @ustcweizhou I want a stable master branch which works all the time. Executing binaries is not reliable as we can't do proper exception handling. Also, virsh do

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151182430 I will test if renaming the plugin works (and make sure there are no links to its name). --- If your project is set up for it, you can reply to this email and h

Re: [DISCUSS] Move to GitHub

2015-10-26 Thread Sebastien Goasguen
so just to be clear, this is not about leaving the ASF. This would be about moving our source code to GitHub. We would remain an ASF project On Mon, Oct 26, 2015 at 3:35 PM, Nux! wrote: > +1 what Wido said. > > -- > Sent from the Delta quadrant using Borg technology! > > Nux! > www.nux.ro > > -

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-26 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-151184063 ran nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_vpc_redundant.py \ component/test_ro

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

2015-10-26 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/918#issuecomment-151184193 @remibergsma @bhaisaab we could merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

Re: Hyper-V clock on KVM node - CLOUDSTACK-8978

2015-10-26 Thread Wido den Hollander
On 24-10-15 02:15, Josh Harshman wrote: > Just looking for some feedback on this idea for an improvement. > > > Currently, for any windows guest OS, we set RTC for the clock source. This > seems to contribute to clock-drift issues leading to BSODs on Windows Server > 2008 R2 Guests. > > I be

[GitHub] cloudstack pull request: CLOUDSTACK-8992 Allow 32 disks to be atta...

2015-10-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/980#issuecomment-151190538 LGTM Should be no problem for KVM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2015-10-26 Thread rodrigo93
Github user rodrigo93 closed the pull request at: https://github.com/apache/cloudstack/pull/969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

2015-10-26 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151204309 @wido now I got your concern. I will change code to enable/disable vm snapshot for kvm by a global configuration kvm.snapshot.enabled, so that someone who do

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2015-10-26 Thread rodrigo93
GitHub user rodrigo93 reopened a pull request: https://github.com/apache/cloudstack/pull/969 Fixed return type Void to void in DataMotionStrategy. The main changes are: - Changing methods “Void” to “void”. - Removal of the method “Void copyAsync(DataObject srcD

[GitHub] cloudstack pull request: Fixed return type Void to void in DataMot...

2015-10-26 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/969#issuecomment-151204587 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

2015-10-26 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/982 Rename xapi plugins for s3 and swift to make them work after renaming the calls Make renaming introduced in a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 work for S3 and Swift xapi plugins.

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/970#issuecomment-151206019 New PR #982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: Removed unused adapters from async-job-co...

2015-10-26 Thread rodrigo93
Github user rodrigo93 commented on the pull request: https://github.com/apache/cloudstack/pull/943#issuecomment-151206169 Hi @remibergsma, the files that I am changing were not altered in the current master. Why do we need to rebase? Thanks for your time. --- If your project is s

[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...

2015-10-26 Thread remibergsma
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack/pull/970 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-8994 Add logging for the passw...

2015-10-26 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/983 CLOUDSTACK-8994 Add logging for the password server. Activity of the password server is now logged. ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1

Re: jenkins disk full ?

2015-10-26 Thread Pierre-Luc Dion
Disks is full againt on master jenkins server. I did not cleanup the disk yet as I don't have access to the server. I'll delete some jobs see how it goes... On Thu, Oct 1, 2015 at 11:11 AM, Daan Hoogland wrote: > So PL, these are just the slaves and not jenkins, right? > If we can incorporate

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8989 test_ps_limits.py t...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/979#issuecomment-151210234 I have talked to @borisroman and he explained me that this PR depends on the fixes on PR #860 from @karuturi . I will merge both and run the tests again.

[GitHub] cloudstack pull request: CLOUDSTACK-8924: Enable dynamic scaling t...

2015-10-26 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/902#issuecomment-151213457 @pvr9711 Can you please share the test results or explain what you did to test? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8889: delete volume doesnt dec...

2015-10-26 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/860#issuecomment-151214062 Ping @karuturi @remibergsma ... time to get this on in? :) Cheers, Wilder --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43025979 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java --- @@ -17,18 +17,37 @@ // under the License. //

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43026042 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/PingNuageVspCommand.java --- @@ -17,18 +17,37 @@ // under the License. //

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43026384 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,61 @@ +// +// Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43026417 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,61 @@ +// +// Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43026839 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java --- @@ -79,4 +79,41 @@ public String getProxyUserDomainuuid

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43026868 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/VspResourceCommand.java --- @@ -79,4 +79,41 @@ public String getProxyUserDomainuuid

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43027769 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java --- @@ -58,20 +73,117 @@ public String getVpcOr

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43030790 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java --- @@ -79,4 +191,47 @@ public boolean executeI

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43030803 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java --- @@ -79,4 +191,47 @@ public boolean executeI

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43030847 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java --- @@ -51,13 +61,91 @@ public boolean isL3Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43030869 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyStaticNatVspCommand.java --- @@ -51,13 +61,91 @@ public boolean isL3Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43030966 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java --- @@ -0,0 +1,295 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43031025 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java --- @@ -40,9 +43,61 @@ public String getVpcUuid(

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43030931 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java --- @@ -0,0 +1,295 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43031053 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java --- @@ -83,9 +92,130 @@ public String getVmUuid()

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43031073 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java --- @@ -83,9 +92,130 @@ public String getVmUuid()

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-10-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r43031009 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java --- @@ -40,9 +43,61 @@ public String getVpcUuid(

  1   2   >