> Now, I'll not comment on all of this, but I still have a few comments:
> a) you still did not come up with a use case or a sample for the need of
> this patch.
> b) all your patches actually broke the build as they copied way too
> much, for instance the samples and test-suit dir should only be c
[EMAIL PROTECTED] wrote
>
> Having commit rights meant I did not need to sit back and wait. The
> jira gave the project notice of my intentions; nobody objected.
> Controversy requires interest. Nobody cared about this. I would have
> committed this two weeks after the jira if I had time. Comm
On 12/29/07, Ralph Goers <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > Creating the jira posted to the Cocoon Dev ML in June. Nobody
> > commented. Should we consider that as no interest or no objections? I
> > did not receive notification that nobody looked at the jira. What is
> >
[EMAIL PROTECTED] pisze:
>
> We needed a new 2.1 because at least one very annoying bug was
> patched. When releasing 2.1.11 was first discussed, someone mentioned
> making this the final release as most of the Cocoon devs are working
> on 2.2. I hope you are correct that development of Cocoon-2
[EMAIL PROTECTED] wrote:
Creating the jira posted to the Cocoon Dev ML in June. Nobody
commented. Should we consider that as no interest or no objections? I
did not receive notification that nobody looked at the jira. What is
the proper channel for more review?
This list. If you want to adv
On 12/28/07, Ralph Goers <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > I committed/closed my Cocoon jiras as soon as I learned a Cocoon
> > release was planned. This may be the final release of Cocoon-2.1 so
> > every change must be committed or discarded.
> I wouldn't get your hopes u
In the meantime I reverted the commit.
I'm open to discuss the issue at hand, so there is still a chance to get
it a solution (if required) into the upcoming version.
Carsten
Bertrand Delacretaz wrote:
> On Dec 28, 2007 11:30 AM, Joerg Heinicke <[EMAIL PROTECTED]> wrote:
>
>> On 28.12.2007 11:1
On Dec 28, 2007 11:30 AM, Joerg Heinicke <[EMAIL PROTECTED]> wrote:
> On 28.12.2007 11:19 Uhr, Bertrand Delacretaz wrote:
> > ...In other words, commits from non-Cocoon committers who have SVN rights
> > to our codebase must be review-then-commit, *not* commit-then-review.
>
> The suggested patch
On 28.12.2007 11:19 Uhr, Bertrand Delacretaz wrote:
IIUC (please correct me if I'm wrong), solprovider has commit rights
on Cocoon by way of being a Lenya committer - that's fine, but we
expect you guys to ask on list before committing stuff.
In other words, commits from non-Cocoon committers w
On Dec 27, 2007 1:06 PM, Carsten Ziegeler <[EMAIL PROTECTED]> wrote:
> ...If I get no response from Paul (or anyone else on this), I'll revert the
> change for the release
+1 for reverting: the change introduces risks, and does not introduce
useful functionality that has been agreed upon by Co
[EMAIL PROTECTED] wrote:
I committed/closed my Cocoon jiras as soon as I learned a Cocoon
release was planned. This may be the final release of Cocoon-2.1 so
every change must be committed or discarded.
I wouldn't get your hopes up on this one. 2.2 is sufficiently different
enough that I w
On 12/27/07, Carsten Ziegeler <[EMAIL PROTECTED]> wrote:
> [EMAIL PROTECTED] wrote:
> > Cocoon-2.1 keeps applications ("samples") in the webapp directory.
> > Newbies would expect to add applications to that directory. The build
> > process chooses specific files and directories to copy so new
> >
[EMAIL PROTECTED] wrote:
> Hi All,
>
> Cocoon-2.1 keeps applications ("samples") in the webapp directory.
> Newbies would expect to add applications to that directory. The build
> process chooses specific files and directories to copy so new
> applications are not copied to the build directory.
On Dec 27, 2007, at 10:29 AM, [EMAIL PROTECTED] wrote:
The discussion is that nobody trusts ant to work properly
so this patch should be reverted because theoretical problems may
result if the ant developers are poor programmers.
It is not theoretical. Binary files, as well as UTF-8 encoded fi
Hi All,
Cocoon-2.1 keeps applications ("samples") in the webapp directory.
Newbies would expect to add applications to that directory. The build
process chooses specific files and directories to copy so new
applications are not copied to the build directory. The patch removed
the list of specifi
On Thu, 2007-12-27 at 13:06 +0100, Carsten Ziegeler wrote:
> If I get no response from Paul (or anyone else on this), I'll revert the
> change for the release. I'm currently planning to prepare the
> distribution next monday.
Yes, please revert the commit.
The fix was to have custom components in
If I get no response from Paul (or anyone else on this), I'll revert the
change for the release. I'm currently planning to prepare the
distribution next monday.
Carsten
Carsten Ziegeler wrote:
> At least the resources have been copied with filtering "off" before. As
> the resources contain images
At least the resources have been copied with filtering "off" before. As
the resources contain images and other binary stuff, this changes
breakes definitly the build as binary files have to be copied with
filtering turned off.
Apart from that, I'm wondering what this change tries to fix.
So Paul,
I remember there have often been issues with either encoding or binary
files. I have no idea if that's still the case and I'm ok with the
change. I also looked into the revision log of the file [1] but could
not find anything particular (only last 4 years available).
Joerg
[1]
http://svn.apa
In case you didn't know, people.apache.org/~jim lists solprovider as
Paul Ercolino, a committer from Lenya. He opened Cocoon-2074 in June and
listed the change then. No one ever commented on it.
I'm not clear on what you are saying. Does your question "I am
wondering if a simple filtering="on
Hi solprovider,
I am wondering if a simple
filtering="on" statement can replace the previous code. I recall issues with
files that become broken on the resources if we use filtering. And also some files we
don't want on the final webapp.
Best Regards,
Antonio Gallardo.
[EMAIL PROTECTED] es
21 matches
Mail list logo
