On Mon, Oct 24, 2022 at 4:19 PM Alex Herbert wrote:
>
> On Sun, 23 Oct 2022 at 14:09, Gary D. Gregory wrote:
> >
> > Ah, well, let's have you review git master now and feel free to refactor. I
> > think we are close if not done for another RC. WDYT?
>
> Since this thread was for the RC1 vote I s
On Sun, 23 Oct 2022 at 14:09, Gary D. Gregory wrote:
>
> Ah, well, let's have you review git master now and feel free to refactor. I
> think we are close if not done for another RC. WDYT?
Since this thread was for the RC1 vote I started a new thread titled:
[csv] validation of duplicate headers
Hi All, Alex, more below:
On 2022/10/22 21:23:13 Alex Herbert wrote:
> On Sat, 22 Oct 2022 at 20:05, Gary D. Gregory wrote:
> >
> > Thank you for the new tests Alex!
> >
> > Here is one area that is easy to overlook: As Commons CSV has evolved, _not
> > all settings in CSVFormat_ apply to both w
On Sat, 22 Oct 2022 at 20:05, Gary D. Gregory wrote:
>
> Thank you for the new tests Alex!
>
> Here is one area that is easy to overlook: As Commons CSV has evolved, _not
> all settings in CSVFormat_ apply to both writing and parsing. To wit, the
> existing Javadoc for CSVFormat.getAllowMissingC
Thank you for the new tests Alex!
Here is one area that is easy to overlook: As Commons CSV has evolved, _not all
settings in CSVFormat_ apply to both writing and parsing. To wit, the existing
Javadoc for CSVFormat.getAllowMissingColumnNames(): "Gets whether missing
column names are allowed whe
On Sat, 22 Oct 2022 at 13:56, Gary D. Gregory wrote:
>
> Thank you for your excellent investigation, Alex, and for finding and fixing
> the missing Test annotations. Overall, we have 98% coverage.
:)
> Taking stock, I think that this is where we are, we have main 3 issues:
>
> 1) Compatibility
t; > default should be changed.
> >
> > Gary
> >
> > On Fri, Oct 21, 2022, 09:44 wrote:
> >
> > > Hi Gary,
> > >
> > > the PR did not have conflicts 30 minutes ago. So we must have encountered
> > > a race condition between you updating
ior or if changing the default is
> > needed and if doing so is just ping-pongonging from one incompatibility to
> > another, based on previous versions.
> >
> > TY!
> >
> > Gary
> >
> > On Fri, Oct 21, 2022, 08:52 wrote:
> >
> > > I
R have dribbled into master already,
> so if you rather implement the changes yourself, please go ahead. I am fine
> with closing my pr.
>
> regards,
> Markus
>
>
> From: Gary Gregory
> Sent: Friday, October 21, 2022 15:17
> To: Commons Developers List
> Subjec
ready, so if
you rather implement the changes yourself, please go ahead. I am fine with
closing my pr.
regards,
Markus
From: Gary Gregory
Sent: Friday, October 21, 2022 15:17
To: Commons Developers List
Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
Hi Markus,
The P
, October 21, 2022 14:18
> To: dev@commons.apache.org
> Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
>
> On 2022/10/20 22:56:05 Alex Herbert wrote:
> > On Thu, 20 Oct 2022 at 23:43, Alex Herbert
> wrote:
> > >
> > > I did not have tim
I've removed serialization stuff from the PR and rebased it to master
https://github.com/apache/commons-csv/pull/276
kind regards,
Markus
From: Gary D. Gregory
Sent: Friday, October 21, 2022 14:18
To: dev@commons.apache.org
Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based o
On 2022/10/20 22:56:05 Alex Herbert wrote:
> On Thu, 20 Oct 2022 at 23:43, Alex Herbert wrote:
> >
> > I did not have time to track through whether this behaviour changed
> > after the initial implementation of the flag. I would think not as the
> > original behaviour is from 1.0. This would map t
illegal and should be fail-fast IMO
> >
> > kind regards,
> > Markus
> >
> > From: Gary Gregory
> > Sent: Thursday, October 20, 2022 16:43
> > To: Commons Developers List
> > Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
> >
,
> Markus
>
> From: Gary Gregory
> Sent: Thursday, October 20, 2022 16:43
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
>
> Would't it be simpler to deal with the serialization issue by bumping the
> serialVersionI
l throw an NPE in the builder
> when instead of using the validate() method.
setDuplicateHeaderMode(null) is illegal and should be fail-fast IMO
kind regards,
Markus
From: Gary Gregory
Sent: Thursday, October 20, 2022 16:43
To: Commons Developers List
Subject: Re: [VOTE] Release Apache
I had just started to look into this and was going to call out the same
thing. I'm concerned with those changes, especially the ones regarding the
allowDuplicates change, I made a note in my ticket for work to make sure we
have appropriate test cases on our end, with the RC, we didn't see any
issu
On Thu, 20 Oct 2022 at 23:43, Alex Herbert wrote:
>
> I did not have time to track through whether this behaviour changed
> after the initial implementation of the flag. I would think not as the
> original behaviour is from 1.0. This would map to:
>
> true -> ALLOW_ALL
> false -> ALLOW_EMPTY
> new
On Thu, 20 Oct 2022 at 22:45, Gary D. Gregory wrote:
>
> Hi All (below)
>
> On 2022/10/20 18:08:31 Alex Herbert wrote:
> > On Thu, 20 Oct 2022 at 17:05, sebb wrote:
> > >
> > > On Thu, 20 Oct 2022 at 15:43, Gary Gregory wrote:
> > > >
> > > > Would't it be simpler to deal with the serialization
Hi All (below)
On 2022/10/20 18:08:31 Alex Herbert wrote:
> On Thu, 20 Oct 2022 at 17:05, sebb wrote:
> >
> > On Thu, 20 Oct 2022 at 15:43, Gary Gregory wrote:
> > >
> > > Would't it be simpler to deal with the serialization issue by bumping the
> > > serialVersionID? We can just say that you on
On Thu, 20 Oct 2022 at 17:05, sebb wrote:
>
> On Thu, 20 Oct 2022 at 15:43, Gary Gregory wrote:
> >
> > Would't it be simpler to deal with the serialization issue by bumping the
> > serialVersionID? We can just say that you only serialized and deserialize
> > for the same version.
>
> Are we will
On Thu, 20 Oct 2022 at 15:43, Gary Gregory wrote:
>
> Would't it be simpler to deal with the serialization issue by bumping the
> serialVersionID? We can just say that you only serialized and deserialize
> for the same version.
Are we willing to continue supporting serialisation going forward?
It
Would't it be simpler to deal with the serialization issue by bumping the
serialVersionID? We can just say that you only serialized and deserialize
for the same version. Also note the PR will throw an NPE in the builder
when instead of using the validate() method.
Gary
On Wed, Oct 19, 2022, 18:27
I've commented on the PR.
TY.
Gary
On 2022/10/19 16:51:57 Gary Gregory wrote:
> On Wed, Oct 19, 2022 at 10:01 AM Alex Herbert
> wrote:
> >
> > On Wed, 19 Oct 2022 at 14:57, Gary D. Gregory wrote:
> > >
> > > My +1
> > >
> > > Gary
> >
> > Gary,
> >
> > PR #276 highlights a behavioural compatibi
On Wed, Oct 19, 2022 at 10:01 AM Alex Herbert wrote:
>
> On Wed, 19 Oct 2022 at 14:57, Gary D. Gregory wrote:
> >
> > My +1
> >
> > Gary
>
> Gary,
>
> PR #276 highlights a behavioural compatibility error in the 1.10.0 RC1.
>
> AllowDuplicates enum may be set to the incorrect value when setting
>
___
> From: Alex Herbert
> Sent: Monday, October 17, 2022 19:53
> To: Commons Developers List
> Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
>
> On Mon, 17 Oct 2022 at 17:11, wrote:
> >
> > Hello
> >
> > >
Hi Markus,
Anyone can vote, please see https://www.apache.org/foundation/voting.html
Note that PMC member votes are binding, while others are advisory.
Gary
On 2022/10/17 10:00:13 sma...@outlook.de wrote:
> Hello
>
> CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before
On Wed, 19 Oct 2022 at 14:57, Gary D. Gregory wrote:
>
> My +1
>
> Gary
Gary,
PR #276 highlights a behavioural compatibility error in the 1.10.0 RC1.
AllowDuplicates enum may be set to the incorrect value when setting
the allow duplicates boolean. Have you reviewed this? I believe it is
valid.
On Wed, 19 Oct 2022 at 14:52, wrote:
>
> > You have added test data for CSVFormat for 1.7 and 1.8 and these do
> not work (commented out). I take it this means serialization has been
> broken since the CSVFormat.delimiter was changed from char to String
> in 1.9.0.
>
> That's correct, Alex. I adde
My +1
Gary
On 2022/10/16 12:48:50 Gary Gregory wrote:
> To: dev@commons.apache.org
> We have fixed a few bugs and added some enhancements since Apache
> Commons CSV 1.9.0 was released, so I would like to release Apache
> Commons CSV 1.10.0.
>
> Apache Commons CSV 1.10.0 RC1 is available for revi
rds,
Markus
From: Alex Herbert
Sent: Monday, October 17, 2022 19:53
To: Commons Developers List
Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1
On Mon, 17 Oct 2022 at 17:11, wrote:
>
> Hello
>
> > This is the logi
On Mon, 17 Oct 2022 at 17:11, wrote:
>
> Hello
>
> > This is the logic from the current builder:
> > DuplicateHeaderMode mode = allowDuplicateHeaderNames ?
> > DuplicateHeaderMode.ALLOW_ALL : DuplicateHeaderMode.ALLOW_EMPTY
>
> This is true only if Builder.setAllowDuplicateHeaderNames is actually
f the above in pull request https://github.com/apache/commons-csv/pull/276
@Alex would you review my PR please?
Kind regards,
Markus
From: Alex Herbert
Sent: Monday, October 17, 2022 13:46
To: Commons Developers List
Subject: Re: [VOTE] Release Apache Commons CSV
On Mon, 17 Oct 2022 at 11:00, wrote:
>
> Hello
>
> CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before
> shipping 1.10.0 IMO
> - missing default
> - broken serialization of class CSVFormat
>
> I raised these issues in CSV-302.
>
> The serialization issue is caught by Rev
Hello
CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before
shipping 1.10.0 IMO
- missing default
- broken serialization of class CSVFormat
I raised these issues in CSV-302.
The serialization issue is caught by Revapi. I had suggested to include Revapi
in the project (C
+1
Built successfully from tag, using:
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.4, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", versi
I will update all of this now but not cut another RC, as you said, none of
these are blockers. I'm doing this in the release branch for convenience.
Tracking below..
On Sun, Oct 16, 2022 at 10:57 AM Alex Herbert
wrote:
>
> Verified sha512 and asc signatures on the binary and source distributions
Verified sha512 and asc signatures on the binary and source distributions.
Built the src.tar.gz using:
mvn clean install site -Pjacoco,japicmp
with:
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 17, vendor: Oracle Corporati
38 matches
Mail list logo
