[GitHub] cordova-plugin-splashscreen pull request: Fix ios launchimage

2014-04-28 Thread Inwinder
Github user Inwinder commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/13#issuecomment-41538040 Hi, The is creating a problem. I am using an iPad in landscape mode and when i fire up the application proper landscape splash screen is shown

Re: [osx, cli] pull request, need another set of eyes

2014-04-28 Thread Braden Shepherdson
LGTM. There might be some reason we can't use identical flows for OSX and iOS, but there's no point in having duplicate branches to the code if they're the same right now. They can be split later if they diverge. Braden On Fri, Apr 25, 2014 at 7:17 PM, Jesse purplecabb...@gmail.com wrote: I

[GitHub] cordova-firefoxos pull request: CB-5816 FirefoxOS - add build scri...

2014-04-28 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-firefoxos/pull/7#discussion_r12049234 --- Diff: bin/lib/create.js --- @@ -26,6 +26,7 @@ var fs = require('fs'), ROOT= path.join(__dirname, '..', '..'), check_reqs =

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements support f...

2014-04-28 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41573670 Done, rebased on master, ready to be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [DISCUSS] Automate signed icla to git commits

2014-04-28 Thread Andrew Grieve
Interesting! Going by this description, it sounds like we wound't need ICLAs for the majority of pull requests since pull requests details get forwarded to the mailing-list. New proposal: don't worry about CLAs at release time. On Fri, Apr 25, 2014 at 5:43 PM, Marvin Humphrey

Publish docs to cordova.apache.org

2014-04-28 Thread Ian Clelland
I'm updating the public plugin docs (in cordova-docs) to point to the plugin registry, rather than the now-defunct dev branch on github. Plugin docs links are currently broken (CB-6530), so this is kind of an urgent fix. It looks like the docs at cordova.apache.org haven't been updated since

Re: [JS] merging to master for cordova-js and cordova-plugman

2014-04-28 Thread Andrew Grieve
I didn't revert it right away, I sent an email saying that I'd do it in the morning if it wasn't fixed, and then did so. It's much worse to have a broken build than it is to just revert. It's *very* easy to revert a revert commit, and it takes the pressure off the person who broke it to come up

Re: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Andrew Grieve
Right, it doesn't exist yet (no one's picked up working on it). +Brian made the original pitch for it, but my understanding is that it is meant to be adding first-class support for testing Cordova apps in the browser, but do so by being a fully-supported cordova platform. Another way to look at

plugman caches local plugin directories and never invalidates that cache

2014-04-28 Thread Kaan Soral
I couldn't find a way to make plugman fetch the updated version of a local plugin, researched the issue a lot, it seems to be related to the recent cache changes (also the cache directory is nowhere to be found)

Re: [JS] merging to master for cordova-js and cordova-plugman

2014-04-28 Thread Jesse
The fact that indentation can break the build is troubling to me. Am I alone? @purplecabbage risingj.com On Mon, Apr 28, 2014 at 9:36 AM, Andrew Grieve agri...@chromium.org wrote: I didn't revert it right away, I sent an email saying that I'd do it in the morning if it wasn't fixed, and then

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements support f...

2014-04-28 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41587797 Merge conflict resolved --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Brian LeRoux
Its not a bad idea but this takes Ripple out of 'gui simulator' into 'env simulator' territory. FWIW, we hope to have cycles this summer to put into cordova-browser but help from others would be VERY welcome. On Mon, Apr 28, 2014 at 9:49 AM, Andrew Grieve agri...@chromium.org wrote: Right, it

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41590320 From @shepheb on the mailing list: LGTM. There might be some reason we can't use identical flows for OSX and iOS, but there's no point in having duplicate

RE: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Ray Camden
Oh - when I read your call for Ripple devs to 'switch', I had assumed it was something already done. From: agri...@google.com agri...@google.com on behalf of Andrew Grieve agri...@chromium.org Sent: Monday, April 28, 2014 11:49 AM To: dev Subject: Re:

RE: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Parashuram Narasimhan (MS OPEN TECH)
So, should we start the formal proposal to the Apache Foundation to move on making Ripple a part of Cordova? I am guessing that we would need technical reasons on why that would make sense. I could help with drafting the proposal. - Ripple is mostly used for Cordova development. Browsers

[GitHub] cordova-cli pull request: Windows 8.1 update breaks app manifest p...

2014-04-28 Thread anewcomer-evostrat
GitHub user anewcomer-evostrat opened a pull request: https://github.com/apache/cordova-cli/pull/171 Windows 8.1 update breaks app manifest parser The powers-that-be at Microsoft decided to add another namespace to the package.appxmanifest when I updated my Windows 8 app to Windows

[GitHub] cordova-plugin-file-transfer pull request: CB-6466 Auto-create dir...

2014-04-28 Thread stacic
Github user stacic commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/28#issuecomment-41593367 Thanks for merging for me! I'll go ahead and close. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-file-transfer pull request: CB-6466 Auto-create dir...

2014-04-28 Thread stacic
Github user stacic closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Ray Camden
As just an FYI, I couldn't disagree more about your first point (minimal value). Now that Ripple is working again, I find it to be *extremely* helpful for prototyping, quick testing, and teaching as well. You mention built in emulation in Chrome, and yep, that's nice, but consider geolocation.

[GitHub] cordova-cli pull request: Windows 8.1 update breaks app manifest p...

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/171#issuecomment-41593880 Issue created here: https://issues.apache.org/jira/browse/CB-6536 Merged, and issue closed. --- If your project is set up for it, you can reply to this

RE: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Parashuram Narasimhan (MS OPEN TECH)
To clarify, I did not mean to diminish the value of Ripple, I was just saying that Ripple is much more than valuable considering Cordova plugins. Ripple specializes in Cordova like API - deviceready, cordova plugins, etc. -Original Message- From: Ray Camden [mailto:rayca...@adobe.com]

[GitHub] cordova-cli pull request: Windows 8.1 update breaks app manifest p...

2014-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Ross Gerbasi
Ripple is awesome and if we are thinking about really pushing the cordova-browser idea it really should consider all the things Ripple provides. Personally I would like to see all that stuff move into the individual plugins. For example the geolocation plugin should have a emulator in it. This

Some pain points from our users :'(

2014-04-28 Thread Shazron
See: https://groups.google.com/d/msg/phonegap/II0qo-dSFWs/Fj8jkemGSbUJ

Re: Some pain points from our users :'(

2014-04-28 Thread Brian LeRoux
I feel the comments there are not really constructive or fair. Cordova changes too much? Sorry, static code means bitrot aka abandonware. We work on Cordova because we are improving it for the many thousands of our users whom appreciate that. I don't need to tell you guys that but 1.8 was a mess

Re: Some pain points from our users :'(

2014-04-28 Thread Joe Bowser
Can we keep track of which users make up which conspiracy theory, and the company that gets mentioned as ruining Cordova the most has to buy beer? I say this because at least this time Google got mentioned with Adobe, as opposed to Adobe is going to kill PhoneGap1!!!eleventyone!!! (Seriously,

Re: Some pain points from our users :'(

2014-04-28 Thread Josh Soref
Shazron wrote: See: https://groups.google.com/d/msg/phonegap/II0qo-dSFWs/Fj8jkemGSbUJ While I haven't written it, I've contemplated the metadata required for an update check that could tell you when a given api breaks. because the API for device.platform changed and returned ios instead of

Re: Some pain points from our users :'(

2014-04-28 Thread Joe Bowser
On Mon, Apr 28, 2014 at 11:44 AM, Brian LeRoux b...@brian.io wrote: I feel the comments there are not really constructive or fair. Cordova changes too much? Sorry, static code means bitrot aka abandonware. We work on Cordova because we are improving it for the many thousands of our users whom

Re: Some pain points from our users :'(

2014-04-28 Thread Shazron
We come with a (framework) developer's perspective, thus an echo chamber. The comments may or may not be fair but the users do encounter pain, and I think it does help in identifying issues we missed (reading from the list overall). Canary in the coal mine, etc. Filing issues etc ideal, but some,

Re: Publish docs to cordova.apache.org

2014-04-28 Thread Andrew Grieve
I think historically, we've deployed when there's a need + deployed during cadence releases. So.. Go for it! On Mon, Apr 28, 2014 at 12:20 PM, Ian Clelland iclell...@chromium.orgwrote: I'm updating the public plugin docs (in cordova-docs) to point to the plugin registry, rather than the

[GitHub] cordova-blackberry pull request: Improve README

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/156 Improve README You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-blackberry readme Alternatively you can review and

[GitHub] cordova-windows pull request: cordova run test + add common.js l...

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/19#issuecomment-41599483 The inclusion of 'eval' to load code is problematic. This pull-request will not be merged. You can close it. --- If your project is set up for it, you

Re: Publish docs to cordova.apache.org

2014-04-28 Thread Steven Gill
+1! We don't have a release process for updating the website + docs. We update when we need to or during cadence releases. On Mon, Apr 28, 2014 at 11:56 AM, Andrew Grieve agri...@chromium.orgwrote: I think historically, we've deployed when there's a need + deployed during cadence releases.

Re: [DISCUSS] Automate signed icla to git commits

2014-04-28 Thread Marvin Humphrey
On Mon, Apr 28, 2014 at 9:20 AM, Andrew Grieve agri...@chromium.org wrote: Interesting! Going by this description, it sounds like we wound't need ICLAs for the majority of pull requests since pull requests details get forwarded to the mailing-list. Legally, the party making the pull request

Re: Some pain points from our users :'(

2014-04-28 Thread Brian LeRoux
We need to clone Tommy for the various channels and convince Mike Sierra to come back and continue docs. Good problems to have at least. On Mon, Apr 28, 2014 at 11:54 AM, Shazron shaz...@gmail.com wrote: We come with a (framework) developer's perspective, thus an echo chamber. The comments

Re: [JS] merging to master for cordova-js and cordova-plugman

2014-04-28 Thread Brian LeRoux
no no! linting is good / I think that should def be considered broken the fast/loose style of 'approve anything that doesn't break the tests' made a lot of sense in our early days. this is a (mostly) mature project now and I think driving to consistency in our code would be a very good thing.

[GitHub] cordova-plugin-globalization pull request: Android should return B...

2014-04-28 Thread mbillau
GitHub user mbillau opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/9 Android should return BCP47 tag, not localized string For https://issues.apache.org/jira/browse/CB-4602 I still want to test the consistency with iOS. Return the

[GitHub] cordova-cli pull request: CB-6537 Consistently indicate `cordova ....

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/172 CB-6537 Consistently indicate `cordova ...` in errors You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_6537

Re: Some pain points from our users :'(

2014-04-28 Thread Michal Mocny
I think this particular users' frustration is not addressable (and his feedback in places is just annoying: you work for X and I demand that you should have the money to do everything for me). He hasn't maintained his project for 2 years, hasn't read our docs, hasn't written tests to guard

Re: plugman caches local plugin directories and never invalidates that cache

2014-04-28 Thread Mark Koudritsky
Currently the plugman cache is in ~/.plugman/cache There is a plan to move to npm cache for both plugman and cli for caching the downloaded plugins and platforms. A cache command will also be part of it to allow cleaning the cache. On Sun, Apr 27, 2014 at 10:51 PM, Kaan Soral

[GitHub] cordova-wp8 pull request: CB-5203 Using XmlHTTPRequest.open on WP8...

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/19#issuecomment-41606953 @dotnetwise The .cs file writes js to the WebBrowser to handle XHR. --- If your project is set up for it, you can reply to this email and have your reply

Re: Some pain points from our users :'(

2014-04-28 Thread Freak Show
I think they are fair, or at least were. I have an app running on 1.2. Its staying there. Why? Because 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, etcall came with some fatal problem relative to 1.2. Some plugin or other was broken. None of those versions offered new capabilities - but often came

Release tagging of code and docs

2014-04-28 Thread Vahid H
Hello, Is there any sort of Git tagging done on version release of both the code and the documentation? The latest tag I could find was 3.0.0. The plugin documentation links are currently broken (on here http://cordova.apache.org/docs/en/3.4.0/cordova_plugins_pluginapis.md.html#Plugin%20APIs),

Re: Release tagging of code and docs

2014-04-28 Thread Ian Clelland
Hi, Vahid -- I'm actually in the middle of updating the plugin documentation links right now, and hopefully this is going to be getting better. The plugin documentation is now available right on the plugin registry -- http://plugins.cordova.io -- so, you could find the docs for the latest

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41610058 I have added a VERSION file and tagged 3.5.0-dev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Some pain points from our users :'(

2014-04-28 Thread Marcel Kinard
How about this: 1) No API changes within a minor version bump. For example, we're looking at some consistency improvements to the globalization plugin that would change the return values. That should trigger a major version bump, even if the signatures/parms don't change. As a consumer of

Re: Some pain points from our users :'(

2014-04-28 Thread Joe Bowser
On Mon, Apr 28, 2014 at 1:01 PM, Freak Show freaksho...@me.com wrote: Because 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, etcall came with some fatal problem relative to 1.2. Some plugin or other was broken. None of those versions offered new capabilities - but often came with new bugs. That's my

Re: Some pain points from our users :'(

2014-04-28 Thread Freak Show
On Apr 28, 2014, at 1:36 PM, Joe Bowser bows...@gmail.com wrote: This wasn't necessary and I was against it. Cool - now there are two of us. These reasons were legal, and it was done to keep PhoneGap open source. If we didn't do this, we wouldn't be having this conversation. And this

[GitHub] cordova-cli pull request: CB-6540 Error for creating a project ins...

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/173 CB-6540 Error for creating a project inside its template is confusing You can merge this pull request into a Git repository by running: $ git pull

Re: Some pain points from our users :'(

2014-04-28 Thread Joe Bowser
On Mon, Apr 28, 2014 at 1:49 PM, Freak Show freaksho...@me.com wrote: On Apr 28, 2014, at 1:36 PM, Joe Bowser bows...@gmail.com wrote: This wasn't necessary and I was against it. Cool - now there are two of us. Strange, I don't remember hearing from you before today? Which commits are you

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41612738 thanks @purplecabbage. there is already a `VERSION` file in the `CordovaLib` directory. do we need both? --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-globalization pull request: Android should return B...

2014-04-28 Thread cmarcelk
Github user cmarcelk commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/9#issuecomment-41613038 I would suggest modifying the existing APIs instead of creating new ones, assuming they have consistent signatures across platforms. And if changing

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41613278 yes, I see that now. Do not need both, although I am a little confused why iOS + OSX both have them in a lib folder while every other platform has it

Re: Some pain points from our users :'(

2014-04-28 Thread Brian LeRoux
Cordova has a CLI. The fact that PhoneGap has one and is different is irrelevant to this list. This is the Cordova mailing list. Why is it different? We donated the PhoneGap source to Apache and it needs to be different for a variety of reasons I'd be happy to share on a personal thread or over a

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41613750 makes sense. I'll (re)move the one in CordovaLib later, and fixup the respective scripts see https://issues.apache.org/jira/browse/CB-6541 --- If your

Re: [GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread Jesse
It probably makes more sense to delete the one I just added, as consistency with iOS is probably the first priority. @purplecabbage risingj.com On Mon, Apr 28, 2014 at 2:08 PM, tripodsan g...@git.apache.org wrote: Github user tripodsan commented on the pull request:

[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...

2014-04-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/174 CB-6542 Delay creating project until there's some chance that it will work You can merge this pull request into a Git repository by running: $ git pull

Re: [GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread Jesse
I have deleted the root VERSION file, however, the tag will remain where it is. @purplecabbage risingj.com On Mon, Apr 28, 2014 at 2:14 PM, Jesse purplecabb...@gmail.com wrote: It probably makes more sense to delete the one I just added, as consistency with iOS is probably the first

Re: Some pain points from our users :'(

2014-04-28 Thread Josh Soref
Marcel Kinard wrote: How about this: 1) No API changes within a minor version bump. For example, we're looking at some consistency improvements to the globalization plugin that would change the return values. That should trigger a major version bump, even if the signatures/parms don't change. As a

Re: [Discuss] The Future of Ripple as a Top Level ASF Project

2014-04-28 Thread Frederico Galvão
Although I agree completely that Ripple is awesome both underneath and in the UI, it'd have to go up quite a length to reach what Chrome already provides on mobile emulation. I'm talking about custom device creation/emulation, touch emulation, viewport automatic sizing and custom pixel-ratio,

Re: Some pain points from our users :'(

2014-04-28 Thread Freak Show
On Apr 28, 2014, at 1:54 PM, Joe Bowser bows...@gmail.com wrote: On Mon, Apr 28, 2014 at 1:49 PM, Freak Show freaksho...@me.com wrote: On Apr 28, 2014, at 1:36 PM, Joe Bowser bows...@gmail.com wrote: This wasn't necessary and I was against it. Cool - now there are two of us.

Re: Some pain points from our users :'(

2014-04-28 Thread Joe Bowser
On Mon, Apr 28, 2014 at 2:32 PM, Freak Show freaksho...@me.com wrote: I guess maybe you're new. https://github.com/phonegap/phonegap/commit/1beb1b5f6ac7470eb516768ef52ceda8df6278e1

Re: Some pain points from our users :'(

2014-04-28 Thread Terence M. Bandoian
For what it's worth, the biggest problem I've had in upgrading is with 'phonegap plugin add plugin'. The native code gets copied but cordova_plugins.js doesn't get updated and the plugin JS isn't wrapped in a call to cordova.define. In a couple of Stack Overflow posts, running 'phonegap

Re: Some pain points from our users :'(

2014-04-28 Thread Joe Bowser
Oh yeah, this too: https://github.com/infil00p/cordova-android/commit/9911202d5b2a5f07ba2050176f72c3642a34a8c6 On Mon, Apr 28, 2014 at 2:49 PM, Joe Bowser bows...@gmail.com wrote: On Mon, Apr 28, 2014 at 2:32 PM, Freak Show freaksho...@me.com wrote: I guess maybe you're new.

Re: [Discuss] Release statusbar plugin

2014-04-28 Thread Marcel Kinard
On Apr 24, 2014, at 10:31 PM, Ian Clelland iclell...@chromium.org wrote: … it's not represented in mobile-spec at all :( Well, there's our problem.

Re: Hangouts Followup - API Audit / W3C Alignment Closing the Gap with Native Apps

2014-04-28 Thread Marcel Kinard
Sorry for the late response, I'm catching up on my email backlog. Why: One of the things I think of Cordova as is bridging the gap between point A (standardized HTML5 JS APIs) and point B (what the device vendors implement in their browsers/webviews). We'd love the bridge to not be needed, but

RE: [Android] Refactoring for different engines

2014-04-28 Thread Hu, Ningxin
Some follow-ups: - fix failing mobile spec tests (file-transfer?, media?) Media automation tests pass after install media plugin after file plugin. - (option) one plugin, use hooks to download static library An update: after Crosswalk 6.35.129.0, the Crosswalk WebView could be downloaded

[GitHub] cordova-android pull request: CB-6543: Fix cordova/run failure whe...

2014-04-28 Thread huningxin
GitHub user huningxin opened a pull request: https://github.com/apache/cordova-android/pull/99 CB-6543: Fix cordova/run failure when no custom_rules.xml available. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request: CB-6543: Fix cordova/run failure whe...

2014-04-28 Thread huningxin
Github user huningxin commented on the pull request: https://github.com/apache/cordova-android/pull/99#issuecomment-41634753 @agrieve, PTAL. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [DISCUSS] Automate signed icla to git commits

2014-04-28 Thread Andrew Grieve
I'm pretty confident it's working as intended for now. On Mon, Apr 28, 2014 at 3:05 PM, Marvin Humphrey mar...@rectangular.comwrote: On Mon, Apr 28, 2014 at 9:20 AM, Andrew Grieve agri...@chromium.org wrote: Interesting! Going by this description, it sounds like we wound't need ICLAs for

[GitHub] cordova-android pull request: CB-6543: Fix cordova/run failure whe...

2014-04-28 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/99#issuecomment-41637291 LGTM! Thanks! I've merged it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-6543: Fix cordova/run failure whe...

2014-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2014-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the