Plugman issues/questions

2014-10-29 Thread John M. Wargo
I'm playing around with plugman in Cordova 4.0 and have found some issues and have some questions. First of all, the docs are incorrect and I've filed a ticket: https://issues.apache.org/jira/browse/CB-7894. The example for adding a plugin is missing the install switch.: $ plugman -platform

[GitHub] cordova-js pull request: CB-7816 Cordova JS doesn't build with Gru...

2014-10-29 Thread EvgenyAgafonchikov
Github user EvgenyAgafonchikov closed the pull request at: https://github.com/apache/cordova-js/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

introduction

2014-10-29 Thread Kinzie, Alan
Hi all, I'm getting myself set up as a contributor to Cordova. So far I've just been working on projects that use Cordova, but I hope to contribute back to Cordova in the future. Regards, Alan

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
GitHub user agrieve opened a pull request: https://github.com/apache/cordova-android/pull/132 Unplug whitelist Creating for code review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-android unplug-whitelist

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540066 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -354,7 +349,9 @@ private void loadUrlNow(String url) { if

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540154 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -429,7 +426,7 @@ public void showWebPage(String url, boolean openExternal,

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540282 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data) { *

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540361 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data) { *

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540420 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data) { *

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540508 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -429,7 +426,7 @@ public void showWebPage(String url, boolean openExternal,

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540574 --- Diff: framework/src/org/apache/cordova/CordovaUriHelper.java --- @@ -37,11 +38,54 @@ public CordovaUriHelper(CordovaInterface cdv,

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540914 --- Diff: framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java --- @@ -72,8 +72,14 @@ public WebResourceResponse

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540972 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data) {

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19541080 --- Diff: framework/src/org/apache/cordova/CordovaPlugin.java --- @@ -162,19 +162,53 @@ public Object onMessage(String id, Object data) {

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19541046 --- Diff: framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java --- @@ -72,8 +72,14 @@ public WebResourceResponse

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19541119 --- Diff: framework/src/org/apache/cordova/PluginManager.java --- @@ -254,6 +254,110 @@ public void onNewIntent(Intent intent) { }

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19540735 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -429,7 +426,7 @@ public void showWebPage(String url, boolean openExternal,

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19541221 --- Diff: framework/src/org/apache/cordova/CordovaUriHelper.java --- @@ -37,11 +38,54 @@ public CordovaUriHelper(CordovaInterface cdv,

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/116#discussion_r19541386 --- Diff: CordovaLib/Classes/CDVViewController.m --- @@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-29 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/116#discussion_r19541663 --- Diff: CordovaLib/Classes/CDVViewController.m --- @@ -749,24 +767,77 @@ - (BOOL)webView:(UIWebView*)theWebView

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19542061 --- Diff: framework/src/org/apache/cordova/PluginManager.java --- @@ -254,6 +254,110 @@ public void onNewIntent(Intent intent) { }

[GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...

2014-10-29 Thread MariaBukharina
GitHub user MariaBukharina opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/49 CB-7896 Pending tests for Save and Find methods for windows Pending tests for Save and Find methods for windows cause they are not supported yet You can merge this pull

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/116#discussion_r19543890 --- Diff: CordovaLib/Classes/CDVViewController.m --- @@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView

RE: introduction

2014-10-29 Thread Wargo, John
Welcome Alan! Alan is one of the developers working on the SAP Mobile Platform Hybrid SDK (what we call Kapsel, our set of Cordova plugins). John M. Wargo Email: john.wa...@sap.com SCN Blog: http://scn.sap.com/blogs/johnwargo Twitter: @johnwargo -Original Message- From: Kinzie, Alan

[GitHub] cordova-android pull request: Unplug whitelist

2014-10-29 Thread clelland
Github user clelland commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/132#discussion_r19553788 --- Diff: framework/src/org/apache/cordova/AndroidWebView.java --- @@ -354,7 +349,9 @@ private void loadUrlNow(String url) { if

Re: introduction

2014-10-29 Thread Shazron
Welcome Alan! Any and all contributions welcome. Let me know if you need any help navigating. On Wed, Oct 29, 2014 at 7:01 AM, Kinzie, Alan alan.kin...@sap.com wrote: Hi all, I'm getting myself set up as a contributor to Cordova. So far I've just been working on projects that use Cordova,

Re: iOS iframe text input issue

2014-10-29 Thread Shazron
Hi, I'm going to put out a proposal on this list on the next steps for WKWebView. Wait for it. On Tue, Oct 28, 2014 at 10:44 AM, CHRISTELDA, SUNIJA sc2...@att.com wrote: Hi, The iOS version 7.0 has a bug related to text inputs in iframes as mentioned in these posts:

Re: introduction

2014-10-29 Thread Michal Mocny
Pleasure to meet you, thanks for saying hello! Do you have any particular interests of focus? Any specific platforms or tooling features? Perhaps interested in starting out with documentation or tests? -Michal On Wed, Oct 29, 2014 at 1:05 PM, Shazron shaz...@gmail.com wrote: Welcome Alan!

Re: Plugman issues/questions

2014-10-29 Thread Brian LeRoux
thats def a bug John / pls file! On Wed, Oct 29, 2014 at 5:52 AM, John M. Wargo jwarg...@gmail.com wrote: I'm playing around with plugman in Cordova 4.0 and have found some issues and have some questions. First of all, the docs are incorrect and I've filed a ticket:

MozillaView update, bridge questions

2014-10-29 Thread Joe Bowser
Hey Unfortunately, I don't have anything working yet for the new MozillaView, but because MozillaView is so radically different than any other view, I've been forced to re-think some things with our current exec script in cordova.js, namely why we're still using a prompt-based solution for

Re: MozillaView update, bridge questions

2014-10-29 Thread Michal Mocny
On Wed, Oct 29, 2014 at 1:45 PM, Joe Bowser bows...@gmail.com wrote: Hey Unfortunately, I don't have anything working yet for the new MozillaView, but because MozillaView is so radically different than any other view, I've been forced to re-think some things with our current exec script in

Re: MozillaView update, bridge questions

2014-10-29 Thread Andrew Grieve
PROMPT isn't the default bridge, addJavaScriptInterface is. We fall back to PROMPT on Androids where AJI exposes security concerns. For Native-JS, we still use ONLINE events, which is actually crazy. Reason for non-JSON is two-fold: 1. JSON doesn't support binary (e.g. ArrayBuffer) 2. JSON

Re: MozillaView update, bridge questions

2014-10-29 Thread Joe Bowser
On Wed Oct 29 2014 at 10:58:08 AM Michal Mocny mmo...@chromium.org wrote: On Wed, Oct 29, 2014 at 1:45 PM, Joe Bowser bows...@gmail.com wrote: Hey Unfortunately, I don't have anything working yet for the new MozillaView, but because MozillaView is so radically different than any other

Re: Plugman issues/questions

2014-10-29 Thread Steven Gill
Hey John, Thanks for filing the two issues. It would be great if you could send PRs for them too! I believe the correct information is in this help file [1] Platform scripts: the platforms were not bumped to version 4.0. What you see at https://www.apache.org/dist/cordova/platforms/ is the

Re: MozillaView update, bridge questions

2014-10-29 Thread Joe Bowser
On Wed Oct 29 2014 at 11:19:02 AM Andrew Grieve agri...@chromium.org wrote: PROMPT isn't the default bridge, addJavaScriptInterface is. We fall back to PROMPT on Androids where AJI exposes security concerns. For Native-JS, we still use ONLINE events, which is actually crazy. OK, so it's not

Re: MozillaView update, bridge questions

2014-10-29 Thread Michal Mocny
On Wed, Oct 29, 2014 at 2:18 PM, Joe Bowser bows...@gmail.com wrote: On Wed Oct 29 2014 at 10:58:08 AM Michal Mocny mmo...@chromium.org wrote: On Wed, Oct 29, 2014 at 1:45 PM, Joe Bowser bows...@gmail.com wrote: Hey Unfortunately, I don't have anything working yet for the new

Re: MozillaView update, bridge questions

2014-10-29 Thread Michal Mocny
On Wed, Oct 29, 2014 at 2:18 PM, Andrew Grieve agri...@chromium.org wrote: PROMPT isn't the default bridge, addJavaScriptInterface is. We fall back to PROMPT on Androids where AJI exposes security concerns. For Native-JS, we still use ONLINE events, which is actually crazy. Reason for

Re: MozillaView update, bridge questions

2014-10-29 Thread Joe Bowser
On Wed Oct 29 2014 at 11:46:43 AM Michal Mocny mmo...@chromium.org wrote: On Wed, Oct 29, 2014 at 2:18 PM, Joe Bowser bows...@gmail.com wrote: Not sure KK and L will kill 2.3, but perhaps Android One etc will (cheap devices and 512 ram was previous motivation to continue shipping these old

Re: Plugman issues/questions

2014-10-29 Thread John M. Wargo
Steve, I'd love to make the changes, but I can't right now. With my day job and trying to finish up Apache Cordova 4 Programming at night, I won't be able to contribute any doc changes until after that is done. Yeah, I figured as much, but the download link on the home page says Download 4.0

Re: Plugman issues/questions

2014-10-29 Thread Shazron
``` $ plugman owner ls org.apache.cordova.core.file $ plugman owner add username org.apache.cordova.core.file $ plugman owner rm username org.apache.cordova.core.file ``` plugins.cordova.io basically uses npm code on the backend, so it's similar (substitute package for plugin). Each plugin on

[DISCUSS] Tools Release

2014-10-29 Thread Mark Koudritsky
I would like to start a tools release. Any outstanding patches to land? Thoughts? - Mark

[GitHub] cordova-lib pull request: CB-7863 Fixed broken test run on Windows...

2014-10-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/112#issuecomment-61009185 Unfortunately, it looks like appveyor is reporting that tests are failing ... --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-29 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/116#discussion_r19574303 --- Diff: CordovaLib/Classes/CDVViewController.m --- @@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView

[iOS 8] WKWebView moving forward

2014-10-29 Thread Shazron
## What We Know So Far 1. Because of the file:// url loading bug, we couldn't support the WKWebView in the iOS 8 GM release. It has since been fixed, for release post iOS 8.1 (not sure when), through a new WKWebView API function ( http://trac.webkit.org/changeset/174029/trunk) 2. The alternative

RE: [DISCUSS] Tools Release

2014-10-29 Thread Parashuram Narasimhan (MS OPEN TECH)
+1 to a tools release. We also have some bugs fixes for the Windows platform, so we may use this as an opportunity to increase the pinned windows platform version. -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Wednesday, October 29, 2014 2:20 PM To:

[GitHub] cordova-ios pull request: Unplug whitelist - review

2014-10-29 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/116#issuecomment-61010261 Also important to note that the tests are now failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: [iOS 8] WKWebView moving forward

2014-10-29 Thread Tommy Williams
This whole thing reeks of sadness and pain. The security implications of this will have to be considered very carefully. On 29 Oct 2014 16:40, Shazron shaz...@apache.org wrote: ## What We Know So Far 1. Because of the file:// url loading bug, we couldn't support the WKWebView in the iOS 8 GM

[DISCUSS] cordova-ios release (3.7.0)

2014-10-29 Thread Shazron
Does anyone have any reason to delay a cordova-ios platform release? Any outstanding patches to land? If not, I will start the release tomorrow.

Re: [iOS] Xcode 6 requirement

2014-10-29 Thread Shazron
See cordova-ios 3.7.0 discuss thread. That release will require Xcode 6, and I will update the docs accordingly. On Sat, Oct 18, 2014 at 8:24 AM, Kevin Hawkins kevin.hawkins.cord...@gmail.com wrote: Our biggest reason for not having solidly moved to Xcode 6 is that there are a number of

Re: Plugman issues/questions

2014-10-29 Thread John M. Wargo
Shaz, Thanks. I just tried it against my registry entry and was able to get it to work. There's a bug in plugman - if I don't provide a plugin ID, I get weird errors. For example, if I issue plugman owner ls and don't provide a plugin ID, I get a 404 error rather than something like You

Re: Plugman issues/questions

2014-10-29 Thread John M. Wargo
Filed: https://issues.apache.org/jira/browse/CB-7900. On 10/29/2014 1:43 PM, Brian LeRoux wrote: thats def a bug John / pls file! On Wed, Oct 29, 2014 at 5:52 AM, John M. Wargo jwarg...@gmail.com wrote: I'm playing around with plugman in Cordova 4.0 and have found some issues and have some

[GitHub] cordova-lib pull request: CB-7890 validate file copy operations in...

2014-10-29 Thread goya
GitHub user goya opened a pull request: https://github.com/apache/cordova-lib/pull/116 CB-7890 validate file copy operations in plugman You can merge this pull request into a Git repository by running: $ git pull https://github.com/phonegap-build/cordova-lib CB-7890

Re: [iOS 8] WKWebView moving forward

2014-10-29 Thread Shazron
This does not preclude using the file url API function I suppose. Here's a flowchart on how I think it would work: http://i.imgur.com/zq4zreN.png On Wed, Oct 29, 2014 at 2:48 PM, Tommy Williams to...@devgeeks.org wrote: This whole thing reeks of sadness and pain. The security implications of

Re: [DISCUSS] Tools Release

2014-10-29 Thread Shazron
Mark, this patch is important for us to get pulled in: https://github.com/apache/cordova-lib/pull/116 On Wed, Oct 29, 2014 at 3:27 PM, Steven Gill stevengil...@gmail.com wrote: Okay, so lets get windows + ios platforms released and then follow that up with a tools release On Wed, Oct 29,

Re: [VOTE] Plugins Release Oct 3, 2014

2014-10-29 Thread Shazron
Just a little book-keeping, this: cordova-plugin-inappbrowser: 0.5.2 is actually: cordova-plugin-inappbrowser: 0.5.3 On Wed, Oct 15, 2014 at 6:47 PM, Steven Gill stevengil...@gmail.com wrote: The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Sergey Grebnov

Re: [VOTE] 3.6.4 Android Release

2014-10-29 Thread Shazron
This vote wasn't closed, so I am closing it. --- The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Sergey Grebnov Marcel Kinard Negative Binding Votes: 0 The vote has passed. On Fri, Oct 3, 2014 at 1:36 PM, Marcel Kinard cmarc...@gmail.com wrote: I vote +1:

Re: MozillaView update, bridge questions

2014-10-29 Thread Andrew Grieve
On Wed, Oct 29, 2014 at 2:46 PM, Michal Mocny mmo...@chromium.org wrote: On Wed, Oct 29, 2014 at 2:18 PM, Andrew Grieve agri...@chromium.org wrote: PROMPT isn't the default bridge, addJavaScriptInterface is. We fall back to PROMPT on Androids where AJI exposes security concerns. For

Re: MozillaView update, bridge questions

2014-10-29 Thread Andrew Grieve
On Wed, Oct 29, 2014 at 2:42 PM, Joe Bowser bows...@gmail.com wrote: On Wed Oct 29 2014 at 11:19:02 AM Andrew Grieve agri...@chromium.org wrote: PROMPT isn't the default bridge, addJavaScriptInterface is. We fall back to PROMPT on Androids where AJI exposes security concerns. For

Re: [iOS 8] WKWebView moving forward

2014-10-29 Thread Andrew Grieve
We could restrict access to the webserver by stuffing a cookie into the webview with an access token, then have the server just 500 on any request missing the cookie. We should also be able to restrict external requests just by listening on 127.0.0.1 instead of 0.0.0.0 (doesn't look like

Re: MozillaView update, bridge questions

2014-10-29 Thread Joe Bowser
On Wed Oct 29 2014 at 4:56:24 PM Andrew Grieve agri...@chromium.org wrote: Is any of this documented anywhere other than the Cordova Mailing List? I'm noticing a lack of comments on the NativeToJsMessageQueue object I was hoping to re-use for MozillaView so I wouldn't have to create

Re: MozillaView update, bridge questions

2014-10-29 Thread Michal Mocny
On Wed, Oct 29, 2014 at 7:52 PM, Andrew Grieve agri...@chromium.org wrote: On Wed, Oct 29, 2014 at 2:46 PM, Michal Mocny mmo...@chromium.org wrote: On Wed, Oct 29, 2014 at 2:18 PM, Andrew Grieve agri...@chromium.org wrote: PROMPT isn't the default bridge, addJavaScriptInterface is. We

[GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...

2014-10-29 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/49#discussion_r19587554 --- Diff: tests/tests.js --- @@ -99,7 +110,14 @@ exports.defineAutoTests = function () { afterEach(removeContact);

[GitHub] cordova-coho pull request: Cb-7904: Pull request for nightlys

2014-10-29 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/58 Cb-7904: Pull request for nightlys You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho cb-7904 Alternatively you

Cordova Nightly Builds

2014-10-29 Thread Steven Gill
I have been doing some work on releasing nightlys recently. Please review PR [1] and comment on the issue [2]. [1] https://github.com/apache/cordova-coho/pull/58 [2] https://issues.apache.org/jira/browse/CB-7904

[GitHub] cordova-coho pull request: Updated location of platforms within co...

2014-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature