[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...

2014-11-10 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/51#issuecomment-62513685 Hello Jesse, Added the name, Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...

2014-11-10 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/51#issuecomment-62489706 Hi @daserge Thanks for the commit! Can you please add your real name to your github profile so I can resolve your github user account to a signed i

[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...

2014-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Add comment section at end of build.grad...

2014-11-10 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-lib/pull/117#issuecomment-62483257 > @clelland What happens on upgrade, if a project already has a platforms/android/build.gradle file? Do we need to put some code in to either replace build.gradle

Re: [VOTE] Tools Release

2014-11-10 Thread Steven Gill
Those instructions look good to me -Steve On Mon, Nov 10, 2014 at 3:54 PM, Mark Koudritsky wrote: > Ok, published new packages and a new vote thread. > > Thinking about fixes the the release doc [1]. > > We need some clear instructions for the case when releasing with an update > from an existi

Re: [VOTE] Tools Release

2014-11-10 Thread Mark Koudritsky
Ok, published new packages and a new vote thread. Thinking about fixes the the release doc [1]. We need some clear instructions for the case when releasing with an update from an existing branch. Does the following sound right? Assuming a micro version bump is needed from 4.1.0 to 4.1.1. * On ma

[VOTE] Tools Release, take 2

2014-11-10 Thread Mark Koudritsky
Please review and vote on this Tools Release. Release issue: https://issues.apache.org/jira/browse/CB-7988 Packages have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-7988/ And to npm under @rc tag To test them out you can use: npm -g uninstall cordova npm

Re: [iOS 8] WKWebView moving forward

2014-11-10 Thread tommy-carlos williams
Yeah… I’ll try to report some of it and get back to you. --  tommy-carlos williams On 11 November 2014 at 09:50:55, Shazron (shaz...@gmail.com) wrote: Bug report? Or email me personally. Which ones besides the ones that will have problems as we discussed on this thread. On Mon, Nov 10, 2014

Re: [iOS 8] WKWebView moving forward

2014-11-10 Thread Shazron
Bug report? Or email me personally. Which ones besides the ones that will have problems as we discussed on this thread. On Mon, Nov 10, 2014 at 2:41 PM, tommy-carlos williams wrote: > I had much less success… it doesn’t play well with other legacy plugins, > does it? > > > > -- > tommy-carlos wi

Re: [iOS 8] WKWebView moving forward

2014-11-10 Thread tommy-carlos williams
I had much less success… it doesn’t play well with other legacy plugins, does it? --  tommy-carlos williams On 11 November 2014 at 03:00:30, Michal Mocny (mmo...@chromium.org) wrote: Success! I did indeed have to add the framework manually. Thanks for instructions. On Thu, Nov 6, 2014 a

Re: [VOTE] Tools Release

2014-11-10 Thread Steven Gill
In terms of having to bump the version when you have to retag an rc that has been published to npm: The reason why this is necessary is because we want to test exactly what we vote on. We push the tgz file that we are voting on to npm under the rc flag. The alternative would be to extract it, chan

Re: [VOTE] Tools Release

2014-11-10 Thread Mark Koudritsky
This vote is cancelled. Blocking issue https://issues.apache.org/jira/browse/CB-8000 Will post a new vote with updated packages On Mon, Nov 10, 2014 at 12:34 PM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Thank you Mark; Resending link to the fix here since looks like I answered

Re: CB-7927

2014-11-10 Thread Shazron
Hi Kamil, Yes a pull request is ideal way. See: https://github.com/apache/cordova-plugin-file/blob/master/CONTRIBUTING.md On Sun, Nov 9, 2014 at 11:54 PM, Kamil Durkiewicz wrote: > Hi, > > There is a bug in the File plugin that is quite severe from a point of view > of a project I'm currently

[GitHub] cordova-lib pull request: CB-8000 Fix --usegit option when adding ...

2014-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8000 Fix --usegit option when adding ...

2014-11-10 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/118#issuecomment-62464427 Looks good. Pushing to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

Re: Review: Tools Release blog post

2014-11-10 Thread Shazron
Added some lines: https://github.com/cordova/apache-blog-posts/pull/20 On Mon, Nov 10, 2014 at 1:23 PM, Mark Koudritsky wrote: > Incorporated pull request from Josh and Marcel, added the CB-7890 to > notable changes in the lib, bumped micro numbers for versions that will > have to be changed. >

Re: cordova 64-bit support

2014-11-10 Thread Joe Bowser
+1 I think we really need more data. I know that in Marcel's case, there's the Asia-Pacific customer, but I have no idea how big that customer base is. The only numbers I have are the Play Store. and I think the same thing goes for iOS and the App Store. In Android's case, there's a lot of thir

Re: Review: Tools Release blog post

2014-11-10 Thread Mark Koudritsky
Incorporated pull request from Josh and Marcel, added the CB-7890 to notable changes in the lib, bumped micro numbers for versions that will have to be changed. Published it in github/cordova/apache-blog-posts at https://github.com/cordova/apache-blog-posts/blob/master/2014-11-10-tools-release.md

Re: Review: Tools Release blog post

2014-11-10 Thread Josh Soref
I'm assuming I can't push there either... On 11/10/14, 2:41 PM, "Steven Gill" wrote: >Mark, I added you as owner to that Org. > >-Steve > >On Mon, Nov 10, 2014 at 11:30 AM, Mark Koudritsky >wrote: > >> I got a permission denied error when trying to push to origin. Didn't >> invest the time to i

Re: Review: Tools Release blog post

2014-11-10 Thread Steven Gill
Mark, I added you as owner to that Org. -Steve On Mon, Nov 10, 2014 at 11:30 AM, Mark Koudritsky wrote: > I got a permission denied error when trying to push to origin. Didn't > invest the time to investigate it. Does this repo live on GitHub or is it > only mirrored there? > Cloned it using `g

Re: Review: Tools Release blog post

2014-11-10 Thread Mark Koudritsky
I got a permission denied error when trying to push to origin. Didn't invest the time to investigate it. Does this repo live on GitHub or is it only mirrored there? Cloned it using `grunt cloneBlog` according to instructions at https://svn.apache.org/repos/asf/cordova/site/README.md On Mon, Nov 10

[GitHub] cordova-plugin-statusbar pull request: CB-7986 Add cordova-plugin-...

2014-11-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/18 CB-7986 Add cordova-plugin-statusbar support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated the documentation [JIRA issue](https://issues.apache.org/jira/

Re: cordova 64-bit support

2014-11-10 Thread Shazron
We'll delay this decision for another time, in a proper thread without hijacking this one. On Mon, Nov 10, 2014 at 8:37 AM, Marcel Kinard wrote: > My customers still need iOS 6. Specifically the ones in the Asia-Pacific > area. The feedback we are getting from there is that end users hold on the

Re: cordova 64-bit support

2014-11-10 Thread Josh Soref
Marcel Kinard wrote: > I suspect there will be many more questions around iOS 64-bit. > I think it deserves a blog entry. Seems reasonable >I've drafted one here: >https://github.com/cordova/apache-blog-posts/blob/ios64bit/2014-11-11-ios- >64bit.md > >Feedback desired. I'd like to see this publis

CB-7927

2014-11-10 Thread Kamil Durkiewicz
Hi, There is a bug in the File plugin that is quite severe from a point of view of a project I'm currently in: https://issues.apache.org/jira/browse/CB-7927 I've attached a patch file to the Jira issue. This fix is also available on my fork of the plugin: https://github.com/durkiewicz/cordova-p

Re: Review: Tools Release blog post

2014-11-10 Thread Jesse
This was a huge security hole fix that should be mentioned most likely. https://github.com/apache/cordova-lib/commit/281aee737dbe5143c9cb5957359ed5df6298a154 This landed quietly, but ultimately tooling released before this commit could read private user data, copy it to the project folder and u

Re: cordova 64-bit support

2014-11-10 Thread Marcel Kinard
I suspect there will be many more questions around iOS 64-bit. I think it deserves a blog entry. I've drafted one here: https://github.com/cordova/apache-blog-posts/blob/ios64bit/2014-11-11-ios-64bit.md Feedback desired. I'd like to see this published in the next few days. Thanks! On Nov 7, 20

Re: Review: Tools Release blog post

2014-11-10 Thread Josh Soref
I only did the PR there because that's what I saw advertised. I don't really care where it is done :) On 11/10/14, 1:00 PM, "Marcel Kinard" wrote: >https://github.com/kamrik/apache-blog-posts/pull/2 > >BTW, is there a reason to do the work on kamrik/master instead of >origin/topicBranch or orig

Re: Review: Tools Release blog post

2014-11-10 Thread Marcel Kinard
https://github.com/kamrik/apache-blog-posts/pull/2 BTW, is there a reason to do the work on kamrik/master instead of origin/topicBranch or origin/master? I think I have content from Parashuram that you don't. On Nov 10, 2014, at 11:31 AM, Josh Soref wrote: > To be fair, if you missed it, othe

RE: [VOTE] Tools Release

2014-11-10 Thread Sergey Grebnov (Akvelon)
Thank you Mark; Resending link to the fix here since looks like I answered not to the latest email last time. https://github.com/apache/cordova-lib/pull/118/ Thx! Sergey -Original Message- From: Mark Koudritsky [mailto:kam...@google.com] Sent: Monday, November 10, 2014 9:14 AM To: dev@co

[GitHub] cordova-lib pull request: CB-8000 Fix --usegit option when adding ...

2014-11-10 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/118 CB-8000 Fix --usegit option when adding windows and wp8 https://issues.apache.org/jira/browse/CB-8000 You can merge this pull request into a Git repository by running: $ git pull https://

RE: [VOTE] Tools Release

2014-11-10 Thread Sergey Grebnov (Akvelon)
Here is a proposed fix https://github.com/apache/cordova-lib/pull/118 Fix --usegit option when adding windows and wp8 https://issues.apache.org/jira/browse/CB-8000 Thx! -Sergey -Original Message- From: Sergey Grebnov (Akvelon) Sent: Monday, November 10, 2014 9:06 AM To: dev@cordova.apach

Re: [VOTE] Tools Release

2014-11-10 Thread Mark Koudritsky
Yep, the hash as a versions seems like something that should break the npm download as well. Sergey, I'll merge your patch and republish rc packages. Maria, thanks for finding this. Note, the lib will have a different version number 4.1.1 because npm forbids uploading anything with the same versio

RE: [VOTE] Tools Release

2014-11-10 Thread Sergey Grebnov (Akvelon)
I've found the case will submit the patch shortly - Jira +PR to master Problem cause: we've recently got rid of subdirs for wp8 and windows but still have them defined in tools. https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/platformsConfig.json#L53 Thx! Sergey -Or

RE: [VOTE] Tools Release

2014-11-10 Thread Steven Gill
Definitely a problem. Thanks for testing and finding it! -1 On Nov 10, 2014 8:51 AM, "Maria Bukharina" wrote: > Hi all, > > I've tried to create app with this rc and discover that adding wp8 and > windows platforms with --usegit key fails: > > cordova platform add wp8 --usegit >

RE: [VOTE] Tools Release

2014-11-10 Thread Maria Bukharina
Hi all, I've tried to create app with this rc and discover that adding wp8 and windows platforms with --usegit key fails: cordova platform add wp8 --usegit Creating wp8 project... Error:.cordova\lib\wp\cordova\4.1.0\bin\create: Command failed with exit code ENOENT

Re: cordova 64-bit support

2014-11-10 Thread Marcel Kinard
My customers still need iOS 6. Specifically the ones in the Asia-Pacific area. The feedback we are getting from there is that end users hold on the devices for longer periods than compared to North America / Europe, and they are also less likely to perform os upgrades even when available. Not a

Re: Review: Tools Release blog post

2014-11-10 Thread Josh Soref
To be fair, if you missed it, others will too, which argues that it should be reorganized. I've done a PR for the other bits, but someone should consider this point. On 11/10/14, 11:27 AM, "Marcel Kinard" wrote: >Ah, missed that. > >On Nov 10, 2014, at 11:20 AM, Mark Koudritsky wrote: > >> The

Re: Review: Tools Release blog post

2014-11-10 Thread Marcel Kinard
Ah, missed that. On Nov 10, 2014, at 11:20 AM, Mark Koudritsky wrote: > The two items under "Platform updates" are already links to those two posts. > > On Mon, Nov 10, 2014 at 10:56 AM, Marcel Kinard wrote: > >> You mention near the top that the iOS, Windows, and WP8 platforms are >> updated

Re: Review: Tools Release blog post

2014-11-10 Thread Mark Koudritsky
The two items under "Platform updates" are already links to those two posts. On Mon, Nov 10, 2014 at 10:56 AM, Marcel Kinard wrote: > You mention near the top that the iOS, Windows, and WP8 platforms are > updated, but there isn't mention of what that is. One could infer that this > release has

Re: cordova 64-bit support

2014-11-10 Thread Ian Clelland
I know that's been our Android policy; I though that iOS was roughly "we support the current release and the one previous release", which would mean that we're already good to start just supporting iOS 7 and 8 exclusively. (Not that it's a big difference -- a 1-month delay is about what it would t

Re: [iOS 8] WKWebView moving forward

2014-11-10 Thread Michal Mocny
Success! I did indeed have to add the framework manually. Thanks for instructions. On Thu, Nov 6, 2014 at 7:49 PM, Shazron wrote: > There have been major changes to the `wkwebview` branch of `cordova-ios`. > The `WKWebView` functionality has been moved to a plugin in the > `cordova-plugins` re

Re: Review: Tools Release blog post

2014-11-10 Thread Marcel Kinard
You mention near the top that the iOS, Windows, and WP8 platforms are updated, but there isn't mention of what that is. One could infer that this release has those updates, but I realize it's just changing the default versions of those platforms on an "add". How about linking to those posts: ht

Re: Review: Tools Release blog post

2014-11-10 Thread Mark Koudritsky
It's for the lib, other changes are mostly fixes in help text. Should I add some trivial line about plugman to release notes? On Mon, Nov 10, 2014 at 9:17 AM, Ian Clelland wrote: > Are there any changes at all to plugman that necessitate its release, or is > it just being released so that there'

Re: cordova 64-bit support

2014-11-10 Thread Michal Mocny
Our policy has historically been to drop support if usage is under 5%. There some amount of leeway in judgement here as well: is it trivial to continue support or causing us pain? For iOS, 5% of usage comes from iOS6 or below as reported by https://developer.apple.com/support/appstore/. I'd ventu

Re: Running browser platform in Linux

2014-11-10 Thread Michal Mocny
On Thu, Nov 6, 2014 at 8:53 PM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > Sorry for not being clear. I was saying that we should not open the > file:// URL in a specific browser. We should ideally spin up a webserver > and open the default browser on the system > > Wh

Re: Summarizing thoughts on cordova-browser vs Ripple

2014-11-10 Thread Michal Mocny
On Thu, Nov 6, 2014 at 6:52 PM, Horn, Julian C wrote: > I'd like to introduce myself and put in my two cents here. My name is > Julian Horn. I work for Intel on the XDK, an integrated development > environment for cross-platform HTML5 applications. I am the team lead for > the Device Emulator c

[GitHub] cordova-plugin-battery-status pull request: CB-7971 Add cordova-pl...

2014-11-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/19 CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated the documentation [Jira issue](https://issues.apache

Re: Review: Tools Release blog post

2014-11-10 Thread Ian Clelland
Are there any changes at all to plugman that necessitate its release, or is it just being released so that there's a version that uses the new cordova-lib? It seems odd that it's in the announcement, but missing from the releasenotes. On Fri Nov 07 2014 at 5:22:51 PM Mark Koudritsky wrote: > Ple

[GitHub] cordova-plugin-battery-status pull request: CB-7971 Add cordova-pl...

2014-11-10 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or