[GitHub] cordova-medic pull request: CB-10898 Kill simulator Xcode6 style

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-10898 Kill simulator Xcode6 style

2016-04-12 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-medic/pull/88 CB-10898 Kill simulator Xcode6 style You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-medic CB-10898 Alternatively you can

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-medic/pull/86#issuecomment-209170685 @dblotsky yeah, might be a good idea to add both, since the former string handles Xcode 6 if someone were to be still using it. --- If your project is set up for

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-12 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209169845 For more details, see: https://issues.apache.org/jira/browse/CB-10873 --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-12 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/205#issuecomment-209168919 What happens is that when trying to write the image source, we do it with a null/nil variable ```self.data```: https://github.com/omefire/cordova-plu

[GitHub] cordova-plugin-camera pull request: CB-10873 Avoid crash due to us...

2016-04-12 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/205 CB-10873 Avoid crash due to usage of uninitialized variable when writ… …ing geolocation data to image destination You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

2016-04-12 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59477164 --- Diff: jsdoc2md/TEMPLATE.md --- @@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozil

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

2016-04-12 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59476286 --- Diff: jsdoc2md/TEMPLATE.md --- @@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozil

[GitHub] cordova-plugin-camera pull request: Added Sample section to the Ca...

2016-04-12 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/203#discussion_r59475889 --- Diff: jsdoc2md/TEMPLATE.md --- @@ -203,3 +203,194 @@ Tizen only supports a `destinationType` of [web_activities]: https://hacks.mozil

[GitHub] cordova-medic pull request: Add medic command to download BuildBot...

2016-04-12 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-medic/pull/87 Add medic command to download BuildBot CI logs You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic downloadLog Alte

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/425#issuecomment-209148999 @vladimir-kotikov updated to address feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-plugin-media pull request: get stream buffer data in perce...

2016-04-12 Thread alienslab02
GitHub user alienslab02 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/91 get stream buffer data in percent feature added I have added this feature in this plugin. Please review and accept this pull request. You can merge this pull request into a Git rep

[GitHub] cordova-docs pull request: CB-11001 Incorrect docs - "FullScreen" ...

2016-04-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/576#issuecomment-209119380 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-docs pull request: CB-11064: Adding a note to the engine t...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-11064: Adding a note to the engine t...

2016-04-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/577#issuecomment-209116138 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

RE: Roadmap for next few weeks - Microsoft - April Edition

2016-04-12 Thread Nikhil Khandelwal
Yes, I noticed these updates too. I plan to reach out to Eddy to see if we can consolidate fixes into one github repo here[1]. We're fixing Windows implementation in that repo. [1]: https://github.com/phonegap/phonegap-plugin-barcodescanner -Nikhil -Original Message- From: julio cesar

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

2016-04-12 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-cli/pull/244 CB-11042: Add cordova run option to skip prepare Parse and document a --noprepare option for the cordova run command. See https://github.com/apache/cordova-lib/pull/426 for the corresp

[GitHub] cordova-lib pull request: CB-11042: Add cordova run option to skip...

2016-04-12 Thread jasongin
GitHub user jasongin opened a pull request: https://github.com/apache/cordova-lib/pull/426 CB-11042: Add cordova run option to skip prepare I'm also submitting a PR for the cordova-cli repo to parse and document the --noprepare option. You can merge this pull request into a Git rep

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/86#issuecomment-209098826 @omefire please add both `"iOS Simulator"` and `"Simulator"` to that array. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: CB-6498 Misleading docum...

2016-04-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/97 CB-6498 Misleading documentation in Android Quirks [Jira issue](https://issues.apache.org/jira/browse/CB-6498) This is constantly causing confusion: http://stackoverf

[GitHub] cordova-plugin-contacts pull request: CB-11043: Android App crashe...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-docs pull request: CB-11070 Document SplashScreenBackgroun...

2016-04-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/578 CB-11070 Document SplashScreenBackgroundColor Also documented Windows-specific transparent BackgroundColor [Jira issue](https://issues.apache.org/jira/browse/CB-11070) You can merge t

[GitHub] cordova-plugin-media pull request: Request audio focus when playin...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-docs pull request: CB-11064: Adding a note to the engine t...

2016-04-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-docs/pull/577#issuecomment-209042894 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-file-transfer pull request: CB-9600 FileUploadOptio...

2016-04-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/121#issuecomment-209040166 App JS code with FileUploadOptions would be useful too. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-file-transfer pull request: CB-9600 FileUploadOptio...

2016-04-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/121#issuecomment-209038768 @mirko77 Please provide more details, and repro steps in JIRA [ https://issues.apache.org/jira/browse/CB-9600 ] Where are you posting

[GitHub] cordova-plugin-file-transfer pull request: CB-9600 FileUploadOptio...

2016-04-12 Thread mirko77
Github user mirko77 commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/121#issuecomment-209035343 I am still having the issue using the plugin version 1.5 on iOS 9.2.1 POST request is empty, FILE is ok --- If your project is set up for

[GitHub] cordova-docs pull request: CB-11001 Incorrect docs - "FullScreen" ...

2016-04-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-docs/pull/576#issuecomment-209030235 Updated, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-docs pull request: CB-11064: Adding a note to the engine t...

2016-04-12 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/577 CB-11064: Adding a note to the engine tag spec and fixing a header @nikhilkh when you have a moment You can merge this pull request into a Git repository by running: $ git pull https://gi

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: CB-10957 Remove build-*.xcconfig files f...

2016-04-12 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-ios/pull/214#issuecomment-209017316 @shazron I'm merging this in. I've addressed your CR notes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/86#issuecomment-209016620 LGTM, --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-docs pull request: CB-10996 Updating docs index page to ma...

2016-04-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/575#issuecomment-209013648 @dblotsky why change the headers from what's in the TOC? It might be a little weird to have two links on the page with different text going to the same place. Same

[GitHub] cordova-medic pull request: CB-10898 Kill iOS Simulator, Xcode7 st...

2016-04-12 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-medic/pull/86 CB-10898 Kill iOS Simulator, Xcode7 style With Xcode7, the way to kill the simulator is now by running: "killall -9 Simulator" You can merge this pull request into a Git repository by running

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/425#issuecomment-209011899 @vladimir-kotikov To clarify the plugin mapper comments: I left in the scope with the intention that the mapping would fail if the scope was present. I don't think

[GitHub] cordova-docs pull request: CB-11001 Incorrect docs - "FullScreen" ...

2016-04-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/576#issuecomment-209011002 LGTM otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59412823 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -410,6 +422,9 @@ function getPluginVariables(variables){ } function getVersionFromConfi

[GitHub] cordova-docs pull request: CB-11001 Incorrect docs - "FullScreen" ...

2016-04-12 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/576#discussion_r59412777 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -255,7 +255,7 @@ platform. See [Customize icons topic](images.html) for more information.

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59412652 --- Diff: cordova-lib/src/cordova/util.js --- @@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) { }); }); }

[GitHub] cordova-ios pull request: CB-11069 - CDVViewController appURL is n...

2016-04-12 Thread mirkoluchi
GitHub user mirkoluchi opened a pull request: https://github.com/apache/cordova-ios/pull/217 CB-11069 - CDVViewController appURL is nil if wwwFolderName is the path to a framework Fix -[CDVViewController appUrl] method to take into account a wwwFolderName which is a framework You

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

2016-04-12 Thread Mikael Kindborg
Many thanks for merging :) On 12 April 2016 at 08:06, Dmitry Blotsky wrote: > I’ve merged the PR. The change will go live the next time anyone does a > website deployment. > > Kindly, > Dmitry > > > On Apr 11, 2016, at 4:20 PM, Shazron wrote: > > > > Layout wise, it could get ugly (thus the ran

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-04-12 Thread mikaelkindborg
Github user mikaelkindborg closed the pull request at: https://github.com/apache/cordova-docs/pull/410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

2016-04-12 Thread mikaelkindborg
Github user mikaelkindborg commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-208893125 @dblotsky Many thanks indeed for merging! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-ios pull request: CB-6992 Fix non-working create case, add...

2016-04-12 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-ios/pull/216 CB-6992 Fix non-working create case, add new test Added name normalization from prepare to createProject in order to support the case where the user edits name in config.xml, then adds ios platf

[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...

2016-04-12 Thread akofman
Github user akofman closed the pull request at: https://github.com/apache/cordova-ios/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: Roadmap for next few weeks - Microsoft - April Edition

2016-04-12 Thread julio cesar sanchez
Hello Parashuram. I find your mails useful. About the BarcodeScanner plugin, this weekend I saw that Eddy updated one, not sure if that's the same that you are planning to work on https://github.com/Telerik-Verified-Plugins/BarcodeScanner 2016-04-07 20:46 GMT+02:00 Parashuram N : > Hey folks, >

[GitHub] cordova-docs pull request: CB-11001 Incorrect docs - "FullScreen" ...

2016-04-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/576 CB-11001 Incorrect docs - "FullScreen" config.xml preference only app… …lies to Android [Jira issue](https://issues.apache.org/jira/browse/CB-11001) You can merge this pull reques

[GitHub] cordova-js pull request: Update Cordova.js

2016-04-12 Thread chander12shekhar
GitHub user chander12shekhar opened a pull request: https://github.com/apache/cordova-js/pull/133 Update Cordova.js Updated link of platform js file You can merge this pull request into a Git repository by running: $ git pull https://github.com/chander12shekhar/cordova-js patch

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

2016-04-12 Thread Carlos Santana
I agree, it can be randomize when it becomes a problem or before if someone has some bandwidth - Carlos @csantanapr > On Apr 12, 2016, at 2:06 AM, Dmitry Blotsky wrote: > > I’ve merged the PR. The change will go live the next time anyone does a > website deployment. > > Kindly, > Dmitry >

[GitHub] cordova-lib pull request: CB-11022 Improve performance of `cordova...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/423#issuecomment-208828579 > do we also need changes to iOS and Windows platforms Exactly. Changes for windows and iOS is on their go --- If your project is set up for it, y

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/425#issuecomment-208825623 As a general comment, i'd love to see the methods for dealing with plugin spec returning a structured result instead of an array. This IMO would make the c

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59349270 --- Diff: cordova-lib/src/plugman/uninstall.js --- @@ -145,10 +145,9 @@ module.exports.uninstallPlugin = function(id, plugins_dir, options) {

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59347954 --- Diff: cordova-lib/src/plugman/install.js --- @@ -90,35 +90,37 @@ module.exports = function installPlugin(platform, project_dir, id, plugins_

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59347577 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -205,8 +206,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) { // Helper functi

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59346334 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -132,8 +132,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59345185 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -410,6 +422,9 @@ function getPluginVariables(variables){ } function getVersion

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59339491 --- Diff: cordova-lib/src/cordova/util.js --- @@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) { }); });

[GitHub] cordova-lib pull request: CB-10986: Adding support for scoped npm ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/425#discussion_r59339185 --- Diff: cordova-lib/src/cordova/util.js --- @@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) { }); });

[GitHub] cordova-lib pull request: CB-10975 Allow plugin path to be relativ...

2016-04-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/421#issuecomment-208765981 I think this is not a regression, since this code has been added recently in #363 (see the diff [here](https://github.com/MSOpenTech/cordova-lib/commit/45a

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

2016-04-12 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59334240 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre

[GitHub] cordova-plugin-file-transfer pull request: adding sample section t...

2016-04-12 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59332428 --- Diff: README.md --- @@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer) version of File, and you have pre