[GitHub] cordova-plugin-camera pull request #233: CB-11295 Add WP8.1 quirk when choos...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: CB-9963 iOS uuid should remain even after uninstall

okay, i respect all your suggestion, let's leave it unchanged. On Thu, Aug 25, 2016 at 5:32 AM Shazron wrote: > +1 leave unchanged. This is what Apple has intended, and going against the > spirit of what they intend and rocking the boat (so to speak) is fraught > with risk to the project. > > Th

Nightly build #111 for cordova has succeeded!

Nightly build #111 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/111/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-plugin-media issue #100: CB-7684: (iOS) Fix CDVSound killing all aud...

Github user tbrebant commented on the issue: https://github.com/apache/cordova-plugin-media/pull/100 What about this? Would it be possible to have a comment or an opinion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-plugin-media issue #101: CB-11409: (iOS) New method allowing to disa...

Github user tbrebant commented on the issue: https://github.com/apache/cordova-plugin-media/pull/101 What about this? Would it be possible to have a comment or an opinion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[iOS] Feature change - updates in config.xml

More details and discussion in: https://issues.apache.org/jira/browse/CB-11712 In brief, the proposed change is: changes in config.xml will not be allowed, and cordova will print an error, with instructions on what to do instead. The instructions will tell the user to do a `cordova platform rm io

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 @briananderson1222 this is a separate feature. currently we don't offer granularity for the fallback. could you file an issue at issues.cordova.io ? Thanks! --- If your pro

[GitHub] cordova-plugin-camera issue #197: [CB-5195][CB-4078]: correctOrientation not...

Github user stevengill commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/197 Hey! Just reviewed this and it looks good to me. Can you do one final rebase from master and I'll merge it in? --- If your project is set up for it, you can reply to this

Re: [Discuss] plugins release

PRs to review https://github.com/apache/cordova-plugin-contacts/pull/131 https://github.com/apache/cordova-plugin-camera/pull/229 2016-08-24 20:20 GMT+02:00 Steven Gill : > Hey Scott, > > Thanks for pointing out the PR. I'll take a look. > > The reality of the situation is that cordova has many r

[GitHub] cordova-plugin-camera issue #98: Camera permissions added

Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/98 I agree with @nikhilkh This should be added using a hook or your own plugin that just adds those permissions Can you close the PR? --- If your project is set up for it, y

[GitHub] cordova-plugin-camera pull request #230: CB-6708: [iOS]keep the metadata of ...

Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/230#discussion_r76150053 --- Diff: src/ios/CDVCamera.m --- @@ -240,13 +240,9 @@ - (void)alertView:(UIAlertView *)alertView clickedButtonAtIndex:(NSInteger)butto

[PULL REQUESTS] Platforms 24-08-2016

cordova-android --> 21 Pull Requests cordova-amazon-fireos --> 4 Pull Requests cordova-ios --> 4 Pull Requests cordova-windows --> 3 Pull Requests cordova-ubuntu --> 3 Pull Requests cordova-osx --> 1 Pull Requests cordova-wp8 --> 1 Pull Requests cordova-browser --> 1 Pull Requests cordova-tizen -->

[PULL REQUESTS] Plugins 24-08-2016

cordova-plugin-inappbrowser --> 30 Pull Requests cordova-plugin-camera --> 30 Pull Requests cordova-plugin-media --> 26 Pull Requests cordova-plugin-dialogs --> 18 Pull Requests cordova-plugin-file --> 18 Pull Requests cordova-plugin-splashscreen --> 15 Pull Requests cordova-plugin-contacts --> 15

[COHO] Pull request stats helper

As Steve has said, unfortunately our focus lately has been on platforms, not plugins. To help bring to light our PR workload, I worked on a feature to show PR stats in coho. See: See: https://github.com/apache/cordova-coho/pull/134 Typical usage: coho list-pulls --repo=plugins --stats-only --json

Re: CB-9963 iOS uuid should remain even after uninstall

+1 leave unchanged. This is what Apple has intended, and going against the spirit of what they intend and rocking the boat (so to speak) is fraught with risk to the project. That being said, you could put this feature into your own plugin -- fork the device plugin and call it something else. In th

[GitHub] cordova-plugin-inappbrowser issue #182: CB-11721 android: InAppBrowser histo...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/182 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/182/commits/9909b3509012df57921268a9295

Android InAppBrowser fix for history buttons (CB-11721 and PR 182)

Hi, I just opened PR 182 on cordova-plugin-inappbrowser to fix an issue with the Android InAppBrowser history buttons not reflecting the state of the content. Requesting for the ticket to be assigned to me and a code review when someone gets a chance: https://issues.apache.org/jira/browse/CB-1172

[GitHub] cordova-plugin-inappbrowser pull request #182: CB-11721 android: InAppBrowse...

GitHub user justforgolly opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/182 CB-11721 android: InAppBrowser history buttons fix ### Platforms affected Android ### What does this PR do? CB-11721 - back and forward history bu

[GitHub] cordova-coho pull request #134: CB-11749 - Added --stats-only, --json and --...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: [Discuss] plugins release

Hey Scott, Thanks for pointing out the PR. I'll take a look. The reality of the situation is that cordova has many repos and not enough committers currently. This leads to PRs sitting unreviewed. Plugin PRs are unique in that they can involve various different native language changes. This could

[GitHub] cordova-coho pull request #134: CB-11749 - Added --stats-only, --json and --...

GitHub user shazron opened a pull request: https://github.com/apache/cordova-coho/pull/134 CB-11749 - Added --stats-only, --json and --sort-ascending flag to list-pulls command --json only works with --stats-only and outputs the stats in JSON format (false by default). --sort-a

Re: CB-9963 iOS uuid should remain even after uninstall

I agree the current behaviour of device.uuid for iOS should remain unchanged. Simon Mac Donald http://hi.im/simonmacdonald On Wed, Aug 24, 2016 at 12:53 PM, Kerri Shotts wrote: > I’ve got multiple cents worth of opinions on this one, so bullet points > (each worth 2¢): > > Persistent UUID is (

Re: CB-9963 iOS uuid should remain even after uninstall

I’ve got multiple cents worth of opinions on this one, so bullet points (each worth 2¢): Persistent UUID is (IMNSHO) anti-user and bad for privacy. I’ve yet to see a good reason why this would be a good thing to support, and I’m glad Apple doesn’t let apps get it anymore. As such, I’m OK with t

[GitHub] cordova-plugin-media issue #104: Acc+

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/104 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/2491782b544230046f090ae7bc964d9f208a7c69)

[GitHub] cordova-plugin-media pull request #111: CB-11754 (Android) Fixed the build e...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-media pull request #111: CB-11754 (Android) Fixed the build e...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/111 CB-11754 (Android) Fixed the build error ### Platforms affected Android ### What does this PR do? https://issues.apache.org/jira/browse/CB-11754 Fixes a build-tim

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

Github user briananderson1222 commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Nice work! Due to some problems with WKWebView in iOS9 namely https://issues.apache.org/jira/browse/CB-10732?jql=project%20%3D%20CB%20AND%20labels%20%3D%20wkwebview-k

[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...

Github user swbradshaw commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/170 Someone needs to take a look at all the open camera PR. There are many problems with this getRealPath and it has been discussed in a few places. It seems like this PR helps out a l

[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...

Github user davidbarre commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/170 #160 #155 #149 #148 #93 are close #143 #112 are still opened So what is the status of this PR ? A bag of thing are in master branch ? is next release planified ? -

[GitHub] cordova-plugin-camera issue #170: Fix FileHelper / port cordova-plugin-filep...

Github user davidbarre commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/170 any update on this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cordova-plugin-camera issue #233: CB-11295 Add WP8.1 quirk when choosing ima...

Github user sgrebnov commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/233 :+1: LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: [Discuss] plugins release

Hi Steven - Can you look at camera PR 197 ? This addresses a major bug in the Android camera plugin where it won't rotate pictures chosen from the library. This bug has been around since Android 4.4 was released. I worked on this at the beg

Re: [Discuss] plugins release

On Wed, Aug 24, 2016 at 1:16 AM, Steven Gill wrote: > Thoughts? Any PRs to bring to my attention? > definitely yes for Ubuntu, we have a bundle of core plugins to release, > > Will aim to start it later this week. > sound like a good ETA, please keep up in the loop to make sure that we are re

[GitHub] cordova-plugin-media issue #87: Fix for CB-10882 : Plugin Media - "cordova-p...

Github user bau720123 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/87 2 months passed anything wrong ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-media issue #104: Acc+

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/104 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/104/commits/4d7aabb74a39bdfad0969915377e73106803cdf8)

[GitHub] cordova-plugin-media pull request #109: CB-11086 (Android) Fixed a crash whe...

Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-media pull request #93: Protect setVolume call in case Player...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-media issue #109: CB-11086 (Android) Fixed a crash when setVo...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/109 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/109/commits/67166333ebbbc1b8ac27e6825a7d73be30cea255)

Re: Can't visit the issues.apache.org

wow, when i click the url you give, it seems fine now. i can visit the website now, thanks!!! On Wed, Aug 24, 2016 at 4:26 PM Shazron wrote: > No idea. Try filing an INFRA issue: > http://issues.apache.org/jira/browse/INFRA > > On Wed, Aug 24, 2016 at 12:40 AM, Zam Light wrote: > > > i had been

Re: Can't visit the issues.apache.org

No idea. Try filing an INFRA issue: http://issues.apache.org/jira/browse/INFRA On Wed, Aug 24, 2016 at 12:40 AM, Zam Light wrote: > i had been visit the website: *issues.apache.org/jira > *once, > but, i can't visit it anymore. always return refuse connection erro

Re: CB-9963 iOS uuid should remain even after uninstall

i knew apple restricted the real uuid usage, but let's minimize the thing, other platform seems to return reliable unique uuid per device with same user, and iOS return a different behavior in uninstall and reinstall situation. it looks little weird when use plugin because of different behavior. h

Can't visit the issues.apache.org

i had been visit the website: *issues.apache.org/jira *once, but, i can't visit it anymore. always return refuse connection error. i try to use different network, and it worked, then i ask company mis team, they suggest me to ask, Did there any chance that *issues.a

[GitHub] cordova-plugin-media issue #110: CB-11085 (Android) Fixed AudioHandler logs ...

Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/110 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/110/commits/c1c01b1834e1a37158b6de247ac444a1d49fbdbf)

[GitHub] cordova-plugin-media issue #109: CB-11086 (Android) Fixed a crash when setVo...

Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-media/pull/109 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish