Re: [DISCUSS] Plugins release

2015-02-04 Thread Andrew Grieve
, Feb 4, 2015 at 11:56 AM, Andrew Grieve agri...@chromium.org wrote: I'll start going through easy PRs now, and will hopefully start a vote around 9PM EST tonight. But... Anyone want to call out things re: plugins before doing a release?

Re: File Transfer plugin and Crosswalk engine cookies

2015-02-04 Thread Andrew Grieve
: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, January 28, 2015 10:46 PM To: dev Subject: Re: File Transfer plugin and Crosswalk engine cookies --webview=crosswalk sounds good. All it will do is add the plugin On Tue, Jan 27, 2015 at 4:09 PM

Re: [cordova-android] Commit related to CB-8317 brings issue reported in CB-7371

2015-02-04 Thread Andrew Grieve
Hmm, just had a look at the bug and it's not obvious to me what the problem is? Is there a stack trace for the crash? Is there a known fix for it that doesn't involve not sending the exit event? On Fri, Jan 23, 2015 at 7:24 PM, Martin Gonzalez martin.c.glez.g...@gmail.com wrote: Right, an

[VOTE] Plugins Release

2015-02-04 Thread Andrew Grieve
Please review and vote on the release of this plugins release. Release issue: https://issues.apache.org/jira/browse/CB-8429 (contains release notes for all plugins) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8429/ The packages were published from

Re: [DISCUSS] cordova-ios 3.8.0 release

2015-02-03 Thread Andrew Grieve
I know you've been single-handing iOS lately, so thanks for your hard work Shaz! Your list sounds well thought-out, and I've not got anything to add other than +1! On Tue, Feb 3, 2015 at 8:42 PM, Shazron shaz...@gmail.com wrote: Bug fix release. The two major fixes that are already in are:

[Vote] 3.7.1 Android Release

2015-02-03 Thread Andrew Grieve
Please review and vote on this 3.5.0 Android Release. Release issue: https://issues.apache.org/jira/browse/CB-8415 Repos ready to be released have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8415 The package was published from its corresponding git tag:

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Andrew Grieve
Did some pruning: https://github.com/cordova/apache-blog-posts/pull/30 On Tue, Feb 3, 2015 at 8:55 AM, Michal Mocny mmo...@chromium.org wrote: Its nice when people have a place to look up what changed when they notice a new version is out. (Also, when we do a tools release and updated pinned

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-02-03 Thread Andrew Grieve
And, of course, for your FileTransfer change :P I just last night finished up the fixing of framework custom=false for gradle-based builds, so we're certainly nearing the finish line for 4.0.0 known issues. Of the list from before, only remaining are: - Ian's been working on getting crosswalk

Found a regression in cordova-android@3.7.0

2015-02-03 Thread Andrew Grieve
Regression: https://issues.apache.org/jira/browse/CB-8411 Already applied the fix to the 3.7.x branch (and to master). Question is whether we should skip pinning of 3.7.0, and go straight to 3.7.1? Wouldn't take much extra effort, but we should hold off the blog post though. The bug breaks

Re: [Review] Plugins Package.json

2015-02-03 Thread Andrew Grieve
From looking at it, only thought is whether we should put all of the non-standard fields into a cordova parent key. E.g.: { name: cordova-plugin-device, cordova: { id: org.apache.cordova.device, platforms: [...] } } Sounds like we need to re-write the file when publishing to CPR

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Andrew Grieve
following completion of 3.7.1 vote with 3.7.1 pinned. On Tue, Feb 3, 2015 at 1:09 PM, Andrew Grieve agri...@chromium.org wrote: Regression: https://issues.apache.org/jira/browse/CB-8411 Already applied the fix to the 3.7.x branch

Re: JavaScript comment tags in FileSystem plugin distort, www/*.js: What tool are they designed for?

2015-02-02 Thread Andrew Grieve
I'm fairly certain that they've never been run through a tool :S On Mon, Feb 2, 2015 at 4:27 PM, Joe Malin jma...@exou.com wrote: Greetings! I’m looking at the JavaScript libraries distributed in the FileSystem plugin, org.apache.cordova.file, www/*.js, such as FileEntry.js. They contain

Re: Usage of jscs JSHint in Cordova

2015-02-02 Thread Andrew Grieve
I find the jshint task super helpful when making changes to cordova-lib. Would love it if it appeared in the platforms as well! On Mon, Feb 2, 2015 at 12:17 PM, Murat Sutunc mura...@microsoft.com wrote: Now that cordova-lib is done, I'm considering extending the jshint support to individual

Re: ApacheCon NA, Austin, April 13-16

2015-01-31 Thread Andrew Grieve
developing on Cordova a more coherent experience. Going to cover git workflow, coho commands, --link and IDEs, CIs, Testing via windows VM. On Fri, Jan 9, 2015 at 11:39 AM, Joe Bowser bows...@gmail.com wrote: Is this a troll post? On Fri, Jan 9, 2015, 8:21 AM Andrew Grieve agri...@chromium.org wrote

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-30 Thread Andrew Grieve
if they are already inheriting from another activity, and how are they supposed to use a CordovaWebView in that case? On Fri Jan 30 2015 at 7:29:39 AM Andrew Grieve agri...@chromium.org wrote: Just ran them and see no difference in failures with/without change. Did need to update two spots

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-30 Thread Andrew Grieve
the feature that caused the JUnit tests to exist in the first place. On Thu, Jan 29, 2015, 6:12 PM Andrew Grieve agri...@chromium.org wrote: On Wed, Jan 28, 2015 at 3:32 PM, Andrew Grieve agri...@chromium.org wrote: On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote

Re: Monthly Hangouts - Jan 2015 Edition

2015-01-29 Thread Andrew Grieve
/admin#admin. DO NOT use this link for scheduling, only use it to make changes or administer the doodle. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 20, 2015 1:07 PM To: dev Subject

Re: Monthly Hangouts - Jan 2015 Edition

2015-01-29 Thread Andrew Grieve
Join link: https://plus.google.com/hangouts/_/hoaevent/AP36tYdg1TEGBj7g7YtmTEAJ3MIGgM6kVEllvre_Rvj7g285xqPfmQ?authuser=0hl=en-GB View-only link: http://youtu.be/NAYhX--EdMY (will not be activated until people join and I click go) On Thu, Jan 29, 2015 at 12:52 PM, Andrew Grieve agri

cordova-lib version == cordova-cli version?

2015-01-29 Thread Andrew Grieve
Just filed https://issues.apache.org/jira/browse/CB-8379, and implemented locally and noticed that right now cli.version == lib.version. Wondering if this is on purpose or coincidence? If CLI version is always == lib version, then there's no need to print out both versions.

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-29 Thread Andrew Grieve
On Wed, Jan 28, 2015 at 3:32 PM, Andrew Grieve agri...@chromium.org wrote: On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote: On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org wrote: - Make CordovaActivity not implement CordovaInterface, but instead

Re: cordova-lib version == cordova-cli version?

2015-01-29 Thread Andrew Grieve
:30 PM, Steven Gill stevengil...@gmail.com wrote: That is true. Both are the same. On Jan 29, 2015 1:15 PM, Andrew Grieve agri...@chromium.org wrote: Just filed https://issues.apache.org/jira/browse/CB-8379, and implemented locally and noticed that right now cli.version

Re: [iOS] Merging cordova-ios/wkwebview branch into the mainline

2015-01-29 Thread Andrew Grieve
Sounds good! I think a 3.8.0 would be warranted if only to fix the new-iframe-for-every-exec bug. WDYT? On Thu, Jan 29, 2015 at 7:48 PM, Shazron shaz...@gmail.com wrote: Reviving this thread. After the hangout today, the proposal now is: 1. Integrate the wkwebview (pluggable webviews) branch

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Andrew Grieve
On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote: On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org wrote: - Make CordovaActivity not implement CordovaInterface, but instead provide CordovaInterface via an inner class (to solidify that you can't

Re: So...can we merge 4.0.x into master yet?

2015-01-28 Thread Andrew Grieve
Merged 4.0.x in. On Mon, Jan 26, 2015 at 2:27 PM, Joe Bowser bows...@gmail.com wrote: Well, I think we NEED to support third-party WebViews as a first step. If I don't hear any objections, I'm going to merge 4.0.x into master tomorrow, and start a discuss thread for the 4.0.x release. I

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Andrew Grieve
I'd prefer to go the other way, and change AndroidWebView to composition. It's more flexible and does a better job of splitting up groups of APIs. On Wed, Jan 28, 2015 at 12:49 AM, Hu, Ningxin ningxin...@intel.com wrote: Hi Joe, The tests don't work with Crosswalk because Crosswalk's main

Re: Cordova plugin namespace

2015-01-28 Thread Andrew Grieve
I don't think the URL ever existed. XML namespace URLs don't need to actually exist IIRC. They are just identifiers. On Tue, Jan 27, 2015 at 6:07 PM, John M. Wargo j...@johnwargo.com wrote: Looking at the plugin guide at http://cordova.apache.org/ docs/en/4.0.0/plugin_ref_spec.md.html the

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-28 Thread Andrew Grieve
, at 12:29 PM, Jesse purplecabb...@gmail.com wrote: If you know there will be more, wouldn't it be simpler to just do something like : --webview=crosswalk // ? Just a small thing. @purplecabbage risingj.com On Tue, Jan 27, 2015 at 12:23 PM, Andrew Grieve agri...@chromium.org

Re: Build signed archives using CLI

2015-01-28 Thread Andrew Grieve
in the google doc in this thread. We can start from there and try to make this happen for a future release. Thoughts before adding it to the agenda? 2015-01-26 20:08 GMT-06:00 Andrew Grieve agri...@chromium.org: In anyone interested in working on any of this? Was just looking

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Andrew Grieve
is less straightforward than embedding AndroidWebView or MozillaWebView. On Wed Jan 28 2015 at 10:07:18 AM Andrew Grieve agri...@chromium.org wrote: You can still embed a view using composition. We are not providing any backwards compatibility right now, even with inheritance, because

Re: cordova-android 4.0 JUnit tests

2015-01-28 Thread Andrew Grieve
where I show how to embed a CordovaWebView, so people have been using this feature. On Wed Jan 28 2015 at 6:49:18 AM Andrew Grieve agri...@chromium.org wrote: I'd prefer to go the other way, and change AndroidWebView to composition. It's more flexible and does a better job of splitting up

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-01-28 Thread Andrew Grieve
Things i think we should still wait for: - Ian's been working on getting crosswalk 10 working and is hitting some FileTransfer crash issues. - Mobilespec really should be passing, let's investigate and fix plugins / tests if they are the issues. - Android's update script is not preserving

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Andrew Grieve
Andrew Grieve agri...@chromium.org wrote: Sounds good. We should add a --crosswalk flag to createmobilespec.sh :) On Tue, Jan 27, 2015 at 2:07 AM, Hu, Ningxin ningxin...@intel.com wrote: Hi Joe, Crosswalk has its own release schedule, so it should have its own test project

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-27 Thread Andrew Grieve
waiting for this to be done before starting the vote thread. Does this code exist yet? On Tue Jan 20 2015 at 12:12:22 PM Andrew Grieve agri...@chromium.org wrote: I was planning on doing exactly what Darryl described. Would love such a PR! Note that we've just used

Re: Odd EOL in files in newly cloned repo

2015-01-26 Thread Andrew Grieve
Likely related to this file being added recently: https://github.com/apache/cordova-docs/blob/master/.gitattributes On Fri, Jan 23, 2015 at 5:15 PM, Jesse purplecabb...@gmail.com wrote: Odd. There appears to be an issue with how these files were checked in. Normally only text files have this

Re: FYI: Created a plugin to help with local plugin development

2015-01-26 Thread Andrew Grieve
will be reflected in cordova-ios, cordova-android, cordova-plugin-foo* repos! Also - looks like I had accidentally hardcoded --browserify to be on on Thursday. Fixed now, but if you noticed mobilespec being funny, it's because --browserify was on. On Thu, Jan 22, 2015 at 10:30 PM, Andrew Grieve agri

Re: Build signed archives using CLI

2015-01-26 Thread Andrew Grieve
maybe that is not desirable, using config.xml. We will need to provide the password each time at least for iOS, since we need to unlock the keychain for code signing. On Thu, Oct 9, 2014 at 11:25 AM, Andrew Grieve agri...@chromium.org wrote: The prompting is actually

Re: FYI: Created a plugin to help with local plugin development

2015-01-26 Thread Andrew Grieve
...@google.com] On Behalf Of Andrew Grieve Sent: Monday, January 26, 2015 8:50 AM To: Andrew Grieve Cc: dev Subject: Re: FYI: Created a plugin to help with local plugin development And... now: createmobilespec.sh --linkplatforms and createmobilespec.sh --link

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-26 Thread Andrew Grieve
Go for it! On Mon, Jan 26, 2015 at 7:13 PM, Darryl Pogue dvpdin...@gmail.com wrote: On 26 January 2015 at 15:54, Joe Bowser bows...@gmail.com wrote: As far as I'm aware, we're basically waiting for this to be done before starting the vote thread. Does this code exist yet? Not yet on my

Re: So...can we merge 4.0.x into master yet?

2015-01-23 Thread Andrew Grieve
Not sure what the JB fiasco is, but merging SGTM. We can always work off of 3.7.x if we end up needing another 3.x release. On Fri, Jan 23, 2015 at 1:51 PM, Joe Bowser bows...@gmail.com wrote: Hey So, now that 3.7.0 is mostly out the door (dealing with npm stuff now), I think we should talk

Re: FYI: Created a plugin to help with local plugin development

2015-01-22 Thread Andrew Grieve
reflected in your local cordova-plugin-foo directories Also added: createmobilespec.sh --browserify which does what you think it does. On Mon, Jan 5, 2015 at 9:49 PM, Andrew Grieve agri...@chromium.org wrote: Thought about Windows, but didn't test on it. Figured since --link was a hot-off

Re: [VOTE] 3.7.0 Android Platform release

2015-01-22 Thread Andrew Grieve
+1 - Created test project from archive (with cli and via bin/create) and ensured it built via ant gradle. On Thu, Jan 22, 2015 at 7:46 PM, Jesse purplecabb...@gmail.com wrote: +1 - ran coho verify-archive - ran coho verify-tags = Tag hash verified. @purplecabbage risingj.com On Thu,

Remove CDVJson.h from Copy Headers?

2015-01-21 Thread Andrew Grieve
RE: https://github.com/apache/cordova-ios/commit/a98144b8ad63fe714c9f6d274bc9fd98b62575e7 issue: https://issues.apache.org/jira/browse/CB-8270 We had an unprefixed extension, and prefixing it is a breaking change (e.g. CDVInAppBrowser was using it). It really is the right thing to do though...

Re: cordova-android 4.0 JUnit tests

2015-01-21 Thread Andrew Grieve
a layout.xml that uses a Crosswalk webview as well, and then skip the test if the crosswalk plugin is not compiled in Thanks, Junwei. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Wednesday, January 21, 2015 4:01 AM

Re: Adding ability to add any platform on any OS

2015-01-21 Thread Andrew Grieve
and sent out as a PR. Thanks, Nikhil -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, January 19, 2015 8:59 AM To: dev Subject: Re: Adding ability to add any platform on any OS Wondering if there's been progress

Re: cordova-android 4.0 JUnit tests

2015-01-20 Thread Andrew Grieve
I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio / Gradle world. I'll have another crack at it. On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser bows...@gmail.com wrote: The tests

Re: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-20 Thread Andrew Grieve
with this release? If so, then I want to make sure I could put more translation together with this release. For example could translate and proofread Android section. 2015-01-20 9:31 GMT+06:00 Andrew Grieve agri...@chromium.org: It hadn't been pulled in, but now has! One more we might want

Re: cordova-android 4.0 JUnit tests

2015-01-20 Thread Andrew Grieve
, but that can wait until after 4.0.x is released. On Tue Jan 20 2015 at 9:30:14 AM Andrew Grieve agri...@chromium.org wrote: I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio

Re: cordova-android 4.0 JUnit tests

2015-01-20 Thread Andrew Grieve
Also - maybe leave the inflate test using AndroidWebView, and make the other ones create dynamically? On Tue, Jan 20, 2015 at 2:59 PM, Andrew Grieve agri...@chromium.org wrote: gotcha. I've now got tests building running with gradle (painful learning curve...). I'm going to pull

Re: File Transfer plugin and Crosswalk engine cookies

2015-01-20 Thread Andrew Grieve
I was planning on doing exactly what Darryl described. Would love such a PR! Note that we've just used this approach for the new WebView security hooks: https://github.com/apache/cordova-android/commit/623b394c830b8a83b5c2f16624d8013b6f851cd9

Re: Monthly Hangouts - Jan 2015 Edition

2015-01-20 Thread Andrew Grieve
There's no account. (don't think doodle requires sign-up) On Tue, Jan 20, 2015 at 3:33 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Hi, It has been a while since we had a hangouts, and a lot of folks have suggested that there are topics that could use a hangout. Thanks

Re: platforms/plugins save and restore from config.xml

2015-01-19 Thread Andrew Grieve
could volunteer to start the doodle and set up the date and time if people agree that we should do a hangout. This would be one of the topics we could discuss. On 1/17/15, 6:01 PM, Andrew Grieve agri...@chromium.org wrote: Both proposals are sounding quite good to me at this point! There's

Re: Problem on download file named with @

2015-01-19 Thread Andrew Grieve
May also work to change your @ symbol to a %40. On Mon, Jan 19, 2015 at 7:18 AM, Michael Kurek ku...@intuilab.com wrote: Hi ! To begin, I want to congratulate you for your great job ! I send you this email because I have a trouble to download some files. Since the last change of the

Re: Adding ability to add any platform on any OS

2015-01-19 Thread Andrew Grieve
Wondering if there's been progress for rewriting ios scripts in node? Is there a JIRA for it? On Fri, Nov 7, 2014 at 9:42 AM, Marcel Kinard cmarc...@gmail.com wrote: Exactly. On Nov 5, 2014, at 6:44 PM, Andrew Grieve agri...@chromium.org wrote: That's my understanding. Don't do check_reqs

Re: platforms/plugins save and restore from config.xml

2015-01-17 Thread Andrew Grieve
that you need to use the save/restore command options if you want to do any operations outside of the IDE!. Leo -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 6:57 AM To: Gorkem Ercan Cc: dev

Re: Thought on improving translation and docs

2015-01-16 Thread Andrew Grieve
merged On Fri, Jan 16, 2015 at 1:06 PM, Andrey Kurdumov kant2...@googlemail.com wrote: First tool which is could verify links in translation is ready. Pull request is ready https://github.com/apache/cordova-docs/pull/260 . 08 Янв 2015 г. 11:31 пользователь Andrey Kurdumov

Re: Automatically installing missing platforms from cli

2015-01-15 Thread Andrew Grieve
is for this feature to be force pushed into `master` without a positive consensus. On Mon, Jan 12, 2015 at 9:02 AM, Andrew Grieve agri...@chromium.org wrote: On Sun, Jan 11, 2015 at 11:40 PM, Terence M. Bandoian tere...@tmbsw.com wrote: Creating directories and downloading and installing files

Re: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-15 Thread Andrew Grieve
let me know if it looks good now and could be included to release. https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 10:31 PM To: dev

Re: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-13 Thread Andrew Grieve
://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 6:17 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release +1 On Mon, Jan 12, 2015 at 6

Re: Introduction

2015-01-13 Thread Andrew Grieve
Welcome Nikhil! On Tue, Jan 13, 2015 at 4:59 PM, Steven Gill stevengil...@gmail.com wrote: Welcome Nikhil! On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Hi, I am an engineering manager at Microsoft leading a team working on Cordova. I have been

Re: Renaming CordovaWebView CordovaWebInterface

2015-01-13 Thread Andrew Grieve
Looking at our core plugins, several of them would break if we renamed this file. For that reason, I think keep it as-is for now. Here's my grep: http://pastebin.com/dqvyiMLS On Tue, Jan 13, 2015 at 7:30 PM, Josh Soref jso...@blackberry.com wrote: I'm not an Android developer, but I recently

Re: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-13 Thread Andrew Grieve
+1 On Mon, Jan 12, 2015 at 6:04 PM, Shazron shaz...@gmail.com wrote: +1 On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill stevengil...@gmail.com wrote: Do it! +1 On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser bows...@gmail.com wrote: Hey How do people feel about releasing 3.7.0 this

Re: platforms/plugins save and restore from config.xml

2015-01-12 Thread Andrew Grieve
Thanks for putting the doc together. Added some comments to it. On Mon, Jan 12, 2015 at 5:39 PM, Mefire O. ommen...@microsoft.com wrote: Google docs link : https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41V3-jFc/edit Thanks, Mefire -Original Message- From:

Re: Review: Tools release blog post

2015-01-12 Thread Andrew Grieve
On Mon, Jan 12, 2015 at 6:57 PM, Steven Gill stevengil...@gmail.com wrote: I see your point. We have chatted about moving platform specific JS into the platform repos for a while. I agree that is something we should do now. On Sat, Jan 10, 2015 at 5:27 PM, Andrew Grieve agri

Re: platforms/plugins save and restore from config.xml

2015-01-12 Thread Andrew Grieve
are listed in config.xml for backwards compat. On Mon, Jan 12, 2015 at 9:19 PM, Andrew Grieve agri...@chromium.org wrote: Thanks for putting the doc together. Added some comments to it. On Mon, Jan 12, 2015 at 5:39 PM, Mefire O. ommen...@microsoft.com wrote: Google docs link : https

Re: [DISCUSS] Plugins Release

2015-01-12 Thread Andrew Grieve
Only concern is: https://issues.apache.org/jira/browse/CB-8284 :( On Sat, Jan 10, 2015 at 6:36 AM, julio cesar sanchez jcesarmob...@gmail.com wrote: Well, if somebody can review the pull request I did some months ago for the dialogs plugin I'll be grateful

Re: Automatically installing missing platforms from cli

2015-01-12 Thread Andrew Grieve
-cli commands and their associated options? -Terence On 1/10/2015 7:38 PM, Andrew Grieve wrote: cordova run already builds before running (unless you add --nobuild). I think it'd be pretty annoying if we had run fail with a you need to build first kind of message. In my mind, cordova

Re: Automatically installing missing platforms from cli

2015-01-10 Thread Andrew Grieve
cordova run already builds before running (unless you add --nobuild). I think it'd be pretty annoying if we had run fail with a you need to build first kind of message. In my mind, cordova-cli's purpose is to add magic. Otherwise, you would just use plugman+platform scripts (and yes, some people

Re: Review: Tools release blog post

2015-01-10 Thread Andrew Grieve
like all of our other plugins? On Fri, Jan 9, 2015 at 11:50 AM, Andrew Grieve agri...@chromium.org wrote: On Fri, Jan 9, 2015 at 2:26 PM, Steven Gill stevengil...@gmail.com wrote: Thanks for PRs. Andrew, the browserify method builds a cordova-js for each of the installed

Re: Cordova --list option implementation

2015-01-09 Thread Andrew Grieve
I think 1.b sounds perfect. On Thu, Jan 8, 2015 at 5:48 PM, Murat Sutunc mura...@microsoft.com wrote: I think we have a couple of options here: Option 1 - Adding --list as an optional parameter to cordova run List is related to run and there’s not that much need to introduce another top

Re: MobileSpec for testing cordova-lib@rc

2015-01-09 Thread Andrew Grieve
On Thu, Jan 8, 2015 at 8:39 PM, Steven Gill stevengil...@gmail.com wrote: Just checked out peer-dependencies. Looks like the way to move forward with handling our dependency issues. Right now, plugman publish creates a package.json file by grabbing info from plugin.xml. Once published,

Re: platforms/plugins save and restore from config.xml

2015-01-09 Thread Andrew Grieve
Questions: Would ever not want to use --save? Why not just always update config.xml with what plugins you have? Likewise, would you ever not want to have --shrinkwrap? I think you'd always want the plugin/platform version listed in there. On Fri, Jan 9, 2015 at 1:46 AM, Mefire O.

ApacheCon NA, Austin, April 13-16

2015-01-09 Thread Andrew Grieve
http://events.linuxfoundation.org//events/apachecon-north-america/program/cfp Last year we had about a days worth of Cordova talks and ran a hackathon (thanks to IBM)! For me, the real value was in learning more about Apache, and getting to spend time with other committers. So... I still think

plugman publish is broken

2015-01-09 Thread Andrew Grieve
Speaking of not having to maintain our own registry Not sure if anyone that's touched the couch server has time to look at this: https://issues.apache.org/jira/browse/CB-8284 Seems that publishing always fails to add new tarballs when publishing a new version of an existing plugin. Would

Re: Review: Tools release blog post

2015-01-09 Thread Andrew Grieve
On Fri, Jan 9, 2015 at 2:26 PM, Steven Gill stevengil...@gmail.com wrote: Thanks for PRs. Andrew, the browserify method builds a cordova-js for each of the installed platforms (at prepare time) and copies it over into the platforms www directory (platforms/android/assets/www, etc). We

cordova-cli unit tests failing

2015-01-09 Thread Andrew Grieve
Steve - not sure if I'm npm linking wrong, but I've got cordova-js linked and tests are failing for me again. Same failures are showing on https://travis-ci.org/apache/cordova-lib

Re: Reviewboard

2015-01-08 Thread Andrew Grieve
easier to review I think. @purplecabbage risingj.com On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser bows...@gmail.com wrote: What's reviewboard? j/k, yeah kill it! On Wed Jan 07 2015 at 1:13:55 PM Andrew Grieve agri...@chromium.org wrote: Anyone still interested

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-08 Thread Andrew Grieve
your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve

Re: [Vote] Tools Release Jan 6, 2015

2015-01-08 Thread Andrew Grieve
node_modules) On 1/7/15, 7:24 PM, Mark Koudritsky kam...@google.com wrote: +1 Tests: - npm install -g cordova@rc - Built and ran the default HelloWorld app on Android - ran coho verify-tags On Wed, Jan 7, 2015 at 4:27 PM, Andrew Grieve agri...@chromium.org wrote: +1

Re: Cordova-Android 3.7.0 and 4.0.x releases.

2015-01-08 Thread Andrew Grieve
Yes! Sounds good to me! Although I'm not sure there's much point in creating the 3.7.x branch until CB-8026 is resolved and we set targetApi = 21 On Thu, Jan 8, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote: Sounds like this is all good. I'm going to create a 3.7.0 branch today and

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-08 Thread Andrew Grieve
Created issue for the splashscreen: https://issues.apache.org/jira/browse/CB-8280 On Thu, Jan 8, 2015 at 1:28 PM, Andrew Grieve agri...@chromium.org wrote: Yep! Will have a look at this. On Thu, Jan 8, 2015 at 11:57 AM, Joe Bowser bows...@gmail.com wrote: That said, the tests failing should

Re: MobileSpec for testing cordova-lib@rc

2015-01-08 Thread Andrew Grieve
Nice! Great example of how to use the JS API. On Thu, Jan 8, 2015 at 2:55 PM, Mark Koudritsky kam...@google.com wrote: Josh, thanks for the suggestion. Added it here https://github.com/kamrik/cordova-test-rc/commit/d3a1abeda45357c4cf32b28e6e63cc269d7d3bda as process.env.HOME =

Re: [Code Review] Gradle Changes

2015-01-08 Thread Andrew Grieve
On Thu, Jan 8, 2015 at 2:53 PM, Ian Clelland iclell...@chromium.org wrote: On Tue Jan 06 2015 at 4:09:47 PM Andrew Grieve agri...@chromium.org wrote: For anyone following the gradle work that's been happening, I have a PR that overhauls how settings are overridden. Rather than using custom

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Andrew Grieve
I never test on gingerbread. My opinion is that devs that really need it can just use older Cordova versions, or can fight through the testing themselves. With multi-apk support in the play store, you could even use a different version of Cordova for gingerbread vs. ICS+ On Wed, Jan 7, 2015 at

Reviewboard

2015-01-07 Thread Andrew Grieve
Anyone still interested in using ReviewBoard? I feel like we gave it a decent shot, but github pull requests are working better. If no one objects, I'm going to delete the .reviewboardrc files from the repos and update https://github.com/apache/cordova-coho/blob/master/docs/code-reviews.md

Re: [Vote] Tools Release Jan 6, 2015

2015-01-07 Thread Andrew Grieve
+1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` * Re-created archives to ensure contents match release candidate (did so for cordova-js and cordova-cli) On Tue, Jan 6, 2015 at 8:46 PM, Steven Gill stevengil...@gmail.com wrote: Please

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-07 Thread Andrew Grieve
Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-07 Thread Andrew Grieve
] Sent: Wednesday, January 07, 2015 10:54 AM To: dev@cordova.apache.org Subject: Re: How to test the cordova-android 4.0 by mobile spec So, it's not using the cordova that's installed locally via npm? I'll have to check that again. On Tue Jan 06 2015 at 6:33:14 PM Andrew Grieve agri

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-06 Thread Andrew Grieve
I think you had it right. use cordova-mobile-spec@master and cordova-android@4.0.x. Failing tests are likely issues (in android or in the tests). Just fixed last night that the JS on 4.0.x was not properly registering with the CoreAndroid plugin due to it being renamed, so that could be the cause

Auto-suffixing debug app id on Android

2015-01-06 Thread Andrew Grieve
With gradle, this is easy to do: android { buildTypes { debug { applicationIdSuffix .debug } Seems like a good idea to me, but I'm wondering if there may be reason not to?

[Code Review] Gradle Changes

2015-01-06 Thread Andrew Grieve
For anyone following the gradle work that's been happening, I have a PR that overhauls how settings are overridden. Rather than using custom environment variables, it uses Gradle properties. This is exactly what properties in gradle were designed for, and they are more flexible. I'd like 2

Re: Auto-suffixing debug app id on Android

2015-01-06 Thread Andrew Grieve
to be fleshed out more. On Tue Jan 06 2015 at 10:42:51 AM Andrew Grieve agri...@chromium.org wrote: Mainly - it allows it to be installed alongside the release version of the app. On Tue, Jan 6, 2015 at 11:01 AM, Brian LeRoux b...@brian.io wrote: Why is it a good idea? On Tue

Re: Remove onDestroy event/channel from cordova-js

2015-01-06 Thread Andrew Grieve
The channel is defined here: https://github.com/apache/cordova-js/blob/master/src/common/channel.js#L38 and clearly labeled as an internal event. I don't think it'd be considered an API change to remove it. On Tue, Jan 6, 2015 at 7:59 PM, Joe Bowser bows...@gmail.com wrote: Are we sure the

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-06 Thread Andrew Grieve
mobile-spec working reliably since it was refactored and we were forced to use the createmobilespec.sh script (i.e. Tests don't run on Android 2.3) How did you manage to get it to work with 4.0.x? On Tue Jan 06 2015 at 6:24:51 AM Andrew Grieve agri...@chromium.org wrote: I think you had

Re: Cordova-lib failing on master (stopping release)

2015-01-06 Thread Andrew Grieve
Gar, thanks for reverting and moving on. Sorry for not running tests :( On Tue, Jan 6, 2015 at 5:54 PM, Steven Gill stevengil...@gmail.com wrote: Yup. I reverted to that commit. Pushed to master. Continuing with release. On Tue, Jan 6, 2015 at 2:46 PM, Mark Koudritsky kam...@google.com wrote:

Re: Auto-suffixing debug app id on Android

2015-01-06 Thread Andrew Grieve
Mainly - it allows it to be installed alongside the release version of the app. On Tue, Jan 6, 2015 at 11:01 AM, Brian LeRoux b...@brian.io wrote: Why is it a good idea? On Tue, Jan 6, 2015, 7:40 AM Andrew Grieve agri...@google.com wrote: With gradle, this is easy to do: android

Re: Happy New Year! Let's do stuff!

2015-01-05 Thread Andrew Grieve
on releasing 3.7.0 with targetSdk=21, I think the only issue to fix is CB-8026 (which we can just call the setter and be done with it). On Mon, Jan 5, 2015 at 4:02 PM, Joe Bowser bows...@gmail.com wrote: On Mon Jan 05 2015 at 11:51:44 AM Andrew Grieve agri...@chromium.org wrote: Woohoo! Google

Re: [DISCUSS] Tools Release

2015-01-05 Thread Andrew Grieve
Josh - thanks for pointing out that the change isn't working as intended. I did some testing before merging, but didn't try the error conditions. I've just reverted the one to CLI that enables the flag. Let's move forward with releasing :) Also noticed that if you have an older-than-master

Re: FYI: Created a plugin to help with local plugin development

2015-01-05 Thread Andrew Grieve
/installing @purplecabbage risingj.com On Mon, Jan 5, 2015 at 12:56 PM, Andrew Grieve agri...@chromium.org wrote: Along these lines, I likewise got frustrated with my workflow and added a new feature to cordova plugin add --link. Instead of just creating symlink in the plugins

Re: Happy New Year! Let's do stuff!

2015-01-05 Thread Andrew Grieve
Woohoo! Google team's back this week as well! For 4.0.x - let's enumerate what's left as a first step. Here's things I can think of. Please add to the lists if anyone can think of more things: Some things that I'd like to see resolved for 4.0.x: - pauseTimers (CB-7947) - update script to

Re: Thought on improving translation and docs

2015-01-05 Thread Andrew Grieve
generate single file and use them across all files, that should bring benefit in generation speed. Apache + SSI seems good candidate for that. Again, let's measure and find what place takes most of the time. 2014-12-31 8:31 GMT+06:00 Andrew Grieve agri...@chromium.org: Your links do

<    1   2   3   4   5   6   7   8   9   10   >