Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215811240
@ktop Yeah, I have the `attr="true"` in my plugin.xml and it still gets
added instead of merged.
```
```
I'm not
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215780851
I need to add a workaround for the nodejs bug in setting file timestamps on
Windows: https://github.com/nodejs/node/issues/2069
---
If your project is set up for
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/433
CB-11174 Resolve symlinked path before getting PlatformApi instance
This PR the issue when `getPlatformApi` method in cordova-lib returns a
different instances for two paths pointing
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-215478064
## [Current coverage][cc-pull] is **79.60%**
> Merging [#432][cc-pull] into [master][cc-base-branch] will increase
coverage by **-0.49%**
```diff
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215260110
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-215255548
@vladimir-kotikov I think this is ready to go after the latest update.
Please let me know if you have any further comments.
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/431#issuecomment-214814135
## [Current coverage][cc-pull] is **100%**
> Merging [#431][cc-pull] into [master][cc-base-branch] will not change
coverage
```diff
@@
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-214812288
## [Current coverage][cc-pull] is **100%**
> Merging [#429][cc-pull] into [master][cc-base-branch] will increase
coverage by **+19.90%**
```diff
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/431#issuecomment-214811002
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/431#issuecomment-214810543
Updated, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/431#discussion_r61116509
--- Diff: cordova-common/src/CordovaLogger.js ---
@@ -209,7 +209,7 @@ function formatError(error, isVerbose) {
message = error;
}
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60995427
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60995226
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60899092
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r60898584
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,226 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/430#issuecomment-213597623
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ktop commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213530432
If we can modify existing attributes, and then the plugin gets removed, the
modified attribute will also get removed. I don't think there is a way to
revert it back
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-lib/pull/432#issuecomment-213519895
@ktop I did a quick test of this with one of my existing apps and it does
add the following lines to AndroidManifest.xml:
```
```
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-lib/pull/432
CB-11023 Add attribute through config-file tag
Add functionality to be able to add attributes to xml files through
config-file tag.
Syntax:
Able to add multiple attributes to
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/431
CB-11131 Fix TypeError: message.toUpperCase is not a function in Cordâ¦
â¦ovaLogger
[Jira issue](https://issues.apache.org/jira/browse/CB-11131)
You can merge this pull request into
Github user daserge commented on the pull request:
https://github.com/apache/cordova-lib/pull/430#issuecomment-212903032
Updated this in the remaining commands, thanks.
Although it was not failing (because of simultaneous async run via `Q.all`)
it makes sense to handle them as
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/430#issuecomment-212652866
Does this cloning need to happen for other commands too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60482215
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481666
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60481370
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-lib/pull/430
CB-11036 'args.slice is not a function' when building windows with otâ¦
â¦her platform
Avoid options obj modification as it's then passed to other platforms
[Jira
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460847
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60460033
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459967
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60459281
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60458884
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60452183
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60450430
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60449617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60448617
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60409457
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60407237
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60406393
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60399853
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60399365
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60398700
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60398288
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60397531
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60397076
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396878
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396904
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60396886
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60384873
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/428#discussion_r60380149
--- Diff: cordova-lib/src/cordova/restore-util.js ---
@@ -112,7 +112,10 @@ function installPluginsFromConfigXML(args) {
// assume
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/428
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r60314872
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,389 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-212121255
I opened CB-7 to track this work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/428#issuecomment-212067153
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-212039256
@nikhilkh @vladimir-kotikov please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/429
Add FileUpdater module to cordova-common
The new FileUpdater module contains a few functions that enable optimized
file copies by comparing timestamps. These functions are primarily
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/428#issuecomment-212000688
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/428
CB-10761 Resore plugins saved without spec attribute
This PR updates plugin restore logic to restore plugins that were added to
plugin.xml without `spec` attribute. See
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/419
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/419#issuecomment-211626986
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/426
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/426#issuecomment-210667397
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/427#issuecomment-210559039
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/427
CB-11022 Save modulesMetadata to both www and platform_www when necessary
This is a port of corresponding platform changes (see
https://github.com/apache/cordova-windows/pull/167,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-209620711
Yes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-209607020
@jasongin, i've added tests to cover the new logic. Is this PR ready to go?
---
If your project is set up for it, you can reply to this email and have
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209586254
No problem, and thanks for testing @dpogue!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209579652
:+1: I've tested and this seems to be working properly. Thanks @riknoll!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/426#discussion_r59592544
--- Diff: cordova-lib/src/cordova/run.js ---
@@ -32,8 +32,10 @@ module.exports = function run(options) {
var hooksRunner = new
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59584301
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209292949
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59503554
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59503458
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209148999
@vladimir-kotikov updated to address feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/426
CB-11042: Add cordova run option to skip prepare
I'm also submitting a PR for the cordova-cli repo to parse and document the
--noprepare option.
You can merge this pull request into a Git
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209011899
@vladimir-kotikov To clarify the plugin mapper comments: I left in the
scope with the intention that the mapping would fail if the scope was present.
I don't think
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59412823
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -410,6 +422,9 @@ function getPluginVariables(variables){
}
function
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59412652
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
});
});
}
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-208828579
> do we also need changes to iOS and Windows platforms
Exactly. Changes for windows and iOS is on their go
---
If your project is set up for it,
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-208825623
As a general comment, i'd love to see the methods for dealing with plugin
spec returning a structured result instead of an array. This IMO would make the
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59349270
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -145,10 +145,9 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59347954
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -90,35 +90,37 @@ module.exports = function installPlugin(platform,
project_dir, id,
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59347577
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -205,8 +206,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
// Helper
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59346334
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,8 +132,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59345185
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -410,6 +422,9 @@ function getPluginVariables(variables){
}
function
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59339491
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
});
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59339185
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
});
});
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/421#issuecomment-208765981
I think this is not a regression, since this code has been added recently
in #363 (see the diff
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/423#issuecomment-208603032
OK, I didn't realize config file transformations were also done already in
plugin add. And I think I have a better understanding of the code now.
My
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-20852
@vladimir-kotikov please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/425
CB-10986: Adding support for scoped npm package plugins
Apparently pre 6.1.0 versions of the CLI were able to add scoped npm
packages, but I don't think we ever supported that feature (if it
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/421#issuecomment-208522580
LGTM. Is this a regression? Another one to add tests for.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/422
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/422#issuecomment-208511405
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
801 - 900 of 3208 matches
Mail list logo
