Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209586254
No problem, and thanks for testing @dpogue!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209579652
:+1: I've tested and this seems to be working properly. Thanks @riknoll!
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59584301
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209292949
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59503554
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59503458
--- Diff: cordova-lib/src/cordova/plugin_spec_parser.js ---
@@ -0,0 +1,61 @@
+/**
+Licensed to the Apache Software Foundation (ASF) u
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209148999
@vladimir-kotikov updated to address feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-209011899
@vladimir-kotikov To clarify the plugin mapper comments: I left in the
scope with the intention that the mapping would fail if the scope was present.
I don't think
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59412823
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -410,6 +422,9 @@ function getPluginVariables(variables){
}
function getVersionFromConfi
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59412652
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
});
});
}
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-208825623
As a general comment, i'd love to see the methods for dealing with plugin
spec returning a structured result instead of an array. This IMO would make the
c
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59349270
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -145,10 +145,9 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59347954
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -90,35 +90,37 @@ module.exports = function installPlugin(platform,
project_dir, id, plugins_
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59347577
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -205,8 +206,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
// Helper functi
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59346334
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,8 +132,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59345185
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -410,6 +422,9 @@ function getPluginVariables(variables){
}
function getVersion
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59339491
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
});
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59339185
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -401,3 +407,48 @@ function getAvailableNpmVersions(module_name) {
});
});
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/425#issuecomment-20852
@vladimir-kotikov please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-lib/pull/425
CB-10986: Adding support for scoped npm package plugins
Apparently pre 6.1.0 versions of the CLI were able to add scoped npm
packages, but I don't think we ever supported that feature (if it ev
21 matches
Mail list logo
