RE: 'cordova plugin save' should also save plugin versions

2015-03-25 Thread Tim Barham
___ From: agri...@google.com [agri...@google.com] on behalf of Andrew Grieve [agri...@chromium.org] Sent: Wednesday, March 25, 2015 11:44 PM To: dev Subject: Re: 'cordova plugin save' should also save plugin versions That's what we already do (CPR *is* an npm database)

Re: 'cordova plugin save' should also save plugin versions

2015-03-25 Thread Andrew Grieve
in this area - I'm happy to > make > > >> this change while I'm there. > > >> > > >> Sure, go ahead. I would not be able to get to it until next week. > > > > > > > > > > > >

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Michal Mocny
x27;m currently doing some work in this area - I'm happy to make > >> this change while I'm there. > >> > >> Sure, go ahead. I would not be able to get to it until next week. > > > > > > > >>

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Andrew Grieve
ules and their dependencies: >>> https://docs.npmjs.com/cli/shrinkwrap . It does not look our >>> --shrinkwrap >>> option does that. >>> >>> -Nikhil >>> >>> -Original Message- >>> From: So, Byoungro [mailto:byoungro...@

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
il.com] Sent: Wednesday, March 25, 2015 7:20 AM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions Definitely agree with alignment with npm's save! :D On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal wrote: I'm in favor of al

RE: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Tim Barham
esday, March 25, 2015 7:20 AM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions Definitely agree with alignment with npm's save! :D On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal wrote: > I'm in favor of alignment of &

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Michal Mocny
t; > From: So, Byoungro [mailto:byoungro...@intel.com] > > Sent: Tuesday, March 24, 2015 12:40 PM > > To: dev@cordova.apache.org > > Subject: Re: 'cordova plugin save' should also save plugin versions > > > > +1 for making the shrinkwrap

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Steven Gill
shrinkwrap . It does not look our --shrinkwrap > option does that. > > -Nikhil > > -Original Message- > From: So, Byoungro [mailto:byoungro...@intel.com] > Sent: Tuesday, March 24, 2015 12:40 PM > To: dev@cordova.apache.org > Subject: Re: 'cordova plugin sa

RE: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Nikhil Khandelwal
day, March 24, 2015 12:40 PM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions +1 for making the shrinkwrap as the default for the wrote: > >I think the problem here is shrinkwrap behaviour is the expected >because platforms

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread So, Byoungro
+1 for making the shrinkwrap as the default for the ‹save. This makes sure the users will restore the same version they saved before. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation On 3/24/15, 12:31 PM, "Gorkem Ercan" wrote: > >I think the problem here is shrinkwr

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
I think the problem here is shrinkwrap behaviour is the expected because platforms behave that way. I guess we could just make shrinkwrap default and change the flag to --noshrinkwrap. -- Gorkem On 24 Mar 2015, at 13:58, Andrew Grieve wrote: On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan wro

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Andrew Grieve
On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan wrote: > They are related but not same. > > CB-8594 asks to save the plugin version information during "cordova plugin > add --save". Right now we do not save version unless the command is > "cordova plugin add --save --shrinkwrap". This behaviour al

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
They are related but not same. CB-8594 asks to save the plugin version information during "cordova plugin add --save". Right now we do not save version unless the command is "cordova plugin add --save --shrinkwrap". This behaviour allows plugins to be restored to the latest possible version availa

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Edna Y Morales
Ah yes. Looks like it. Thanks, Edna Morales From: Raymond Camden To: dev@cordova.apache.org Date: 03/24/2015 11:30 AM Subject:Re: 'cordova plugin save' should also save plugin versions Is that a dupe of https://issues.apache.org/jira/browse/CB-8594? On Tue, Ma

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Raymond Camden
Is that a dupe of https://issues.apache.org/jira/browse/CB-8594? On Tue, Mar 24, 2015 at 10:19 AM, Edna Y Morales wrote: > > > Currently, version info is not saved for plugins in the fetch.json. That > needs to be added so that plugin version can be saved in the config.xml. It > should follow wha

Re: cordova plugin save

2014-08-18 Thread Brian LeRoux
ya this too…again we should save moving plugins to npm for a later date…the problems there aren't ones we have and the reuse symmetry being craved here is already in place given we re-used most of npm's arch and modules… On Mon, Aug 18, 2014 at 6:03 PM, Andrew Grieve wrote: > On Mon, Aug 18, 20

Re: cordova plugin save

2014-08-18 Thread Andrew Grieve
On Mon, Aug 18, 2014 at 5:58 PM, Brian LeRoux wrote: > We don't have to make plugins a package.json thing…we could do that latter. > If we do choose to use package.json highly likely we'll need to reserve a > key for our 'namespace'. Perhaps "cordova". That key could have whatever we > want in it

Re: cordova plugin save

2014-08-18 Thread Brian LeRoux
We don't have to make plugins a package.json thing…we could do that latter. If we do choose to use package.json highly likely we'll need to reserve a key for our 'namespace'. Perhaps "cordova". That key could have whatever we want in it (such as mapping our current config.xml properties/values).

Re: cordova plugin save

2014-08-18 Thread Mark Koudritsky
In order to keep the plugins as project deps in package.json we need to sort out some details of treating plugins as npm packages first: 1) Plugins don't currently have package.json files, and list their deps in plugin.xml. 2) Are we ok with loosing the possibility of specifying platform specific

RE: cordova plugin save

2014-08-18 Thread Brian LeRoux
current config.xml, but does this sound > like something we would like to target for the future? > > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Monday, August 18, 2014 5:53 AM > To: Treggiari, Leo > Cc: Mic

RE: cordova plugin save

2014-08-18 Thread Parashuram Narasimhan (MS OPEN TECH)
Of Michal Mocny Sent: Monday, August 18, 2014 5:53 AM To: Treggiari, Leo Cc: Michal Mocny; dev Subject: Re: cordova plugin save On Fri, Aug 15, 2014 at 10:29 PM, Treggiari, Leo wrote: > I have a few follow-on questions / comments: > > > > > Run-time Platform-specific config:

Re: cordova plugin save

2014-08-18 Thread Michal Mocny
Cordova > CLI and an IDE could be used seamlessly on the same application. E.g. > support a user who likes to use both at different times, and teams where > some users want to use the CLI and other users want to use an IDE. > > > Leo > > > > *From:* mmo...@google.com

Re: cordova plugin save

2014-08-15 Thread Gorkem Ercan
ust 14, 2014 5:53 AM > To: dev > Cc: Treggiari, Leo > Subject: Re: cordova plugin save > > Summarizing / simplifying since this thread has run away: > > Run-time Platform-specific config: > - Automatically created on prepare from a combination of initial > application templ

RE: cordova plugin save

2014-08-15 Thread Treggiari, Leo
nd teams where some users want to use the CLI and other users want to use an IDE. Leo From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Thursday, August 14, 2014 5:53 AM To: dev Cc: Treggiari, Leo Subject: Re: cordova plugin save Summarizing / simplifying sinc

Re: cordova plugin save

2014-08-14 Thread Michal Mocny
plugins or platforms to install today > (plugins pull in dependencies for specific platforms so the contents of the > plugins folder is actually not the definitive list). That's what it was > trying to fix. > > > > From: Treggiari, Leo<m

Re: cordova plugin save

2014-08-14 Thread Gorkem Ercan
___ > From: Treggiari, Leo<mailto:leo.treggi...@intel.com> > Sent: ‎8/‎13/‎2014 6:48 PM > To: Chuck Lantz<mailto:cla...@microsoft.com>; > dev@cordova.apache.org<mailto:dev@cordova.apache.org> > Cc: Treggiari, Leo<mailto:leo.treggi...@intel.com> > Subject: RE:

RE: cordova plugin save

2014-08-13 Thread Chuck Lantz
(and possibly additional information) from the sources that were actually fetched? - Can 'restore' be guaranteed to fetch the same exact sources that were in the project that was 'save'd? Does it need to? Thanks, Leo -Original Message- From: Chuck Lantz [mailto:c

RE: cordova plugin save

2014-08-13 Thread Treggiari, Leo
ually fetched? - Can 'restore' be guaranteed to fetch the same exact sources that were in the project that was 'save'd? Does it need to? Thanks, Leo -Original Message----- From: Chuck Lantz [mailto:cla...@microsoft.com] Sent: Wednesday, August 13, 2014 3:58 PM T

RE: cordova plugin save

2014-08-13 Thread Chuck Lantz
gle.com] Sent: Wednesday, August 13, 2014 3:27 PM To: Treggiari, Leo Cc: dev@cordova.apache.org Subject: Re: cordova plugin save On Wed, Aug 13, 2014 at 6:07 PM, Treggiari, Leo wrote: > Hi Michal, > > > > Thanks for your answers. They were quite helpful. I have a few >

Re: cordova plugin save

2014-08-13 Thread Michal Mocny
On Wed, Aug 13, 2014 at 6:07 PM, Treggiari, Leo wrote: > Hi Michal, > > > > Thanks for your answers. They were quite helpful. I have a few > follow-ups. > > > > With your answers, and references, and I found > https://wiki.apache.org/cordova/ConfigurationFiles, > > I have a better understandin

Re: cordova plugin save

2014-08-13 Thread Treggiari, Leo
Hi Michal, Thanks for your answers. They were quite helpful. I have a few follow-ups. With your answers, and references, and I found https://wiki.apache.org/cordova/ConfigurationFiles, I have a better understanding of the existing metadata files. However there seem to be quite a few of

Re: cordova plugin save

2014-08-13 Thread Michal Mocny
A few answers: - There is no spec, since this is an "experimental" feature we aren't ourselves sure yet how it will look when complete. That was the point of recent threads. - The file belongs to the app / user, not to the workspace / tooling. - Aside from the initial create script that sets name