We have just released a major update to our Cordova tooling & template!
- cordova-fetch@3.0.0
- cordova-js@6.0.0
- cordova-serve@4.0.0
- cordova-node-xcode@3.0.0
- cordova-app-hello-world@5.0.0
You can view the release blog post at
https://cordova.apache.org/news/2020/04/13/tools-temp
-contribute/pull/3
> >
> > Please keep all further discussion on the issue and pull request
> > template in this Pull Request. Thank you.
> > Am Di., 21. Aug. 2018 um 20:21 Uhr schrieb :
> > >
> > > Sounds pretty good to me. A few thoughts:
> > >
gt; https://github.com/apache/cordova-contribute/pull/3
>
> Please keep all further discussion on the issue and pull request
> template in this Pull Request. Thank you.
> Am Di., 21. Aug. 2018 um 20:21 Uhr schrieb :
> >
> > Sounds pretty good to me. A few thoughts:
> >
>
We have just released an update to our tools and template!
- cordova-app-hello-world@4.0.0
- cordova-fetch@2.0.0
- cordova-js@5.0.0
- cordova-serve@3.0.0
You can view the release blog post at
https://cordova.apache.org/news/2018/12/25/tools-release.html
Here is the PR on GitHub templates, our usage of them and actual
drafts for all templates:
https://github.com/apache/cordova-contribute/pull/3
Please keep all further discussion on the issue and pull request
template in this Pull Request. Thank you.
Am Di., 21. Aug. 2018 um 20:21 Uhr schrieb
Sounds pretty good to me. A few thoughts:
- The support question template should refer people to a proper support
site like Stack Overflow.
- Merge convention should be: if multiple commits make the history more
meaningful, do a merge commit, else squash and rebase.
- the templates will probably
Agree with all 3 points by Jan.
@Chris Brody I think we should make use of Github Milestones to track
related issues.
On Wed, Aug 8, 2018 at 6:59 AM Jan Piotrowski wrote:
>
> Update to my initial email:
>
> I just noticed we actually _do_ have an issue template in use in the
&g
Update to my initial email:
I just noticed we actually _do_ have an issue template in use in the
cordovs-docs repository:
https://github.com/apache/cordova-docs/blob/master/.github/ISSUE_TEMPLATE.md
J
2018-08-07 23:18 GMT+02:00 julio cesar sanchez :
> I think us as committers should dec
uld favor a place where a contributor can mark if s/he would
> > > recommend the committer should *not* use the squash option.
> >
> > That of course could be defined in the contributor guidelines or PR
> > template (although there it might be a bit confusing t
> > I would favor a place where a contributor can mark if s/he would
> > recommend the committer should *not* use the squash option.
>
> That of course could be defined in the contributor guidelines or PR
> template (although there it might be a bit confusing to new users t
defined in coho and in other places.
> I would favor a place where a contributor can mark if s/he would
> recommend the committer should *not* use the squash option.
That of course could be defined in the contributor guidelines or PR
template (although there it might be a bit confusing to new users
would have
> to go back to the ASF ICLA again. We had finally moved away from
idea withdrawn
(I continue to stand by my other comments regarding the issue
template, PR template, and merge conventions)
-
To unsubs
>
> > What do you think regarding PR template?
>
> Looks nice in general, again we should probably give proper
> attribution upon reuse.
>
> It might be good to require a checkbox for developers certificate of
> origin (developercertificate.org) like at:
> ht
> 1. Issue template:
> [...]
> I think we should definitely use this for Bug Report, Feature Request,
> Support Question. What sections should we suggest in our templates?
All suggestions look good, should probably give proper attribution.
> 2. Pull Request template:
>
>
git repos or will continue to remain as is till it's
>> closed?
>> >
>> > On Tuesday, August 7, 2018, Jan Piotrowski wrote:
>> >
>> > > Now that Github Issues are enabled on all repositories, it makes sense
>> > > to create a (or several) ne
respective git repos or will continue to remain as is till it's
> closed?
> >
> > On Tuesday, August 7, 2018, Jan Piotrowski wrote:
> >
> > > Now that Github Issues are enabled on all repositories, it makes sense
> > > to create a (or several) ne
remain as is till it's closed?
>
> On Tuesday, August 7, 2018, Jan Piotrowski wrote:
>
> > Now that Github Issues are enabled on all repositories, it makes sense
> > to create a (or several) new Issue and PR template(s) that doesn't
> > point to JIRA any more and also uses
Now that Github Issues are enabled on all repositories, it makes sense
> to create a (or several) new Issue and PR template(s) that doesn't
> point to JIRA any more and also uses the current state of the art.
>
> Current Cordova issue and PR template:
> - no issue template
> - https://gith
Now that Github Issues are enabled on all repositories, it makes sense
to create a (or several) new Issue and PR template(s) that doesn't
point to JIRA any more and also uses the current state of the art.
Current Cordova issue and PR template:
- no issue template
-
https://github.com/apache
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/266
## [Current
coverage](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr) is 56.50%
(diff: 100%)
> Merging [#266](https://codecov.io/gh/apache/cordova-ios/pull/266?src=pr)
into
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/266
CB-11729 - template file MainViewController.m has deprecated override
shouldAutorotateToInterfaceOrientation
### Platforms affected
iOS
### What does this PR do?
Remove
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/56
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-console/pull/20
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/87
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-vibration/pull/50
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/196
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file/pull/196/commits/0636e453859bc6a372210933dd0a6fc23180e68e)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/66
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/237
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/118
Cordova CI Build has completed successfully.
**Commit** -
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/137
Cordova CI Build has completed successfully.
**Commit** -
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/612#discussion_r73905774
--- Diff: www/_data/redirects.yml ---
@@ -348,6 +348,7 @@ docs-global:
"guide_appdev_privacy_index.md.html": "guide/appdev/privacy/index.html"
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HenryPing closed the pull request at:
https://github.com/apache/cordova-android/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user HenryPing opened a pull request:
https://github.com/apache/cordova-android/pull/313
Support project template with aar for building app with custom plugins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adobe
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/458
Failures on windows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/458
## [Current coverage][cc-pull] is **80.59%**
> Merging [#458][cc-pull] into [master][cc-base-branch] will increase
coverage by **0.01%**
```diff
@@ master
GitHub user carynbear opened a pull request:
https://github.com/apache/cordova-lib/pull/458
CB-11412 template support for www folders
@stevengill yay but also need to merge the cordova-cli!
You can merge this pull request into a Git repository by running:
$ git pull https
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user carynbear opened a pull request:
https://github.com/apache/cordova-docs/pull/612
CB-11412 Added docs for template use and create
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carynbear/cordova-docs CB-11412
join(paths.www, 'www'))) {
paths.root = paths.www;
paths.www = path.join(paths.root, 'www');
}
-// find config.xml
+// find config.xml OR get stock config.xml, used if template does
not contain config.xml
Github user carynbear commented on the issue:
https://github.com/apache/cordova-lib/pull/456
@stevengill fixed up the little details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user carynbear commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/456#discussion_r67077463
--- Diff:
cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt
---
@@ -0,0 +1 @@
+blah
--- End diff
();
+});
+expect(path.join(project, 'hooks', 'README.md')).toExist();
+
+//index.js and template folder should not exist (inner files
should be copied to the project folder)
+expect(path.join(project, 'index.js')).not.toExist();
+expect
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/456
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
join(paths.www, 'www'))) {
paths.root = paths.www;
paths.www = path.join(paths.root, 'www');
}
-// find config.xml
+// find config.xml OR get stock config.xml, used if template does
not contain config.xml
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/456#discussion_r67073107
--- Diff:
cordova-lib/spec-cordova/fixtures/templates/withsubdirectory_package_json/template/blah.txt
---
@@ -0,0 +1 @@
+blah
--- End diff
();
+});
+expect(path.join(project, 'hooks', 'README.md')).toExist();
+
+//index.js and template folder should not exist (inner files
should be copied to the project folder)
+expect(path.join(project, 'index.js')).not.toExist();
+expect
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/456#discussion_r67070160
--- Diff: cordova-lib/spec-cordova/create.spec.js ---
@@ -38,15 +37,17 @@ var configNormal = {
version: 'testCordovaCreate'
GitHub user carynbear reopened a pull request:
https://github.com/apache/cordova-lib/pull/456
CB-11412 improve template implementation
Removed symlinking.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carynbear/cordova-lib CB
Github user carynbear closed the pull request at:
https://github.com/apache/cordova-lib/pull/456
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user carynbear opened a pull request:
https://github.com/apache/cordova-lib/pull/456
CB-11412 improve template implementation
Removed symlinking.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carynbear/cordova-lib CB
GitHub user carynbear opened a pull request:
https://github.com/apache/cordova-lib/pull/446
CB-11345 Added '/package.json' to path of templatePkg
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/carynbear/cordova-lib master
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219137585
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136559
I wonder if we should shorten the commit message bullet so that it doesn't
wrap lines like that? Maybe we can link to
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219136048
@nikhilkh please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/215
Moving message in PR template to a comment
### Platforms affected
None!
### What does this PR do?
Change the template that I am currently filling out so
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218547172
Thanks for the feedback! I made some updates based on feedback.
As far as running tests - we're automating that process using Jenkins,
Travis
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218282825
great points @tony-- ! +1 to all of 'em
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
workflow is
more current.
It seems like it would make sense to at least point to the docs page from
the template, something like:
"This checklist is intended as a quick reference, for complete details
please see our [Contributor
Guidelines](http://cordova.apache.org/contr
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218265034
+1 to the PR title suggestion
The icla is NOT actually required for smaller changes, and we should only
be enforcing this for large/deep
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218253991
Do we need to provide a link for CCLA info just in case? Can we also
suggest a format for PR titles? Something like:
```
[CB-12345]: Short
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/213
Add pull request template
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-camera pr-template
Big plus one to Jesse's comment. I've felt like the template is too
over complex for quite some time.
On Tue, Feb 16, 2016 at 3:21 PM, Ryan J. Salva <rsa...@microsoft.com> wrote:
> Check out the default template we use in TACO-CLI.
>
> Index.js is a lot simpler and we adopted
Check out the default template we use in TACO-CLI.
Index.js is a lot simpler and we adopted the new Cordova typeface. If folks
like this template, we could issue a PR for it.
rjs
Ryan J. Salva | Principal PM Manager
Visual Studio Tools for Apache Cordova
rsa...@microsoft.com
425 706 5270
Personally, I think we should rewrite/simplify that template ALOT.
The app binding stuff is confusing to users, but not potentially any less
confusing with PR#15. The use of an object is the issue in my mind.
Also, if this is the starting point for a new developer, they will soon
wonder why
-writing the starter-app itself.
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, February 16, 2016 12:28 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template
Personally, I think we should rewrite/simplify that template ALOT.
The app
+1 for the template change
LGTM
This conversation made it sound like this was going to suggest binding
offline/online etc in deviceready. Glad to see that's not the case in the
template at least.
I would discourage teaching people that they need to wait for Cordova’s
deviceready before
Will do.
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Tuesday, February 16, 2016 10:44 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template
LGTM
Could you also add the keyword 'cordova:template' to package.json?
On Tue, Feb 16
Santana [mailto:csantan...@gmail.com]
> Sent: Monday, February 15, 2016 7:51 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> I'm always in favor of having simple answers and guidelines, and we can
> take this as a good convention/practice
>
:) Sounds good
Anyone else have any objections to the change ?
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Monday, February 15, 2016 7:51 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Update to starter template
I'm always in favor of having
%7c01%7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72f988bf86f141af91ab2d7cd011db47%7c1=VLBX15Tz2VxbDC1JuS0H3qm1KGuRv7CdIAXaRnZbqR4%3d
> >
> >
> >On Mon, Feb 15, 2016 at 12:36 PM Parashuram N <panar...@microsoft.com>
> >wrote:
> >
> >> Whil
ar...@microsoft.com>
>wrote:
>
>> While working on documentation about events for Cordova, we noticed that
>> in our Cordova starter template [1] seems to suggest that we bind events
>> like “offline” and “online” alongside the “deviceready” event. As I
>> understand, t
entation about events for Cordova, we noticed that
> in our Cordova starter template [1] seems to suggest that we bind events
> like “offline” and “online” alongside the “deviceready” event. As I
> understand, the “offline” and “online” events are something that the
> NetworkInformatio
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-178816734
+1
Windows 8.0 has been deprecated since Apr 13, 2015, let's cleanup so we can
provide better focus.
---
If your project is set up for it, you can
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723
Reviewed changes, :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user dubeejw opened a pull request:
https://github.com/apache/cordova-lib/pull/372
CB-10499 - --template should pull the latest template from NPM when
version isn't specified
- Pull the latest template if no version is specified
You can merge this pull request
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/373
CB-10499 - --template should pull the latest template from NPM when
version isn't specified
- Pull the latest template if no version is specified
- Rename NPM to npm
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738
For what version is this for? cordova-windows@5.0.0 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user daserge commented on the pull request:
https://github.com/apache/cordova-windows/pull/147#issuecomment-178059859
This will be a breaking change, so yes, probably for cordova-windows@5.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-windows/pull/147
CB-10480 Remove Windows 8 template from cordova-windows
[Jira issue](https://issues.apache.org/jira/browse/CB-10480)
You can merge this pull request into a Git repository by running
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/432
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/227
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/432#issuecomment-161821043
Was this PR stale? Is the change invalid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dubeejw opened a pull request:
https://github.com/apache/cordova-docs/pull/432
CB-9964 - Add --template to online documentation
- Information about --template is now in the CLI documentation
You can merge this pull request into a Git repository by running:
$ git
GitHub user dubeejw opened a pull request:
https://github.com/apache/cordova-cli/pull/227
CB-9964 Make --copy-from use --template behavior
- Arguments are now handled for the --template parameter
- --copy-from now uses the same behavior as --template
You can merge this pull
I think the difference between the two templates is that the CLI template
adds extra navigator entries to point to ../../www and ../../config.xml.
Might still be worth not keeping two templates though, and just have these
entries be red for non-CLI projects (doesn't break builds).
On Tue, Jun 16
I propose to remove the non-CLI template starting in cordova-ios 4.0.0.
It was originally used to easily test your own plugins, but now we have the
alternative using the CLI:
cordova plugin add --link path/to/your/plugin
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-js/pull/111
CB-9016: Added template-packaged WinJS reference for Windows 10 support.
Windows 10 no longer has a Framework Reference for WinJS, instead we
include it in the project template (since we
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78153037
I put the change behind a flag called `--copywww`. By default `www` is
linked, and if the flag is passed, then it is copied instead.
---
If your project
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78015632
The idea LGTM, but i would prefer not to remove linking of www at all, just
hide it behind a corresponding option (`--linkwww` for example). There
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
1 - 100 of 205 matches
Mail list logo
