[jira] [Commented] (CURATOR-42) Background guaranteed delete considers NoNode to be a failed delete, and retries it

2014-07-28 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077447#comment-14077447 ] Cameron McKenzie commented on CURATOR-42: - Just had a look at this, the delete def

[jira] [Commented] (CURATOR-128) There is no namespace-safe way to refer to the root node

2014-07-28 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077398#comment-14077398 ] Cameron McKenzie commented on CURATOR-128: -- This sounds ok to me. It assumes tha

[jira] [Commented] (CURATOR-128) There is no namespace-safe way to refer to the root node

2014-07-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077388#comment-14077388 ] Scott Blum commented on CURATOR-128: It couldn't be made more lenient? e.g. "/" + "

[jira] [Commented] (CURATOR-128) There is no namespace-safe way to refer to the root node

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077258#comment-14077258 ] Jordan Zimmerman commented on CURATOR-128: -- The problem in ZKPaths.makePath() is

[jira] [Commented] (CURATOR-128) There is no namespace-safe way to refer to the root node

2014-07-28 Thread Cameron McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077241#comment-14077241 ] Cameron McKenzie commented on CURATOR-128: -- I think that it would be preferable

[jira] [Created] (CURATOR-128) There is no namespace-safe way to refer to the root node

2014-07-28 Thread Scott Blum (JIRA)
Scott Blum created CURATOR-128: -- Summary: There is no namespace-safe way to refer to the root node Key: CURATOR-128 URL: https://issues.apache.org/jira/browse/CURATOR-128 Project: Apache Curator

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077185#comment-14077185 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on the

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50420280 Sweet, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Resolved] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman resolved CURATOR-126. -- Resolution: Fixed > IllegalStateException in performBackgroundOperation during close >

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077168#comment-14077168 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50419120 Sorry Scott - it looks like CURATOR-126 hasn’t sync’d yet to the Github repo. The whole Github sync think is a lot of black magic. It is, however, here:  https://gi

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077166#comment-14077166 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on the

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077167#comment-14077167 ] ASF GitHub Bot commented on CURATOR-126: Github user cammckenzie commented on the

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50419008 They're there for me, I just pulled off the apache master (CURATOR-126 branch). The changes look good to me Jordan, I was trying to avoid changing the CuratorFramewor

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50418934 Where are the commits? I did a git remote update on both my fork and apache and couldn't find them. --- If your project is set up for it, you can reply to this emai

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50418758 I pushed an update to the test that has an assert. I tested it with the old background thread code and the test fails. It succeeds with the new code. -JZ

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077164#comment-14077164 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on the pu

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077122#comment-14077122 ] ASF GitHub Bot commented on CURATOR-126: Github user cammckenzie commented on the

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50416483 I have pushed a unit test up onto the CURATOR-126 branch. Have a play with it, I still seem to be getting the error logged when running against the fix. Could be some

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076966#comment-14076966 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on the

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50407804 That would be great. If you can send me a commit or diff, I'd be happy to play with trying to test it programmatically. --- If your project is set up for it, you ca

Re: FYI - changing 2.6.1 to 2.7.0

2014-07-28 Thread Jordan Zimmerman
I’m not a fan of cherry picking, etc. I’ve seen too many mistakes made. Officially, Curator follows Github Flow:  http://scottchacon.com/2011/08/31/github-flow.html - which boils down to have a master and lots of other branches. So, maybe even having a 2.7.0 branch would be a mistake. Features r

Re: FYI - changing 2.6.1 to 2.7.0

2014-07-28 Thread Mike Drob
might make more sense to create a 2.6.1 branch from the 2.6.0 release tag and cherry pick all of the relevant commits in. leave master as pointing to 2.7.0. if you have both branches active at once then commit to master and continue to cherry-pick as appropriate. or commit to the branch and merge t

Re: FYI - changing 2.6.1 to 2.7.0

2014-07-28 Thread Jordan Zimmerman
That’s a good point. I think, we’d have master just be whatever the next release will be. Then, we could have a 2.7.0 branch that would become master after 2.6.1 is released. OK? -JZ From: Cameron McKenzie Reply: dev@curator.apache.org > Date: July 28, 2014 at 4:42:57 PM To: dev@curator.apache

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076932#comment-14076932 ] ASF GitHub Bot commented on CURATOR-126: Github user cammckenzie commented on the

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076934#comment-14076934 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on the pu

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50406296 Yeah - please do. Can’t hurt. From: cammckenzie Reply: apache/curator > Date: July 28, 2014 at 4:41:57 PM To: apache/curator > Cc: Jordan

Re: FYI - changing 2.6.1 to 2.7.0

2014-07-28 Thread Cameron McKenzie
How would we manage this with our current branching structure? On Tue, Jul 29, 2014 at 7:36 AM, Mike Drob wrote: > Is it possible (or desirable?) to split some of the bug fixes into a 2.6.1 > before adding the APIs for 2.7.0? > > > On Mon, Jul 28, 2014 at 4:34 PM, Jordan Zimmerman < > jor...@jo

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread cammckenzie
Github user cammckenzie commented on the pull request: https://github.com/apache/curator/pull/23#issuecomment-50406175 Do you have a unit test to reproduce? I cooked one up which could reproduce the issue, but I hadn't found a way for it to work with assertions. I could only verify th

Re: FYI - changing 2.6.1 to 2.7.0

2014-07-28 Thread Mike Drob
Is it possible (or desirable?) to split some of the bug fixes into a 2.6.1 before adding the APIs for 2.7.0? On Mon, Jul 28, 2014 at 4:34 PM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > FYI > > There will be some new APIs in the next release (CURATOR-126 for example) > that suggests

FYI - changing 2.6.1 to 2.7.0

2014-07-28 Thread Jordan Zimmerman
FYI There will be some new APIs in the next release (CURATOR-126 for example) that suggests making this 2.7.0 instead of 2.6.1 -JZ

[jira] [Updated] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-126: - Fix Version/s: 2.6.1 > IllegalStateException in performBackgroundOperation during close

[jira] [Assigned] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman reassigned CURATOR-126: Assignee: Jordan Zimmerman (was: Cameron McKenzie) > IllegalStateException in per

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076878#comment-14076878 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076884#comment-14076884 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15491355 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java --- @@ -239,6 +241,16 @@ public Builder connectionTimeou

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15491274 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java --- @@ -239,6 +241,16 @@ public Builder connectionTim

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076842#comment-14076842 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15490376 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java --- @@ -239,6 +241,16 @@ public Builder connectionTimeou

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076839#comment-14076839 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15490243 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -74,7 +71,7 @@ private final Namesp

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076766#comment-14076766 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15488051 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -74,7 +71,7 @@ private final Namespace

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076754#comment-14076754 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15487369 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -74,7 +71,7 @@ private final Namespace

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15487723 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -74,7 +71,7 @@ private final Namesp

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076743#comment-14076743 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076733#comment-14076733 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076736#comment-14076736 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15487087 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -300,12 +295,20 @@ public Void apply(Curator

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15487030 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -74,7 +71,7 @@ private final Namesp

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076718#comment-14076718 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076715#comment-14076715 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15486439 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -770,9 +769,8 @@ private void backgroundOperati

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15486333 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -770,9 +769,8 @@ private void backgroundOperati

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076709#comment-14076709 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15486219 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -770,9 +769,8 @@ private void backgroundOper

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076701#comment-14076701 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[jira] [Issue Comment Deleted] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-125: - Comment: was deleted (was: GitHub user dragonsinth opened a pull request: https://g

[jira] [Issue Comment Deleted] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-125: - Comment: was deleted (was: Github user dragonsinth closed the pull request at: http

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15485966 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -722,39 +725,35 @@ public void retriesExhaus

[jira] [Issue Comment Deleted] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-125: - Comment: was deleted (was: Please delete the above 3 comments (and this one) opened a PR

[jira] [Issue Comment Deleted] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan Zimmerman updated CURATOR-125: - Comment: was deleted (was: Github user dragonsinth commented on the pull request: h

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076696#comment-14076696 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15485833 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -74,7 +71,7 @@ private final Namespace

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076688#comment-14076688 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076691#comment-14076691 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15485742 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -770,9 +769,8 @@ private void backgroundOperati

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15485690 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -770,9 +769,8 @@ private void backgroundOperati

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076686#comment-14076686 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076684#comment-14076684 ] ASF GitHub Bot commented on CURATOR-126: Github user Randgalt commented on a diff

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15485603 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -722,39 +725,35 @@ public void retriesExhausted

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15485565 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -300,12 +295,20 @@ public Void apply(CuratorLis

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076617#comment-14076617 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15483300 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -300,12 +295,20 @@ public Void apply(Curator

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076610#comment-14076610 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15483196 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -770,9 +769,8 @@ private void backgroundOper

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076603#comment-14076603 ] ASF GitHub Bot commented on CURATOR-126: Github user dragonsinth commented on a d

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on a diff in the pull request: https://github.com/apache/curator/pull/23#discussion_r15483096 --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java --- @@ -722,39 +725,35 @@ public void retriesExhaus

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076576#comment-14076576 ] Scott Blum commented on CURATOR-126: You're right, Thread.interrupt(), Thread.join()

[jira] [Commented] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076573#comment-14076573 ] Scott Blum commented on CURATOR-125: Please delete the above 3 comments (and this one

[jira] [Commented] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076565#comment-14076565 ] ASF GitHub Bot commented on CURATOR-125: GitHub user dragonsinth opened a pull re

[jira] [Commented] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076567#comment-14076567 ] ASF GitHub Bot commented on CURATOR-125: Github user dragonsinth commented on the

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076570#comment-14076570 ] ASF GitHub Bot commented on CURATOR-126: GitHub user dragonsinth opened a pull re

[jira] [Commented] (CURATOR-125) ConnectionStateListener is confused by READ_ONLY state

2014-07-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076568#comment-14076568 ] ASF GitHub Bot commented on CURATOR-125: Github user dragonsinth closed the pull

[GitHub] curator pull request: CURATOR-126: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
GitHub user dragonsinth opened a pull request: https://github.com/apache/curator/pull/23 CURATOR-126: Fix race condition in CuratorFrameworkImpl.close() You can merge this pull request into a Git repository by running: $ git pull https://github.com/dragonsinth/curator CURATOR-

[GitHub] curator pull request: CURATOR-125: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth closed the pull request at: https://github.com/apache/curator/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] curator pull request: CURATOR-125: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
Github user dragonsinth commented on the pull request: https://github.com/apache/curator/pull/22#issuecomment-50380674 oops wrong number --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] curator pull request: CURATOR-125: Fix race condition in CuratorFr...

2014-07-28 Thread dragonsinth
GitHub user dragonsinth opened a pull request: https://github.com/apache/curator/pull/22 CURATOR-125: Fix race condition in CuratorFrameworkImpl.close() You can merge this pull request into a Git repository by running: $ git pull https://github.com/dragonsinth/curator CURATOR-

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076457#comment-14076457 ] Scott Blum commented on CURATOR-126: Also, versions of Java < 1.8 have a bug in Futur

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076460#comment-14076460 ] Jordan Zimmerman commented on CURATOR-126: -- An Executor is just a thread as well

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076452#comment-14076452 ] Scott Blum commented on CURATOR-126: Honestly, the executor is only used to start one

[jira] [Commented] (CURATOR-126) IllegalStateException in performBackgroundOperation during close

2014-07-28 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/CURATOR-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076204#comment-14076204 ] Jordan Zimmerman commented on CURATOR-126: -- I think the above change is a good i