On Thu, Apr 16, 2015 at 5:14 PM, Ananyev, Konstantin <
konstantin.ananyev at intel.com> wrote:
> > Yes, a new set of macros should be introduced first, then we can update
> > PMD code. Did anyone are working on it now ?
>
> As far as I know, no one is working on it right now.
> So, I suppose,
probe and close both don't modify the rte_pci_addr structure
that is passed.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/common/eal_common_pci.c | 4 ++--
lib/librte_eal/common/include/rte_pci.h | 7 ---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git
The PCI device id table is immutable and should be made const
in all drivers. The pseudo drivers can initialize their local
copy as necessary.
Signed-off-by: Stephen Hemminger
---
app/test/virtual_pmd.c | 3 +--
lib/librte_eal/common/include/rte_pci.h | 2 +-
More places where PCI code should be using const but wasn't
Stephen Hemminger (2):
pci: make device_id tables const
pci: allow const for rte_pci_addr
app/test/virtual_pmd.c | 3 +--
lib/librte_eal/common/eal_common_pci.c | 4 ++--
lib/librte_eal/common/include/rte_pci.h
Thomas, Thanks for the review so far, I will make necessary changes and
send out v6.
Thanks, Ravi
On Thu, Apr 16, 2015 at 3:08 PM, Ravi Kerur wrote:
>
>
> On Thu, Apr 16, 2015 at 1:24 AM, Thomas Monjalon <
> thomas.monjalon at 6wind.com> wrote:
>
>> Hi Ravi,
>>
>> I think this patch is too
On Tue, Apr 14, 2015 at 2:35 PM, Ravi Kerur wrote:
>
>
> On Tue, Apr 14, 2015 at 6:59 AM, Thomas Monjalon <
> thomas.monjalon at 6wind.com> wrote:
>
>> Hi Ravi,
>>
>> 2015-04-09 12:40, Ravi Kerur:
>> > --- a/lib/librte_eal/common/eal_common_thread.c
>> > +++
> -Original Message-
> From: outlook_739db8e1c4bc6fae at outlook.com
> [mailto:outlook_739db8e1c4bc6fae at outlook.com] On Behalf Of Wang Dong
> Sent: Thursday, April 16, 2015 12:36 PM
> To: Ananyev, Konstantin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe:Add write memory
On Thu, Apr 16, 2015 at 2:02 AM, Thomas Monjalon
wrote:
> This patch is very sensible and difficult to follow.
> I'm really afraid that some nasty bugs could be hidden.
> Please could you try to split it in several steps?
> Thanks
>
Sure, will drop eal_pci_uio.c and eal_pci_vfio.c changes and
On Thu, Apr 16, 2015 at 1:46 AM, Thomas Monjalon
wrote:
> 2015-04-09 12:40, Ravi Kerur:
> > Changes in v5
> > Rebase to latest code.
> >
> > Changes in v4
> > Removed extern declaration of eal_tsc_resolution_hz,
> > instead provided _set_ API.
> > Make set_tsc_freq_from_clock as wrapper function
On Thu, Apr 16, 2015 at 02:26:59PM +0100, Pablo de Lara wrote:
> Jenkins hash function was developed originally in 1996,
> and was integrated in first versions of DPDK.
> The function has been improved in 2006,
> achieving up to 60% better performance, compared to the original one.
>
> Check out:
2015-04-16 12:12, Olivier MATZ:
> On 04/15/2015 10:49 PM, Thomas Monjalon wrote:
> > To initialize a structure with zeros, one field was explicitly set
> > to avoid "missing initializer" bug with old GCC (e.g. 4.4).
> > This warning is now disabled (commit ) for old versions of GCC,
> > so the
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
Closing /dev/io fd causes SIGBUS in inb/outb instructions
as the process loses the IOPL privileges once the fd is closed:
(gdb) bt
0 0x00492f2c in outb (port=49170, data=0 '\000')
at /usr/include/machine/cpufunc.h:244
1 0x00492f7a in
This patchset contains refactoring steps for the `eventfd_link' module
of the DPDK's `librte_vhost' part.
The commit messages are updated to include `Signed-off-by'.
Pavel Boldin (5):
vhost: eventfd_link: moving ioctl to a function
vhost: eventfd_link: add function fget_from_files
vhost:
Will do
-Original Message-
From: Bruce Richardson [mailto:bruce.richard...@intel.com]
Sent: 16 April 2015 12:39
To: Raz Amir
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6] Restore support for virtio on FreeBSD
On Thu, Apr 16, 2015 at 11:02:03AM +0300, Raz Amir wrote:
> Fixes:
Jenkins hash function was developed originally in 1996,
and was integrated in first versions of DPDK.
The function has been improved in 2006,
achieving up to 60% better performance, compared to the original one.
Check out: http://burtleburtle.net/bob/c/lookup3.c
This patch integrates that code
Hi, sorry to resurrect this question.
I am now using a virtio network interface in a qemu VM.
Is it possible to use ifplugd to automatically setup the IP
configuration of a KNI based interface?
Here is the output of lspci:
00:03.0 Ethernet controller: Red Hat, Inc Virtio network device
00:04.0
On 04/15/15 23:49, Thomas Monjalon wrote:
> With GCC 4.4.7 from CentOS 6.5, the following errors arise:
>
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ?ixgbe_dev_rx_queue_setup?:
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509:
The two flags by default are enabled, but sometimes we want to know the
performance influence due to encapsulation and decapsulation operations, and
I think we should add the two options.
Signed-off-by: Jijiang Liu
---
examples/tep_termination/main.c| 36
If the 'tso-segsz' is not 0, which means TSO offload is enabled.
Signed-off-by: Jijiang Liu
---
examples/tep_termination/main.c | 19 +--
examples/tep_termination/vxlan.c |4
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git
For VXLAN packet, the inner Tx checksum offload means inner IPv4 and inner
L4(TCP/UDP/SCTP).
Signed-off-by: Jijiang Liu
---
examples/tep_termination/main.c | 15 +++
examples/tep_termination/vxlan.c | 77 ++
2 files changed, 92 insertions(+), 0
The follwoing filter types are supported for VXLAN,
1> Inner MAC and tenent ID
2> Inner MAC and tenent ID, and Outer MAC
3> Inner MAC and tenent ID
Signed-off-by: Jijiang Liu
---
examples/tep_termination/main.c| 21 +
examples/tep_termination/vxlan_setup.c | 50
The port number of UDP tunneling packet is configurable, which has 16 entries
in total for i40e.
Signed-off-by: Jijiang Liu
---
examples/tep_termination/main.c| 14 ++
examples/tep_termination/vxlan.c |3 ++-
examples/tep_termination/vxlan_setup.c | 17
Fill the APIs of encapsulation and decapsulation for VXLAN packet; for the
encapsulation operation, IPv6 is not supported now.
Signed-off-by: Jijiang Liu
Signed-off-by: Thomas Long
---
examples/tep_termination/Makefile |4 +-
examples/tep_termination/vxlan.c | 160
Implement the following functions:
1> VXLAN port configuration
2> VXLAN tunnel setup
3> VXLAN tunnel destroying
4> VXLAN packet processing for Rx side
5> VXLAN packet processing for Tx side
Signed-off-by: Jijiang Liu
Signed-off-by: Thomas Long
---
examples/tep_termination/Makefile |
We are trying to create a framework for tunneling packet processing, so some
common APIs are added here, which include
1> tunnel port configuration
2> tunnel setup
3> tunnel destroying
4> tunneling packet processing for Rx side
5> tunneling packet processing for Tx side
6> tunnel parameter
Some basic VXLAN definations and APIs are added in this file, which include
VXLAN device structure and the APIs for encapsulation and decapsulation.
Signed-off-by: Jijiang Liu
Signed-off-by: Thomas Long
---
examples/tep_termination/main.c |1 +
examples/tep_termination/vxlan.h | 81
This example uses the basic virtio devices management function from the vHost
example, which includes virtio device creation, destroying and maintenance.
Signed-off-by: Jijiang Liu
---
examples/Makefile |1 +
examples/tep_termination/Makefile | 58 +++
This VXLAN example simulates a VXLAN Tunnel endpoint(VTEP) termination in DPDK,
which is used to demonstrate the offload and filtering capabilities of i40 NIC
for VXLAN packet.
And this example uses the basic virtio devices management function from vHost
example, and it uses us-Vhost interface
On 16/04/15 11:03, Gonzalez Monroy, Sergio wrote:
> On 15/04/2015 20:24, Stephen Hemminger wrote:
>> On Wed, 15 Apr 2015 20:15:18 +0100
>> Zoltan Kiss wrote:
>>
>>> Hi,
>>>
>>> I have two questions regarding mempools:
>>>
>>> - the first is trivial: how do you delete them? Can you? I can't see
This patch is very sensible and difficult to follow.
I'm really afraid that some nasty bugs could be hidden.
Please could you try to split it in several steps?
Thanks
2015-04-09 12:40, Ravi Kerur:
> Changes in v5
> Rebase to latest code.
> Removed RTE_EXEC_ENV_BSDAPP from earlier changes.
>
>
Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
Closing /dev/io fd causes SIGBUS in inb/outb instructions
as the process loses the IOPL privileges once the fd is closed:
(gdb) bt
0 0x00492f2c in outb (port=49170, data=0 '\000')
at /usr/include/machine/cpufunc.h:244
1 0x00492f7a in
2015-04-09 12:40, Ravi Kerur:
> Changes in v5
> Rebase to latest code.
>
> Changes in v4
> Make rte_eal_hugepage_init and rte_eal_hugepage_attach as
> wrapper functions for BSD.
>
> Changes in v3
> Changed subject to be more explicit on file name inclusion.
>
> Changes in v2
> Use common
Hi,
>From both running and reading the code, the rte_virtio_pmd_init is called
only once from: rte_eal_init -> rte_eal_dev_init.
But, the uninit won't be called, since uninit it called only for PMD_VDEV
driver types, while virtio is PMD_PDEV.
Based on that, I am going to submit the original patch
2015-04-09 12:40, Ravi Kerur:
> Changes in v5
> Rebase to latest code.
>
> Changes in v4
> Removed extern declaration of eal_tsc_resolution_hz,
> instead provided _set_ API.
> Make set_tsc_freq_from_clock as wrapper function for BSD.
>
> Changes in v3
> Changed subject to be more explicit on
2015-04-09 12:40, Ravi Kerur:
> Changes in v5
> Rebase to latest code.
>
> Changes in v4
> Implement cpu_detected() for BSD.
> Have common RTE_LOG for Linux and BSD in rte_eal_cpu_init().
> Remove RTE_EXEC_ENV_BSDAPP in common file.
>
> Changes in v3
> Changed subject to be more explicit on file
On Thu, 16 Apr 2015 06:26:02 +
"Ouyang, Changchun" wrote:
>
>
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, April 16, 2015 1:48 PM
> To: Ouyang, Changchun
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: fix ring size negotiation
>
>
On Thu, 16 Apr 2015 09:38:46 +0200
Thomas Monjalon wrote:
> Guys, this is an example of what should not be done with emails formatting.
Sorry, Google mail client for Android seems to encourage
bad formatting.
On 16/04/2015 10:22, Marc Sune wrote:
>
>
> On 16/04/15 11:03, Gonzalez Monroy, Sergio wrote:
>> On 15/04/2015 20:24, Stephen Hemminger wrote:
>>> On Wed, 15 Apr 2015 20:15:18 +0100
>>> Zoltan Kiss wrote:
>>>
Hi,
I have two questions regarding mempools:
- the first is
Hi Ravi,
I think this patch is too complex and move too many different things:
- sysfs
- mem_cfg
- proc_type
- application_usage
Please split them up.
I'm not sure the classification in eal_common_runtime.c and eal_common_system.c
new file is clear.
2015-04-09 12:40, Ravi Kerur:
> +
On 16/04/2015 10:03, Gonzalez Monroy, Sergio wrote:
> On 15/04/2015 20:24, Stephen Hemminger wrote:
>> On Wed, 15 Apr 2015 20:15:18 +0100
>> Zoltan Kiss wrote:
>>
>>> Hi,
>>>
>>> I have two questions regarding mempools:
>>>
>>> - the first is trivial: how do you delete them? Can you? I can't see
On 15/04/2015 20:24, Stephen Hemminger wrote:
> On Wed, 15 Apr 2015 20:15:18 +0100
> Zoltan Kiss wrote:
>
>> Hi,
>>
>> I have two questions regarding mempools:
>>
>> - the first is trivial: how do you delete them? Can you? I can't see a
>> function to do that, and none of the examples are doing
Guys, this is an example of what should not be done with emails formatting.
2015-04-16 06:26, Ouyang, Changchun:
>
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Thursday, April 16, 2015 1:48 PM
> To: Ouyang, Changchun
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev]
Hi,
> -Original Message-
> From: Michael Qiu [mailto:qiudayu at cn.ibm.com]
> Sent: Tuesday, April 14, 2015 5:25 PM
> To: dev at dpdk.org
> Cc: Chen, Jing D; Qiu, Michael
> Subject: [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
>
> From: Michael Qiu
>
> In DPDK, max_vfs
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, April 16, 2015 4:49 AM
> To: dev at dpdk.org
> Cc: Vlad Zolotarov; Ananyev, Konstantin; Zhang, Helin
> Subject: [PATCH v2 1/2] ixgbe: fix build with gcc 4.4
>
> With GCC 4.4.7 from
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Thursday, April 16, 2015 1:48 PM
To: Ouyang, Changchun
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: fix ring size negotiation
No warning is needed, it just works.
I know it works, but the upper user don?t know
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, April 15, 2015 11:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 3/5] virtio: don't set mac table unless negotiated
>
> Don't attempt to set the MAC address
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, April 15, 2015 11:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 2/5] virtio: don't enable/disable rx modes unless
> supported
>
> Don't try to set features
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, April 15, 2015 11:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/5] virtio: remove useless new lines
>
> There are several places in virtio with extra
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, April 15, 2015 11:20 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 4/5] virtio: fix ring size negotiation
>
> This fixes another of the issues with running
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ananyev,
> Konstantin
> Sent: Wednesday, April 15, 2015 6:22 AM
> To: Raz Amir; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5] Restore support for virtio on FreeBSD
>
> Hi,
>
> > -Original
Hi Olivier
From: Olivier Deme [mailto:od...@druidsoftware.com]
Sent: Wednesday, April 15, 2015 5:49 PM
To: Ouyang, Changchun; dev at dpdk.org
Subject: Re: [dpdk-dev] freeze with dpdk-2.0.0
Hi Changchun,
I confirm that blacklisting the first two network interfaces solve the problem.
Just to be
Hi
Sending packets out from virtio to dpdk vhost to phy will cause packets
corruption
I have tested this using
- DPDK 2.0.0 using vhost-cuse,
- qemu 1.6.1.
- DPDK vhost-switch sample app.
Fedara 21 (kernel 3.19), packets corrupted.
Debian Wheezy (kernel 3.2), packets are ok.
Sometime the
2015-04-16 12:14, Vlad Zolotarov:
> On 04/15/15 23:49, Thomas Monjalon wrote:
> > The "may be used uninitialized" warning seems to be another GCC bug and is
> > workarounded with NULL initialization.
> > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> > @@
53 matches
Mail list logo
