Re: [dpdk-dev] [PATCH v1] common/mlx5: remove devx depndency on ibv and dv

2020-04-09 Thread David Marchand
Hello, On Wed, Apr 8, 2020 at 7:12 PM Ferruh Yigit wrote: > > On 4/1/2020 10:59 AM, Raslan Darawsheh wrote: > > Hi, > > > >> -Original Message- > >> From: Ophir Munk > >> Sent: Monday, March 30, 2020 1:32 AM > >> To: dev@dpdk.org; Matan Azrad > >> Cc: Thomas Monjalon ; Olga Shern > >> ;

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Ray Kinsella
On 08/04/2020 20:56, Neil Horman wrote: > Since we've moved away from our initial validate-abi.sh script, in > favor of check-abi.sh, which uses libabigail, remove the old script from > the tree, and update the docs accordingly > > Signed-off-by: Neil Horman > CC: tho...@monjalon.net > CC: dav

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-09 Thread David Marchand
Hello, On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš wrote: > > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. Thanks for the patch Juraj. Just a little comment, for the v2, there was no significant change and you could have kept Aaron and Ruifeng review tags. I

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, April 7, 2020 8:35 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/5] net/tap:

Re: [dpdk-dev] [PATCH v2 06/16] telemetry: add utility functions for creating json

2020-04-09 Thread Bruce Richardson
On Wed, Apr 08, 2020 at 07:12:57PM +0100, Wiles, Keith wrote: > > > > On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > > > From: Bruce Richardson > > > > The functions added in this patch will make it easier for applications > > to build up correct JSON responses to telemetry requests. > >

Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support for telemetry

2020-04-09 Thread Bruce Richardson
On Wed, Apr 08, 2020 at 07:16:10PM +0100, Wiles, Keith wrote: > > > > On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > > > From: Bruce Richardson > > > > The ethdev library now registers commands with telemetry, and > > implements the callback functions. These commands allow the list of > >

Re: [dpdk-dev] [PATCH] log: fix level picked with globbing on type register

2020-04-09 Thread David Marchand
On Wed, Apr 8, 2020 at 12:48 AM Thomas Monjalon wrote: > > When a log type is registered, the level can be picked > by matching saved options. > The check of fnmatch globbing result was reversed. > > The same bug was already fixed in a similar function. > This one is acting in log type register fu

Re: [dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed

2020-04-09 Thread Hunt, David
Hi Anatoly, On 8/4/2020 4:56 PM, Anatoly Burakov wrote: Currently, if power library initialization fails, only a log message is displayed. This is suboptimal for a number of reasons, but the main one is that telemetry mode does not depend on the power library and can therefore run in environment

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: implement proper shutdown handling

2020-04-09 Thread Hunt, David
Hi Anatoly, On 8/4/2020 4:56 PM, Anatoly Burakov wrote: Currently, shutdown for l3fwd-power application is all over the place and may or may not happen either in the signal handler or in the main() function. Fix this so that the signal handler will only set the exit variable, thereby allowing a

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-09 Thread Bruce Richardson
On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > 08/04/2020 18:49, Ciara Power: > > This patchset extensively reworks the telemetry library adding new > > functionality and simplifying much of the existing code, while > > maintaining backward compatibility. > > > > This work is b

Re: [dpdk-dev] [PATCH 2/2] l3fwd-power: implement proper shutdown handling

2020-04-09 Thread Pattan, Reshma
> -Original Message- > From: Burakov, Anatoly > Subject: [PATCH 2/2] l3fwd-power: implement proper shutdown handling > > Currently, shutdown for l3fwd-power application is all over the place and may > or > may not happen either in the signal handler or in the main() function. Fix > t

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-09 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote: > Hello, > > On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš > wrote: > > > > libjansson4 is not enough to build telemetry. Replace it with > > libjansson-dev. > > Thanks for the patch Juraj. > Just a little comment, for the v2, there

Re: [dpdk-dev] [PATCH 1/2] l3fwd-power: exit if initializing power library failed

2020-04-09 Thread Pattan, Reshma
> -Original Message- > From: Burakov, Anatoly > Subject: [PATCH 1/2] l3fwd-power: exit if initializing power library failed > > > Signed-off-by: Anatoly Burakov > --- Reviewed-by: Reshma Pattan

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-09 Thread Coyle, David
Thanks for the detailed review Fiona. Based on your feedback, we will reduce the scope of our plans for multi-function processing support in DPDK. We will focus on implementing a rawdev-based AESNI-MB PMD for Crypto-CRC and Crypto-CRC-BIP processing and we will add QAT Crypto-CRC support in a l

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-09 Thread Bruce Richardson
On Wed, Apr 08, 2020 at 03:49:49PM +0100, Ray Kinsella wrote: > > > On 06/04/2020 20:34, Neil Horman wrote: > > Since we've moved away from our initial abi_versioning.sh script, in > > favor of check_abi.sh, which uses libabigail, remove the old script from > > the tree, and update the docs accor

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-09 Thread David Marchand
On Thu, Apr 9, 2020 at 11:24 AM Bruce Richardson wrote: > On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote: > > I just want others' opinion, since there is a work on removing the > > dependency on libjansson for telemetry. > > > That would be an end-goal but we are not fully there ye

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-09 Thread Thomas Monjalon
09/04/2020 11:19, Bruce Richardson: > On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > > 08/04/2020 18:49, Ciara Power: > > > This patchset extensively reworks the telemetry library adding new > > > functionality and simplifying much of the existing code, while > > > maintaining b

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-09 Thread Trahe, Fiona
Hi David, Answer inline below > -Original Message- > From: Coyle, David > Sent: Thursday, April 9, 2020 10:26 AM > To: Trahe, Fiona ; Yigit, Ferruh > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; Akhil

Re: [dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

2020-04-09 Thread Kumar, Ravi1
[AMD Public Use] Acked-by: Ravi Kumar > > >-Original Message- >From: Somalapuram, Amaranath >Sent: Wednesday, April 8, 2020 12:38 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v1] net/axgbe: support sfp module EEPROM > >From: Amaranath Somalapuram > >Adding API for get_modul

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-04-09 Thread Gavin Hu
Hi David, > -Original Message- > From: David Marchand > Sent: Wednesday, April 8, 2020 11:22 PM > To: Gavin Hu > Cc: Kevin Traynor ; Bruce Richardson > ; Morten Brørup > ; Ferruh Yigit ; > dev@dpdk.org; nd ; tho...@monjalon.net; > jer...@marvell.com; Honnappa Nagarahalli > ; Ruifeng Wang

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 9:03 AM, wangyunjian wrote: > > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Tuesday, April 7, 2020 8:35 PM >> To: wangyunjian ; dev@dpdk.org >> Cc: keith.wi...@intel.com; Lilijun (Jerry) ; >> xudingke >> ; sta...@dpdk.org >> Subject: R

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

2020-04-09 Thread Ray Kinsella
On 09/04/2020 10:26, Bruce Richardson wrote: > On Wed, Apr 08, 2020 at 03:49:49PM +0100, Ray Kinsella wrote: >> >> >> On 06/04/2020 20:34, Neil Horman wrote: >>> Since we've moved away from our initial abi_versioning.sh script, in >>> favor of check_abi.sh, which uses libabigail, remove the old

[dpdk-dev] [PATCH v5] examples/ipsec-secgw: support flow director feature

2020-04-09 Thread Praveen Shetty
Support load distribution in security gateway application using NIC load distribution feature(Flow Director). Flow Director is used to redirect the specified inbound ipsec flow to a specified queue.This is achieved by extending the SA rule syntax to support specification by adding new action_type o

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Bruce Richardson
On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote: > 08/04/2020 17:49, Lukasz Wojciechowski: > > Hi guys, > > > > I don't know what is the current status of "legacy" build using > > gnumakes, so I added the new DEBUG flag to config just as it was done in > > other libs like eventde

[dpdk-dev] net/ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads

2020-04-09 Thread Martin Weiser
Hi, we recently discovered that our application was not able to create new threads or perform mmaps after some time. With some digging we identified the function ixgbe_dev_link_update_share() to be the reason for this behavior. In the patch "net/ixgbe: fix blocking system events" (819d0d1d57f17aa

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Neil Horman
On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > > > On 08/04/2020 20:56, Neil Horman wrote: > > Since we've moved away from our initial validate-abi.sh script, in > > favor of check-abi.sh, which uses libabigail, remove the old script from > > the tree, and update the docs accordi

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > > > > > > On 08/04/2020 20:56, Neil Horman wrote: > > > Since we've moved away from our initial validate-abi.sh script, in > > > favor of check-abi.sh, which uses libabig

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Ray Kinsella
On 09/04/2020 11:43, Bruce Richardson wrote: > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: >> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: >>> >>> >>> On 08/04/2020 20:56, Neil Horman wrote: Since we've moved away from our initial validate-abi.sh script, in

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-04-09 Thread Thomas Monjalon
09/04/2020 11:48, Gavin Hu: > From: David Marchand > > On Wed, Apr 8, 2020 at 5:05 PM Gavin Hu wrote: > > > From: Kevin Traynor > > > > Hi Gavin, I lost track if v2 is still a candidate for merge. fwiw, it > > > > compiles without giving the zero-length-bounds warning on my system. > > > > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Thomas Monjalon
09/04/2020 12:14, Bruce Richardson: > On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote: > > 08/04/2020 17:49, Lukasz Wojciechowski: > > > Hi guys, > > > > > > I don't know what is the current status of "legacy" build using > > > gnumakes, so I added the new DEBUG flag to config jus

[dpdk-dev] [PATCH dpdk-dev 1/2] eal: introduce last-init queue for libraries initialization

2020-04-09 Thread xiangxia . m . yue
From: Tonghao Zhang This patch introduces last-init queue, user can register a callback for theirs initialization. Running rte_last_init_run(), the almost resource of DPDK are available, such as memzone, ring. With this way, user don't introduce additional codes in eal layer. [This patch will be

[dpdk-dev] [PATCH dpdk-dev 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-09 Thread xiangxia . m . yue
From: Tonghao Zhang The order of mempool initiation affects mempool index in the rte_mempool_ops_table. For example, when building APPs with: $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... The "bucket" mempool will be registered firstly, and its index in table is 0 while the index of "ring"

Re: [dpdk-dev] [PATCH v3 00/30] Update ENA driver to v2.1.0

2020-04-09 Thread Michał Krawczyk
śr., 8 kwi 2020 o 15:23 Ferruh Yigit napisał(a): > > On 4/8/2020 9:28 AM, Michal Krawczyk wrote: > > Hi, > > > > This patchset is including severeal changes, including: > > * ena_com (HAL) update > > * Support for upcoming device features > > * Refactor of the IO path > > * Documentation update ab

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Thomas Monjalon
09/04/2020 12:45, Ray Kinsella: > On 09/04/2020 11:43, Bruce Richardson wrote: > > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > >> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > >>> On 08/04/2020 20:56, Neil Horman wrote: > +The syntax of the ``check-abi.sh``

[dpdk-dev] [PATCH] build: add note about make system deprecation

2020-04-09 Thread Bruce Richardson
When anyone uses the make build system, they are to be informed about upcoming plans to deprecate and subsequently remove that system and to use meson and ninja instead. Signed-off-by: Bruce Richardson --- mk/rte.sdkbuild.mk | 4 mk/rte.sdkconfig.mk | 4 2 files changed, 8 insertions(

Re: [dpdk-dev] [PATCH] build: add note about make system deprecation

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 11:57 AM, Bruce Richardson wrote: > When anyone uses the make build system, they are to be informed > about upcoming plans to deprecate and subsequently remove that > system and to use meson and ninja instead. > > Signed-off-by: Bruce Richardson > --- > mk/rte.sdkbuild.mk | 4 >

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 12:54:10PM +0200, Thomas Monjalon wrote: > 09/04/2020 12:14, Bruce Richardson: > > On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote: > > > 08/04/2020 17:49, Lukasz Wojciechowski: > > > > Hi guys, > > > > > > > > I don't know what is the current status of "leg

Re: [dpdk-dev] [PATCH] build: add note about make system deprecation

2020-04-09 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 12:09:57PM +0100, Ferruh Yigit wrote: > On 4/9/2020 11:57 AM, Bruce Richardson wrote: > > When anyone uses the make build system, they are to be informed > > about upcoming plans to deprecate and subsequently remove that > > system and to use meson and ninja instead. > > >

Re: [dpdk-dev] [PATCH dpdk-dev 1/2] eal: introduce last-init queue for libraries initialization

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 4:24 PM wrote: > > From: Tonghao Zhang > > This patch introduces last-init queue, user can register a > callback for theirs initialization. Running rte_last_init_run(), > the almost resource of DPDK are available, such as memzone, ring. > With this way, user don't introduce

Re: [dpdk-dev] [PATCH v3 00/30] Update ENA driver to v2.1.0

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 11:56 AM, Michał Krawczyk wrote: > śr., 8 kwi 2020 o 15:23 Ferruh Yigit napisał(a): >> >> On 4/8/2020 9:28 AM, Michal Krawczyk wrote: >>> Hi, >>> >>> This patchset is including severeal changes, including: >>> * ena_com (HAL) update >>> * Support for upcoming device features >>> * Refa

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Ferruh Yigit
On 3/20/2020 6:13 AM, Jerin Jacob wrote: > On Thu, Mar 19, 2020 at 7:21 PM Viacheslav Ovsiienko > wrote: >> >> The execution time of rx/tx burst routine depends on the burst size. >> It would be meaningful to research this dependency, the patch >> provides an extra profiling data per rx/tx burst s

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command

2020-04-09 Thread Ferruh Yigit
On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > This commit is preparation step before adding the separated profiling > of Rx and Tx burst routines. The new testpmd command is introduced: > > set fwdprof (flags) > > This command controls which profiling statistics is being gathered > in run

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-09 Thread Coyle, David
Hi Fiona, see below > -Original Message- > From: Trahe, Fiona > Sent: Thursday, April 9, 2020 10:37 AM > > Hi David, > > Answer inline below > > > -Original Message- > > From: Coyle, David > > Sent: Thursday, April 9, 2020 10:26 AM > > > > Thanks for the detailed review Fiona.

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Ferruh Yigit
On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > The execution time of rx/tx burst routine depends on the burst size. > It would be meaningful to research this dependency, the patch > provides an extra profiling data per rx/tx burst size. > > Signed-off-by: Viacheslav Ovsiienko <...> > @@ -1

Re: [dpdk-dev] net/ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads

2020-04-09 Thread Martin Weiser
Hi, I should have mentioned that our findings apply to DPDK 20.02. I can see in master that this since has been reworked to use rte_eal_alarm_set() instead of using a thread. But maybe this should be addressed in stable? Best regards, Martin Weiser Am 09.04.20 um 12:30 schrieb Martin Weiser: >

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Thomas Monjalon
09/04/2020 14:03, Ferruh Yigit: > On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > > - pkt_burst_stats_display("RX", &fs->rx_burst_stats); > > - pkt_burst_stats_display("TX", &fs->tx_burst_stats); > > + pkt_burst_stats_display(false, &fs->rx_burst_stats); > > + pkt_burst_stats_display(tr

Re: [dpdk-dev] [dpdk-techboard] rte_atomic deprecation discussion for the tech board meeting

2020-04-09 Thread Ananyev, Konstantin
Hi Honnappa, > > Adding the dev mailing list. We could not complete the discussion today in > the tech board. > > It was agreed that the older compilers without C11 atomic API support > (stdatomic.h) need to be supported and wrappers around C11 built- > ins can be provided. OVS [1] implement

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-09 Thread Mattias Rönnblom
On 2020-04-08 21:36, Jerin Jacob wrote: > On Wed, Apr 8, 2020 at 11:27 PM Mattias Rönnblom > wrote: >> Extend Eventdev API to allow for event devices which require various >> forms of internal processing to happen, even when events are not >> enqueued to or dequeued from a port. >> >> Signed-off-b

Re: [dpdk-dev] net/ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads

2020-04-09 Thread Martin Weiser
Sorry, please ignore my previous statement about this having been reworked in master. I was comparing to the wrong checkout. This issue seems to be still present in the current master. Am 09.04.20 um 14:06 schrieb Martin Weiser: > Hi, > > I should have mentioned that our findings apply to DPDK 20.

Re: [dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test

2020-04-09 Thread Ananyev, Konstantin
> > > > Subject: [PATCH v3 1/9] test/ring: add contention stress test > Minor, would 'add stress test for overcommitted use case' sound better? I liked to point out that this test-case can be used as contention stress-test (many threads do enqueue/dequeue to/from the same ring) for both over-

[dpdk-dev] DPDK Release Status Meeting 9/04/2020

2020-04-09 Thread Ferruh Yigit
Minutes 9 April 2020 Agenda: * Release Dates * Highlights * Subtrees Participants: * Arm * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.05 dates: * Integration/Merge/RC1: Friday 17 April 2020 * Release:Wednesday

Re: [dpdk-dev] [PATCH v2] net/pfe: fix double free of MAC address

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 2:59 AM, wangyunjian wrote: > From: Yunjian Wang > > The 'mac_addrs' freeing has been moved to rte_eth_dev_release_port(), > so freeing 'mac_addrs' like this in pfe_eth_exit() is unnecessary and > will cause double free. > > Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions")

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 5:16 PM Ferruh Yigit wrote: > > On 3/20/2020 6:13 AM, Jerin Jacob wrote: > > On Thu, Mar 19, 2020 at 7:21 PM Viacheslav Ovsiienko > > wrote: > >> > >> The execution time of rx/tx burst routine depends on the burst size. > >> It would be meaningful to research this dependenc

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, April 9, 2020 5:52 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/5] net/tap:

Re: [dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test

2020-04-09 Thread Ananyev, Konstantin
> > > +static int > > > +test_worker_prcs(void *arg) > > > +{ > > > + int32_t rc; > > > + uint32_t lc, n, num; > > minor, lcore instead of lc would be better > > > > > + uint64_t cl, tm0, tm1; > > > + struct lcore_arg *la; > > > + struct ring_elem def_elm, loc_elm; > > > + struct ring_elem *obj[

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 1:53 PM, wangyunjian wrote: > > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, April 9, 2020 5:52 PM >> To: wangyunjian ; dev@dpdk.org >> Cc: keith.wi...@intel.com; Lilijun (Jerry) ; >> xudingke >> ; sta...@dpdk.org >> Subject:

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Neil Horman
On Thu, Apr 09, 2020 at 12:59:50PM +0200, Thomas Monjalon wrote: > 09/04/2020 12:45, Ray Kinsella: > > On 09/04/2020 11:43, Bruce Richardson wrote: > > > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > > >> On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > > >>> On 08/0

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

2020-04-09 Thread Trahe, Fiona
Thanks David, Sounds good. I look forward to the v3. Fiona > -Original Message- > From: Coyle, David > Sent: Thursday, April 9, 2020 12:56 PM > To: Trahe, Fiona ; Yigit, Ferruh > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; he

Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020

2020-04-09 Thread Jerin Jacob
> * tracing library > * Some concerns on the API, it is copy/paste of log API The following API signatures are taken from log API. 1) void rte_trace_global_level_set(uint32_t level); 2) uint32_t rte_trace_global_level_get(void); 3) uint32_t rte_trace_level_get(rte_trace_t trace); 4) in

Re: [dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

2020-04-09 Thread Ferruh Yigit
On 4/8/2020 8:08 AM, asoma...@amd.com wrote: > From: Amaranath Somalapuram > > Adding API for get_module_eeprom and get_module_info. > > Signed-off-by: Amaranath Somalapuram > --- > drivers/net/axgbe/axgbe_ethdev.c | 2 + > drivers/net/axgbe/axgbe_phy.h | 4 ++ > drivers/net/axgbe/a

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 5:51 PM Mattias Rönnblom wrote: > > On 2020-04-08 21:36, Jerin Jacob wrote: > > On Wed, Apr 8, 2020 at 11:27 PM Mattias Rönnblom > > wrote: > >> Extend Eventdev API to allow for event devices which require various > >> forms of internal processing to happen, even when event

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-09 Thread Eads, Gage
> >> diff --git a/lib/librte_eventdev/rte_eventdev.h > >> b/lib/librte_eventdev/rte_eventdev.h > >> index 226f352ad..d69150792 100644 > >> --- a/lib/librte_eventdev/rte_eventdev.h > >> +++ b/lib/librte_eventdev/rte_eventdev.h > >> @@ -289,6 +289,15 @@ struct rte_event; > >>* single queue to eac

Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020

2020-04-09 Thread Thomas Monjalon
09/04/2020 15:10, Jerin Jacob: > > * tracing library > > * Some concerns on the API, it is copy/paste of log API > > The following API signatures are taken from log API. > > 1) void rte_trace_global_level_set(uint32_t level); > 2) uint32_t rte_trace_global_level_get(void); > 3) uint32_

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Thomas Monjalon
09/04/2020 15:02, Neil Horman: > On Thu, Apr 09, 2020 at 12:59:50PM +0200, Thomas Monjalon wrote: > > 09/04/2020 12:45, Ray Kinsella: > > > On 09/04/2020 11:43, Bruce Richardson wrote: > > > > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > > > >> On Thu, Apr 09, 2020 at 08:57:34AM +

Re: [dpdk-dev] [PATCH v3 2/9] ring: prepare ring to allow new sync schemes

2020-04-09 Thread Ananyev, Konstantin
> > Subject: [PATCH v3 2/9] ring: prepare ring to allow new sync schemes > > > > Change from *single* to *sync_type* to allow different synchronisation > > schemes to be applied. > > Mark *single* as deprecated in comments. > > Add new functions to allow user to query ring sync types. > > Replace d

Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 7:06 PM Thomas Monjalon wrote: > > 09/04/2020 15:10, Jerin Jacob: > > > * tracing library > > > * Some concerns on the API, it is copy/paste of log API > > > > The following API signatures are taken from log API. > > > > 1) void rte_trace_global_level_set(uint32_t

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Thomas Monjalon
Hi, 03/04/2020 17:36, jer...@marvell.com: > Features: > ~ > - APIs and Features are similar to rte_log dynamic framework > API(expect log prints on stdout vs it dumps on trace file) A log can print to syslog as well. As discussed somewhere else, please do not introduce global level in rt

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-09 Thread Mattias Rönnblom
On 2020-04-09 15:32, Jerin Jacob wrote: > On Thu, Apr 9, 2020 at 5:51 PM Mattias Rönnblom > wrote: >> On 2020-04-08 21:36, Jerin Jacob wrote: >>> On Wed, Apr 8, 2020 at 11:27 PM Mattias Rönnblom >>> wrote: Extend Eventdev API to allow for event devices which require various forms of int

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Lukasz Wojciechowski
W dniu 09.04.2020 o 13:13, Bruce Richardson pisze: > On Thu, Apr 09, 2020 at 12:54:10PM +0200, Thomas Monjalon wrote: >> 09/04/2020 12:14, Bruce Richardson: >>> On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote: 08/04/2020 17:49, Lukasz Wojciechowski: > Hi guys, > >

Re: [dpdk-dev] [PATCH v1] vhost: dequeue zero copy with linear buffers

2020-04-09 Thread Maxime Coquelin
On 3/26/20 9:03 AM, Sivaprasad Tummala wrote: > Removed the linear buffer and zero_copy compatibility restriction. > > Applications that requires packets contained in a single buffer > will enable linear buffer in vhost library. This restriction > is not allowing zero_copy mode for such cases.

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-09 Thread Lukasz Wojciechowski
W dniu 08.04.2020 o 19:47, Thomas Monjalon pisze: > 08/04/2020 18:15, Lukasz Wojciechowski: >> Hi Thomas, >> >> Before my patch there was just a definition: >> #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE >> without #ifndef condition. >> >> It caused a build problem to me when working on sec

Re: [dpdk-dev] [PATCH v1] net/vhost: add config option for linear and extbuf

2020-04-09 Thread Maxime Coquelin
On 2/26/20 11:00 AM, Sivaprasad Tummala wrote: > Added vHost PMD arguments 'linear-buffer' and 'ext-buffer' > to configure 'RTE_VHOST_USER_LINEARBUF_SUPPORT' and > 'RTE_VHOST_USER_EXTBUF_SUPPORT' flags in the vhost library > > Signed-off-by: Sivaprasad Tummala > --- > doc/guides/nics/vhost.r

[dpdk-dev] [PATCH] build: add arm 32bit cross compilation to Meson

2020-04-09 Thread Juraj Linkeš
* Add arm-linux-gnueabihf cross-file * Add generic and default arm 32 bit flags to arm meson.build * Add support for disabling drivers using flags defined in Meson * Change checks from dpdk_conf.has() to dpdk.conf.get() * When processing which drivers to build, check whether the appropriate

Re: [dpdk-dev] [RFC 1/3] eventdev: allow for event devices requiring maintenance

2020-04-09 Thread Mattias Rönnblom
On 2020-04-09 15:33, Eads, Gage wrote: diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index 226f352ad..d69150792 100644 --- a/lib/librte_eventdev/rte_eventdev.h +++ b/lib/librte_eventdev/rte_eventdev.h @@ -289,6 +289,15 @@ struct r

Re: [dpdk-dev] [PATCH v2 1/2] bitmap: add create bitmap with all bits set

2020-04-09 Thread Dumitrescu, Cristian
Hi Sunaming, > -Original Message- > From: Suanming Mou > Sent: Wednesday, April 8, 2020 4:06 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; a...@semihalf.com > Subject: [PATCH v2 1/2] bitmap: add create bitmap with all bits set > > Currently, in the case to use bitmap as resource all

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: fix for out of date comment

2020-04-09 Thread Maxime Coquelin
On 3/7/20 2:22 PM, Xiaolong Ye wrote: > Fix the comment that's incorrect as the code evolves. > > Fixes: 9470427c88e1 ("net/virtio: do not store PCI device pointer at shared > memory") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaolong Ye > --- > drivers/net/virtio/virtio_ethdev.c | 6 +++---

Re: [dpdk-dev] [PATCH v1 2/2] vhost: remove unused variable

2020-04-09 Thread Maxime Coquelin
On 3/7/20 2:22 PM, Xiaolong Ye wrote: > VHOST_FEATURES has been removed in previous refactor. > > Fixes: 0917f9d1f059 ("vhost: use new APIs to handle features") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaolong Ye > --- > lib/librte_vhost/vhost.h | 1 - > 1 file changed, 1 deletion(-) > > d

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Lukasz Wojciechowski
W dniu 09.04.2020 o 16:07, Lukasz Wojciechowski pisze: > > W dniu 09.04.2020 o 13:13, Bruce Richardson pisze: >> On Thu, Apr 09, 2020 at 12:54:10PM +0200, Thomas Monjalon wrote: >>> 09/04/2020 12:14, Bruce Richardson: On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote: > 08/

Re: [dpdk-dev] [PATCH v3] vhost: make iotlb cache name unique among multi processes

2020-04-09 Thread Maxime Coquelin
On 3/12/20 12:19 AM, Itsuro Oda wrote: > Currently, iotlb cache name is comprised of vid and virtqueue > index. For example, "iotlb_cache_0_0". Because vid is assigned > per process, iotlb cache name is not unique among multi processes. > For example a secondary process uses a vhost > (ex. eth_v

[dpdk-dev] [PATCH] net/mlx5: fix incorrect index when creating flow

2020-04-09 Thread Bing Zhao
When creating a flow, usually the creating routine is called in serial. No parallel execution is supported right now. The same function will be called only once for a single flow creation. But there is a special case that the creating routine will be called nested. If the xmeta feature is enabled a

Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats

2020-04-09 Thread Maxime Coquelin
Hi Matan, On 3/16/20 4:12 PM, Matan Azrad wrote: > The vDPA device offloads all the datapath of the vhost device to the HW > device. > > In order to expose to the user traffic information this patch introduce > new API to get traffic statistics per virtio queue. > > The statistics are taken dire

[dpdk-dev] [PATCH v2] net/mlx5: fix incorrect index when creating flow

2020-04-09 Thread Bing Zhao
When creating a flow, usually the creating routine is called in serial. No parallel execution is supported right now. The same function will be called only once for a single flow creation. But there is a special case that the creating routine will be called nested. If the xmeta feature is enabled a

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread Stephen Hemminger
On Thu, 9 Apr 2020 08:03:23 + wangyunjian wrote: > error = tap_write_mbufs(txq, num_mbufs, mbuf, > &num_packets, &num_tx_bytes); > if (error == -1) { > txq->stats.errs++; > /* free tso mbufs */ > for (j = 0; j < ret; j++) > rte_pktmbuf_free(mbuf[j]); >

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-09 Thread Ananyev, Konstantin
> > Introduce relaxed tail sync (RTS) mode for MT ring synchronization. > > Aim to reduce stall times in case when ring is used on overcommited cpus > > (multiple active threads on the same cpu). > > The main difference from original MP/MC algorithm is that tail value is > > increased not by every

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Ray Kinsella
On 09/04/2020 11:59, Thomas Monjalon wrote: > 09/04/2020 12:45, Ray Kinsella: >> On 09/04/2020 11:43, Bruce Richardson wrote: >>> On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote: > On 08/04/2020 20:56, Neil Horman

[dpdk-dev] [PATCH dpdk-dev v2 1/2] eal: introduce rte-init queue for libraries initialization

2020-04-09 Thread xiangxia . m . yue
From: Tonghao Zhang This patch introduces last-init queue, user can register a callback for theirs initialization. Running rte_last_init_run(), the almost resource of DPDK are available, such as memzone, ring. With this way, user don't introduce additional codes in eal layer. [This patch will be

[dpdk-dev] [PATCH dpdk-dev v2 2/2] mempool: use shared memzone for rte_mempool_ops

2020-04-09 Thread xiangxia . m . yue
From: Tonghao Zhang The order of mempool initiation affects mempool index in the rte_mempool_ops_table. For example, when building APPs with: $ gcc -lrte_mempool_bucket -lrte_mempool_ring ... The "bucket" mempool will be registered firstly, and its index in table is 0 while the index of "ring"

Re: [dpdk-dev] [PATCH dpdk-dev 1/2] eal: introduce last-init queue for libraries initialization

2020-04-09 Thread Tonghao Zhang
On Thu, Apr 9, 2020 at 7:31 PM Jerin Jacob wrote: > > On Thu, Apr 9, 2020 at 4:24 PM wrote: > > > > From: Tonghao Zhang > > > > This patch introduces last-init queue, user can register a > > callback for theirs initialization. Running rte_last_init_run(), > > the almost resource of DPDK are avai

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Thomas Monjalon
09/04/2020 16:52, Ray Kinsella: > On 09/04/2020 11:59, Thomas Monjalon wrote: > > 09/04/2020 12:45, Ray Kinsella: > >> On 09/04/2020 11:43, Bruce Richardson wrote: > >>> On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: > On Thu, Apr 09, 2020 at 08:57:34AM +0100, Ray Kinsella wrote:

Re: [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array

2020-04-09 Thread Maxime Coquelin
On 3/31/20 1:12 PM, Matan Azrad wrote: > As a preparation to listen the virtqs status before the device is > configured, manage the virtqs structures in array instead of list. > > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > drivers/vdpa/mlx5/mlx5_vdpa.c | 43 +++

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Thomas Monjalon
09/04/2020 16:21, Lukasz Wojciechowski: > W dniu 09.04.2020 o 16:07, Lukasz Wojciechowski pisze: > > W dniu 09.04.2020 o 13:13, Bruce Richardson pisze: > >> On Thu, Apr 09, 2020 at 12:54:10PM +0200, Thomas Monjalon wrote: > >>> 09/04/2020 12:14, Bruce Richardson: > On Wed, Apr 08, 2020 at 07:5

Re: [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop

2020-04-09 Thread Maxime Coquelin
On 3/31/20 1:12 PM, Matan Azrad wrote: > In live migration, before loging the virtq, the driver queries the virtq s/loging/logging/ > indexes after moving it to suspend mode. > > Separate this method to new function mlx5_vdpa_virtq_stop as a > preparation for reusing. > > Signed-off-by: Matan Azr

Re: [dpdk-dev] net/ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads

2020-04-09 Thread Ananyev, Konstantin
Hi Martin, > Sorry, please ignore my previous statement about this having been > reworked in master. I was comparing to the wrong checkout. > This issue seems to be still present in the current master. Can you please file a ticket with your findings in the bugzilla? Thanks Konstantin > > Am 09

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon wrote: > > Hi, > > 03/04/2020 17:36, jer...@marvell.com: > > Features: > > ~ > > - APIs and Features are similar to rte_log dynamic framework > > API(expect log prints on stdout vs it dumps on trace file) > > A log can print to syslog as well.

[dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app

2020-04-09 Thread Wisam Jaddo
Introduce new feature to dump memory statistics of each socket and a total for all before and after the creation. This will give two main advantage: 1- Check the memory consumption for large number of flows "insertion rate scenario alone" 2- Check that no memory leackage after doing insertion the

[dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-09 Thread Wisam Jaddo
Add flow performance application skeleton. Signed-off-by: Wisam Jaddo --- MAINTAINERS | 5 + app/Makefile | 1 + app/meson.build | 1 + app/test-flow-perf/Makefile | 26 +++ app/test-flow-perf/main.c

[dpdk-dev] [PATCH 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-09 Thread Wisam Jaddo
Add insertion rate calculation feature into flow performance application. The application now provide the ability to test insertion rate of specific rte_flow rule, by stressing it to the NIC, and calculate the insertion rate. The application offers some options in the command line, to configure w

[dpdk-dev] [PATCH 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-09 Thread Wisam Jaddo
Add the ability to test deletion rate for flow performance application. This feature is disabled by default, and can be enabled by add "--deletion-rate" in the application command line options. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 87 ++

[dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support

2020-04-09 Thread Wisam Jaddo
Introduce packet forwarding support to the app to do some performance measurements. The measurements are reported in term of packet per second unit. The forwarding will start after the end of insertion/deletion operations. The support has single and multi performance measurements. Signed-off-by:

[dpdk-dev] [PATCH] doc: update hairpin data buffer size config

2020-04-09 Thread Bing Zhao
This patch updates the MLX5 PMD and release notes documentations. Adding the guideline for hairpin data buffer size configuration. Signed-off-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 11 +++ doc/guides/rel_notes/release_20_05.rst | 1 + 2 files changed, 12 insertions(+

  1   2   >