[dpdk-dev] [PATCH] event/cnxk: fix reading stale Tx queue depth

2021-07-20 Thread pbhagavatula
From: Pavan Nikhilesh Reads to Tx queue FC memory need to be atomic to avoid cores using same Tx queue spinning on stale values. Fixes: 313e884a22fd ("event/cnxk: support Tx adapter fast path") Signed-off-by: Pavan Nikhilesh --- Please squash this into next-event tree drivers/event/cnxk/cn9

Re: [dpdk-dev] [PATCH v6 2/3] vhost: rework async configuration structure

2021-07-20 Thread Maxime Coquelin
On 7/19/21 5:00 PM, Jiayu Hu wrote: > This patch reworks the async configuration structure to improve code > readability. In addition, add preserved padding fields on the structure > for future usage. > > Signed-off-by: Jiayu Hu > Reviewed-by: Chenbo Xia > --- > doc/guides/prog_guide/vhost_l

Re: [dpdk-dev] [EXT] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-20 Thread Pavan Nikhilesh Bhagavatula
>Older compilers may not support all arch versions and all features that >the target SoC supports, in which case it's better to figure out the >highest arch version and features that the compiler supports. >Implement >a way to achieve this: >1. Find the highest arch version that the compiler suppor

Re: [dpdk-dev] [PATCH v6 3/3] vhost: add thread unsafe async registeration functions

2021-07-20 Thread Maxime Coquelin
On 7/19/21 5:00 PM, Jiayu Hu wrote: > This patch adds thread unsafe version for async register and > unregister functions. > > Signed-off-by: Jiayu Hu > Reviewed-by: Chenbo Xia > --- > doc/guides/prog_guide/vhost_lib.rst | 16 > lib/vhost/rte_vhost_async.h | 41 ++ > l

Re: [dpdk-dev] [PATCH v6 2/3] vhost: rework async configuration structure

2021-07-20 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 20, 2021 3:18 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Xia, Chenbo > Subject: Re: [PATCH v6 2/3] vhost: rework async configuration structure > > > > On 7/19/21 5:00 PM, Jiayu Hu wrote: > > This patch reworks the async

[dpdk-dev] [PATCH v3] net/virtio: fix Rx scatter offload

2021-07-20 Thread Andrew Rybchenko
From: Ivan Ilchenko Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. If Rx scatter is not requested, ensure that provided Rx buffers on each Rx queue are big enough to fit Rx packets up to configured MTU. Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") C

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Akhil Goyal
> > > > v2: > > > - Add data-path part. > > > > > > v3: > > > - Rebase. > > > > > > v4: > > > - Rebase + Address the following Akhil comments: > > > - Set HW feature flag in the capability patch. > > > - Fix mp object release in session clear. > > > - Some spelling and word missing in doc. > > >

Re: [dpdk-dev] [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management

2021-07-20 Thread Akhil Goyal
> > > A DEK(Data encryption Key) is an mlx5 HW object which represents the > > > cipher algorithm key. > > > The DEKs are used during data encryption/decryption operations. > > > > > > In symmetric algorithms like AES-STS, we use the same DEK for both > > > encryption and decryption. > > > > > > Us

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Akhil Goyal
> > > > > v2: > > > > > - Add data-path part. > > > > > > > > > > v3: > > > > > - Rebase. > > > > > > > > > > v4: > > > > > - Rebase + Address the following Akhil comments: > > > > > - Set HW feature flag in the capability patch. > > > > > - Fix mp object release in session clear. > > > > > - Some

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Akhil Goyal
> > Sorry for the late reply, Shiri is not available these days, so I'm trying > > to > > follow up the status and update the new version later today. > > Regarding the compilation failure, it's due to the crypto patch series > depends > > on some mlx5 common code. > > The mlx5 common code has so

Re: [dpdk-dev] [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management

2021-07-20 Thread Akhil Goyal
> > > > > A DEK(Data encryption Key) is an mlx5 HW object which represents > > > > > the cipher algorithm key. > > > > > The DEKs are used during data encryption/decryption operations. > > > > > > > > > > In symmetric algorithms like AES-STS, we use the same DEK for both > > > > > encryption and de

Re: [dpdk-dev] [PATCH] ethdev: fix representor port ID search by name

2021-07-20 Thread Andrew Rybchenko
On 7/19/21 3:50 PM, Xueming(Steven) Li wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, July 19, 2021 8:36 PM To: Xueming(Steven) Li ; Ajit Khaparde ; Somnath Kotur ; John Daley ; Hyong Youb Kim ; Beilei Xing ; Qiming Yang ; Qi Zhang ; Haiyue Wang ; Matan Azrad ; Shah

Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-20 Thread Akhil Goyal
> -Original Message- > From: Suanming Mou > Sent: Tuesday, July 20, 2021 2:29 PM > To: Akhil Goyal ; Shiri Kuzin ; > dev@dpdk.org > Cc: Matan Azrad ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations > > > > > -Original Message---

Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-20 Thread Akhil Goyal
> > > Sessions are used in symmetric transformations in order to prepare > > > objects and data for packet processing stage. > > > > > > A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, > > > bsf_size, bsf_p_type, block size index, encryption_order and > > > encryption standard

Re: [dpdk-dev] [PATCH v8] dmadev: introduce DMA device library

2021-07-20 Thread Jerin Jacob
On Tue, Jul 20, 2021 at 12:23 PM fengchengwen wrote: > > Thanks Jerin, comment inline > > On 2021/7/20 13:03, Jerin Jacob wrote: > > On Tue, Jul 20, 2021 at 6:48 AM Chengwen Feng > > wrote: > >> > >> This patch introduce 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs

Re: [dpdk-dev] [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors

2021-07-20 Thread Akhil Goyal
> > > > > The AES-XTS algorithm supports using a wrapped key. > > > In AES-XTS the data-unit defines the data block size to be > > > encrypted\decrypted. > > > > > > Add AES-XTS vectors with a wrapped key. > > > Add a variable stating whether the key is wrapped or not. > > > Add the AES-XTS data-un

Re: [dpdk-dev] [PATCH] examples/pipeline: fix build

2021-07-20 Thread Thomas Monjalon
12/07/2021 10:08, Dumitrescu, Cristian: > From: Ali Alnubani > > This patch fixes the following build failures seen on Ubuntu 16.04 > > with gcc 5.4.0 because of uninitialized variables: > > Acked-by: Cristian Dumitrescu Applied, thanks

Re: [dpdk-dev] [PATCH v8] dmadev: introduce DMA device library

2021-07-20 Thread Bruce Richardson
On Tue, Jul 20, 2021 at 02:53:08PM +0800, fengchengwen wrote: > Thanks Jerin, comment inline > > On 2021/7/20 13:03, Jerin Jacob wrote: > > On Tue, Jul 20, 2021 at 6:48 AM Chengwen Feng > > wrote: > >> > >> This patch introduce 'dmadevice' which is a generic type of DMA > >> device. > >> > >> Th

Re: [dpdk-dev] [PATCH v2] build: check AVX512 rather than compiler version

2021-07-20 Thread Bruce Richardson
On Mon, Jul 19, 2021 at 11:34:33PM +0100, Liang Ma wrote: > From: Liang Ma > > GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. > Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 > > Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, > whic

Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-20 Thread Thomas Monjalon
19/07/2021 18:42, Ferruh Yigit: > On 7/15/2021 2:20 PM, Paulis Gributs wrote: > > This patch removes most uses of the global variable rte_eth_devices > > from testpmd. This was done to avoid using the object directly which > > applications should not do. > > > > Most uses have been replaced with s

Re: [dpdk-dev] [PATCH v9 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-20 Thread David Marchand
On Wed, Jul 14, 2021 at 11:02 AM wrote: > > From: Pavan Nikhilesh > > Add support for event eth Rx adapter fastpath operations. > > Signed-off-by: Pavan Nikhilesh This patch triggers a build issue for arm64 cross compiling on my system with a 8.3 toolchain from Linaro. I ended up upgrading my t

[dpdk-dev] [PATCH v9] dmadev: introduce DMA device library

2021-07-20 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v9: * delete RTE_ASSERT invoke. * make sure vchan setup fail when devic

[dpdk-dev] [PATCH v3] build: check AVX512 rather than compiler version

2021-07-20 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which cause building failure with debug buildtype. Therefore, it's helpful

Re: [dpdk-dev] [PATCH v2] build: check AVX512 rather than compiler version

2021-07-20 Thread Liang Ma
On Tue, Jul 20, 2021 at 11:19:48AM +0100, Bruce Richardson wrote: > On Mon, Jul 19, 2021 at 11:34:33PM +0100, Liang Ma wrote: > > From: Liang Ma > > > > GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. > > Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 >

Re: [dpdk-dev] [EXT] Re: [PATCH v9 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-20 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: David Marchand >Sent: Tuesday, July 20, 2021 4:33 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton >; dev >Subject: [EXT] Re: [dpdk-dev] [PATCH v9 2/7] event/cnxk: add Rx >adapter fastpath ops > >External Email > >-

[dpdk-dev] [PATCH] net/mlx5: fix meta register conversion for extensive mode

2021-07-20 Thread Alexander Kozyrev
Register C is used in the extensive metadata mode number 1 and its width can vary from 0 to 32 bits depending on the kernel usage of it. There are several issues associated with this mode (dv_xmeta_en=1): 1. The metadata setting assumes that the width is always 16 bits, which is the most common ca

Re: [dpdk-dev] [EXT] Re: [PATCH v9 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-20 Thread David Marchand
On Tue, Jul 20, 2021 at 1:43 PM Pavan Nikhilesh Bhagavatula wrote: > >This patch triggers a build issue for arm64 cross compiling on my > >system with a 8.3 toolchain from Linaro. > >I ended up upgrading my toolchain (which solved the issue), but some > >users might hit this, so posting for info:

[dpdk-dev] [PATCH v2] net/mlx5: fix meta register conversion for extensive mode

2021-07-20 Thread Alexander Kozyrev
Register C is used in the extensive metadata mode number 1 and its width can vary from 0 to 32 bits depending on the kernel usage of it. There are several issues associated with this mode (dv_xmeta_en=1): 1. The metadata setting assumes that the width is always 16 bits, which is the most common ca

[dpdk-dev] [PATCH] net/mlx5: fix invalid Rx/Tx queue checks

2021-07-20 Thread Dmitry Kozlyuk
When device configuration was interrupted by a signal, mlx5_rxq/txq_release() could access yet unitinialized array and crash the application. Add checks whether queue array is initialized. Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx queues") Fixes: 6e78005a9b30 ("net/mlx5: add

Re: [dpdk-dev] [PATCH v3] build: check AVX512 rather than compiler version

2021-07-20 Thread Bruce Richardson
On Tue, Jul 20, 2021 at 12:20:59PM +0100, Liang Ma wrote: > From: Liang Ma > > GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. > Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 > > Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, > whic

Re: [dpdk-dev] [EXT] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-20 Thread Juraj Linkeš
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Tuesday, July 20, 2021 9:25 AM > To: Juraj Linkeš ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; > fengcheng...@huawei.com; ferruh.yi...

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework

2021-07-20 Thread Akhil Goyal
Hi David, > > > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > > 'net_octeontx'] > > > +deps += ['crypto_octeontx'] > > > > This extra dependency resulted in disabling the event/octeontx driver > > in FreeBSD, since crypto/octeontx only builds on Linux. > > Removing hw support t

Re: [dpdk-dev] [PATCH v9] dmadev: introduce DMA device library

2021-07-20 Thread Bruce Richardson
On Tue, Jul 20, 2021 at 07:12:52PM +0800, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework

2021-07-20 Thread David Marchand
On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal wrote: > > Hi David, > > > > > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > > > 'net_octeontx'] > > > > +deps += ['crypto_octeontx'] > > > > > > This extra dependency resulted in disabling the event/octeontx driver > > > in FreeBSD,

Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices

2021-07-20 Thread Ferruh Yigit
On 7/20/2021 11:35 AM, Thomas Monjalon wrote: > 19/07/2021 18:42, Ferruh Yigit: >> On 7/15/2021 2:20 PM, Paulis Gributs wrote: >>> This patch removes most uses of the global variable rte_eth_devices >>> from testpmd. This was done to avoid using the object directly which >>> applications should not

Re: [dpdk-dev] [PATCH v4 00/20] net/sfc: support flow API COUNT action

2021-07-20 Thread David Marchand
On Fri, Jul 2, 2021 at 10:40 AM Andrew Rybchenko wrote: > > Update base driver and support COUNT action in transfer flow rules. > > v4: > - fix build on Fedora 32 and RHEL 8 / CentOS 8 with half-installed >libatomic > > v3: > - fix build brekage because of incorrectly rebased and squashed >

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Suanming Mou
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 20, 2021 4:14 PM > To: Shiri Kuzin ; NBU-Contact-Thomas Monjalon > ; Matan Azrad ; Suanming Mou > > Cc: david.march...@redhat.com; dev@dpdk.org > Subject: RE: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PM

Re: [dpdk-dev] [EXT] [PATCH v8 01/16] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:19 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 01/16] drivers: introduce mlx5 crypto PMD > > > diff --git a/doc/guides/rel_no

Re: [dpdk-dev] [PATCH v1] lib/distributor: fix unaligned 128-bit write

2021-07-20 Thread Thomas Monjalon
16/07/2021 15:32, David Hunt: > When the distributor sample app is built as a 32-bit app, > the data buffer passed to find_match_vec can be unaligned, > causing a segmentation fault due to writing a 128-bit value > using _mm_store_si128(). 128-bit align the data being > passed in so this does not

Re: [dpdk-dev] [PATCH v1] lib/distributor: fix unaligned 128-bit write

2021-07-20 Thread Thomas Monjalon
16/07/2021 15:32, David Hunt: > When the distributor sample app is built as a 32-bit app, > the data buffer passed to find_match_vec can be unaligned, > causing a segmentation fault due to writing a 128-bit value > using _mm_store_si128(). 128-bit align the data being > passed in so this does not

Re: [dpdk-dev] [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:26 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management > > > A DEK(Data encryption Key)

[dpdk-dev] [PATCH v3 1/2] config/arm: split march cfg into arch and features

2021-07-20 Thread Juraj Linkeš
Older compilers may not support all arch versions and all features that the target SoC supports, in which case it's better to figure out the highest arch version and features that the compiler supports. Implement a way to achieve this: 1. Find the highest arch version that the compiler supports, ke

[dpdk-dev] [PATCH v3 2/2] config/arm: make n2 'crypto' an optional feature

2021-07-20 Thread Juraj Linkeš
Not all Neoverse-N2 cpus must support the crypto feature/extension which makes it an optional feature. Only enable the feature for SoCs which support it. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.

Re: [dpdk-dev] [EXT] [PATCH v8 04/16] crypto/mlx5: add basic operations

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:34 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 04/16] crypto/mlx5: add basic operations > > > The basic dev control operation

Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 20, 2021 4:42 PM > To: Suanming Mou ; Shiri Kuzin ; > NBU-Contact-Thomas Monjalon ; Matan Azrad > > Cc: david.march...@redhat.com; dev@dpdk.org > Subject: RE: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD > > >

[dpdk-dev] [PATCH v10] dmadev: introduce DMA device library

2021-07-20 Thread Chengwen Feng
This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v10: * fix rte_dmadev_completed_status comment. v9: * delete RTE_ASSERT

Re: [dpdk-dev] [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 20, 2021 4:36 PM > To: Suanming Mou ; Shiri Kuzin ; > dev@dpdk.org > Cc: Matan Azrad ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 02/16] crypto/mlx5: add DEK object management > > > > > A DEK(Data encryption K

Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:40 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations > > doc/guides/cryptodevs/mlx5.rst

Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:44 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations > > > Sessions are used in symmetri

Re: [dpdk-dev] [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start operations

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:45 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 06/16] crypto/mlx5: add dev stop and start > operations > > > Add the dev_star

[dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported

2021-07-20 Thread Adam Dybkowski
This patch adds checking if RAW API is supported at the start of the test command "cryptodev_qat_raw_api_autotest". Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/app/test/tes

Re: [dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported

2021-07-20 Thread Zhang, Roy Fan
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, July 20, 2021 2:12 PM > To: dev@dpdk.org; Zhang, Roy Fan ; > gak...@marvell.com > Cc: Dybkowski, AdamX > Subject: [PATCH v4] test/crypto: check if RAW API is supported > > This patch adds checking if RAW API is supported at t

Re: [dpdk-dev] dpdk-testpmd app with SRIOV VF on Kubernetes POD not working

2021-07-20 Thread Truring Team
Hi Everyone , Can someone please look into this and analyse logs ? I need help to proceed further . Best Regards Puneet On Fri, 16 Jul 2021 at 09:34, Truring Team wrote: > Hi Everyone, > > > We have Kubernetes setup where Master Node and one worker node are there > and tried running dpdk-test

Re: [dpdk-dev] [PATCH v3] build: check AVX512 rather than compiler version

2021-07-20 Thread Liang Ma
On Tue, Jul 20, 2021 at 12:58:13PM +0100, Bruce Richardson wrote: > One minor comment below. Also the commit title needs rewording, since the > current title is based on the changes from V1->V2 of your patch. I'd > suggest something like: > "build: check for broken AVX-512 compiler support" > >

Re: [dpdk-dev] [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors

2021-07-20 Thread Suanming Mou
> -Original Message- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 4:06 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped > vectors > > > The AES-XTS algo

Re: [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe

2021-07-20 Thread Thomas Monjalon
20/07/2021 00:00, Stephen Hemminger: > On Mon, 19 Jul 2021 10:15:34 -0700 > Tyler Retzlaff wrote: > > > On Tue, Jul 13, 2021 at 01:12:21PM -0700, Stephen Hemminger wrote: > > > The first argument to rte_bsf32_safe was incorrectly declared as > > > a 64 bit value. This function only correctly hand

[dpdk-dev] [PATCH v4] build: check for broken AVX-512 compiler support

2021-07-20 Thread Liang Ma
From: Liang Ma GCC 6.3.0 has a known bug which related to _mm512_extracti64x4_epi64. Please reference https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82887 Some DPDK PMD avx512 version heavily use _mm512_extracti64x4_epi6, which cause building failure with debug buildtype. Therefore, it's helpful

Re: [dpdk-dev] [dpdk-stable] [PATCH] raw/ioat: fix config script queue size calculation

2021-07-20 Thread David Marchand
On Fri, Jul 16, 2021 at 3:22 PM Kevin Laatz wrote: > > The queue size calculation is currently based on "max_tokens" rather than > "max_work_queues_size". This is resulting in the queue size being > incorrectly configured when using the script to configure devices bound to > the IDXD kernel driver

Re: [dpdk-dev] [PATCH] raw/ioat: fix termination descriptor for batch

2021-07-20 Thread David Marchand
On Fri, Jul 16, 2021 at 4:28 PM Bruce Richardson wrote: > > On Fri, Jul 16, 2021 at 02:50:27PM +0100, Konstantin Ananyev wrote: > > When batch_size == 1, idxd has to add a dummy termination descriptor > > to satisfy HW requirements. > > Right now it uses NOP descriptor with FENCE flag. > > This is

[dpdk-dev] DPDK Packet drop/Out of sequence issue with Jumbo frames on MLX ConnectX-4 Lx NIC

2021-07-20 Thread Balbeer Tiwari
Hi There, I am using MLX ConnectX-4 Lx with DPDK and with this I am observing packet drops at receiver if size greater than ~8k(jumbo) frames. Smaller packets go through fine. Its being run directly on baremetal with Centos 8.3. Please can you share if there is any fix for this. Regards, Bal

[dpdk-dev] [PATCH] bus/vmbus: Fix crash when handling packets in secondary process

2021-07-20 Thread jerb
Have secondary processes construct their own copy of primary channel with own mappings. Remove vmbus_channel primary ptr from struct mapped_vmbus_resource as its not used. Populate virtual memory address "addr" in struct rte_mem_resource for secondary processes as netvsc will attempt to reference

Re: [dpdk-dev] DPDK Packet drop/Out of sequence issue with Jumbo frames on MLX ConnectX-4 Lx NIC

2021-07-20 Thread Balbeer Tiwari
Hi Asaf, Please see details, let me know if more details required. What DPDK version do you use? DPDK-20.05 What EAL and devargs value are being used? Following are the argv at eal_init 1005 if (rte_eal_init(argc, argv) < 0) (gdb) p argv $7 = {0x72bce60 "fast_pkt_app", 0x72bc

Re: [dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check

2021-07-20 Thread David Marchand
On Wed, Jul 14, 2021 at 2:23 PM David Hunt wrote: > On 14/7/2021 11:44 AM, Richael Zhuang wrote: > > For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and > > scaling_cur_freq exist. For pstate, only scaling_cur_freq exists. > > And value in scaling_cur_freq and cpuinfo_cur_freq may not be

Re: [dpdk-dev] [PATCH v2 1/1] power: fix potential null dereferences

2021-07-20 Thread David Marchand
On Fri, Jul 9, 2021 at 5:57 PM Anatoly Burakov wrote: > > Currently, the error paths can lead to attempts at dereferencing NULL > pointers. Add the check to avoid attempts at dereferencing NULL > pointers. > > Coverity issue: 371895 > Coverity issue: 371889 > Fixes: 06cffd468fdd ("power: refactor

Re: [dpdk-dev] [PATCH v2 1/2] net/sfc: extend logging in MAE backend of RTE flow support

2021-07-20 Thread David Marchand
On Fri, Jul 16, 2021 at 4:20 AM Ivan Malov wrote: > > Extra log statements will provide more details to the user > in the case of errors discovered in the pattern or actions. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- > drivers/net/sfc/sfc_m

[dpdk-dev] [PATCH] net/bnxt: fix null pointer dereferences

2021-07-20 Thread Kalesh A P
From: Kalesh AP Coverity reports that pointer "cpr->cp_ring_struct" may be dereferenced with null value. This patch fixes this. Coverity issue: 372063 Fixes: 5ed30db87fa8 ("net/bnxt: fix missing barriers in completion handling") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Kh

Re: [dpdk-dev] [PATCH v3] net/virtio: fix Rx scatter offload

2021-07-20 Thread Maxime Coquelin
On 7/20/21 9:54 AM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. > > If Rx scatter is not requested, ensure that provided Rx buffers on > each Rx queue are big enough to fit Rx packets up to configured MTU. > > Fi

Re: [dpdk-dev] [PATCH 03/11] ethdev: fix docs of functions getting xstats by IDs

2021-07-20 Thread Ferruh Yigit
On 6/4/2021 3:42 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Document valid combinations of input arguments in accordance with > current implementation in ethdev. > > Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed-

[dpdk-dev] [PATCH v2] test: avoid hang if queues are full and Tx fails

2021-07-20 Thread Rakesh Kudurumalla
Current pmd_perf_autotest() in continuous mode tries to enqueue MAX_TRAFFIC_BURST completely before starting the test. Some drivers cannot accept complete MAX_TRAFFIC_BURST even though rx+tx desc count can fit it. This patch changes behaviour to stop enqueuing after few retries. Fixes: 002ade70e93

Re: [dpdk-dev] [PATCH 04/11] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-07-20 Thread Ferruh Yigit
On 6/4/2021 3:42 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Update xstats by IDs callbacks documentation in accordance with > ethdev usage of these callbacks. Document valid combinations of > input arguments to make driver implementation simpler. > > Fixes: 79c913a42f0 ("ethdev: retri

[dpdk-dev] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Suanming Mou
v2: - Add data-path part. v3: - Rebase. v4: - Rebase + Address the following Akhil comments: - Set HW feature flag in the capability patch. - Fix mp object release in session clear. - Some spelling and word missing in doc. - Squash data-unit adjustment to the session operations commit. - Wording:

[dpdk-dev] [PATCH v9 01/15] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin Add a new PMD for Mellanox devices- crypto PMD. The crypto PMD will be supported starting Nvidia ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 D

[dpdk-dev] [PATCH v9 02/15] crypto/mlx5: add DEK object management

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin A DEK(Data encryption Key) is an mlx5 HW object which represents the cipher algorithm key. The DEKs are used during data encryption/decryption operations. In symmetric algorithms like AES-STS, we use the same DEK for both encryption and decryption. Use the mlx5 hash-list tool

[dpdk-dev] [PATCH v9 05/15] crypto/mlx5: add session operations

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, bsf_size, bsf_p_type, block size index, encryption_order and encryption standard. Implement th

[dpdk-dev] [PATCH v9 03/15] crypto/mlx5: add basic operations

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin The basic dev control operations are configure, close, start, stop and get info. Extended the existing support of configure and close: -mlx5_crypto_dev_configure- function used to configure device. -mlx5_crypto_dev_close- function used to close a configured

[dpdk-dev] [PATCH v9 06/15] crypto/mlx5: add memory region management

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin Mellanox user space drivers don't deal with physical addresses as part of a memory protection mechanism. The device translates the given virtual address to a physical address using the given memory key as an address space identifier. That's why any mbuf virtual address is moved

[dpdk-dev] [PATCH v9 09/15] crypto/mlx5: add maximum segments devarg

2021-07-20 Thread Suanming Mou
The mlx5 HW crypto operations are done by attaching crypto property to a memory region. Once done, every access to the memory via the crypto-enabled memory region will result with in-line encryption or decryption of the data. As a result, the design choice is to provide two types of WQEs. One is U

[dpdk-dev] [PATCH v9 08/15] crypto/mlx5: add keytag devarg

2021-07-20 Thread Suanming Mou
A keytag is a piece of data encrypted together with a DEK. When a DEK is referenced by an MKEY.bsf through its index, the keytag is also supplied in the BSF as plaintext. The HW will decrypt the DEK (and the attached keytag) and will fail the operation if the keytags don't match. This commit adds

[dpdk-dev] [PATCH v9 07/15] crypto/mlx5: create login object using DevX

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin To work with crypto engines that are marked with wrapped_import_method, a login session is required. A crypto login object needs to be created using DevX. The crypto login object contains: - The credential pointer. - The import_KEK pointer to be used for all sec

[dpdk-dev] [PATCH v9 11/15] crypto/mlx5: add enqueue and dequeue operations

2021-07-20 Thread Suanming Mou
The crypto operations are done with the WQE set which contains one UMR WQE and one rdma write WQE. Most segments of the WQE set are initialized properly during queue setup, only limited segments are initialized according to the crypto detail in the datapath process. This commit adds the enquue and

[dpdk-dev] [PATCH v9 04/15] crypto/mlx5: add queue pairs operations

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin The HW queue pairs are a pair of send queue and receive queue of independent work queues packed together in one object for the purpose of transferring data between nodes of a network. Completion Queue is a FIFO queue of completed work requests. In crypto driver we use one QP i

[dpdk-dev] [PATCH v9 15/15] test/crypto: add mlx5 crypto driver

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin In order to test the new mlx5 crypto PMD, the driver is added to the crypto test application. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 2 ++ doc/guides/cryptodevs/mlx5.rst | 3 +++ 3 fil

[dpdk-dev] [PATCH v9 10/15] crypto/mlx5: add WQE set initialization

2021-07-20 Thread Suanming Mou
Currently, HW handles the WQEs much faster than the software, Using the constant WQE set layout can initialize most of the WQE segments in advanced, and software only needs to configure very limited segments in datapath. This accelerates the software WQE organize in datapath. This commit initializ

[dpdk-dev] [PATCH v9 12/15] crypto/mlx5: add statistic get and reset operations

2021-07-20 Thread Suanming Mou
This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- doc/guides/rel_notes/release_21_08.rst | 5 drivers/crypto/mlx5/mlx5_crypto.c | 40 -- 2 files changed, 42 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH v9 13/15] test/crypto: add data-unit and wrapped vectors

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin The AES-XTS algorithm supports using a wrapped key. In AES-XTS the data-unit defines the data block size to be encrypted\decrypted. Add AES-XTS vectors with a wrapped key. Add a variable stating whether the key is wrapped or not. Add the AES-XTS data-unit. Signed-off-by: Shiri

[dpdk-dev] [PATCH v9 14/15] test/crypto: add AES-XTS multi segment OOP tests

2021-07-20 Thread Suanming Mou
From: Shiri Kuzin The AES-XTS algorithm can supports wrapped key and data-unit. The encryption/decryption can be done out of place and using multi segments. Add multi segment and out of place tests to the recently added AES-XTS vectors, which support using data-unit and a wrapped key. Signed-of

[dpdk-dev] [PATCH] test/crypto: increase mbuf data payload size to 4K

2021-07-20 Thread Suanming Mou
Currently, there is vendor which can support bigger crypto data size. Increase the default mbuf data payload size to 4K as needed. Signed-off-by: Suanming Mou --- app/test/test_cryptodev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.h b/app/test/te

[dpdk-dev] [Bug 760] net/sfc build failure with clang 3.4.2

2021-07-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=760 Bug ID: 760 Summary: net/sfc build failure with clang 3.4.2 Product: DPDK Version: 21.08 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Prior

Re: [dpdk-dev] DPDK Packet drop/Out of sequence issue with Jumbo frames on MLX ConnectX-4 Lx NIC

2021-07-20 Thread Asaf Penso
Hello Balbeer, Can you please provide more details? What DPDK version do you use? What EAL and devargs value are being used? Regards, Asaf Penso >-Original Message- >From: dev On Behalf Of Balbeer Tiwari >Sent: Tuesday, July 20, 2021 4:54 PM >To: dev@dpdk.org >Subject: [dpdk-dev] DPDK P

[dpdk-dev] [PATCH v1] net/mlx5: fix ETH validation for GTP

2021-07-20 Thread Lior Margalit
The user is able to create a flow rule pattern with ETH after GTP although it is not supported by the flex-parser configuration. Failed the rule validation in such case with proper error message. Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH] net/mlx5: fix representor interrupts handler assignment

2021-07-20 Thread Gregory Etelson
In mlx5 PMD the PCI device interrupt vector was used by Uplink representor exclusively and other VF representors did not support interrupt mode. All the VFs and Uplink representors are separate ethernet devices and must have dedicated interrupt vectors. The fix provides each representor with a dedi

Re: [dpdk-dev] [EXT] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Akhil Goyal
> v2: > - Add data-path part. > > v3: > - Rebase. > > v4: > - Rebase + Address the following Akhil comments: > - Set HW feature flag in the capability patch. > - Fix mp object release in session clear. > - Some spelling and word missing in doc. > - Squash data-unit adjustment to the session opera

Re: [dpdk-dev] [PATCH v4] test/crypto: check if RAW API is supported

2021-07-20 Thread Akhil Goyal
> > This patch adds checking if RAW API is supported at the start > > of the test command "cryptodev_qat_raw_api_autotest". > > > > Signed-off-by: Adam Dybkowski > > --- > Acked-by: Fan Zhang Acked-by: Akhil Goyal Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH v4] build: optional NUMA and cpu counts detection

2021-07-20 Thread David Christensen
On 7/16/21 6:53 AM, Juraj Linkeš wrote: -Original Message- From: David Christensen Sent: Tuesday, July 6, 2021 8:11 PM To: Bruce Richardson ; Juraj Linkeš Cc: tho...@monjalon.net; david.march...@redhat.com; honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; ferruh.yi...@intel.com

Re: [dpdk-dev] [PATCH v2] crypto/mvsam: IPSec full offload support

2021-07-20 Thread Akhil Goyal
> From: Michael Shamis > > This patch provides the support for IPSec protocol > offload to the hardware. > Following security operations are added: > - session_create > - session_destroy > - capabilities_get > > Signed-off-by: Michael Shamis > Reviewed-by: Liron Himi > Tested-by: Liron Himi >

Re: [dpdk-dev] [EXT] [PATCH v9 00/15] drivers: introduce mlx5 crypto PMD

2021-07-20 Thread Akhil Goyal
> > v2: > > - Add data-path part. > > > > v3: > > - Rebase. > > > > v4: > > - Rebase + Address the following Akhil comments: > > - Set HW feature flag in the capability patch. > > - Fix mp object release in session clear. > > - Some spelling and word missing in doc. > > - Squash data-unit adjustmen

Re: [dpdk-dev] [PATCH] net/bnxt: fix null pointer dereferences

2021-07-20 Thread Ajit Khaparde
On Tue, Jul 20, 2021 at 9:01 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > Coverity reports that pointer "cpr->cp_ring_struct" may be > dereferenced with null value. This patch fixes this. > > Coverity issue: 372063 > Fixes: 5ed30db87fa8 ("net/bnxt: fix missing

Re: [dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC

2021-07-20 Thread Ajit Khaparde
On Sat, Jul 17, 2021 at 10:10 PM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > On older Wh+ firmware versions, HWRM_FUNC_QCFG returns zero > for the parent default vnic. Commit "3fb93bc7c349" added a > temporary Wh+-specific workaround in the PMD. > This has been

[dpdk-dev] [PATCH v7 0/4] support async dequeue for split ring

2021-07-20 Thread Wenwu Ma
This patch implements asynchronous dequeue data path for split ring. A new asynchronous dequeue function is introduced. With this function, the application can try to receive packets from the guest with offloading large copies to the DMA engine, thus saving precious CPU cycles. v7: - Add Reviewed-

[dpdk-dev] [PATCH v7 1/4] examples/vhost: refactor vhost enqueue and dequeue datapaths

2021-07-20 Thread Wenwu Ma
Previously, by judging the flag, we call different enqueue/dequeue functions in data path. Now, we use an ops that was initialized when Vhost was created, so that we can call ops directly in Vhost data path without any more flag judgment. Signed-off-by: Wenwu Ma Reviewed-by: Maxime Coquelin ---

  1   2   >