Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/914
Thank you, @bitblender, for your in-person review. I've pushed a commit
that reflects your comments.
---
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/1014
Thanks I took a look.
---
Here are the topics so far:
Unit Testing - Tim
1.12 Release - Arina
Metadata Management - Padma
Thanks
Padma
On Nov 13, 2017, at 1:15 PM, Padma Penumarthy
mailto:ppenumar...@mapr.com>> wrote:
Drill hangout tomorrow Nov 14th, at 10 AM PST.
Please send email or bring them up tomorrow, if you ha
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/978
---
[
https://issues.apache.org/jira/browse/DRILL-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthikeyan Manivannan resolved DRILL-4708.
---
Resolution: Works for Me
> connection closed unexpectedly
> --
Hi All,
Here is the next installment in the “batch size control” project update.
Drill has a great many operators. As we move forward, we must update them to
use the new batch size control framework. Unit testing becomes a major concern.
This note explains how we address that issue in this proj
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1026
On the two functions... Maybe just have one function that handles the
Nan/Infinity case. As noted earlier, no matter what we do, JSON without these
symbols will work. So, we need only consider JS
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150688725
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
sto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150688949
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
sto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150689236
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
sto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150689617
--- Diff:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoRecordReader.java
---
@@ -73,6 +73,7 @@
private final MongoS
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150686404
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -229,7 +229,7 @@ public DrillbitContext getDrillbitContext()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150682963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java
---
@@ -20,12 +20,13 @@
import java.io.IOException;
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150685672
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -175,6 +193,21 @@ public WorkspaceSchema creat
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150685414
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -150,14 +152,30 @@ public WorkspaceSchemaFacto
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150680095
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150684042
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
---
@@ -52,9 +55,20 @@
private List fac
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150679941
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150686157
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -532,7 +572,10 @@ public boolean isMutable() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150682252
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150680951
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150680632
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150682787
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicSchema.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150679636
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150685946
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -532,7 +572,10 @@ public boolean isMutable() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150684114
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
---
@@ -52,9 +55,20 @@
private List fac
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150682074
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150684557
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
---
@@ -73,9 +87,10 @@ public void registerSchemas(S
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150683680
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java
---
@@ -105,12 +106,36 @@ public SchemaPlus createRootSchema(
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150682678
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicSchema.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150685113
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java
---
@@ -73,9 +87,10 @@ public void registerSchemas(S
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150680454
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150678803
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r150678680
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DynamicRootSchema.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Ap
Github user vladimirtkach commented on the issue:
https://github.com/apache/drill/pull/1026
what do you think about having two functions instead: convertFromJSON and
convertFromJSON+some suffix. Second will be able to convert NaN, Infinity
---
Drill hangout tomorrow Nov 14th, at 10 AM PST.
Please send email or bring them up tomorrow, if you have topics to discuss.
Hangout link:
https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
Thanks
Padma
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1030
For FWIW, the native CSV reader does the following:
* To read the header, it seeks to offset 0 in the file, regardless of the
block being read, then reads the header, which may be a remot
Github user ppadma commented on the issue:
https://github.com/apache/drill/pull/1030
@arina-ielchiieva That will have performance impact. Better way would be
to keep one reader per split and see if we can figure out a way to tell readers
how many rows they should skip (for header or
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
@arina-ielchiieva Please test with the latest commit. I changed mapr
version back to 5.2.1, note that 2.7.0-mapr-1707 is compiled with 5.2.2
---
Chris Sandison created DRILL-5960:
-
Summary: Add function STAsGeoJSON to extend GIS support
Key: DRILL-5960
URL: https://issues.apache.org/jira/browse/DRILL-5960
Project: Apache Drill
Issue T
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/984
@arina-ielchiieva I can put **DRILL-5783** in a separate PR **DRILL-5841**
and **DRILL-5894** are however tightly coupled and must be in the same PR.
Unfortunately **DRILL-5841** and **DRILL-5894** to
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
@vrozov I have posted all content of drillbit.out. drillbit.log just had
information that could not create remote function registry directory.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1031
@arina-ielchiieva Please attach the full log to JIRA.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1030
@ppadma really good point! I did not realize that when creating readers
input splits can be already distributed among several drillbits. So I guess we
should make sure that when we have skip
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/970
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/978
+1, LGTM.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/970
+1, LGTM.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/984
@ilooner changes in 361 files seems to be too much :) I suggest you split
this PR at least at three according to the addressed issues. So we try to merge
smaller chunks.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1031
@vrozov when I have deployed Drill with your changes on test cluster, Drill
start up failed with the following error:
```
2017-11-13 01:30:12,3367 ERROR JniCommon
fs/client/fileclien
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1005
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/904
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/774
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/987
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1021
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1015
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1019
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/949
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1017
---
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1020
---
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150512392
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java ---
@@ -313,6 +313,59 @@ public void createTableWithCustomUmask() thr
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150513171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java
---
@@ -83,7 +84,20 @@ public PhysicalPla
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150512944
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -241,8 +243,8 @@ SqlNode SqlCreateTable() :
query = Orde
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150512516
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java ---
@@ -313,6 +313,59 @@ public void createTableWithCustomUmask() thr
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150512175
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestCTAS.java ---
@@ -313,6 +313,59 @@ public void createTableWithCustomUmask() thr
Rajeshwar Rao created DRILL-5959:
Summary: Unable to apply Union on multiple select query
expressions
Key: DRILL-5959
URL: https://issues.apache.org/jira/browse/DRILL-5959
Project: Apache Drill
Github user vladimirtkach commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150500913
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
s
Github user vladimirtkach commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150500204
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
s
Github user vladimirtkach commented on a diff in the pull request:
https://github.com/apache/drill/pull/1026#discussion_r150500059
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -502,6 +502,8 @@ drill.exec.options: {
store.format: "parquet",
s
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1014
@ilooner Paul has correctly described race condition issue. At planning
time when we have defined plugin configuration we want to make sure it would
stay the same during query execution. Rel
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/904
+1, LGTM.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/774
+1, LGTM.
---
71 matches
Mail list logo
