[GitHub] Ben-Zvi closed pull request #1114: DRILL-6104: Added Logfile Reader

2018-07-18 Thread GitBox
Ben-Zvi closed pull request #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] Ben-Zvi closed pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths)

2018-07-18 Thread GitBox
Ben-Zvi closed pull request #1336: DRILL-6496: Added missing logging statement in VectorUtil.showVectorAccessibleContent(VectorAccessible va, int[] columnWidths) URL: https://github.com/apache/drill/pull/1336 This is a PR merged from a forked repository. As GitHub hides the original diff

[GitHub] Ben-Zvi closed pull request #1381: DRILL-6475: Unnest: Null fieldId Pointer.

2018-07-18 Thread GitBox
Ben-Zvi closed pull request #1381: DRILL-6475: Unnest: Null fieldId Pointer. URL: https://github.com/apache/drill/pull/1381 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Robert Hou
Congratulations, Arina! --Robert On Wed, Jul 18, 2018 at 9:12 PM, Sorabh Hamirwasia wrote: > Congratulations Arina! > > On Wed, Jul 18, 2018 at 6:13 PM, Charles Givre wrote: > > > Congrats Arina!! Well done! > > > > > On Jul 18, 2018, at 20:59, Paul Rogers > > wrote: > > > > > > Congratulatio

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Sorabh Hamirwasia
Congratulations Arina! On Wed, Jul 18, 2018 at 6:13 PM, Charles Givre wrote: > Congrats Arina!! Well done! > > > On Jul 18, 2018, at 20:59, Paul Rogers > wrote: > > > > Congratulations Arina! > > > > - Paul > > > > > > > >On Wednesday, July 18, 2018, 2:19:44 PM PDT, Aman Sinha < > amansi...

Re: [DISCUSS] 1.14.0 release

2018-07-18 Thread Charles Givre
HI Boaz, DRILL-6104 is ready to release. Do you think we’ll have an RC this week? Thanks, — C > On Jul 2, 2018, at 23:01, Boaz Ben-Zvi wrote: > > Let's try to make progress on the 1.14 release, aiming for a Release > Candidate towards the end of this week (a little ambitious, with the July

[GitHub] vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387#discussion_r203544029 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/s

[GitHub] vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387#discussion_r203543266 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/s

[GitHub] vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387#discussion_r203590106 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/

[GitHub] vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387#discussion_r203590424 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/

[GitHub] vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387#discussion_r203541339 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/s

[GitHub] Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#discussion_r203586629 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/phy

[GitHub] Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#discussion_r203538175 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/phy

[GitHub] Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#discussion_r203588145 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/phy

[GitHub] Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#discussion_r203576783 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/phy

[GitHub] Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#discussion_r203557114 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/phy

[GitHub] Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
Ben-Zvi commented on a change in pull request #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#discussion_r203555686 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/phy

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Charles Givre
Congrats Arina!! Well done! > On Jul 18, 2018, at 20:59, Paul Rogers wrote: > > Congratulations Arina! > > - Paul > > > >On Wednesday, July 18, 2018, 2:19:44 PM PDT, Aman Sinha > wrote: > > Drill developers, > Time flies and it is time for a new PMC chair ! Thank you all for your >

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Paul Rogers
Congratulations Arina! - Paul On Wednesday, July 18, 2018, 2:19:44 PM PDT, Aman Sinha wrote: Drill developers, Time flies and it is time for a new PMC chair !  Thank you all for your support during the past year. I am very pleased to announce that the Drill PMC has voted to elect A

[GitHub] vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203570718 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncP

RE: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Robert Wu
Congratulations, Arina! Best regards, Rob -Original Message- From: Padma Penumarthy Sent: Wednesday, July 18, 2018 5:01 PM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New PMC Chair of Apache Drill Arina, Congratulations and best wishes. Thanks Padma On Wed, Jul 18, 2018 at 4:

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Padma Penumarthy
Arina, Congratulations and best wishes. Thanks Padma On Wed, Jul 18, 2018 at 4:54 PM, Bridget Bevens wrote: > Congratulations, Arina!!! > > On Wed, Jul 18, 2018 at 3:20 PM, Parth Chandra wrote: > > > Congratulations > > > > On Wed, Jul 18, 2018 at 3:14 PM, Kunal Khatua wrote: > > > > > Cong

[GitHub] vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203566882 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/ExecutableTasksLatch.java ##

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Bridget Bevens
Congratulations, Arina!!! On Wed, Jul 18, 2018 at 3:20 PM, Parth Chandra wrote: > Congratulations > > On Wed, Jul 18, 2018 at 3:14 PM, Kunal Khatua wrote: > > > Congratulations, Arina ! > > On 7/18/2018 2:26:05 PM, Volodymyr Vysotskyi > wrote: > > Congratulations, Arina! Well deserved! > > > >

[GitHub] vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203566491 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/ExecutableTasksLatch.java ##

[GitHub] vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203566303 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncP

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Gautam Parai
Congratulations Arina! Gautam On Wed, Jul 18, 2018 at 4:03 PM, Boaz Ben-Zvi wrote: >"plus one" more congratulations > > > > On 7/18/18 3:20 PM, Parth Chandra wrote: > >> Congratulations >> >> On Wed, Jul 18, 2018 at 3:14 PM, Kunal Khatua wrote: >> >> Congratulations, Arina ! >>> On 7/

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Boaz Ben-Zvi
   "plus one" more congratulations On 7/18/18 3:20 PM, Parth Chandra wrote: Congratulations On Wed, Jul 18, 2018 at 3:14 PM, Kunal Khatua wrote: Congratulations, Arina ! On 7/18/2018 2:26:05 PM, Volodymyr Vysotskyi wrote: Congratulations, Arina! Well deserved! Kind regards, Volodymyr

[GitHub] parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203556768 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/

[GitHub] parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203207677 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/

[GitHub] parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203210709 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/

[GitHub] parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203482144 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/ExecutableTasksLatch.ja

[GitHub] parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation

2018-07-18 Thread GitBox
parthchandra commented on a change in pull request #1333: DRILL-6410: Memory leak in Parquet Reader during cancellation URL: https://github.com/apache/drill/pull/1333#discussion_r203556793 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/ExecutableTasksLatch.ja

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Parth Chandra
Congratulations On Wed, Jul 18, 2018 at 3:14 PM, Kunal Khatua wrote: > Congratulations, Arina ! > On 7/18/2018 2:26:05 PM, Volodymyr Vysotskyi wrote: > Congratulations, Arina! Well deserved! > > Kind regards, > Volodymyr Vysotskyi > > > On Thu, Jul 19, 2018 at 12:24 AM Abhishek Girish wrote: >

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Kunal Khatua
Congratulations, Arina ! On 7/18/2018 2:26:05 PM, Volodymyr Vysotskyi wrote: Congratulations, Arina! Well deserved! Kind regards, Volodymyr Vysotskyi On Thu, Jul 19, 2018 at 12:24 AM Abhishek Girish wrote: > Congratulations, Arina! > > On Wed, Jul 18, 2018 at 2:19 PM Aman Sinha wrote: > > > Dr

[jira] [Resolved] (DRILL-6605) TPCDS-84 Query does not return any rows

2018-07-18 Thread Robert Hou (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Hou resolved DRILL-6605. --- Resolution: Fixed > TPCDS-84 Query does not return any rows > ---

[GitHub] superbstreak opened a new pull request #1388: DRILL-6610: Add support for Minimum TLS restriction.

2018-07-18 Thread GitBox
superbstreak opened a new pull request #1388: DRILL-6610: Add support for Minimum TLS restriction. URL: https://github.com/apache/drill/pull/1388 This is an automated message from the Apache Git Service. To respond to the me

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Volodymyr Vysotskyi
Congratulations, Arina! Well deserved! Kind regards, Volodymyr Vysotskyi On Thu, Jul 19, 2018 at 12:24 AM Abhishek Girish wrote: > Congratulations, Arina! > > On Wed, Jul 18, 2018 at 2:19 PM Aman Sinha wrote: > > > Drill developers, > > Time flies and it is time for a new PMC chair ! Thank

Re: [ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Abhishek Girish
Congratulations, Arina! On Wed, Jul 18, 2018 at 2:19 PM Aman Sinha wrote: > Drill developers, > Time flies and it is time for a new PMC chair ! Thank you all for your > support during the past year. > > I am very pleased to announce that the Drill PMC has voted to elect Arina > Ielchiieva as th

[ANNOUNCE] New PMC Chair of Apache Drill

2018-07-18 Thread Aman Sinha
Drill developers, Time flies and it is time for a new PMC chair ! Thank you all for your support during the past year. I am very pleased to announce that the Drill PMC has voted to elect Arina Ielchiieva as the new PMC chair of Apache Drill. She has also been approved unanimously by the Apache B

[GitHub] arina-ielchiieva commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r203505315 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] sohami commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-18 Thread GitBox
sohami commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r203504583 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/stor

[GitHub] sohami commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-18 Thread GitBox
sohami commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r203504920 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/stor

[GitHub] arina-ielchiieva commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r203505132 ## File path: exec/java-exec/src/main/java/org/apache/drill

[GitHub] vrozov commented on issue #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-18 Thread GitBox
vrozov commented on issue #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#issuecomment-406040097 Shaded jar needs to be published to maven no matter what. In case of a single PR, publishing to maven needs to happen **before** PR is merged

[jira] [Created] (DRILL-6619) Lateral changes for implicit column

2018-07-18 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6619: Summary: Lateral changes for implicit column Key: DRILL-6619 URL: https://issues.apache.org/jira/browse/DRILL-6619 Project: Apache Drill Issue Type:

[jira] [Created] (DRILL-6618) Unnest changes for implicit column

2018-07-18 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6618: Summary: Unnest changes for implicit column Key: DRILL-6618 URL: https://issues.apache.org/jira/browse/DRILL-6618 Project: Apache Drill Issue Type: S

[jira] [Created] (DRILL-6616) Batch Processing for Lateral/Unnest

2018-07-18 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6616: Summary: Batch Processing for Lateral/Unnest Key: DRILL-6616 URL: https://issues.apache.org/jira/browse/DRILL-6616 Project: Apache Drill Issue Type:

[jira] [Created] (DRILL-6617) Planner Side changed to propagate $drill_implicit_field$ information

2018-07-18 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-6617: Summary: Planner Side changed to propagate $drill_implicit_field$ information Key: DRILL-6617 URL: https://issues.apache.org/jira/browse/DRILL-6617 Project: A

[GitHub] ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-18 Thread GitBox
ilooner commented on a change in pull request #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#discussion_r203484229 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/sto

[GitHub] priteshm commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
priteshm commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#issuecomment-406028909 Spoke with @Ben-Zvi - he will review this shortly. --

[GitHub] priteshm commented on issue #1381: DRILL-6475: Unnest: Null fieldId Pointer.

2018-07-18 Thread GitBox
priteshm commented on issue #1381: DRILL-6475: Unnest: Null fieldId Pointer. URL: https://github.com/apache/drill/pull/1381#issuecomment-406022366 @amansinha100 , @HanumathRao since it has an overall +1, I added the ready-to-commit label on the JIRA

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r203471930 ## File path: drill-shaded/pom.xml ## @@ -0,0 +1,72 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r203472049 ## File path: drill-shaded/pom.xml ## @@ -0,0 +1,72 @@ + + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] arina-ielchiieva commented on issue #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
arina-ielchiieva commented on issue #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387#issuecomment-406009671 @vvysotskyi could you please review? --

[GitHub] arina-ielchiieva opened a new pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined.

2018-07-18 Thread GitBox
arina-ielchiieva opened a new pull request #1387: DRILL-6603: Set num_nulls for parquet statistics to -1 when actual number is not defined. URL: https://github.com/apache/drill/pull/1387 Details in [DRILL-6603](https://issues.apache.org/jira/browse/DRILL-6603).

[GitHub] ilooner commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
ilooner commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#issuecomment-405991291 @KazydubB I saw that bug as well after opening the PR and pushed a fix. The test is passing no

[GitHub] KazydubB commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
KazydubB commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203434125 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql

[GitHub] KazydubB commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
KazydubB commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203434125 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203432621 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -115,56 +175,1

[GitHub] vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203412894 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/s

[GitHub] vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203427626 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/

[GitHub] vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203428413 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/

[GitHub] vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203399743 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/s

[GitHub] vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203427936 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/

[GitHub] vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#discussion_r203419904 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/s

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203427835 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203427239 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203426875 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203418113 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203416964 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -49,39 +54,79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203416278 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/MaterializedField.java ## @@ -38,6 +41,8 @@

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203415144 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java ## @@ -58,32

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203414024 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java ## @@ -58,32

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203408822 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/impl/ColumnState.java ## @@ -12

[GitHub] cgivre commented on issue #1114: DRILL-6104: Added Logfile Reader

2018-07-18 Thread GitBox
cgivre commented on issue #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#issuecomment-405957791 Commits squashed and proper commit message added. Regarding the unit tests, is there an example of a unit test for when we are expecting Drill to

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203407400 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@ -79

[GitHub] vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField

2018-07-18 Thread GitBox
vrozov commented on a change in pull request #1383: DRILL-6613: Refactor MaterializedField URL: https://github.com/apache/drill/pull/1383#discussion_r203406367 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java ##

[GitHub] arina-ielchiieva closed pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a…

2018-07-18 Thread GitBox
arina-ielchiieva closed pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a… URL: https://github.com/apache/drill/pull/1385 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] arina-ielchiieva commented on issue #1114: DRILL-6104: Added Logfile Reader

2018-07-18 Thread GitBox
arina-ielchiieva commented on issue #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#issuecomment-405931381 @cgivre looks like PR is ready to commit. Please squash the commits and leave one with proper commit message. Maybe add extra unit tests as Paul

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371503 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcapng/TestPcapngHeaders.java ## @

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371455 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/schema/Schema.java ## @@ -0

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371427 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngRecordReader.java ##

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371346 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngRecordReader.java ##

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371324 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/schema/Schema.java ## @@ -0

[GitHub] vvysotskyi commented on issue #1385: DRILL-6612: Query fails with AssertionError when joining persistent a…

2018-07-18 Thread GitBox
vvysotskyi commented on issue #1385: DRILL-6612: Query fails with AssertionError when joining persistent a… URL: https://github.com/apache/drill/pull/1385#issuecomment-405924429 @arina-ielchiieva, thanks for the review! This

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371235 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngRecordReader.java ##

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371152 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngRecordReader.java ##

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371188 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngRecordReader.java ##

[GitHub] Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-07-18 Thread GitBox
Vlad-Storona commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r203371117 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngRecordReader.java ##

[GitHub] arina-ielchiieva commented on issue #1385: DRILL-6612: Query fails with AssertionError when joining persistent a…

2018-07-18 Thread GitBox
arina-ielchiieva commented on issue #1385: DRILL-6612: Query fails with AssertionError when joining persistent a… URL: https://github.com/apache/drill/pull/1385#issuecomment-405923205 +1, LGTM. This is an automated message fr

[GitHub] vvysotskyi commented on a change in pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a…

2018-07-18 Thread GitBox
vvysotskyi commented on a change in pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a… URL: https://github.com/apache/drill/pull/1385#discussion_r203368482 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SchemaUti

[GitHub] arina-ielchiieva commented on a change in pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a…

2018-07-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a… URL: https://github.com/apache/drill/pull/1385#discussion_r203363652 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Sch

[GitHub] arina-ielchiieva commented on issue #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
arina-ielchiieva commented on issue #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#issuecomment-405911162 Please note currently Travis checks do not pass since #1384 should be merged first. -

[GitHub] arina-ielchiieva commented on issue #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
arina-ielchiieva commented on issue #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386#issuecomment-405893185 @vvysotskyi could you please review? -

[GitHub] KazydubB opened a new pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization)

2018-07-18 Thread GitBox
KazydubB opened a new pull request #1386: DRILL-6574: Add option to push LIMIT(0) on top of SCAN (late limit 0 optimization) URL: https://github.com/apache/drill/pull/1386 This is an automated message from the Apache Git Ser

[GitHub] KazydubB commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
KazydubB commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#issuecomment-405886995 @ilooner, was verifying my changes with your fix and found that there is a failing test: `

[GitHub] arina-ielchiieva commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable.

2018-07-18 Thread GitBox
arina-ielchiieva commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-405874956 @ilooner removed ready-to-commit label since I want to make sure we address comment a

[GitHub] vvysotskyi opened a new pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a…

2018-07-18 Thread GitBox
vvysotskyi opened a new pull request #1385: DRILL-6612: Query fails with AssertionError when joining persistent a… URL: https://github.com/apache/drill/pull/1385 …nd temporary tables For details please see [DRILL-6612](https://issues.apache.org/jira/browse/DRILL-6612) -

[GitHub] ilooner commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases.

2018-07-18 Thread GitBox
ilooner commented on issue #1384: DRILL-6606: Fixed bug in HashJoin that caused it not to return OK_NEW_SCHEMA in some cases. URL: https://github.com/apache/drill/pull/1384#issuecomment-405840660 @Ben-Zvi please review. This should be merged before DRILL-6453. -

  1   2   >