[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi closed the pull request at: https://github.com/apache/drill/pull/909 ---

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r136016798 --- Diff: logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java --- @@ -115,6 +112,33 @@ public static SchemaPath create(NamePart

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r135872295 --- Diff: logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java --- @@ -115,6 +112,33 @@ public static SchemaPath create(NamePart

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r135868684 --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/CompareFunctionsProcessor.java --- @@ -82,466 +45,37 @@ public

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r135753493 --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/CompareFunctionsProcessor.java --- @@ -82,466 +45,37 @@ public

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r135359090 --- Diff: contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/binary/CompareFunctionsProcessor.java --- @@ -82,466 +45,37 @@ public

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134778939 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/TestSchemaPathMaterialization.java --- @@ -93,4 +93,23 @@ public void

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134788919 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/TupleAccessor.java --- @@ -48,9 +48,21 @@ MaterializedField

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134539810 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -359,30 +361,109 @@ public Mutator(OperatorExecContext

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134686740 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -359,30 +361,109 @@ public Mutator(OperatorExecContext

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134688368 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java --- @@ -293,7 +294,7 @@ private

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134764401 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/SchemaPathUtil.java --- @@ -0,0 +1,59 @@ +/* +* Licensed to the

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134782398 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java --- @@ -84,4 +89,22 @@ public void testClone() {

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134787569 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -83,7 +85,13 @@ private void updateStructure(int index,

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134540459 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/CompareFunctionsProcessor.java --- @@ -147,10 +147,10 @@ public Boolean

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134788014 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java --- @@ -94,12 +102,20 @@ private void updateStructure(int index,

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134795741 --- Diff: logical/src/main/java/org/apache/drill/common/expression/SchemaPath.java --- @@ -115,6 +112,33 @@ public static SchemaPath create(NamePart

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134689741 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java --- @@ -362,16 +363,16 @@ protected boolean

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134098834 --- Diff: logical/src/main/java/org/apache/drill/common/expression/PathSegment.java --- @@ -17,11 +17,15 @@ */ package

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134064098 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/SchemaPathUtil.java --- @@ -0,0 +1,59 @@ +/* +* Licensed to the

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134098783 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/TupleAccessor.java --- @@ -48,9 +48,21 @@ MaterializedField

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134098584 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java --- @@ -84,4 +89,22 @@ public void testClone() {

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134061376 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -359,30 +361,109 @@ public Mutator(OperatorExecContext

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134063880 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/SchemaPathUtil.java --- @@ -0,0 +1,59 @@ +/* +* Licensed to the

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134060544 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -359,30 +361,109 @@ public Mutator(OperatorExecContext

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/909#discussion_r134061527 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java --- @@ -359,30 +361,109 @@ public Mutator(OperatorExecContext

[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/909 DRILL-4264: Allow field names to include dots 1. Removed checking the field name for dots. 2. Replaced using `SchemaPath.getAsUnescapedPath()` method by `SchemaPath.getRootSegmentPath()` and