Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Justin Mclean
Hi, When I look at the diffs, I don't see the clearFlag line until Nick adds it. The comment above the if (!stylesheet) makes me think the flag shouldn't be cleared, but I haven't really looked into it. If htmlText is set to null I think the HTML flag needs to be cleared, I think (but not

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread OmPrakash Muppirala
Here is the commit history to the file: https://fisheye6.atlassian.com/browse/~br=develop/flex-sdk/frameworks/projects/spark/src/mx/core/FTETextField.as I dont see Nick's revert. Thanks, Om On Wed, Oct 9, 2013 at 11:07 PM, Justin Mclean jus...@classsoftware.comwrote: Hi, When I look at

Re: [FALCON] Large App Compiles and Starts

2013-10-10 Thread Erik de Bruin
https://issues.apache.org/jira/browse/FLEX-33307 The test is currently @Ignore, but there are I think about 3 (types of) errors when you run it. It is the only test blocking Falcon compiling all the SDK SWCs. A couple of other tests generate warnings, that are currently '-ignore-problem', that

Re: [FALCON] Large App Compiles and Starts

2013-10-10 Thread Erik de Bruin
On Wed, Oct 9, 2013 at 8:07 AM, Alex Harui aha...@adobe.com wrote: I checked in a bunch of fixes to Falcon to get a large 20MB SWF to compile and get to its first screen. I'm sure there are more bugs to fix if I used that SWF, but I'm going to stop there for a bit and work on other issues.

RE: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Alex Harui
The test doesn't seem to be setting htmlText to null, but I haven't stepped through it. First, I want to figure out what went wrong with Git, then I'll try to find time to investigate the original bug and proposed fix. I'm done for tonight. More tomorrow... -Alex

RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Maurice Amsellem
Understood. In this case, I' am changing the test code so that it matches the existing baseline, not changing the baseline. So it should not have any impact. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 10 octobre 2013 02:43 À :

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Justin Mclean
Hi, The test doesn't seem to be setting htmlText to null, but I haven't stepped through it. Doesn't doing this tf.text = txt also set htmlText to null? First, I want to figure out what went wrong with Git, There's noting wrong with it - it's git? :-) Thanks, Justin

RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Maurice Amsellem
After running the test again, I realize there is a bug in the existing code: In \flex-sdk\mustella\tests\mobile\SplitViewNavigator\integration\baselines\Callout_skin@android_240ppi.png The thick red border surrounds the frame, but not the arrow.

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Nicholas Kwiatkowski
My revert was on hash e3d52e485c1063a71d3682750ac0c2eb833f193a submitted on 10/8/13 @ 12:15am according to my git history. I haven't done a pull yet from remote. It was showing up in the logs on the website (it is not anymore). Maybe it got clobbered during Justin's merge fix a few hours after

Problem with copy-paste text from MS Excel - spark TextInput

2013-10-10 Thread piotr.zarzycki
Hi Guys. I've got serious problem with pasted text from MS excel's cell to spark TextInput Text in cell: 43091080566 Text after copy from excel's cell (ctrl + c): 43091080566\n Text pasted to my TextInput Screen: http://bit.ly/GQhoBv I'm getting cutted text with additional line.

Re: 4.10 spark datagrid

2013-10-10 Thread Lee Burrows
Its for desktop (actually for mobile too, but not tried that yet) On 10/10/2013 12:28, Deepak MS wrote: Is it for web or mobile? I had the same issue for mobile app. interactionMode=touch on datagrid solved the problem. On Thu, Oct 10, 2013 at 4:52 PM, Lee Burrows

Re: FlexJS Dynamic Controls

2013-10-10 Thread Tom Chiverton
On 09/10/2013 19:33, Peter Ent wrote: staticControls. The intent of this package was to have controls that were relatively simple and had direct or close approximation with HTML elements. In which case I think the name is confusing. They are just as dynamic in terms of data binding as the

Re: 4.10 spark datagrid

2013-10-10 Thread Justin Mclean
Hi, Any chance I meant to say .. that's what you get posting late at night after a glass of wine or two :-) Justin

WOFF - font type instead of ttf/otf

2013-10-10 Thread Miguel Ferreira
There is some one with knowledge about this font format? This is a web open font format a font zipped that is really normal for browsers. Benefits - less space in our swf- also possibility to manage the font online (dynamic loaded) I read some posts with some code that permit this reading but i

Re: 4.10 spark datagrid

2013-10-10 Thread Gary Young
I have the same problem, it won't give any stack trace or any debug stop, it's a stop shipping bug. I will try to collect more information today. -Gary On Thu, Oct 10, 2013 at 8:01 AM, Justin Mclean jus...@classsoftware.comwrote: Hi, Any chance I meant to say .. that's what you get

Re: FlexJS Dynamic Controls

2013-10-10 Thread Peter Ent
I'm 99% sure we will be renaming and refactoring - just wanted to separate the component sets. Here's an example: MainView.mxml: flexjs:ViewBase xmlns:fx=http://ns.adobe.com/mxml/2009; xmlns:flexjs=library://ns.apache.org/flexjs/basic

describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
Hi, While digging into MXML binding code, I discovered it was using DescribeTypeCache class, which is still relying on the old describeType() XML instead of the new describeTypeJSON() Hopefully, it's only called in some specific binding situations, such as using a Binding expression on

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Alex Harui
On 10/10/13 4:40 AM, Nicholas Kwiatkowski nicho...@spoon.as wrote: My revert was on hash e3d52e485c1063a71d3682750ac0c2eb833f193a submitted on 10/8/13 @ 12:15am according to my git history. I haven't done a pull yet from remote. It was showing up in the logs on the website (it is not

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Alex Harui
On 10/10/13 12:01 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, The test doesn't seem to be setting htmlText to null, but I haven't stepped through it. Doesn't doing this tf.text = txt also set htmlText to null? I don't see that happening in the setter, but I might have missed it.

Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Alex Harui
On 10/9/13 11:51 PM, Maurice Amsellem maurice.amsel...@systar.com wrote: Understood. In this case, I' am changing the test code so that it matches the existing baseline, not changing the baseline. So it should not have any impact. Maybe I'm not understanding you, but IMO, the test code

Re: 4.10 spark datagrid

2013-10-10 Thread Lee Burrows
Ok, the problem was a change to Grid component updated in the default DataGrid skin wasn't reflected in my custom skin. In 4.9.1 and previous, the skin contained: s:Grid ... s:GridLayer name=backgroundLayer/ s:GridLayer name=selectionLayer/ s:GridLayer name=editorIndicatorLayer/

Re: 4.10 spark datagrid

2013-10-10 Thread Gary Young
well, if this code is not upgraded, it won't compile right? On Thu, Oct 10, 2013 at 11:06 AM, Lee Burrows subscripti...@leeburrows.comwrote: Ok, the problem was a change to Grid component updated in the default DataGrid skin wasn't reflected in my custom skin. In 4.9.1 and previous, the

Garbage Collection Concern

2013-10-10 Thread Thomas Wright
I have a question about garbage collection in reference to a technique I've used on a fairly regular basis. Perhaps this is bad form, but this is what I've been doing nonetheless. So this is as close to what I've been doing as possible, let's consider a mobile app in my example of this method.

Re: 4.10 spark datagrid

2013-10-10 Thread Gary Young
That happens sometimes, I would recommend using Flexmojos to do auto clean build all the time to make sure everything is updated. I upgraded the code long time ago, but still having the same problem, I will try the default skin this afternoon. -Gary On Thu, Oct 10, 2013 at 11:14 AM, Lee

Re: Garbage Collection Concern

2013-10-10 Thread Jeffry Houser
On 10/10/2013 11:14 AM, Thomas Wright wrote: Second - is there a better way to handle this, or is this legit? From an encapsulation perspective, the renderer shouldn't know its parents. I always recommend dispatching an event, that bubbles from the renderer and then handling it in the

Re: WOFF - font type instead of ttf/otf

2013-10-10 Thread Alex Harui
I'm not an expert on this stuff at all. This is the first I've heard of it, but it looks like browser support is pretty high with the exception of Android). Support in Flex might require a server as the data would need to be transcoded into a SWF. I suppose an AS Worker could be asked to do it,

Re: Mobile Callout mustella tests

2013-10-10 Thread Alex Harui
On 10/10/13 3:18 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: Hi, I have noticed mobile mustella tests on CalloutButton were excluded. History of mustella1.properties says: Peter Ent on 12/21/12: excluding Callout test suite due to missing source files. Is there a chance we can

Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Alex Harui
On 10/10/13 12:17 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: But how do I generate the 4 other ones? I tried different Target_os_name and adl_extras but it didn't work. Don't worry about any other bitmaps for now. They are broken in lots of other cases as well. -Alex

Re: describeType still used in many places in SDK

2013-10-10 Thread Alex Harui
On 10/10/13 7:25 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: Hi, While digging into MXML binding code, I discovered it was using DescribeTypeCache class, which is still relying on the old describeType() XML instead of the new describeTypeJSON() Hopefully, it's only called in some

RE: Mobile Callout mustella tests

2013-10-10 Thread Maurice Amsellem
Hi Alex, thanks for the clarification. I already tried to guess what was missing, but there are just too many things (views, renderers ...) So I guess the tests will remain excluded. Hopefully, we still have an indirect testing of Callout in SplitViewNavigator :-) Maurice -Message

RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Maurice Amsellem
I get it. So I will try to change the code so that it supports both the old behavior (ie by subclassing) and new behavior (ie by styling). Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 10 octobre 2013 16:56 À : Maurice Amsellem;

Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Alex Harui
On 10/10/13 8:58 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: I get it. So I will try to change the code so that it supports both the old behavior (ie by subclassing) and new behavior (ie by styling). I'm sure some users will be very happy if you do that. You don't have to, you

Re: Garbage Collection Concern

2013-10-10 Thread Thomas Wright
Ok, thanks. I can't remember why I even started doing this in the first place - honestly. I do remember having problems with dispatching an event in one particular circumstance, so I did this and didn't look back. Bad habits die hard I guess. Thanks for the response :) On Thu, Oct 10, 2013 at

Re: describeType still used in many places in SDK

2013-10-10 Thread Alex Harui
Before we switch to it, we have to be absolutely sure of when it was first supported. I wouldn't want to break our Flash version compatibility range. But otherwise, I have no objections if you want to switch to it. -Alex On 10/10/13 9:13 AM, Maurice Amsellem maurice.amsel...@systar.com wrote:

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
I have tested with 10.0, 10.1 and 10.2 It's not in 10.0 (only describeType) It's in 10.1 and 10.2 = package avmplus.describeTypeJSON() I will do the benchmarks when I have some spare time. Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 10 octobre

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Nicholas Kwiatkowski
When you try to use FTE within MX components without a stylesheet explicitly declared it won't render any text under certain circumstances. This was just a simple fix to force the htmlText to be regenerated and therefore display. I ran into this issue when trying to debug an issue I was having

RE: describeType still used in many places in SDK

2013-10-10 Thread Michael A. Labriola
Before we switch to it, we have to be absolutely sure of when it was first supported. I wouldn't want to break our Flash version compatibility range. But otherwise, I have no objections if you want to switch to it. Internally describeType now calls describeTypeJSON and then serializes the

RE: describeType still used in many places in SDK

2013-10-10 Thread Michael A. Labriola
Before we switch to it, we have to be absolutely sure of when it was first supported. I wouldn't want to break our Flash version compatibility range. But otherwise, I have no objections if you want to switch to it. If it helps, in my code, I am checking for FP10.1 or higher which is when I

RE: Date and Time with TZ discussion

2013-10-10 Thread Michael A. Labriola
i have a very vague recollection that somebody partially ported icu4j/icu4c to AS3 (maybe just the calenders). wondering what happened to it? You may be recalling my work. Not sure. could the flasCC or whatever its called now be used to wrapper/import the icu4c bits??? Tried that first, it

Re: Date and Time with TZ discussion

2013-10-10 Thread Paul Hastings
On 10/11/2013 12:16 AM, Michael A. Labriola wrote: i have a very vague recollection that somebody partially ported icu4j/icu4c to AS3 (maybe just the calenders). wondering what happened to it? You may be recalling my work. Not sure. no idea who authored it, very likely it was you ;-) recall

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
That may sound like a dumb question, but since Apache Flex only supports FP 10.2 and beyond, do we even need to make the check for 10.1 ? Maurice -Message d'origine- De : Michael A. Labriola [mailto:labri...@digitalprimates.net] Envoyé : jeudi 10 octobre 2013 19:14 À :

Re: describeType still used in many places in SDK

2013-10-10 Thread Alex Harui
I wouldn't bother. On 10/10/13 10:44 AM, Maurice Amsellem maurice.amsel...@systar.com wrote: That may sound like a dumb question, but since Apache Flex only supports FP 10.2 and beyond, do we even need to make the check for 10.1 ? Maurice -Message d'origine- De : Michael A. Labriola

Re: [FlexJS] IFlexInfo

2013-10-10 Thread Alex Harui
Hmm, looks like something broke in the current overlay's compiler. I'll try to get everything re-synced and publish a new overlay after I finish up on some of these SDK mustella failures. -Alex On 10/9/13 12:22 PM, OmPrakash Muppirala bigosma...@gmail.com wrote: I am trying to build out a Dojo

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
I just did some benchmarks on UI and non UI classes (run several times each test, the results are consistent) . [trace] [Chrono: [class Button] descripeType x1000] duration= 11.123 s [trace] [Chrono: [class Label] descripeType x1000] duration= 12.064 s [trace] [Chrono: [class EntityMosaic]

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
(EDITED: added new lines): I just did some benchmarks on UI and non UI classes (run several times each test, the results are consistent) : [trace] [Chrono: [class Button] descripeType x1000] duration= 11.123 s [trace] [Chrono: [class Label] descripeType x1000] duration= 12.064 s [trace]

RE: describeType still used in many places in SDK

2013-10-10 Thread Tianzhen Lin
I venture to guess Flash Player may dominate nearly 90% of the FP's? On the other hand, I wonder if it is feasible to write a pre-FP 10.2 implementation of describeTypeJSON to help make up the functionality. If so, we can still extend our support. Tangent -Original Message- From:

Re: describeType still used in many places in SDK

2013-10-10 Thread Alex Harui
There is other stuff in the SDK that doesn't work on 10.1 and earlier. I don't think this is a good time to try to shim/polyfill/fake that stuff or add code paths to deal with missing stuff, but I won't object if someone is itching to do it. -Alex On 10/10/13 11:43 AM, Tianzhen Lin

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
I agree. I think 10.2 is the right breaking point with Apache Flex. This has been confirmed by most of our customers... Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 10 octobre 2013 20:50 À : dev@flex.apache.org Objet : Re: describeType still

Re: describeType still used in many places in SDK

2013-10-10 Thread Alex Harui
Sounds like it is worth doing, but let's discuss at the next level of detail. What was the test, just the call to describeType vs describeTypeJSON? IIRC, the XML format is such that you may use the .. expression to grab the superclass's set of a particular thing of interest, and in JSON you

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
Yes, I am just calling describeType vs decribeTypeJSON. JSON is returning an unstructured object with the following props: isDynamic: Bool isFinal: bool isStatic: bool name: String traits accessors: Array of unstructured Objects . bases: Array of Strings , for the hierarchy of supers

Re: describeType still used in many places in SDK

2013-10-10 Thread Alex Harui
On 10/10/13 12:31 PM, Maurice Amsellem maurice.amsel...@systar.com wrote: Yes, I am just calling describeType vs decribeTypeJSON. JSON is returning an unstructured object with the following props: isDynamic: Bool isFinal: bool isStatic: bool name: String traits accessors: Array of

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
I will use Parsley's Spicefactory implementation as a reference, to know how to access elements. (I will not steal the code). Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : jeudi 10 octobre 2013 21:44 À : dev@flex.apache.org Objet : Re: describeType

Re: describeType still used in many places in SDK

2013-10-10 Thread Justin Mclean
Hi, I know datagrid use objectUtil describeType and caches the XML structures to work out the columns. May need to be careful around that. Thanks, Justin

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Justin Mclean
Hi, Doesn't doing this tf.text = txt also set htmlText to null? I don't see that happening in the setter, but I might have missed it. Look at all the configX (1-8) methods in global.as some set htmlText, some set text. This is one the same text field. Thanks, Justin

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
Thnaks for the info. -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : jeudi 10 octobre 2013 23:28 À : dev@flex.apache.org Objet : Re: describeType still used in many places in SDK Hi, I know datagrid use objectUtil describeType and caches the XML

RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)

2013-10-10 Thread Maurice Amsellem
I'm sure some users will be very happy if you do that. You don't have to, you just have to judge how many people will be impacted and whether it will cause them to think poorly of Apache Flex. I have no idea how many people will be using sub-classing for CalloutSkin (like in the mustella

RE: describeType still used in many places in SDK

2013-10-10 Thread Maurice Amsellem
Created https://issues.apache.org/jira/browse/FLEX-33810 -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 00:43 À : dev@flex.apache.org Objet : RE: describeType still used in many places in SDK Thnaks for the info.

Re: Build failed in Jenkins: flex-sdk_mustella #460

2013-10-10 Thread Alex Harui
I did more digging. Imo the clearing of the flag is not the correct fix. It only fixes the bug because it makes the ftetextfield switch to plain text composition which is why the tests failed. It looks like the tcm has a weird behavior of assuming that any existing textlines were composed from

FLEX-33806 and spark Alert implementation

2013-10-10 Thread Maurice Amsellem
Hi, while working on FLEX-33806 (changing the message top padding of experimental Alert), I realized the implementation of this class was unnecessarily complex: - it derives from Panel (ok) and adds 3 skinParts (messageDisplay , iconDisplay, and buttonGroup) - Defines its

ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, Looks like this file is showing up in ASdocs: SampleExperimental.as Should that be the case? and if so why is it missing an Apache header? Thanks, Justin

Re: FLEX-33806 and spark Alert implementation

2013-10-10 Thread Justin Mclean
Hi, Being an experimental component I think just about any improvement is a good idea. Thanks, Justin

ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, We're currently getting this: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc]

Re: ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, Looks like an issue with the asdocs build file - just trying to sort. Justin

Re: ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, Fixed that issue (and a few more) but now have this one: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc]

Re: FLEX-33806 and spark Alert implementation

2013-10-10 Thread Alex Harui
On 10/10/13 7:20 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Being an experimental component I think just about any improvement is a good idea. I agree with that statement, but is removing skinparts a good idea? Simplification tends to remove flexibility. Spark components are

Re: ASDocs issue

2013-10-10 Thread Alex Harui
On 10/10/13 8:21 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, Fixed that issue (and a few more) but now have this one: doc: [asdoc] Loading configuration file /Users/justinmclean/Documents/ApacheFlex4.11.0/frameworks/flex-config.xml [asdoc]

Re: ASDocs issue

2013-10-10 Thread Justin Mclean
Hi, I assume you meant ViewMenuLayout? The manifests, etc look ok. Yep I meant ViewMenuLayout. I guess you could dump the mobilecomponents.swc and see if that class is actually in there It;s in there: swfdump ./mobile/mobilecomponents.swc | grep ViewMenuLayout DoABC2

Re: ASDocs issue

2013-10-10 Thread Alex Harui
On 10/10/13 10:22 PM, Justin Mclean jus...@classsoftware.com wrote: but the main build should have failed in the same way. It compiles no issues. Did you push the other ASDoc fixes required to get to this problem? I just ran ant asdoc and got the AnimationTarget issue. I have a fix for

Re: ASDocs issue

2013-10-10 Thread Alex Harui
The TLF change is part of https://issues.apache.org/jira/browse/FLEX-33409 On 10/10/13 10:44 PM, Alex Harui aha...@adobe.com wrote: On 10/10/13 10:22 PM, Justin Mclean jus...@classsoftware.com wrote: but the main build should have failed in the same way. It compiles no issues. Did you push