Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Xintong Song
@Yuxia, We are aware of the issue that you mentioned. Actually, I don't think the DataStream API can cover everything in the DataSet API in exactly the same way, because the fundamental model, concepts and primitives of the two sets of APIs are completely different. Many of the DataSet APIs,

Re: [DISCUSS] FLIP-314: Support Customized Job Lineage Listener

2023-07-11 Thread Shammon FY
Thanks for the valuable feedback, Leonard. I have discussed with Leonard off-line. We have reached some conclusions about these issues and I have updated the FLIP as follows: 1. Simplify the `LineageEdge` interface by creating an edge from one source vertex to sink vertex. 2. Remove the

[jira] [Created] (FLINK-32581) Add document for atomic CTAS

2023-07-11 Thread tartarus (Jira)
tartarus created FLINK-32581: Summary: Add document for atomic CTAS Key: FLINK-32581 URL: https://issues.apache.org/jira/browse/FLINK-32581 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32580) FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS)

2023-07-11 Thread tartarus (Jira)
tartarus created FLINK-32580: Summary: FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) Key: FLINK-32580 URL: https://issues.apache.org/jira/browse/FLINK-32580 Project: Flink Issue

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Jingsong Li
+1 to Leonard and Galen and Jing. About Source and Sink. We're still missing quite a bit of work, including functionality, including ease of use, including bug fixes, and I'm not sure we'll be completely done by 2.0. Until that's done, we won't be in a position to clean up the old APIs. Best,

[jira] [Created] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-11 Thread jasonliangyc (Jira)
jasonliangyc created FLINK-32579: Summary: The filter criteria on the lookup table of Lookup join has no effect Key: FLINK-32579 URL: https://issues.apache.org/jira/browse/FLINK-32579 Project: Flink

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-07-11 Thread Dong Lin
Hi Piotr, I think I understand your motivation for suggeseting execution.slow-end-to-end-latency now. Please see my followup comments (after the previous email) inline. On Wed, Jul 12, 2023 at 12:32 AM Piotr Nowojski wrote: > Hi Dong, > > Thanks for the updates, a couple of comments: > > > If

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread yuxia
Hi,Xintong. Sorry to disturb the voting. I just found an email[1] about DataSet API from flink-user-zh channel. And I think it's not just a single case according to my observation. Remove DataSet is a must have item in release-2.0. But as the user email said, if we remove DataSet, how users

Re: [DISCUSS] FLIP-327: Support stream-batch unified operator to improve job throughput when processing backlog data

2023-07-11 Thread Dong Lin
Hi Jing, Thanks for the comments. Please see my reply inline. On Wed, Jul 12, 2023 at 5:04 AM Jing Ge wrote: > Hi Dong, > > Thanks for the clarification. Now it is clear for me. I got additional noob > questions wrt the internal sorter. > > 1. when to call setter to set the

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-07-11 Thread Dong Lin
Hi Piotr, Thanks for the comments. Please see my reply inline. On Wed, Jul 12, 2023 at 12:32 AM Piotr Nowojski wrote: > Hi Dong, > > Thanks for the updates, a couple of comments: > > > If a record is generated by a source when the source's > isProcessingBacklog is true, or some of the records

Re: [DISCUSS] FLIP-327: Support stream-batch unified operator to improve job throughput when processing backlog data

2023-07-11 Thread Jing Ge
Hi Dong, Thanks for the clarification. Now it is clear for me. I got additional noob questions wrt the internal sorter. 1. when to call setter to set the internalSorterSupported to be true? 2 *"For those operators whose throughput can be considerably improved with an internal sorter, update it

Re: [VOTE] Graduate the FileSink to @PublicEvolving

2023-07-11 Thread Jing Ge
Hi, Sorry for the typo. The title is correct. The VOTE is for graduating the "FileSink" to @PublicEvolving. Best regards, Jing On Mon, Jul 10, 2023 at 1:10 PM Jing Ge wrote: > Hi, > > I'd like to start the VOTE for graduating the FlinkSink > to @PublicEvolving. The discussion thread can be

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Jing Ge
agree with what Leonard said. There are actually more issues wrt the new Source and SinkV2[1] Speaking of must-have vs nice-to-have, I think it depends on the priority. If removing them has higher priority, we should keep related tasks as must-have and make sure enough effort will be put to solve

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-07-11 Thread Piotr Nowojski
Hi Dong, Thanks for the updates, a couple of comments: > If a record is generated by a source when the source's isProcessingBacklog is true, or some of the records used to > derive this record (by an operator) has isBacklog = true, then this record should have isBacklog = true. Otherwise, > this

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Jing Ge
Hi Galen, We were aware of the issue and are working on it. StreamingFileSink is a SinkFunction that could not be removed yes as mentioned previously. You can find SinkV1 at [1] Best regards, Jing [1]

[jira] [Created] (FLINK-32578) Cascaded group by window time columns on a proctime window aggregate may result hang for ever

2023-07-11 Thread lincoln lee (Jira)
lincoln lee created FLINK-32578: --- Summary: Cascaded group by window time columns on a proctime window aggregate may result hang for ever Key: FLINK-32578 URL: https://issues.apache.org/jira/browse/FLINK-32578

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-07-11 Thread Dong Lin
Hi Piotr and everyone, I have documented the vision with a summary of the existing work in this doc. Please feel free to review/comment/edit this doc. Looking forward to working with you together in this line of work.

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Jingsong Li
It's exciting to finally have someone to refactor the Flink website. Thanks Deepthi. To Xintong, > maintain two sets of website designs at the same time If our website is not so complex, and new webui can be full feature coverage, there would be no need to maintain two sets of web. To Jing

Re: [DISCUSS] FLIP-327: Support stream-batch unified operator to improve job throughput when processing backlog data

2023-07-11 Thread Dong Lin
Hi Jing, Thank you for the comments! Please see my reply inline. On Tue, Jul 11, 2023 at 5:41 AM Jing Ge wrote: > Hi Dong, > > Thanks for the proposal! The FLIP is already in good shape. I got some NIT > questions. > > 1. It is a little bit weird to write the hint right after the motivation >

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Jing Ge
Hi, +1, the UI design looks good! Commonly speaking, there are two parts of the whole website: Flink Web and Flink doc. Will the dart mode also cover Flink doc? Best regards, Jing On Tue, Jul 11, 2023 at 12:40 PM Matthias Pohl wrote: > I also like the proposed designs. Considering that you

Re: [DISCUSS] FLIP-325: Support configuring end-to-end allowed latency

2023-07-11 Thread Dong Lin
Hi Stefan, Thanks for all the comments! That is really helpful and I have updated the FLIP based on your comments. Please see my reply inline. On Mon, Jul 10, 2023 at 10:23 PM Stefan Richter wrote: > Hi, > > After reading through the discussion, I think the FLIP should provide > additional

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Galen Warren
Regarding SinkV1 vs. SinkV2: Is StreamingFileSink a SinkV1-related interface that is proposed to be removed? In a separate thread, it was discussed how it's important not to remove StreamingFileSink as long as this critical issue with SinkV2 is still outstanding --

[jira] [Created] (FLINK-32577) Avoid memory fragmentation when running CI for flink-table-planner module

2023-07-11 Thread Yunhong Zheng (Jira)
Yunhong Zheng created FLINK-32577: - Summary: Avoid memory fragmentation when running CI for flink-table-planner module Key: FLINK-32577 URL: https://issues.apache.org/jira/browse/FLINK-32577 Project:

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Leonard Xu
Hi, Xintong > Could you please clarify what exact changes you are proposing to make on > the existing list? > - Are you suggesting removing the item "Remove deprecated APIs - > SourceFunction / SinkFunction / SinkV1", or are you suggesting downgrading > it as nice-to-have? I prefer to remove the

Re: [DISCUSS] Release 2.0 Work Items

2023-07-11 Thread Xintong Song
> > What we might want to come up with is a summary with each 2.0.0 issue on > why it should be included or not. That summary is something the community > could vote on. WDYT? I'm happy to help here. > That sounds great. Thanks for offering the help. I'll also try to go through the issues, but

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Matthias Pohl
I also like the proposed designs. Considering that you want to touch individual subpages, there are also some subpages of Flink's website not being mentioned in the FLIP (e.g. roadmap [1]). What is the plan with those? Are they covered by the "We recommend modifications only to the design of the

Re: [DISCUSS] Release 2.0 Work Items

2023-07-11 Thread Matthias Pohl
@Xintong I guess it makes sense. I agree with your conclusions on the four mentioned Jira issues. I just checked any issues that have fixVersion = 2.0.0 [1]. There are a few more items that are not affiliated with FLINK-3957 [2]. I guess we should find answers for these issues: Either closing

[jira] [Created] (FLINK-32576) ProducerMergedPartitionFileIndex supports spilling to file

2023-07-11 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-32576: - Summary: ProducerMergedPartitionFileIndex supports spilling to file Key: FLINK-32576 URL: https://issues.apache.org/jira/browse/FLINK-32576 Project: Flink Issue

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Xintong Song
+1 in general. Thanks for proposing this contribution, Deepthi. The new design looks very cool. I have a few questions, which might be entry-level given that I barely know anything about the website design. - Do you think it's feasible to maintain two sets of website designs at the same time?

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Xintong Song
Thanks for the inputs, Yuan and Leonard. I'm canceling this vote, w.r.t. the objections and proposed changes. Meantime, please feel free to raise other concerns and proposed changes in this thread, before we call for another vote. @Leonard, Could you please clarify what exact changes you are

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Feifan Wang
+1 , the new design looks more attractive and is well organized | | Feifan Wang | | zoltar9...@163.com | Replied Message | From | Leonard Xu | | Date | 07/11/2023 16:34 | | To | dev | | Subject | Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website | +1 for the redesigning, the new

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Leonard Xu
+1 for the redesigning, the new website looks cool. Best, Leonard > On Jul 11, 2023, at 7:55 AM, Mohan, Deepthi > wrote: > > Hi, > > I’m opening this thread to discuss a proposal to redesign the Apache Flink > website: https://flink.apache.org. The approach and a few initial mockups are >

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Leonard Xu
Thanks Xintong for driving this great work! But I’ve to give my -1(binding) here: -1 to mark "deprecat SourceFunction/SinkFunction/Sinkv1" item as must to have for release 2.0. I do a lot of connector work in the community, and I have two insights from past experience: 1. Many developers

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Yuan Mei
As a second thought, I think "Eager State Declaration" is probably not a must-have. I was originally thinking it is a prerequisite for "state querying for disaggregated state management". Since disaggregated state management itself is not a must-have, "Eager State Declaration" is not as well. We

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-07-11 Thread Dong Lin
Hi Piotr, Thank you for all the discussions! I will ask for a meeting in the future when we have prolonged discussions like this :) Please see my comments inline. BTW, I am hoping we can make this feature available in Flink 1.18, which will feature freeze soon on July 24. If this FLIP looks

[jira] [Created] (FLINK-32575) Unified the Cpu of JobManager Name

2023-07-11 Thread Bo Cui (Jira)
Bo Cui created FLINK-32575: -- Summary: Unified the Cpu of JobManager Name Key: FLINK-32575 URL: https://issues.apache.org/jira/browse/FLINK-32575 Project: Flink Issue Type: New Feature

[jira] [Created] (FLINK-32574) RescalingITCase.testSavepointRescalingInPartitionedOperatorState fails on AZP

2023-07-11 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32574: --- Summary: RescalingITCase.testSavepointRescalingInPartitionedOperatorState fails on AZP Key: FLINK-32574 URL: https://issues.apache.org/jira/browse/FLINK-32574

Re: JIRA Permission Opening Application

2023-07-11 Thread 李勇平
Thank you, Weihua. Yes, I have created a new Issue to familiarize myself with the complete process of contribution! > 2023年7月11日 13:37,Weihua Hu 写道: > > ​满帮安全提示: 此封邮件来自公司外部,除非您能判断发件人和知道邮件内容安全,否则请勿打开链接或者附件。 > MB Security Tips: Please do not click on links or open attachments unless you > trust