Re: [VOTE] Release Apache Flink 1.2.1 (RC1)

2017-03-30 Thread Aljoscha Krettek
, Mar 29, 2017, at 23:08, Aljoscha Krettek wrote: > I commented on FLINK-6214: I think it's working as intended, although we > could fix the javadoc/doc. > > On Wed, Mar 29, 2017, at 17:35, Timo Walther wrote: > > A user reported that all tumbling and slinding window assigners con

Re: [VOTE] Release Apache Flink 1.2.1 (RC1)

2017-03-29 Thread Aljoscha Krettek
sible I would like to include FLINK-6183 & FLINK-6184 as well. > >>> > >>> They fix 2 metric-related issues that could arise when a Task is > >>> cancelled very early. (like, right away) > >>> > >>> FLINK-6183 fixes a memory leak where

Re: [VOTE] Release Apache Flink 1.2.1 (RC1)

2017-03-26 Thread Aljoscha Krettek
e.org> wrote: > > I agree with Aljoscha. > > -1 because of FLINK-6188 > > > On Sat, Mar 25, 2017 at 9:38 AM, Aljoscha Krettek <aljos...@apache.org> wrote: >> I filed this issue, which was observed by a user: >> https://issues.apache.org/jira/brow

Re: [VOTE] Release Apache Flink 1.2.1 (RC1)

2017-03-25 Thread Aljoscha Krettek
I filed this issue, which was observed by a user: https://issues.apache.org/jira/browse/FLINK-6188 I think that’s blocking for 1.2.1. > On 24 Mar 2017, at 18:57, Ufuk Celebi wrote: > > RC1 doesn't contain Stefan's backport for the Asynchronous snapshots > for heap-based keyed

[jira] [Created] (FLINK-6188) Some setParallelism() method can't cope with default parallelism

2017-03-25 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6188: --- Summary: Some setParallelism() method can't cope with default parallelism Key: FLINK-6188 URL: https://issues.apache.org/jira/browse/FLINK-6188 Project: Flink

[jira] [Created] (FLINK-6164) Make ProcessWindowFunction a RichFunction

2017-03-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6164: --- Summary: Make ProcessWindowFunction a RichFunction Key: FLINK-6164 URL: https://issues.apache.org/jira/browse/FLINK-6164 Project: Flink Issue Type

[jira] [Created] (FLINK-6163) Document per-window state in ProcessWindowFunction

2017-03-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6163: --- Summary: Document per-window state in ProcessWindowFunction Key: FLINK-6163 URL: https://issues.apache.org/jira/browse/FLINK-6163 Project: Flink Issue

Re: [VOTE] Release Apache Flink 1.1.5 (RC1)

2017-03-21 Thread Aljoscha Krettek
+1 I looked at every commit since 1.1.4. The code looks good and we didn’t introduce any new dependencies, so ,legally speaking, we should be fine. > On 21 Mar 2017, at 14:40, Stephan Ewen wrote: > > +1 > > - Verified the LICENSE and NOTICE (no dependency updates, update on

Re: [ANNOUNCE] New committer: Theodore Vasiloudis

2017-03-21 Thread Aljoscha Krettek
Welcome (to committership)! (Since you’re already with us for such a long time…) :-) > On 21 Mar 2017, at 10:08, Tzu-Li (Gordon) Tai wrote: > > Welcome Theodore! Great to have you on board :-) > > > On March 21, 2017 at 4:35:35 PM, Robert Metzger (rmetz...@apache.org)

[jira] [Created] (FLINK-6135) Allowing adding inputs to StreamOperator

2017-03-20 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6135: --- Summary: Allowing adding inputs to StreamOperator Key: FLINK-6135 URL: https://issues.apache.org/jira/browse/FLINK-6135 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-6131) Add side inputs for DataStream API

2017-03-20 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6131: --- Summary: Add side inputs for DataStream API Key: FLINK-6131 URL: https://issues.apache.org/jira/browse/FLINK-6131 Project: Flink Issue Type

Re: Future of Queryable State Feature

2017-03-20 Thread Aljoscha Krettek
I think adding this could be as simple as adding a makeWindowContentsQueryable(String) call to WindowedStream. In there, we create the StateDescriptor for keeping the window contents so we can call setQueryable() on the StateDescriptor and set the name under which it should be accessible. If

Re: [DISCUSS] Project build time and possible restructuring

2017-03-20 Thread Aljoscha Krettek
to release management >>> (e.g. more frequent releases of libraries) or other criteria (e.g. core and >>> non-core) instead of build time. What would happen if the built of another >>> submodule would become too long, would we split/restructure again and >>> agai

Re: [jira] [Updated] (FLINK-6126) Yet another conflict : guava

2017-03-20 Thread Aljoscha Krettek
So it is resolved now? Thanks for letting us know! > On 20 Mar 2017, at 12:55, Liangfei Su wrote: > > Well...Comments added. > > This looks due to incorrect local build of flink. > > Documentation at >

Re: [DISCUSS] Project build time and possible restructuring

2017-03-20 Thread Aljoscha Krettek
I prefer Jenkins to Travis by far. Working on Beam, where we have good Jenkins integration, has opened my eyes to what is possible with good CI integration. For example, look at this recent Beam PR: https://github.com/apache/beam/pull/2263 . The

[jira] [Created] (FLINK-6118) Chained operators forward watermark without checking

2017-03-19 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6118: --- Summary: Chained operators forward watermark without checking Key: FLINK-6118 URL: https://issues.apache.org/jira/browse/FLINK-6118 Project: Flink

Re: [DISCUSS] Code style / checkstyle

2017-03-19 Thread Aljoscha Krettek
turns out. Best, Aljoscha > On 18 Mar 2017, at 08:00, Aljoscha Krettek <aljos...@apache.org> wrote: > > I added an issue for adding a custom checkstyle.xml for flink-streaming-java > so that we can gradually add checks: > https://issues.apache.org/jira/browse/FLINK-610

[jira] [Created] (FLINK-6116) Watermarks don't work when unioning with same DataStream

2017-03-19 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6116: --- Summary: Watermarks don't work when unioning with same DataStream Key: FLINK-6116 URL: https://issues.apache.org/jira/browse/FLINK-6116 Project: Flink

Re: [DISCUSS] Code style / checkstyle

2017-03-18 Thread Aljoscha Krettek
>>>> (2) Author history: This is less of an issue, I think. "git log >>>> " and "git show -- " will still work and >>> one >>>> may have to go one commit back to find out why something was changed >>>> >>>>

[jira] [Created] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-03-18 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-6107: --- Summary: Add custom checkstyle for flink-streaming-java Key: FLINK-6107 URL: https://issues.apache.org/jira/browse/FLINK-6107 Project: Flink Issue

Re: [DISCUSS] FLIP-17 Side Inputs

2017-03-17 Thread Aljoscha Krettek
let's > not forget about it. > > Cheers, > Gabor > > > On 2017-03-15 16:14, Aljoscha Krettek wrote: > > Hi, > > thanks for you input! :-) > > > > Regarding 1) > > I don't see the benefit of integrating windowing into the side-input > &g

Re: [DISCUSS] FLIP-17 Side Inputs

2017-03-15 Thread Aljoscha Krettek
is related also to windowing. By far the most useful > > > singleton side input is the result of a global reduction with an > > > associative operator. A lot of these operators also have an > > > identity element. It is nice for this identity element (known a

Re: Question: RemoteStreamEnvironment submit in detach mode.

2017-03-15 Thread Aljoscha Krettek
I would also really like to have this feature in. I'll try and see if I can find some time to get the PR into mergeable shape. On Wed, Mar 15, 2017, at 09:11, Liangfei Su wrote: > Thanks for the information, Evgeny. > > It looks no fixed version for these feature which i think it quite common >

Re: [DISCUSS] Release Flink 1.1.5 / Flink 1.2.1

2017-03-15 Thread Aljoscha Krettek
I did in fact just open a PR for > https://issues.apache.org/jira/browse/FLINK-6001 > NPE on TumblingEventTimeWindows with ContinuousEventTimeTrigger and > allowedLateness On Tue, Mar 14, 2017, at 18:20, Vladislav Pernin wrote: > Hi, > > I would also include the following (not yet resolved)

Re: [DISCUSS] Release Flink 1.1.5 / Flink 1.2.1

2017-03-14 Thread Aljoscha Krettek
Thanks for kicking off the discussion! I have an open PR for - https://issues.apache.org/jira/browse/FLINK-5808: Missing verification for setParallelism and setMaxParallelism - https://issues.apache.org/jira/browse/FLINK-5713: Protect against NPE in WindowOperator window cleanup On Tue, Mar

Re: [DISCUSS] FLIP-17 Side Inputs

2017-03-13 Thread Aljoscha Krettek
t no input will ever be received for a window, and the side input > becomes ready. > > Map Side Inputs with triggers: When new data arrives for a key in Beam, > there's no way to know which value should "win", so you basically just > can't use map side inputs with trigger

Re: [DISCUSS] FLIP-17 Side Inputs

2017-03-09 Thread Aljoscha Krettek
a great > start and I think that was what you're suggesting in the design doc. > > -Jamie > > > On Thu, Mar 9, 2017 at 7:27 AM, Aljoscha Krettek <aljos...@apache.org> > wrote: > > > Hi, > > these are all valuable suggestions and I think that we should implemen

Re: [DISCUSS] FLIP-17 Side Inputs

2017-03-09 Thread Aljoscha Krettek
arrives is > > only > > > slightly better then making it always ready from usability perspective. > > For > > > instance if I am joining against a static data set I want to wait for the > > > whole set before making it ready. This could be exposed as a user defined

[jira] [Created] (FLINK-5972) Don't allow shrinking merging windows

2017-03-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5972: --- Summary: Don't allow shrinking merging windows Key: FLINK-5972 URL: https://issues.apache.org/jira/browse/FLINK-5972 Project: Flink Issue Type: Bug

[DISCUSS] FLIP-17 Side Inputs

2017-03-06 Thread Aljoscha Krettek
Hi Folks, I would like to finally agree on a plan for implementing side inputs in Flink. There has already been an attempt to come to consensus [1], which resulted in two design documents. I tried to consolidate those two and also added a section about implementation plans. This is the resulting

[jira] [Created] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-03-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5969: --- Summary: Add savepoint backwards compatibility tests from 1.2 to 1.3 Key: FLINK-5969 URL: https://issues.apache.org/jira/browse/FLINK-5969 Project: Flink

[jira] [Created] (FLINK-5968) Document WindowedStream.aggregate()

2017-03-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5968: --- Summary: Document WindowedStream.aggregate() Key: FLINK-5968 URL: https://issues.apache.org/jira/browse/FLINK-5968 Project: Flink Issue Type

[jira] [Created] (FLINK-5967) Document AggregatingState

2017-03-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5967: --- Summary: Document AggregatingState Key: FLINK-5967 URL: https://issues.apache.org/jira/browse/FLINK-5967 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Side Outputs and Split/Select

2017-03-02 Thread Aljoscha Krettek
dowedOperator.getLateStream() variant without explicit > > tags. > > I think it is fine to start adding side output to ProcessFunction (keyed > > and non-keyed) and window operators and see how it is picked up by users. > > > > Best, Fabian > > > &g

Re: [DISCUSS] Side Outputs and Split/Select

2017-02-28 Thread Aljoscha Krettek
17 at 12:39 Ufuk Celebi <u...@apache.org> wrote: > On Tue, Feb 28, 2017 at 11:38 AM, Aljoscha Krettek <aljos...@apache.org> > wrote: > > I see the ProcessFunction as a bit of the generalised future of FlatMap, > so > > to me it makes sense to only allow side

Re: [DISCUSS] Per-key event time

2017-02-28 Thread Aljoscha Krettek
ce, keyExtractor); > input > .map() > .window(...) // notice that we don't need keyBy because it is implicit > .reduce(...) > .map(...) > .window(...) > ... > > Would this mean that another `keyBy` isn’t allowed downstream? Or still > allowed, but we’re using the key

Re: [DISCUSS] Code style / checkstyle

2017-02-28 Thread Aljoscha Krettek
s is hard, especially for the folks that > > >> have > > >>> to merge the pull requests ;-) > > >>> > > >>> (2) Author history: This is less of an issue, I think. "git log > > >>> " and "git show -- " will stil

Re: [DISCUSS] Side Outputs and Split/Select

2017-02-28 Thread Aljoscha Krettek
fine. I also like the second variant where a user > > doesn't have to explicitly create the OutputTag. > > > > > > > > On Mon, Feb 27, 2017 at 8:45 AM, Aljoscha Krettek <aljos...@apache.org> > > wrote: > > > >> @Jamie I must have misty

[jira] [Created] (FLINK-5933) Allow Evictor for merging windows

2017-02-28 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5933: --- Summary: Allow Evictor for merging windows Key: FLINK-5933 URL: https://issues.apache.org/jira/browse/FLINK-5933 Project: Flink Issue Type: Bug

Re: [DISCUSS] Side Outputs and Split/Select

2017-02-27 Thread Aljoscha Krettek
allowing ProcessFunction on a non-keyed stream, as I mentioned in my first mail (I hope). On Mon, 27 Feb 2017 at 17:45 Aljoscha Krettek <aljos...@apache.org> wrote: > @Jamie I must have mistyped my last API proposal. This piece of code: > WindowedOperator windowedResult = inpu

Re: [DISCUSS] Side Outputs and Split/Select

2017-02-27 Thread Aljoscha Krettek
t; we invalidate when the user should not be collecting to it. (just a > quick > >> idea) > >> > >> I personally wouldn't deprecate the "universal" Split/Select API that > can > >> be used on any DataStream in favor of functionality that is only

[jira] [Created] (FLINK-5929) Allow Access to Per-Window State in ProcessWindowFunction

2017-02-27 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5929: --- Summary: Allow Access to Per-Window State in ProcessWindowFunction Key: FLINK-5929 URL: https://issues.apache.org/jira/browse/FLINK-5929 Project: Flink

Re: ElasticsearchSink Exception

2017-02-27 Thread Aljoscha Krettek
+Tzu-Li (Gordon) Tai Do you have any idea what could be causing this? I'm asking because you recently worked on the Elasticsearch connectors, right? On Sun, 26 Feb 2017 at 04:26 Govindarajan Srinivasaraghavan < govindragh...@gmail.com> wrote: > Thanks Flavio. I tried with

Re: [DISCUSS] Per-key event time

2017-02-27 Thread Aljoscha Krettek
This is indeed an interesting topic, thanks for starting the discussion, Jamie! I now thought about this for a while, since more and more people seem to be asking about it lately. First, I thought that per-key watermark handling would not be necessary because it can be done locally (as Paris

Re: [DISCUSS] Code style / checkstyle

2017-02-27 Thread Aljoscha Krettek
Just for a bit of context, this is the output of running cloc on the Flink codebase: --- Language files blankcomment code

[jira] [Created] (FLINK-5917) Remove MapState.size()

2017-02-24 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5917: --- Summary: Remove MapState.size() Key: FLINK-5917 URL: https://issues.apache.org/jira/browse/FLINK-5917 Project: Flink Issue Type: Improvement

Re: Frontend classpath issue

2017-02-24 Thread Aljoscha Krettek
Did any user have problems with the Flink 1.1 behaviour? If not, we could disable it again, by default, and add a flag for adding the user jar to all the classpaths. On Fri, 24 Feb 2017 at 14:50 Robert Metzger wrote: > I agree with you Gyula, this change is dangerous. I

Re: [DISCUSS] Code style / checkstyle

2017-02-23 Thread Aljoscha Krettek
If we go for a codestyle/checkstyle I would suggest to use the Google style. This already has checkstyle, IntelliJ style, Eclipse style and a code formatting tool and is well established. However, some people will not like this style. In general, I think we will never manage to find a style that

[DISCUSS] Side Outputs and Split/Select

2017-02-23 Thread Aljoscha Krettek
Hi Folks, Chen and I have been working for a while now on making FLIP-13 (side outputs) [1] a reality. We think we have a pretty good internal implementation and also a proposal for an API but now we need to discuss how we want to go forward with this, especially how we should deal with

Re: [DISCUSS] Project build time and possible restructuring

2017-02-22 Thread Aljoscha Krettek
I'm not against splitting but I wan't to highlight that there are other options: - We could split the tests run on travis logically. For example, run unit tests and integration tests separately. This would have the benefit that you would see early on if the (fast) unit tests fail. We could also

Re: [DISCUSS] Should we supply a new Iterator instance for Functions with Iterable input(s) like CoGroupFunction ?

2017-02-22 Thread Aljoscha Krettek
I think this was mostly an oversight on my part that was possible because we didn't have good test-coverage that was enforcing correctness. Please go ahead and open an issue for re-adding the throw. On Wed, 22 Feb 2017 at 13:28 Lin Li wrote: > Thank you for the answer! >

[jira] [Created] (FLINK-5880) Add documentation for object reuse for DataStream API

2017-02-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5880: --- Summary: Add documentation for object reuse for DataStream API Key: FLINK-5880 URL: https://issues.apache.org/jira/browse/FLINK-5880 Project: Flink

Re: KeyGroupRangeAssignment ?

2017-02-21 Thread Aljoscha Krettek
. > > If I have 100 keys and 100 slots, for each key I have the same rate of > > events, I don’t want skewed distribution. > > > > Best, > > Ovidiu > > > > > On 21 Feb 2017, at 11:38, Aljoscha Krettek <aljos...@apache.org> > wrote: > > >

Re: KeyGroupRangeAssignment ?

2017-02-21 Thread Aljoscha Krettek
Hi Ovidiu, what's the reason for wanting to make the parallelism equal to the number of keys? I think in general it's very hard to ensure that hashes even go to different key groups. It can always happen that all your keys (if you have so few of them) are assigned to the same parallel operator

Re: Reliable Distributed FS support (HCFS)

2017-02-17 Thread Aljoscha Krettek
Hi, I think atomic rename is not part of the requirements. I'll add +Stephan who recently wrote this document in case he has any additional input. Cheers, Aljoscha On Thu, 16 Feb 2017 at 23:28 Vijay Srinivasaraghavan wrote: > Following up on my question regarding backed

Re: Wish to Contribute - Andrea Spina

2017-02-17 Thread Aljoscha Krettek
Welcome to the community, Andrea! :-) On Fri, 17 Feb 2017 at 10:22 Fabian Hueske wrote: > Hi Andrea, > > welcome to the community! > I gave you Contributor permissions. You can now assign issues to yourself. > > Best, Fabian > > 2017-02-17 9:14 GMT+01:00 Andrea Spina

Re: Contribute Flink

2017-02-17 Thread Aljoscha Krettek
Hi, welcome to the community. :-) I'm sure Ufuk, who opened the issue, will get back to you once he notices your message. Cheers, Aljoscha On Fri, 17 Feb 2017 at 11:18 Riccardo Diomedi < riccardo.diom...@radicalbit.io> wrote: > Hi Fabian, > > I’d like to contribute mainly on Flink streaming

Re: Flink Job Exception

2017-02-16 Thread Aljoscha Krettek
Hi Govindarajan, the Jira issue that you linked to and which Till is currently fixing will only fix the obvious type mismatch in the Akka messages. There is also an underlying problem that causes this message to be sent in the first place. In the case of the user who originally created the Jira

Re: [DISCUSS] Planning Release 1.3

2017-02-13 Thread Aljoscha Krettek
+1, we can do it this time! :-) On Mon, 6 Feb 2017 at 20:19 Robert Metzger wrote: > Hi, > according to our recent time-based releases discussion, I came up with the > following deadlines for the upcoming 1.3 release: > > *Feature freeze (branch forking)*: 1 May 2017 >

Re: [ANNOUNCE] Welcome Stefan Richter as a new committer

2017-02-10 Thread Aljoscha Krettek
Welcome! :-) On Fri, 10 Feb 2017 at 16:10 Till Rohrmann wrote: > Great to have you on board as a committer Stefan :-) > > On Fri, Feb 10, 2017 at 3:32 PM, Greg Hogan wrote: > > > Welcome, Stefan, and thank you for your contributions! > > > > On Fri,

Re: [ANNOUNCE] Welcome Jark Wu and Kostas Kloudas as committers

2017-02-10 Thread Aljoscha Krettek
Congrats! :-) On Wed, 8 Feb 2017 at 11:29 Robert Metzger wrote: > Welcome on board guys! > > If you want to try our your new privileges, you can add yourself here: > http://flink.apache.org/community.html#people (through the > apache/flink-web > repo) > > On Wed, Feb 8,

[jira] [Created] (FLINK-5774) ContinuousFileProcessingTest has test instability

2017-02-10 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5774: --- Summary: ContinuousFileProcessingTest has test instability Key: FLINK-5774 URL: https://issues.apache.org/jira/browse/FLINK-5774 Project: Flink Issue

[jira] [Created] (FLINK-5743) Mark WindowedStream.aggregate* methods as PublicEvolving

2017-02-08 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5743: --- Summary: Mark WindowedStream.aggregate* methods as PublicEvolving Key: FLINK-5743 URL: https://issues.apache.org/jira/browse/FLINK-5743 Project: Flink

[jira] [Created] (FLINK-5741) Add tests for window function wrappers with RichFunctions

2017-02-08 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5741: --- Summary: Add tests for window function wrappers with RichFunctions Key: FLINK-5741 URL: https://issues.apache.org/jira/browse/FLINK-5741 Project: Flink

[jira] [Created] (FLINK-5740) Make WrappingFunction an interface and move to flink-core

2017-02-08 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5740: --- Summary: Make WrappingFunction an interface and move to flink-core Key: FLINK-5740 URL: https://issues.apache.org/jira/browse/FLINK-5740 Project: Flink

[jira] [Created] (FLINK-5721) Add FoldingState to State Documentation

2017-02-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5721: --- Summary: Add FoldingState to State Documentation Key: FLINK-5721 URL: https://issues.apache.org/jira/browse/FLINK-5721 Project: Flink Issue Type

[jira] [Created] (FLINK-5720) Deprecate "Folding" in all of DataStream API

2017-02-06 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5720: --- Summary: Deprecate "Folding" in all of DataStream API Key: FLINK-5720 URL: https://issues.apache.org/jira/browse/FLINK-5720 Project: Flink

[jira] [Created] (FLINK-5713) Protect against NPE in WindowOperator window cleanup

2017-02-05 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5713: --- Summary: Protect against NPE in WindowOperator window cleanup Key: FLINK-5713 URL: https://issues.apache.org/jira/browse/FLINK-5713 Project: Flink

[jira] [Created] (FLINK-5709) Add Max Parallelism to Parallel Execution Doc

2017-02-03 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5709: --- Summary: Add Max Parallelism to Parallel Execution Doc Key: FLINK-5709 URL: https://issues.apache.org/jira/browse/FLINK-5709 Project: Flink Issue Type

Re: clean up jira

2017-01-30 Thread Aljoscha Krettek
RAs for that version / ... ) to > >> encourage people to clean up our JIRA. > >> > >> > >> > >> On Thu, Dec 22, 2016 at 9:45 AM, Fabian Hueske <fhue...@gmail.com> > wrote: > >> > >> Hi Anton, > >>> > >>>

Re: [VOTE] Release Apache Flink 1.2.0 (RC2)

2017-01-27 Thread Aljoscha Krettek
I think this issue that Ufuk opened is also a blocker: https://issues.apache.org/jira/browse/FLINK-5670 As I comment in the Issue, at least one bigger user of Flink has run into this problem on their cluster. On Fri, 27 Jan 2017 at 10:50 Ufuk Celebi wrote: > Thanks Gyula! > >

[jira] [Created] (FLINK-5647) Fix RocksDB Backend Cleanup

2017-01-25 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5647: --- Summary: Fix RocksDB Backend Cleanup Key: FLINK-5647 URL: https://issues.apache.org/jira/browse/FLINK-5647 Project: Flink Issue Type: Bug

Re: Unregistering Managed State in Operator Backend

2017-01-24 Thread Aljoscha Krettek
Just a bit of clarification, the OperatorState stuff is independent of keyed state backends, i.e. even if you use RocksDB the operator state will not be stored in RocksDB, only keyed state is stored there. Right now, when an operator state (ListState) is empty we will still write some meta data

Re: Need help on understanding flink runtime and window function

2017-01-24 Thread Aljoscha Krettek
Hi,depending on which version of Flink you're using the answer changes. If you use Flink 1.1 AggregatingProcessingTimeWindowOperator should be responsible for executing that. In Flink 1.2 it should be WindowOperator. For a quick overview of how scheduling works in Flink you could look at this:

Re: [DISCUSS] (Not) tagging reviewers

2017-01-24 Thread Aljoscha Krettek
It seems I'm in a bit of a minority here but I like the @R tags. There are simply to many pull request for someone to keep track of all of them and if someone things that a certain person would be good for reviewing a change then tagging them helps them notice the PR. I think the tag should not

[jira] [Created] (FLINK-5616) YarnPreConfiguredMasterHaServicesTest fails sometimes

2017-01-23 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5616: --- Summary: YarnPreConfiguredMasterHaServicesTest fails sometimes Key: FLINK-5616 URL: https://issues.apache.org/jira/browse/FLINK-5616 Project: Flink

Re: Slow duplicated tests

2017-01-10 Thread Aljoscha Krettek
titioned in the > recursion again. > */ > > but he incorrect, because code of both test fully equal, > one difference line very similar on bug after refactoring with inserting > recordReuse > > testSpillingHashJoinWithMassiveCollisions > 353 while ((record = buildSide.ne

Re: [ANNOUNCE] Flink 1.1.4 Released

2016-12-25 Thread Aljoscha Krettek
Very nice. Good work, team!  On Sat, Dec 24, 2016, 00:07 Fabian Hueske wrote: > Thank you Ufuk for your work as release manager and everybody who > contributed! > > Cheers, Fabian > > 2016-12-23 16:40 GMT+01:00 Ufuk Celebi : > > > The Flink PMC is pleased to

[jira] [Created] (FLINK-5374) Extend Unit Tests for RegisteredBackendStateMetaInfo

2016-12-20 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5374: --- Summary: Extend Unit Tests for RegisteredBackendStateMetaInfo Key: FLINK-5374 URL: https://issues.apache.org/jira/browse/FLINK-5374 Project: Flink

[jira] [Created] (FLINK-5373) Extend Unit Tests for StateAssignmentOperation

2016-12-20 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5373: --- Summary: Extend Unit Tests for StateAssignmentOperation Key: FLINK-5373 URL: https://issues.apache.org/jira/browse/FLINK-5373 Project: Flink Issue

Re: Flink gives incorrect result when event time windowing used

2016-12-20 Thread Aljoscha Krettek
I'm afraid the doc is wrong here. The JavaDoc on Watermark says this about watermarks: "A Watermark tells operators that receive it that no elements with a timestamp older or equal to the watermark timestamp should arrive at the operator." The system also relies on this fact, as visible in how

[jira] [Created] (FLINK-5372) Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints()

2016-12-20 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5372: --- Summary: Fix RocksDBAsyncSnapshotTest.testCancelFullyAsyncCheckpoints() Key: FLINK-5372 URL: https://issues.apache.org/jira/browse/FLINK-5372 Project: Flink

Re: [DISCUSS] Schedule and Scope for Flink 1.2

2016-12-20 Thread Aljoscha Krettek
t; > On Fri, Dec 16, 2016 at 5:55 PM, Fabian Hueske <fhue...@gmail.com> > wrote: > > > >> Hi, > >> > >> I merged the Table API refactoring changes: > >> > >> - RESOLVED Clean up the packages of the Table API (FLINK-4704) > >>

[jira] [Created] (FLINK-5366) Add end-to-end tests for Savepoint Backwards Compatibility

2016-12-19 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5366: --- Summary: Add end-to-end tests for Savepoint Backwards Compatibility Key: FLINK-5366 URL: https://issues.apache.org/jira/browse/FLINK-5366 Project: Flink

[jira] [Created] (FLINK-5363) Fire timers when window state is currently empty

2016-12-18 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5363: --- Summary: Fire timers when window state is currently empty Key: FLINK-5363 URL: https://issues.apache.org/jira/browse/FLINK-5363 Project: Flink Issue

Re: [DISCUSS] Schedule and Scope for Flink 1.2

2016-12-16 Thread Aljoscha Krettek
Yes, I'm confident that we can finish the tests until then and merge the code. On Fri, Dec 16, 2016, 17:41 Robert Metzger <rmetz...@apache.org> wrote: > Thank you for the update. Do you think you get it done until Monday > evening? > > On Fri, Dec 16, 2016 at 5:23 PM, Aljos

Re: [DISCUSS] Schedule and Scope for Flink 1.2

2016-12-16 Thread Aljoscha Krettek
Hi, we're still working on making the backwards compatibility from 1.1 savepoints a reality. We have most of the code and some tests now but it still needs some work. This is the issue that tracks the progress on the operators that we would like to make backwards compatible:

[jira] [Created] (FLINK-5250) Make AbstractUdfStreamOperator aware of WrappingFunction

2016-12-04 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5250: --- Summary: Make AbstractUdfStreamOperator aware of WrappingFunction Key: FLINK-5250 URL: https://issues.apache.org/jira/browse/FLINK-5250 Project: Flink

[jira] [Created] (FLINK-5240) Properly Close StateBackend in StreamTask when closing/canceling

2016-12-02 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5240: --- Summary: Properly Close StateBackend in StreamTask when closing/canceling Key: FLINK-5240 URL: https://issues.apache.org/jira/browse/FLINK-5240 Project: Flink

[jira] [Created] (FLINK-5237) Consolidate and harmonize Window Translation Tests

2016-12-02 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5237: --- Summary: Consolidate and harmonize Window Translation Tests Key: FLINK-5237 URL: https://issues.apache.org/jira/browse/FLINK-5237 Project: Flink Issue

[jira] [Created] (FLINK-5155) Deprecate ValueStateDescriptor constructors with default value

2016-11-24 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5155: --- Summary: Deprecate ValueStateDescriptor constructors with default value Key: FLINK-5155 URL: https://issues.apache.org/jira/browse/FLINK-5155 Project: Flink

[jira] [Created] (FLINK-5154) Duplicate TypeSerializer when writing RocksDB Snapshot

2016-11-24 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5154: --- Summary: Duplicate TypeSerializer when writing RocksDB Snapshot Key: FLINK-5154 URL: https://issues.apache.org/jira/browse/FLINK-5154 Project: Flink

Re: [DISCUSS] @Public libraries

2016-11-23 Thread Aljoscha Krettek
I would be for also annotating library methods/classes. Maybe Robert has a stronger opinion on this because he introduced these annotations. On Tue, 22 Nov 2016 at 18:56 Greg Hogan wrote: > Hi all, > > Should stable APIs in Flink's CEP, ML, and Gelly libraries be annotated >

Re: [DISCUSS] Hold copies in HeapStateBackend

2016-11-23 Thread Aljoscha Krettek
b. > > >> Can we renew a object with its data or direct use kryo for object > > >> serialization? > > >> I’m not prefer object copy. > > >> > > >> > > >>> On Nov 22, 2016, at 20:33, Fabian Hueske <fhue...@gmail.com> w

Re: [DISCUSS] deprecated function need more detail

2016-11-23 Thread Aljoscha Krettek
+1 That sounds excellent. On Wed, 23 Nov 2016 at 11:04 Till Rohrmann wrote: > +1 for your proposal. > > Cheers, > Till > > On Wed, Nov 23, 2016 at 9:33 AM, Fabian Hueske wrote: > > > I agree on this one. > > Whenever we deprecate a method or a feature

[jira] [Created] (FLINK-5130) Remove Deprecated Methods from WindowedStream

2016-11-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5130: --- Summary: Remove Deprecated Methods from WindowedStream Key: FLINK-5130 URL: https://issues.apache.org/jira/browse/FLINK-5130 Project: Flink Issue Type

[jira] [Created] (FLINK-5126) Remove Checked Exceptions from State Interfaces

2016-11-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5126: --- Summary: Remove Checked Exceptions from State Interfaces Key: FLINK-5126 URL: https://issues.apache.org/jira/browse/FLINK-5126 Project: Flink Issue

[jira] [Created] (FLINK-5125) ContinuousFileProcessingCheckpointITCase is Flaky

2016-11-22 Thread Aljoscha Krettek (JIRA)
Aljoscha Krettek created FLINK-5125: --- Summary: ContinuousFileProcessingCheckpointITCase is Flaky Key: FLINK-5125 URL: https://issues.apache.org/jira/browse/FLINK-5125 Project: Flink Issue

Re: [DISCUSS] Hold copies in HeapStateBackend

2016-11-22 Thread Aljoscha Krettek
That's right, yes. On Mon, 21 Nov 2016 at 19:14 Fabian Hueske <fhue...@gmail.com> wrote: > Right, but that would be a much bigger change than "just" copying the > *first* record that goes into the ReduceState, or am I missing something? > > > 2016-11-21 18:41 GM

Re: [DISCUSS] Hold copies in HeapStateBackend

2016-11-21 Thread Aljoscha Krettek
gt; > > it will come with performance overhead when updating the state, but I > > > think it'll be possible to perform asynchronous snapshots using > > > HeapStateBackend (probably some changes to underlying data structures > > would > > > be needed) - which wo

<    4   5   6   7   8   9   10   11   12   13   >