Re: Migrate to Log4j 2

2016-10-21 Thread Lior Zeno
Sure, point taken. The only issue is having both versions in the same binary. But it's not the case here. I am not sure of it is a good practice to continue supporting deprecated software, but that's another discussion I guess. On Oct 22, 2016 01:24, "Ralph Goers"

Re: Migrate to Log4j 2

2016-10-21 Thread Ralph Goers
I should point out that Log4j 2 has shipped a Flume Appender since before it went GA. The Flume Log4j Appender is for users who use Log4j 1.x to connect to Flume. There really is no reason to drop that even if Flume itself starts using Log4j 2. Since Flume is a standalone app there really isn’t

Re: jira reference is missing from git commit messages

2016-10-21 Thread Attila Simon
Hi Mike, I'm a big fan of having the site in scm so I guess I can volunteer after Donat finishes that movement. I have no strong opinion on whether we should have a jira or not (thus the proposal of FLUME-PR70). I just "I found this habit very useful". I have tooling which depends on the commit

Re: Migrate to Log4j 2

2016-10-21 Thread Ralph Goers
FYI, I have been using Log4j 2 in my Flume deployments for over a year, despite whatever Flume or its dependencies are using for an API. Having Flume come preconfigured for Log4j 2 would be nice. It will take some work to convert the code to use the Log4j 2 API. At a minimum all the log4j

[jira] [Comment Edited] (FLUME-3015) Fix flaky org.apache.flume.channel.jdbc.TestJdbcChannelProviderNoFK.testEventWithSimulatedSourceAndSinks

2016-10-21 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595616#comment-15595616 ] Attila Simon edited comment on FLUME-3015 at 10/21/16 4:54 PM: ---

[jira] [Created] (FLUME-3017) Fix flaky org.apache.flume.sink.hbase.TestHBaseSink

2016-10-21 Thread Attila Simon (JIRA)
Attila Simon created FLUME-3017: --- Summary: Fix flaky org.apache.flume.sink.hbase.TestHBaseSink Key: FLUME-3017 URL: https://issues.apache.org/jira/browse/FLUME-3017 Project: Flume Issue Type:

[jira] [Created] (FLUME-3016) Fix flaky org.apache.flume.sink.hbase.TestAsyncHBaseSink

2016-10-21 Thread Attila Simon (JIRA)
Attila Simon created FLUME-3016: --- Summary: Fix flaky org.apache.flume.sink.hbase.TestAsyncHBaseSink Key: FLUME-3016 URL: https://issues.apache.org/jira/browse/FLUME-3016 Project: Flume Issue

[jira] [Commented] (FLUME-3015) Fix flaky org.apache.flume.channel.jdbc.TestJdbcChannelProviderNoFK.testEventWithSimulatedSourceAndSinks

2016-10-21 Thread Attila Simon (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595616#comment-15595616 ] Attila Simon commented on FLUME-3015: - TestJdbcChannelProvider.testEventWithSimulatedSourceAndSinks

[jira] [Created] (FLUME-3015) Fix flaky org.apache.flume.channel.jdbc.TestJdbcChannelProviderNoFK.testEventWithSimulatedSourceAndSinks

2016-10-21 Thread Attila Simon (JIRA)
Attila Simon created FLUME-3015: --- Summary: Fix flaky org.apache.flume.channel.jdbc.TestJdbcChannelProviderNoFK.testEventWithSimulatedSourceAndSinks Key: FLUME-3015 URL:

[jira] [Created] (FLUME-3014) fix flaky test org.apache.flume.source.TestSyslogUdpSource.testSourceCounter

2016-10-21 Thread Attila Simon (JIRA)
Attila Simon created FLUME-3014: --- Summary: fix flaky test org.apache.flume.source.TestSyslogUdpSource.testSourceCounter Key: FLUME-3014 URL: https://issues.apache.org/jira/browse/FLUME-3014 Project:

[jira] [Created] (FLUME-3013) Fix flaky testShutdown(org.apache.flume.source.TestExecSource)

2016-10-21 Thread Attila Simon (JIRA)
Attila Simon created FLUME-3013: --- Summary: Fix flaky testShutdown(org.apache.flume.source.TestExecSource) Key: FLUME-3013 URL: https://issues.apache.org/jira/browse/FLUME-3013 Project: Flume

Re: Enabling Travis-CI on Flume

2016-10-21 Thread Mike Percy
Hi Lior! No, my message was not directed at you, or any person in particular. I intended this message for those paying attention to this topic to try and set expectations for how decision making for things like this usually (and hopefully) works in Apache: If you are willing to do the work to get

Re: Moving Developer Section of cwiki to the git repository

2016-10-21 Thread Mike Percy
Thanks, Donat. +1 on moving the docs. Regarding the web site source code, it can reside in svn or git however it should continue using the standard ASF site infrastructure [1] for hosting content which consists only of static rendered HTML content. Our options for pushing that rendered HTML are

Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8

2016-10-21 Thread Lior Zeno
> On Oct. 21, 2016, 10:57 a.m., Attila Simon wrote: > > Hi Lior, > > conf/flume-env.sh.template#22 is still referenceing to java-6-sun. Could > > you please include that as well. Thanks. BTW, do you think we should continue recommending Oracle's JVM? The default-jdk/jre in variuos

Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8

2016-10-21 Thread Lior Zeno
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/ --- (Updated Oct. 21, 2016, 3:56 p.m.) Review request for Flume. Changes ---

Re: Enabling Travis-CI on Flume

2016-10-21 Thread Lior Zeno
Mike, I was not holding Donat back. I was just suggesting ways to configure Jenins, per Donat's request. I'm sorry if my former post delivered the wrong message. On Fri, Oct 21, 2016 at 6:29 PM, Mike Percy wrote: > Personally I prefer Jenkins over TravisCI for various reasons

Re: Enabling Travis-CI on Flume

2016-10-21 Thread Mike Percy
Personally I prefer Jenkins over TravisCI for various reasons however if Donat is willing to do the work of adding pre-commit checks on PRs via Travis then I say let him do it, in the Apache spirit of "let they that do the work make the decisions". If someone actually spends the time to set up

Re: Enabling Travis-CI on Flume

2016-10-21 Thread Lior Zeno
There are many ways to do it, for example: https://www.theguild.nl/building-github-pull-requests-using-jenkins-pipelines/ or https://www.theguild.nl/building-github-pull-requests-with-jenkins/ for earlier versions of Jenkins. I do not really care if it would be Jenkins or Travis, but I do think

Re: Enabling Travis-CI on Flume

2016-10-21 Thread Balazs Donat Bessenyei
As I haven't received any objections to enabling Travis, I'm going to ask INFRA to enable it for Flume soon. This change would help submitting and reviewing pull requests. If someone figures out how we could use Jenkins for this purpose, we can always disable Travis. PS. there are more projects

Re: Review Request 52510: Some tests in TestBucketWriter are flaky

2016-10-21 Thread Attila Simon
> On Oct. 21, 2016, 1:21 p.m., Attila Simon wrote: > > Ship It! Discussed offline that there will be a follow up patch to use builder pattern for constructing BucketWriter. (So that further testing only instance mutators can be eliminated) - Attila

Re: Review Request 52510: Some tests in TestBucketWriter are flaky

2016-10-21 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52510/#review153538 --- Ship it! Ship It! - Attila Simon On Oct. 4, 2016, 11:11

Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8

2016-10-21 Thread Attila Simon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53056/#review153527 --- Hi Lior, conf/flume-env.sh.template#22 is still referenceing to

Re: jira reference is missing from git commit messages

2016-10-21 Thread Mike Percy
Hi Attila, Thanks for raising this concern of yours. Please see inline. On Fri, Oct 21, 2016 at 12:17 PM, Attila Simon wrote: > The how to contribute page asks to have a jira first for each change. I > guess with allowing pull requests we have to update the how to contribute

Re: Review Request 52510: Some tests in TestBucketWriter are flaky

2016-10-21 Thread Attila Simon
> On Oct. 18, 2016, 4:26 p.m., Attila Simon wrote: > > Ahh now I see what is going on. BucketWriter instantiate a Clock class > > which is in turn used in the file name counter. The test first instantiates > > the BucketWriter - which initialize the filename counter -then overrides > > the

jira reference is missing from git commit messages

2016-10-21 Thread Attila Simon
Hi, Not too long ago all the messages in the git log started with the corresponding jira. I found this habit very useful. The how to contribute page asks to have a jira first for each change. I guess with allowing pull requests we have to update the how to contribute page as well (which only

[jira] [Commented] (FLUME-3012) Sending a term signal can not shutdown Flume agent when KafkaChannel starting has exceptions

2016-10-21 Thread Ping Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15594537#comment-15594537 ] Ping Wang commented on FLUME-3012: -- I found

[jira] [Updated] (FLUME-3012) Sending a term signal can not shutdown Flume agent when KafkaChannel starting has exceptions

2016-10-21 Thread Ping Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ping Wang updated FLUME-3012: - Attachment: threaddumps.log Attach the the dump from jstack. > Sending a term signal can not shutdown

[jira] [Created] (FLUME-3012) Sending a term signal can not shutdown Flume agent when KafkaChannel starting has exceptions

2016-10-21 Thread Ping Wang (JIRA)
Ping Wang created FLUME-3012: Summary: Sending a term signal can not shutdown Flume agent when KafkaChannel starting has exceptions Key: FLUME-3012 URL: https://issues.apache.org/jira/browse/FLUME-3012

Re: Review Request 52510: Some tests in TestBucketWriter are flaky

2016-10-21 Thread Balázs Donát Bessenyei
> On Oct. 18, 2016, 4:26 p.m., Attila Simon wrote: > > Ahh now I see what is going on. BucketWriter instantiate a Clock class > > which is in turn used in the file name counter. The test first instantiates > > the BucketWriter - which initialize the filename counter -then overrides > > the

[jira] [Comment Edited] (FLUME-3011) metrics messages does not change when spooling directory source exit abnormaly

2016-10-21 Thread huyanping (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-3011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593941#comment-15593941 ] huyanping edited comment on FLUME-3011 at 10/21/16 6:01 AM: I found that all