Re: Kafka Ingester

2016-06-02 Thread William Markito
Hey Ross This sounds like a great idea and I'd recommend it to be yet another separate module, like the Spark connector for example. Kafka and Geode share many similar concepts but support different data structures so there could be many different use cases for such connector. Looking forwar

Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

2016-06-02 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48095/#review136024 --- Ship it! Ship It! - Hitesh Khamesra On May 31, 2016, 10:15 p

Re: build error with development branch...

2016-06-02 Thread Anilkumar Gingade
Devs, Thanks for the help and pointers... -Anil. On Thu, Jun 2, 2016 at 2:49 PM, Udo Kohlmeyer wrote: > Maybe try 1.8.0_92... I know it works > > > On 3/06/2016 7:47 am, Dan Smith wrote: > >> Hmm, does that -ea mean it's an early access build? I would recommend >> running with a later version

Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).

2016-06-02 Thread anilkumar gingade
> On May 24, 2016, 9:44 p.m., Dan Smith wrote: > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java, > > line 70 > > > > > > The javadocs for setAllowLeadingWildercard sa

Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-02 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt, Ja

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/ --- (Updated June 3, 2016, 12:05 a.m.) Review request for geode, Darrel Schneider a

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/#review136004 --- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXMa

Re: Review Request 48175: GEODE-1408: gfsh help alter region output defaults say '__DEFAULT__'

2016-06-02 Thread Dave Barnes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48175/#review136006 --- Ship it! I believe that the code is correct - it appears to fix

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #328 was SUCCESSFUL (with 1398 tests)

2016-06-02 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #328 was successful. --- Scheduled 1400 tests in total. https://build.spring.io/browse/SGF-NAG-328/ -- This

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Swapnil Bawaskar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/#review136005 --- Ship it! Ship It! - Swapnil Bawaskar On June 2, 2016, 9:33 p

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

2016-06-02 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review135999 --- Ship it! Ship It! - Darrel Schneider On June 2, 2016, 2:26 p

Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-02 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48189/ --- Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.

Re: build error with development branch...

2016-06-02 Thread Udo Kohlmeyer
Maybe try 1.8.0_92... I know it works On 3/06/2016 7:47 am, Dan Smith wrote: Hmm, does that -ea mean it's an early access build? I would recommend running with a later version of java 8. -Dan On Thu, Jun 2, 2016 at 2:41 PM, Anilkumar Gingade wrote: If gradle is using the java installed/set

Re: build error with development branch...

2016-06-02 Thread Dan Smith
Hmm, does that -ea mean it's an early access build? I would recommend running with a later version of java 8. -Dan On Thu, Jun 2, 2016 at 2:41 PM, Anilkumar Gingade wrote: > If gradle is using the java installed/set in my environment, then it is: > > java version "1.8.0_20-ea" > Java(TM) SE Run

Re: build error with development branch...

2016-06-02 Thread Anilkumar Gingade
If gradle is using the java installed/set in my environment, then it is: java version "1.8.0_20-ea" Java(TM) SE Runtime Environment (build 1.8.0_20-ea-b05) Java HotSpot(TM) 64-Bit Server VM (build 25.20-b05, mixed mode) I could not see any build output that printed java version it used (nice to h

Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/ --- Review request for geode, Darrel Schneider and Swapnil Bawaskar. Bugs: GEODE-14

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/ --- (Updated June 2, 2016, 9:33 p.m.) Review request for geode, Darrel Schneider an

Re: Proposal - provide a callback to compute statistics

2016-06-02 Thread Dan Smith
On Thu, Jun 2, 2016 at 11:47 AM, Darrel Schneider wrote: > Statistics are supposed to work even if you don't have sampling enabled. > For example you could turn off sampling and not have a statistic archive > but could still run a gfsh command that fetches a bunch of stats from the > running syst

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

2016-06-02 Thread Sai Boorlagadda
> On May 24, 2016, 10:17 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java, > > line 1077 > > > > > > It looks to me like every place we call incrementBuc

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

2016-06-02 Thread Sai Boorlagadda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/ --- (Updated June 2, 2016, 9:26 p.m.) Review request for geode, Darrel Schneider, E

Re: Proposal - provide a callback to compute statistics

2016-06-02 Thread Dan Smith
On Thu, Jun 2, 2016 at 11:23 AM, Jens Deppe wrote: > If the methods are providing a Supplier (to the Statistic) shouldn't they > be called 'set{Int,Long,Double}Supplier'? > Seems reasonable. I'll change them to be set{Int,Long,Double}Supplier

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-02 Thread Darrel Schneider
When did forwardXXX become ignoreXXX? I read through the email thread and couldn't find why that happened. It is best for the default on a boolean property to be false. That was the case when it was forwardXXX. But now that it has changed to ignoreXXX the default has become true. I'd vote for it be

Re: build error with development branch...

2016-06-02 Thread Dan Smith
Develop builds for me. And travis seems happy - https://travis-ci.org/apache/incubator-geode But this is actually pretty weird. In Intellij at least, it thinks that lambda maps to a SerializableCallable even though it doesn't return a value. I think maybe that's due to the while(true) part. If I c

Re: build error with development branch...

2016-06-02 Thread Jinmei Liao
Hmmm, never see that before. which version of java are you using? On Thu, Jun 2, 2016 at 1:58 PM, Anilkumar Gingade wrote: > Hi Devs, > > Anyone seeing this issue: > > > :geode-core:compileTestJava/export/india1/users/agingade/src/gemfire/open/geode-core/src/test/java/com/gemstone/gemfire/manage

Re: build error with development branch...

2016-06-02 Thread Udo Kohlmeyer
I think that you getting this because vm1.invokeAsync(... seems to need to return something but it does not. Maybe remove the 'AsynInvocation vm1Invoke =' part... As it serves no purpose here. --Udo On 3/06/2016 6:58 am, Anilkumar Gingade wrote: Hi Devs, Anyone seeing this issue: :geode-c

build error with development branch...

2016-06-02 Thread Anilkumar Gingade
Hi Devs, Anyone seeing this issue: :geode-core:compileTestJava/export/india1/users/agingade/src/gemfire/open/geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java:62: error: reference to invokeAsync is ambiguous AsyncInvocation vm1Invoke = vm1.inv

Re: DistributionConfig and Geode system properties

2016-06-02 Thread William Markito
++1 - This is really good! On Thu, Jun 2, 2016 at 12:16 PM, Udo Kohlmeyer wrote: > John: Perhaps the (interface) name can be simplified to > ConfigurationProperties too. > > Funnily enough I initially had called it SystemConfigurationProperties, > but later renamed it because it felt too gener

Fwd: Kafka Ingester

2016-06-02 Thread Ross Duncan
Hello, I came across the landing page for Geode contributions today, and I noticed one of the suggested ideas (no 6) was a Kafka ingester plugin. https://cwiki.apache.org/confluence/display/GEODE/How+to+Contribute I dont know terribly much about geode yet, but was wondering if anyone had attemp

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48176/#review135989 --- Ship it! Once CACHE_XML_FILE has referenced the correct Distri

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Udo Kohlmeyer
> On June 2, 2016, 5:16 p.m., Dan Smith wrote: > > geode-spark-connector/geode-spark-connector/src/it/java/ittest/io/pivotal/geode/spark/connector/JavaApiIntegrationTest.java, > > line 62 > > > > > > Should this use

Re: DistributionConfig and Geode system properties

2016-06-02 Thread Udo Kohlmeyer
John: Perhaps the (interface) name can be simplified to ConfigurationProperties too. Funnily enough I initially had called it SystemConfigurationProperties, but later renamed it because it felt too generic. Dan: 3) DistributedSystem has a ton of javadocs describing each property and what it

Re: Proposal - provide a callback to compute statistics

2016-06-02 Thread Darrel Schneider
Statistics are supposed to work even if you don't have sampling enabled. For example you could turn off sampling and not have a statistic archive but could still run a gfsh command that fetches a bunch of stats from the running system or use the pulse tool. However you can leave sampling turned on

Re: DistributionConfig and Geode system properties

2016-06-02 Thread Darrel Schneider
+1 to naming it "ConfigurationProperties" +1 to moving the javadocs On Thu, Jun 2, 2016 at 10:46 AM, John Blum wrote: > Perhaps the (interface) name can be simplified to ConfigurationProperties > too. Not all properties necessarily involve specifically the distributed > system configuration, b

Re: Proposal - provide a callback to compute statistics

2016-06-02 Thread Jens Deppe
If the methods are providing a Supplier (to the Statistic) shouldn't they be called 'set{Int,Long,Double}Supplier'? On Thu, Jun 2, 2016 at 11:04 AM, Dan Smith wrote: > Replies inline. > > On Thu, Jun 2, 2016 at 10:04 AM, Darrel Schneider > wrote: > > > It is not clear to me how the new apis beh

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-02 Thread Anilkumar Gingade
Hi Team, As proposed here, we added support to propagate eviction and expiration (destroy) operation to AsyncEventQueue using single flag/attribute "ignoreEvictionAndExpiration" by default which is true (to keep the same behavior) and one could set (false) to receive eviction/expiration event...

Re: Proposal - provide a callback to compute statistics

2016-06-02 Thread Dan Smith
Replies inline. On Thu, Jun 2, 2016 at 10:04 AM, Darrel Schneider wrote: > It is not clear to me how the new apis behave. > Is the supplier for a particular id/name/descriptor remembered by the > Statistics instance? So if you wanted to add an intSupplier for a int > statistic you would do it on

Re: DistributionConfig and Geode system properties

2016-06-02 Thread John Blum
Perhaps the (interface) name can be simplified to ConfigurationProperties too. Not all properties necessarily involve specifically the distributed system configuration, but rather the overall Geode system configuration (Cache, Management, HTTP Service(s), Clients, etc). On Thu, Jun 2, 2016 at 10:

Re: DistributionConfig and Geode system properties

2016-06-02 Thread Bruce Schuchardt
+1 for moving the javadocs Also, CacheFactory has two methods that should point to this new class: CacheFactory(Properties) and set(String,String). Le 6/2/2016 à 10:27 AM, Dan Smith a écrit : 3) DistributedSystem has a ton of javadocs describing each property and what it does. I wonder if th

Re: DistributionConfig and Geode system properties

2016-06-02 Thread Dan Smith
First off - nice job, these constants should have been available a long time ago! One question a couple of comments: 1) Is the idea with the change that all code should reference the constants in DistributedSystemConfigProperties. For example, I should use DistributedSystemConfigProperties.CACHE_

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48176/#review135970 --- geode-spark-connector/geode-spark-connector/src/it/java/ittest/io

Re: Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48176/#review135968 --- Fix it, then Ship it! Ship It! geode-spark-connector/geode-sp

Review Request 48176: Changed cache xml property for spark tests to use new DistributionConfig property

2016-06-02 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48176/ --- Review request for geode, William Markito, Udo Kohlmeyer, and Dan Smith. Reposi

Review Request 48175: GEODE-1408: gfsh help alter region output defaults say '__DEFAULT__'

2016-06-02 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48175/ --- Review request for geode, Jinmei Liao, Karen Miller, Kevin Duling, and Kirk Lund

Re: Proposal - provide a callback to compute statistics

2016-06-02 Thread Darrel Schneider
It is not clear to me how the new apis behave. Is the supplier for a particular id/name/descriptor remembered by the Statistics instance? So if you wanted to add an intSupplier for a int statistic you would do it once by calling sampleInt? The name of these methods give the impression that calling

Re: DistributionConfig and Geode system properties

2016-06-02 Thread Anthony Baker
Since this an addition to the public API (albeit small) please make sure to review and offer feedback. We should consider how future changes (property additions, removals, renames, defaults) will impact backwards compatibility. Thanks, Anthony > On Jun 1, 2016, at 5:17 PM, Udo Kohlmeyer wrote

Re: Review Request 47850: GEODE-1454: Have "region" attribute, in JSONAuthorization json file be an array

2016-06-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47850/#review135953 --- Ship it! Ship It! - Kirk Lund On May 25, 2016, 8:27 p.m., Je

Re: Review Request 48076: GEODE-1463: Legacy OperationContexts do not set the appropriate Shiro permission tuple

2016-06-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48076/#review135951 --- Ship it! Ship It! - Kirk Lund On June 1, 2016, 2:52 p.m., Je

Re: Review Request 48090: GEODE-1469: correctly handle the step arguements in http request

2016-06-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48090/#review135949 --- Ship it! Ship It! - Kirk Lund On June 1, 2016, 6:38 p.m., Ji

Re: Review Request 48148: GEODE-1179: Remove references to vsd

2016-06-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48148/#review135947 --- Ship it! Ship It! - Kirk Lund On June 1, 2016, 6:49 p.m., Je

Re: Review Request 48150: GEODE-1185: typo in gfsh help on alter disk-store

2016-06-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48150/#review135948 --- Ship it! Ship It! - Kirk Lund On June 1, 2016, 7:05 p.m., Je

[GitHub] incubator-geode issue #150: Feature/geode 308

2016-06-02 Thread jinmeiliao
Github user jinmeiliao commented on the issue: https://github.com/apache/incubator-geode/pull/150 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-geode issue #150: Feature/geode 308

2016-06-02 Thread jdeppe-pivotal
Github user jdeppe-pivotal commented on the issue: https://github.com/apache/incubator-geode/pull/150 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Build failed in Jenkins: Geode-spark-connector #23

2016-06-02 Thread Apache Jenkins Server
See Changes: [jdeppe] GEODE-1455: Add SecurityTest JUnit category to outstanding gfsh / JMX [jdeppe] GEODE-1454: Have "region" attribute, in JSONAuthorization json file be [huynhja] GEODE-1316: Changing @since tags to @GemFire or

Jenkins build is back to normal : Geode-nightly #487

2016-06-02 Thread Apache Jenkins Server
See