Re: Publishing of geode javadocs

2016-08-12 Thread William Markito
+1 for that as well. Sent from my iPhone > On Aug 12, 2016, at 5:15 PM, Kirk Lund wrote: > > +1 I'd love to have this in place. What do others think? > > > On Fri, Aug 12, 2016 at 5:13 PM, Roman Shaposhnik > wrote: > >>> On Fri, Aug 12, 2016 at 4:51 PM, Dan Smith wrote: >>> I'm not sure

Re: Review Request 51064: GEODE-1775: annotate test with FlakyTest category

2016-08-12 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51064/#review145683 --- Ship it! Ship It! - Dan Smith On Aug. 13, 2016, 12:33 a.m.,

Review Request 51064: GEODE-1775: annotate test with FlakyTest category

2016-08-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51064/ --- Review request for geode, Jason Huynh, nabarun nag, and Dan Smith. Bugs: GEODE-

Review Request 51063: GEODE-1648: fix new javadocs on security-enabled-components

2016-08-12 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51063/ --- Review request for geode, Anthony Baker and Kevin Duling. Bugs: GEODE-1648

Re: Publishing of geode javadocs

2016-08-12 Thread Kirk Lund
+1 I'd love to have this in place. What do others think? On Fri, Aug 12, 2016 at 5:13 PM, Roman Shaposhnik wrote: > On Fri, Aug 12, 2016 at 4:51 PM, Dan Smith wrote: > > I'm not sure if we're publishing the nightly javadocs anywhere, but you > can > > build them from source. If you do a ./grad

Re: Publishing of geode javadocs

2016-08-12 Thread Roman Shaposhnik
On Fri, Aug 12, 2016 at 4:51 PM, Dan Smith wrote: > I'm not sure if we're publishing the nightly javadocs anywhere, but you can > build them from source. If you do a ./gradlew build, the external javadocs > are in geode-assembly/build/install/apache-geode/javadoc One solution that worked well for

Re: Publishing of geode javadocs

2016-08-12 Thread Kirk Lund
The javadocs on ConfigurationProperties look fine in the html generated by gradle, but it doesn't render properly in IntelliJ (some properties have javadocs that are fine but more complex ones are broken in the IDE). I think we should prefer having javadocs that are useful both in IDEs and as html

Re: Publishing of geode javadocs

2016-08-12 Thread Kirk Lund
We really need to find an automated solution for discovering javadoc errors earlier than manual inspection or looking for warnings in the gradle output. We change our build to fail on javadoc errors because it starts to fail due to 3rd party library javadocs, but at a minimum there must be some al

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
> On Aug. 12, 2016, 4:28 p.m., Dan Smith wrote: > > geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java, > > line 49 > > > > > > This could probably extend ExternalResou

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51010/ --- (Updated Aug. 12, 2016, 11:58 p.m.) Review request for geode, anilkumar gingade

Re: Publishing of geode javadocs

2016-08-12 Thread Dan Smith
I'm not sure if we're publishing the nightly javadocs anywhere, but you can build them from source. If you do a ./gradlew build, the external javadocs are in geode-assembly/build/install/apache-geode/javadoc -Dan On Fri, Aug 12, 2016 at 4:31 PM, Kirk Lund wrote: > I can find the following from

Re: Review Request 51018: fix diskStats and prStats related to entry count and data size

2016-08-12 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51018/#review145677 --- Ship it! Ship It! - Scott Jewell On Aug. 11, 2016, 11:15 p.m

Publishing of geode javadocs

2016-08-12 Thread Kirk Lund
I can find the following from Google, but this is the javadocs for the M2 release: http://geode.incubator.apache.org/releases/latest/javadoc/ Does this need manual updating for M3? Are we publishing nightly javadocs? When I use CTRL-J (in IntelliJ) on the ConfiguratingProperties class, the java

[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #399 was SUCCESSFUL (with 1423 tests)

2016-08-12 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #399 was successful. --- Scheduled 1425 tests in total. https://build.spring.io/browse/SGF-NAG-399/ -- This

[GitHub] incubator-geode pull request #228: GEODE-1673: Use security.json as default

2016-08-12 Thread gracemeilen
Github user gracemeilen closed the pull request at: https://github.com/apache/incubator-geode/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] incubator-geode pull request #224: GEODE-1648: Introduce security-enabled-co...

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

2016-08-12 Thread Ken Howe
> On Aug. 11, 2016, 7:23 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java, > > line 200 > > > > > > I see. This is a bit different than what I expe

Re: Experimental features for 1.0

2016-08-12 Thread Real Wes
That did it. > On Aug 12, 2016, at 3:10 PM, William Markito wrote: > > I've just updated it, can you please try again ? > > Thanks > > On Fri, Aug 12, 2016 at 11:30 AM, John Blum wrote: > >> Hi William- >> >> Says your filter does not exist or is private, even when logged in. >> >> Thanks,

Re: Experimental features for 1.0

2016-08-12 Thread John Blum
Yep, were good... Thanks William! On Fri, Aug 12, 2016 at 12:10 PM, William Markito wrote: > I've just updated it, can you please try again ? > > Thanks > > On Fri, Aug 12, 2016 at 11:30 AM, John Blum wrote: > > > Hi William- > > > > Says your filter does not exist or is private, even when logg

Re: Experimental features for 1.0

2016-08-12 Thread William Markito
I've just updated it, can you please try again ? Thanks On Fri, Aug 12, 2016 at 11:30 AM, John Blum wrote: > Hi William- > > Says your filter does not exist or is private, even when logged in. > > Thanks, > -John > > > On Fri, Aug 12, 2016 at 11:22 AM, William Markito > wrote: > > > Here is th

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java, > > line 189 > > > > > > Will this

Re: Experimental features for 1.0

2016-08-12 Thread John Blum
Hi William- Says your filter does not exist or is private, even when logged in. Thanks, -John On Fri, Aug 12, 2016 at 11:22 AM, William Markito wrote: > Here is the initial list of JIRA's... > > https://issues.apache.org/jira/issues/?filter=12338213 > > This might be a good query to bookmark

Re: Experimental features for 1.0

2016-08-12 Thread William Markito
Here is the initial list of JIRA's... https://issues.apache.org/jira/issues/?filter=12338213 This might be a good query to bookmark and keep track of experimental features. I've also added the UDP SSL support (GEODE-1372 ) to the list. Thanks!

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread Jason Huynh
> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java, > > line 189 > > > > > > Will this

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java, > > line 189 > > > > > > Will this

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread Jason Huynh
> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java, > > line 189 > > > > > > Will this

Geode Clubhouse Thursday, Aug 18, 9AM Pacific: What's New with Spring Data Geode

2016-08-12 Thread Gregory Chase
Dear Geode Community, John Blum will be our guest speaker at the next Geode Clubhouse on Thursday August 18, at 9AM Pacific. He'll give us an update on his latest work with the Spring Data Geode API. Join here | Add reminder to Calendar

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-12 Thread gracemeilen
Github user gracemeilen commented on the issue: https://github.com/apache/incubator-geode/pull/230 Checked in a fix due to a unit test failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

2016-08-12 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51044/#review145636 --- geode-core/src/main/java/com/gemstone/gemfire/management/internal

Re: Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

2016-08-12 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51044/#review145635 --- Ship it! Ship It! - nabarun nag On Aug. 12, 2016, 4:44 p.m.,

Re: Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

2016-08-12 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51044/#review145634 --- geode-core/src/main/java/com/gemstone/gemfire/management/internal

Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

2016-08-12 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51044/ --- Review request for geode, anilkumar gingade and nabarun nag. Repository: geode

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51010/#review145629 --- Looks good! I had a couple of comments about the LocatorServerCon

Re: Geode M3 docs: Review opportunity

2016-08-12 Thread Kirk Lund
Looks great Dave. Thanks! On Thu, Aug 11, 2016 at 3:42 PM, Dave Barnes wrote: > This version of the Geode User Manual has been posted to the public site: > http://geode.docs.pivotal.io/ > > > > On Wed, Aug 10, 2016 at 1:15 PM, William Markito > wrote: > > > LGTM. +1 > > > > Thanks Dave! > > >

Build failed in Jenkins: Geode-nightly #558

2016-08-12 Thread Apache Jenkins Server
See Changes: [boglesby] GEODE-11: Added rate and latency JMX attributes for lucene index metrics [upthewaterspout] GEODE-1742: Fixing synchronization of cqListeners in CqAttributesImpl [upthewaterspout] GEODE-1583: Pass the keep alive

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51010/#review145572 --- geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/Lo

Re: Upgrade test dependency to Awaitility 2.0.0

2016-08-12 Thread Kirk Lund
Note: part of this upgrade will require changing our tests to import org.awaitility instead of com.jaway.awaitility. -Kirk On Thu, Aug 11, 2016 at 5:39 PM, Kirk Lund wrote: > We currently have a dependency on Awaitility 1.7.0. I'd like to upgrade > this to 2.0.0 so we can take advantage of the

Re: Review Request 50967: GEODE-599: CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

2016-08-12 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50967/#review145579 --- Ship it! Ship It! - Darrel Schneider On Aug. 11, 2016, 12:04

Re: Revised SSL properties failure scenario advice.

2016-08-12 Thread Udo Kohlmeyer
Hi there Darrel, You are correct I ssl-certificate-alias and ssl-default-alias would be the same. I must have missed the property You are also correct in stating the question more clearly. If a component provides a specific alias and one has not set the ssl-ceritificate-alias (or sha

[GitHub] incubator-geode pull request #231: Feature/geode 1743

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51010/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, Kirk Lu

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-12 Thread gracemeilen
Github user gracemeilen commented on the issue: https://github.com/apache/incubator-geode/pull/230 Updated this to use StringUtils, added unit tests to verify --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec