Re: An idea for defining custom valves in config.xml

Hi Jason, This is now checked-in. I had to change some naming conventions to have better stack trace information when a Groovy script fails. Scripts must match the patterns Dependencies(.*).groovy and GBeans (.*).groovy to be picked up. Let me know how you go! Thanks, Gianny On 30/10/20

Re: An idea for defining custom valves in config.xml

There's no need to check in what you have if you don't feel it's quite done yet. I was just wondering where you were at. I was eager to have a solution for the original issue find its way into the 2.2 release, and it seems that would be the case. I think that improving the classloading isolation

Re: An idea for defining custom valves in config.xml

Hi Jason, It is implemented and I will check-in over the week-end. Here is the design: 1. When a ConfigurationData is loaded from a ConfigurationStore, its dependencies can be altered based on scripts matching the pattern dependencies-(.*).groovy. Here is the script I have been using to pe

Re: An idea for defining custom valves in config.xml

Hi Gianny, Have you made any progress with this? Are you targeting this for the 2.2 release (whenever that happens to be)? Thanks! On Fri, Oct 17, 2008 at 8:11 PM, Gianny Damour < [EMAIL PROTECTED]> wrote: > Hi, > > I am proposing the following implementation to start with: > > 1. In the META-

Re: An idea for defining custom valves in config.xml

Hi, I am proposing the following implementation to start with: 1. In the META-INF folder of a config, we scan for files matching the patterns "dependencies-(.*).groovy" and "extentions-(.*).groovy". 2. We execute the scripts "dependencies-(.*).groovy" which modify dependencies. For instanc

Re: An idea for defining custom valves in config.xml

On Wed, Oct 15, 2008 at 7:59 PM, David Jencks <[EMAIL PROTECTED]>wrote: > Hi Gianny, > > First, I'd like to make sure I understand the philosophy behind your > proposals. IIUC they both involve the idea of making it easy to modify an > existing plugin rather than making it easy to replace an exis

Re: An idea for defining custom valves in config.xml

While David is more interested in the philosophy, I'd prefer to know a little bit more about your thoughts on implementation. Specifically what do you imagine would be involved in defining this configuration? Would it be as simple as a definition in config.xml? On Thu, Oct 16, 2008 at 4:08 AM, G

Re: An idea for defining custom valves in config.xml

Hi David, You are correct: the underpinning philosophy of these approaches is to make it easier to modify pre-canned plugins through extension points. This may be a good approach to improve further the packaging model of dependencies and services. Let's say that an end-user wants to add a

Re: An idea for defining custom valves in config.xml

Hi Gianny, First, I'd like to make sure I understand the philosophy behind your proposals. IIUC they both involve the idea of making it easy to modify an existing plugin rather than making it easy to replace an existing plugin with a similar one. Why is this a good idea? My idea has bee

Re: An idea for defining custom valves in config.xml

On 15/10/2008, at 4:16 AM, David Jencks wrote: That's one of the main missing bits of functionality. Right now the only way to get the g-p.xml is to use c-m-p or to export the plugin from a server it's been deployed into, or to do something by hand with jar packing and unpacking. The big

Re: An idea for defining custom valves in config.xml

David, I've been trying to follow your steps and seem to be having issues accomplishing the goal. Please see questions inline. On Wed, Oct 8, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED]> wrote: > > On Oct 8, 2008, at 1:55 PM, Joe Bohn wrote: > > Jason Warner wrote: >> >>> Thanks for the e

Re: An idea for defining custom valves in config.xml

On Wed, Oct 8, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED]> wrote: > > On Oct 8, 2008, at 1:55 PM, Joe Bohn wrote: > > Jason Warner wrote: >> >>> Thanks for the explanation, David. I don't disagree with anything you've >>> explained, but I'm not sure you've addressed my concern about the di

Re: An idea for defining custom valves in config.xml

On Oct 8, 2008, at 1:55 PM, Joe Bohn wrote: Jason Warner wrote: Thanks for the explanation, David. I don't disagree with anything you've explained, but I'm not sure you've addressed my concern about the disparity in the effort required to deploy a custom valve on tomcat and on geronimo.

Re: An idea for defining custom valves in config.xml

Jason Warner wrote: Thanks for the explanation, David. I don't disagree with anything you've explained, but I'm not sure you've addressed my concern about the disparity in the effort required to deploy a custom valve on tomcat and on geronimo. Even with the a streamlined process involving a t

Re: An idea for defining custom valves in config.xml

Thanks for the explanation, David. I don't disagree with anything you've explained, but I'm not sure you've addressed my concern about the disparity in the effort required to deploy a custom valve on tomcat and on geronimo. Even with the a streamlined process involving a tomcat server portlet and

Re: An idea for defining custom valves in config.xml

On Oct 8, 2008, at 11:04 AM, Jason Warner wrote: I'm not sure if these steps are reasonable from a purely user perspective. When using plain old tomcat, you can download a binary, add your custom valve jar, make a config change and then use your server with its custom valve. To accomplis

Re: An idea for defining custom valves in config.xml

I'm not sure if these steps are reasonable from a purely user perspective. When using plain old tomcat, you can download a binary, add your custom valve jar, make a config change and then use your server with its custom valve. To accomplish the same task in geronimo, we are asking the user to down

Re: An idea for defining custom valves in config.xml

On Oct 8, 2008, at 7:45 AM, Jason Warner wrote: David, Could you describe to me in a little more detail what you were thinking in regards to defining a new tomcat server in a child classloader? I'm still working on creating an example, but I found some documentation confirming tomcat's

Re: An idea for defining custom valves in config.xml

David, Could you describe to me in a little more detail what you were thinking in regards to defining a new tomcat server in a child classloader? I'm still working on creating an example, but I found some documentation confirming tomcat's use of a TCCL in loading components and would like to cont

Re: An idea for defining custom valves in config.xml

On Mon, Oct 6, 2008 at 1:59 PM, David Jencks <[EMAIL PROTECTED]> wrote: > > On Oct 6, 2008, at 10:35 AM, Jason Warner wrote: > > > > On Mon, Oct 6, 2008 at 11:56 AM, David Jencks <[EMAIL PROTECTED]>wrote: > >> >> On Oct 6, 2008, at 7:22 AM, Jason Warner wrote: >> >> >> >> On Fri, Oct 3, 2008 at 6:

Re: An idea for defining custom valves in config.xml

On Oct 6, 2008, at 10:35 AM, Jason Warner wrote: On Mon, Oct 6, 2008 at 11:56 AM, David Jencks <[EMAIL PROTECTED]> wrote: On Oct 6, 2008, at 7:22 AM, Jason Warner wrote: On Fri, Oct 3, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED]> wrote: On Oct 3, 2008, at 12:51 PM, Jason Warn

Re: An idea for defining custom valves in config.xml

On Mon, Oct 6, 2008 at 11:56 AM, David Jencks <[EMAIL PROTECTED]>wrote: > > On Oct 6, 2008, at 7:22 AM, Jason Warner wrote: > > > > On Fri, Oct 3, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED]>wrote: > >> >> On Oct 3, 2008, at 12:51 PM, Jason Warner wrote: >> >> Hey all. I'm working on an id

Re: An idea for defining custom valves in config.xml

On Oct 6, 2008, at 7:22 AM, Jason Warner wrote: On Fri, Oct 3, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED]> wrote: On Oct 3, 2008, at 12:51 PM, Jason Warner wrote: Hey all. I'm working on an idea for allowing custom valves to be defined in config.xml. Currently this isn't poss

Re: An idea for defining custom valves in config.xml

Jason Warner wrote: On Fri, Oct 3, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED] > wrote: On Oct 3, 2008, at 12:51 PM, Jason Warner wrote: Hey all. I'm working on an idea for allowing custom valves to be defined in config.xml. Currently this is

Re: An idea for defining custom valves in config.xml

On Fri, Oct 3, 2008 at 6:55 PM, David Jencks <[EMAIL PROTECTED]> wrote: > > On Oct 3, 2008, at 12:51 PM, Jason Warner wrote: > > Hey all. I'm working on an idea for allowing custom valves to be defined > in config.xml. Currently this isn't possible since the tomcat classloader > would not cont

Re: An idea for defining custom valves in config.xml

In-line below. David Jencks wrote: On Oct 3, 2008, at 12:51 PM, Jason Warner wrote: Hey all. I'm working on an idea for allowing custom valves to be defined in config.xml. Currently this isn't possible since the tomcat classloader would not contain the custom classes for the valve. I'v

Re: An idea for defining custom valves in config.xml

On Oct 3, 2008, at 12:51 PM, Jason Warner wrote: Hey all. I'm working on an idea for allowing custom valves to be defined in config.xml. Currently this isn't possible since the tomcat classloader would not contain the custom classes for the valve. I've create a jira for tracking this