kkewwei commented on PR #473:
URL:
https://github.com/apache/httpcomponents-core/pull/473#issuecomment-2247018192
> > @ok2c I have added the parameters in `SocketConfig`, but they are not
used anywhere, is that ok?
>
> @kkewwei Why? It is being used in `HttpRequester`, `HttpServer`
ok2c commented on PR #473:
URL:
https://github.com/apache/httpcomponents-core/pull/473#issuecomment-224322
> @ok2c I have added the parameters in `SocketConfig`, but they are not used
anywhere, is that ok?
@kkewwei Why? It is being used in `HttpRequester`, `HttpServer` and
kkewwei commented on PR #473:
URL:
https://github.com/apache/httpcomponents-core/pull/473#issuecomment-2242754778
@ok2c I have added the parameters in `SocketConfig`, but they are not used
anywhere, is that ok?
--
This is an automated message from the Apache Git Service.
To respond to
ok2c commented on PR #473:
URL:
https://github.com/apache/httpcomponents-core/pull/473#issuecomment-2242545374
@kkewwei One last thing. Could you please make symmetric changes to
`SocketConfig` used by the classic transport?
--
This is an automated message from the Apache Git Service.
ok2c commented on PR #473:
URL:
https://github.com/apache/httpcomponents-core/pull/473#issuecomment-2241752695
@kkewwei I am fine with the proposed changes. There is a problem with the
build, however.
--
This is an automated message from the Apache Git Service.
To respond to the
kkewwei commented on PR #473:
URL:
https://github.com/apache/httpcomponents-core/pull/473#issuecomment-2238812266
@ok2c, please have a look when you are free.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kkewwei opened a new pull request, #473:
URL: https://github.com/apache/httpcomponents-core/pull/473
Support setting TCP_KEEPIDLE, TCP_KEEPINTERVAL, TCP_KEEPCOUNT in Socket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238780064
@kkewwei Exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kkewwei commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238730495
@ok2c, how about like this?
```
public void testSetExtendedSocketOption() throws IOException {
..
// 1.Partial versions of jdk1.8 contain
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238686487
@kkewwei I am sorry I could not express myself clearly enough. What I am
trying to say that one can use different asserts or even skip some tests /
asserts altogether when
kkewwei commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238652024
> TestSSLContextBuilder
@ok2c I don't quite understand what you mean. could you describe it more
clearly? very thank you. I should test whether it is supported on a Win
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238551181
@kkewwei You may also consider doing something similar to what
`TestSSLContextBuilder` does to test if the it is being executed on a Win OS
variant.
--
This is an automated
ok2c commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238546136
> If ok, I will modify the unit test.
@kkewwei Yes, that would be enough as far as I am concerned.
--
This is an automated message from the Apache Git Service.
To
kkewwei commented on PR #442:
URL:
https://github.com/apache/httpcomponents-core/pull/442#issuecomment-2238517961
@ok2c, It seems unnecessary to find out why the test fails on windows.
If the user set parameters and httpcomponents does not support , then an
exception will be thrown
massdosage closed pull request #563: Fix behaviour of PublicSuffixMatcher to
match https://github.com/publicsuffix
URL: https://github.com/apache/httpcomponents-client/pull/563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
massdosage commented on PR #563:
URL:
https://github.com/apache/httpcomponents-client/pull/563#issuecomment-510584
Apologies, this is still a work in progress and I meant to submit the PR
against our fork and not the origin. I'm closing this, will create a proper PR
in future when
massdosage opened a new pull request, #563:
URL: https://github.com/apache/httpcomponents-client/pull/563
This PR is just for internal discussion currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ok2c merged PR #472:
URL: https://github.com/apache/httpcomponents-core/pull/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c merged PR #471:
URL: https://github.com/apache/httpcomponents-core/pull/471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
strangelookingnerd commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191642879
> I would not change public vs package visibility, but that's just me, and
the convention we've been using.
The thing is that right now there is a mixture (at
strangelookingnerd commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191634860
> > Make sure tests have at least one assertion
>
> I am aware of this recommendation but I always felt it was not justified /
too extreme.
I myself am
ok2c commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191594071
Oh, that is a big one.
> Make sure tests have at least one assertion
I am aware of this recommendation but I always felt it was not justified /
too extreme.
garydgregory commented on PR #470:
URL:
https://github.com/apache/httpcomponents-core/pull/470#issuecomment-2191613075
I would not change public vs package visibility, but that's just me, and the
convention we've been using.
--
This is an automated message from the Apache Git Service.
strangelookingnerd opened a new pull request, #470:
URL: https://github.com/apache/httpcomponents-core/pull/470
This PR cleans up the test classes. The proposed changes include:
**Remove superfluous exceptions in throws clauses**
Superfluous exceptions within throws clauses have
ok2c merged PR #468:
URL: https://github.com/apache/httpcomponents-core/pull/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sfc-gh-dbouassida closed pull request #560: first commit
URL: https://github.com/apache/httpcomponents-client/pull/560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sfc-gh-dbouassida opened a new pull request, #560:
URL: https://github.com/apache/httpcomponents-client/pull/560
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ok2c merged PR #467:
URL: https://github.com/apache/httpcomponents-core/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c opened a new pull request, #468:
URL: https://github.com/apache/httpcomponents-core/pull/468
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ok2c commented on PR #467:
URL:
https://github.com/apache/httpcomponents-core/pull/467#issuecomment-2144011481
> Overall this looks fine, though it was a much larger change than I had
anticipated.
@erik-wramner True. I ended up rewriting the entire request routing layer as
a
erik-wramner commented on PR #467:
URL:
https://github.com/apache/httpcomponents-core/pull/467#issuecomment-2143943997
Overall this looks fine, though it was a much larger change than I had
anticipated. I only have one question. The code uses
`UriPatternType.URI_PATTERN` and the other
ok2c opened a new pull request, #467:
URL: https://github.com/apache/httpcomponents-core/pull/467
Redesign of server-side request routing:
* support for multiple authorities (defined as hostname / port pair)
* customizable authority resolution / authority normalization
* support for
ok2c merged PR #559:
URL: https://github.com/apache/httpcomponents-client/pull/559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c merged PR #466:
URL: https://github.com/apache/httpcomponents-core/pull/466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on code in PR #559:
URL:
https://github.com/apache/httpcomponents-client/pull/559#discussion_r1602857699
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/memcached/MemcachedOperationCancellationException.java:
##
@@ -0,0 +1,42 @@
+/*
+ *
laststem opened a new pull request, #466:
URL: https://github.com/apache/httpcomponents-core/pull/466
Fix descriptions that seem inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jattisha commented on code in PR #559:
URL:
https://github.com/apache/httpcomponents-client/pull/559#discussion_r1602246401
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/memcached/MemcachedHttpAsyncCacheStorage.java:
##
@@ -161,7 +162,11 @@ private
ok2c commented on PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2083253924
@crazylulululu Merged to `5.2.x` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ok2c merged PR #465:
URL: https://github.com/apache/httpcomponents-core/pull/465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
crazylulululu commented on code in PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#discussion_r1583366968
##
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackDecoder.java:
##
@@ -158,6 +158,10 @@ void decodeString(final ByteArrayBuffer
ok2c commented on code in PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#discussion_r1583023593
##
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/HPackDecoder.java:
##
@@ -158,6 +158,10 @@ void decodeString(final ByteArrayBuffer buffer, final
crazylulululu commented on PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082495455
@ok2c ， I have add the test case ,please help to check , thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ok2c commented on PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082425684
> > @crazylulululu Do you think you could add a test case for this defect to
`TestHPackCoding`?
>
> OK， use this.tmpBuf.position() + extra as the requiredCapacity is error
crazylulululu commented on PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082418772
> @crazylulululu Do you think you could add a test case for this defect to
`TestHPackCoding`?
OK， use this.tmpBuf.position() + extra as the requiredCapacity is
ok2c commented on PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082386349
@crazylulululu Do you think you could add a test case for this defect to
`TestHPackCoding`?
--
This is an automated message from the Apache Git Service.
To respond to the
crazylulululu commented on PR #465:
URL:
https://github.com/apache/httpcomponents-core/pull/465#issuecomment-2082359208
--
This is an automated message from the Apache Git
crazylulululu opened a new pull request, #465:
URL: https://github.com/apache/httpcomponents-core/pull/465
the logic is incorrect ，if a connection is used continuously , it will
generate the G1 Humongous Allocation , and GC will be particularly frequent,
please fix this bug as soon as
dependabot[bot] opened a new pull request, #464:
URL: https://github.com/apache/httpcomponents-core/pull/464
Bumps commons-cli:commons-cli from 1.6.0 to 1.7.0.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #558:
URL: https://github.com/apache/httpcomponents-client/pull/558
Bumps
[com.googlecode.maven-download-plugin:download-maven-plugin](https://github.com/maven-download-plugin/maven-download-plugin)
from 1.8.1 to 1.9.0.
Release notes
ok2c commented on PR #463:
URL:
https://github.com/apache/httpcomponents-core/pull/463#issuecomment-2049173346
Superseded by 45b6138676a568b3c357c0ee5c802dbc964cff75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ok2c closed pull request #463: Avoid unnecessary volatile reads
URL: https://github.com/apache/httpcomponents-core/pull/463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ok2c merged PR #555:
URL: https://github.com/apache/httpcomponents-client/pull/555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2043306992
One more edit, making the Builder constructor not protected means you cannot
extend it. Made an oversight when removing the protected there.
--
This is an automated message
tippl commented on code in PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#discussion_r1556186911
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java:
##
@@ -273,15 +275,24 @@ public final
ok2c commented on code in PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#discussion_r1556181108
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java:
##
@@ -273,15 +275,24 @@ public final
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2043269396
Hopefully this is how you meant it. :)
Yeah, exposing the private variables wasn't ideal, but all of this is kind
of not ideal since it's trying to expose callbacks for
garydgregory commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2042446988
Changing to protected instance variables are a very bad idea IMO: we are
handcuffing ourselves to names, types and details that break encapsulation. A
subclass should
ok2c commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2042084955
> I've also modified the bulilders to allow extending
@tippl Everything looks good to me except for builders. Your change exposes
every single internal implementation
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2041466636
@ok2c Sorry for the delay.
Hopefully this is more to your liking.
I've tried to avoid the need of having to extend the
`PoolingHttpClientConnectionManager` to use a
ok2c commented on PR #463:
URL:
https://github.com/apache/httpcomponents-core/pull/463#issuecomment-2028019357
@rhernandez35 Could you please correct style check violations and ideally
split the change-set into two separate commits? Looks good otherwise.
--
This is an automated message
rhernandez35 opened a new pull request, #463:
URL: https://github.com/apache/httpcomponents-core/pull/463
This commit avoids repeatedly reading volatile instance fields in
ClientH2PrefaceHandler and AbstractCharDataConsumer. This is important for both
performance and correctness,
ok2c merged PR #462:
URL: https://github.com/apache/httpcomponents-core/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ok2c commented on PR #462:
URL:
https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2011603034
@wangkaish There are style-check violations. Please address them. Please
also add `@since 5.3` to a;; new methods. Otherwise looks good.
--
This is an automated message from
wangkaish commented on PR #462:
URL:
https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2011021839
@ok2c There is a method named `isIPv4MappedIPv64Address` in
InetAddressUtils, is that mean `isIPv4MappedIPv6Address`?
--
This is an automated message from the Apache Git
ok2c commented on PR #462:
URL:
https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2009194371
@wangkaish You do something like that
https://github.com/ok2c/httpcomponents-core/commit/96ca1afe17af5e7e4973b21579adf9ebd5a10a69
--
This is an automated message from the
ok2c commented on PR #462:
URL:
https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2009196175
> but in fact the API is compatible
@wangkaish No, it is not. It is compile compatible but binary incompatible.
--
This is an automated message from the Apache Git Service.
wangkaish commented on PR #462:
URL:
https://github.com/apache/httpcomponents-core/pull/462#issuecomment-2009107247
Hi, @ok2c CI indicates that version compatibility check failed, but in fact
the API is compatible, what do I do in this case?
--
This is an automated message from the
wangkaish opened a new pull request, #462:
URL: https://github.com/apache/httpcomponents-core/pull/462
Update the method parameter of InetAddressUtils from String to CharSequence.
Sometimes I need to pass parts of a String(create a String slice) to this
method instead of splitting
wangkaish commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2009032435
@ok2c ok, InetAddressUtils moved to httpcomponents-core, I will create a new
pr to httpcomponents-core and close this pr.
--
This is an automated message from the Apache
wangkaish closed pull request #557: Update the method parameter from String to
CharSequence.
URL: https://github.com/apache/httpcomponents-client/pull/557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ok2c commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008965636
@wangkaish There will be no more changes to 4.5.x. Please port the proposed
change-set to `master`.
--
This is an automated message from the Apache Git Service.
To respond
garydgregory commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008643813
Changing the API from a class to an interface has no such behavioral
guarantee, even if the API binary compatibility is maintained.
IOW there is no proof that
wangkaish commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008608253
Hi @garydgregory
String is an implementation of CharSequence, and the test argument used in
TestInetAddressUtils is String, so I don't think we need a test case with a
garydgregory commented on PR #557:
URL:
https://github.com/apache/httpcomponents-client/pull/557#issuecomment-2008585993
@wangkaish
You'll need to _add_ tests that exercise CharSequence parameter values.
--
This is an automated message from the Apache Git Service.
To respond to the
wangkaish opened a new pull request, #557:
URL: https://github.com/apache/httpcomponents-client/pull/557
Update the method parameter of InetAddressUtils from String to CharSequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004716082
I've come across the idea for these metrics here
micrometer-metrics/micrometer#1617, so I cannot say i'm the only one who wants
these metrics, but the pool of people is
ok2c commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004622070
> Is there a reason for not being able to add the
`HttpClientConnectionOperator` to the builder?
>
@tippl The are two reasons:
1. Internal interfaces ideally
ok2c merged PR #556:
URL: https://github.com/apache/httpcomponents-client/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004560033
> One can subclass `PoolingHttpClientConnectionManager` and pass a custom
`HttpClientConnectionOperator` through the protected super constructor.
Is there a reason for
ok2c commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2003798399
> So there is no way to actually create a PoolingHttpClientConnectionManager
with a custom HttpClientConnectionOperator, either by itself or through the
Builder.
One can
ok2c commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528452045
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528412914
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528370944
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528368485
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528366507
##
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##
@@ -88,7 +88,7 @@ public void
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528356852
##
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##
@@ -99,7 +99,7 @@ public void
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528354232
##
httpclient5/src/test/java/org/apache/hc/client5/http/entity/mime/TestMultipartEntityBuilder.java:
##
@@ -88,7 +88,7 @@ public void
vlsi commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528350724
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity buildEntity() {
michael-o commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-client/pull/556#discussion_r1528332718
##
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##
@@ -253,12 +253,13 @@ MultipartFormEntity
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2002643664
> @tippl Do you mean `PoolingHttpClientConnectionManager` builder? if so, I
would rather not couple it with an internal interface..
@ok2c
As it stands now,
ok2c commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2002636234
> 1. While keeping the `PoolingHttpClientConnectionManager` constructor
internal, should I add a way to provide a custom `HttpClientConnectionOperator`
to the
tippl commented on PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2002499629
> @tippl I apologize if I have said was misleading but the idea was to
provide hooks for performance metrics without exposing the whole thing in the
public APIs.
>
> 1.
tippl opened a new pull request, #555:
URL: https://github.com/apache/httpcomponents-client/pull/555
As discussed on the mailing list, implements a callback for Connection
initialization steps.
Useful for collection of metrics on how long each step takes for network
troubleshooting.
dependabot[bot] commented on PR #459:
URL:
https://github.com/apache/httpcomponents-core/pull/459#issuecomment-1999768275
Superseded by #461.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #459: Bump log4j.version from 2.22.1 to
2.23.0
URL: https://github.com/apache/httpcomponents-core/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #461:
URL: https://github.com/apache/httpcomponents-core/pull/461
Bumps `log4j.version` from 2.22.1 to 2.23.1.
Updates `org.apache.logging.log4j:log4j-slf4j-impl` from 2.22.1 to 2.23.1
Updates `org.apache.logging.log4j:log4j-core` from
dependabot[bot] opened a new pull request, #554:
URL: https://github.com/apache/httpcomponents-client/pull/554
Bumps `log4j.version` from 2.23.0 to 2.23.1.
Updates `org.apache.logging.log4j:log4j-slf4j-impl` from 2.23.0 to 2.23.1
Updates `org.apache.logging.log4j:log4j-core` from
ok2c closed pull request #553: HTTPCLIENT-2321 Clarify default implementation
of HttpClientConnectio…
URL: https://github.com/apache/httpcomponents-client/pull/553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ok2c commented on code in PR #553:
URL:
https://github.com/apache/httpcomponents-client/pull/553#discussion_r1522819492
##
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java:
##
@@ -134,7 +135,27 @@
* exclusive and may not apply when
ok2c merged PR #548:
URL: https://github.com/apache/httpcomponents-client/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1 - 100 of 1262 matches
Mail list logo
