Review Request 17178: Support truncate for non-native tables

2014-01-21 Thread Navis Ryu
/DDLTask.java 92ed55b ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultStorageHandler.java 83772bd ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0e2d555 Diff: https://reviews.apache.org/r/17178/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-01-21 Thread Navis Ryu
/session/SessionManager.java bfe0e7b Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-01-21 Thread Navis Ryu
? It's not introduced by this issue. But I moved logic itself to operation manager. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28950 --

Re: Review Request 15449: session/operation timeout for hiveserver2

2014-01-21 Thread Navis Ryu
----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28855 --- On Nov. 18, 2013, 2:32 a.m., Navis Ryu wrote: > > --

Re: Review Request 17002: alter partition column throws NPE in authorization

2014-01-21 Thread Navis Ryu
/clientnegative/alter_partition_coltype_2columns.q.out e1f9a27 ql/src/test/results/clientpositive/alter_partition_coltype.q.out 685bf88 Diff: https://reviews.apache.org/r/17002/diff/ Testing --- Thanks, Navis Ryu

Review Request 17118: Stats are missing sometimes (regression from HIVE-5936)

2014-01-20 Thread Navis Ryu
/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16728: Implement non-staged MapJoin

2014-01-19 Thread Navis Ryu
erty.q.out 2aa1dae ql/src/test/results/clientpositive/vector_left_outer_join.q.out 0113bb5 ql/src/test/results/clientpositive/vectorized_context.q.out 5cd9f61 ql/src/test/results/clientpositive/vectorized_mapjoin.q.out 13d5489 Diff: https://reviews.apache.org/r/16728/diff/ Testing --- Thanks, Navis Ryu

Review Request 17103: Predicates pushed down to hbase is not handled properly when constant part is shown first

2014-01-18 Thread Navis Ryu
Diff: https://reviews.apache.org/r/17103/diff/ Testing --- Thanks, Navis Ryu

Review Request 17102: Implement show grant on

2014-01-18 Thread Navis Ryu
/clientpositive/authorization_6.q.out 0685c1e ql/src/test/results/clientpositive/authorization_9.q.out PRE-CREATION Diff: https://reviews.apache.org/r/17102/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 17002: alter partition column throws NPE in authorization

2014-01-16 Thread Navis Ryu
<https://reviews.apache.org/r/17002/#comment60796> Didn't noticed that. I'll check this. - Navis Ryu On Jan. 17, 2014, 12:40 a.m., Navis Ryu wrote: > > --- > This is an automatically generated e-mail.

Review Request 17004: Create view does not captures inputs

2014-01-16 Thread Navis Ryu
rc/test/results/clientpositive/view_inputs.q.out 5ea7589 ql/src/test/results/clientpositive/windowing.q.out bbd169f Diff: https://reviews.apache.org/r/17004/diff/ Testing --- Thanks, Navis Ryu

Review Request 17002: alter partition column throws NPE in authorization

2014-01-16 Thread Navis Ryu
/clientpositive/alter_partition_coltype.q.out 685bf88 Diff: https://reviews.apache.org/r/17002/diff/ Testing --- Thanks, Navis Ryu

Review Request 16900: Add "select database()" command to show the current database

2014-01-14 Thread Navis Ryu
/ Testing --- Thanks, Navis Ryu

Re: Review Request 16747: Add file pruning into Hive

2014-01-13 Thread Navis Ryu
/ Testing --- Thanks, Navis Ryu

Re: Review Request 16643: SQL std auth - support 'show all roles'

2014-01-13 Thread Navis Ryu
99dadb0 ql/src/test/queries/clientpositive/show_roles.q PRE-CREATION ql/src/test/results/clientpositive/show_roles.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16643/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2014-01-13 Thread Navis Ryu
sults/clientpositive/mapjoin_hook.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16728: Implement non-staged MapJoin

2014-01-12 Thread Navis Ryu
adoop/hive/ql/plan/MapredLocalWork.java 83a778d ql/src/test/queries/clientpositive/auto_join_without_localtask.q PRE-CREATION ql/src/test/results/clientpositive/auto_join_without_localtask.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16728/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16728: Implement non-staged MapJoin

2014-01-12 Thread Navis Ryu
ork.java 83a778d ql/src/test/queries/clientpositive/auto_join_without_localtask.q PRE-CREATION ql/src/test/results/clientpositive/auto_join_without_localtask.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16728/diff/ Testing ------- Thanks, Navis Ryu

Re: Review Request 16747: Add file pruning into Hive

2014-01-12 Thread Navis Ryu
javadoc for these methods? Here and above/below at least a little > > description if not params :) done - Navis ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16747/#review31518 -

Re: Review Request 16747: Add file pruning into Hive

2014-01-12 Thread Navis Ryu
doop/hive/ql/ppd/OpProcFactory.java 40298e1 ql/src/test/queries/clientpositive/file_pruning.q PRE-CREATION ql/src/test/results/clientpositive/file_pruning.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16747/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2014-01-12 Thread Navis Ryu
ut 7d06739 ql/src/test/results/clientpositive/mapjoin_hook.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16643: SQL std auth - support 'show all roles'

2014-01-12 Thread Navis Ryu
> > other places in this class. > > Ok. I'll find things like this and removed them all. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16643/

Re: Review Request 16643: SQL std auth - support 'show all roles'

2014-01-12 Thread Navis Ryu
/test/queries/clientpositive/show_roles.q PRE-CREATION ql/src/test/results/clientpositive/show_roles.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16643/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16644: MapredLocalTask task does not make virtual columns

2014-01-12 Thread Navis Ryu
/test/results/clientpositive/join_vc.q.out cdbc5c1 Diff: https://reviews.apache.org/r/16644/diff/ Testing --- Thanks, Navis Ryu

Review Request 16747: Add file pruning into Hive

2014-01-08 Thread Navis Ryu
ql/src/test/results/clientpositive/file_pruning.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16747/diff/ Testing --- Thanks, Navis Ryu

Review Request 16728: Implement non-staged MapJoin

2014-01-07 Thread Navis Ryu
RE-CREATION Diff: https://reviews.apache.org/r/16728/diff/ Testing --- Thanks, Navis Ryu

Review Request 16644: MapredLocalTask task does not make virtual columns

2014-01-05 Thread Navis Ryu
a 3cae727 ql/src/test/queries/clientpositive/join_vc.q 63b3da7 ql/src/test/results/clientpositive/join_vc.q.out cdbc5c1 Diff: https://reviews.apache.org/r/16644/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15873: Query cancel should stop running MR tasks

2014-01-05 Thread Navis Ryu
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15873/#review31039 ----------- On Dec. 30, 2013, 6:57 a.m., Navis Ryu wrote: > > --- > This is an aut

Review Request 16643: SQL std auth - support 'show all roles'

2014-01-05 Thread Navis Ryu
/clientpositive/show_roles.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16643/diff/ Testing --- Thanks, Navis Ryu

Review Request 16600: alter exchange is implemented in inverted manner

2014-01-02 Thread Navis Ryu
ge_partition2.q.out 5136106 ql/src/test/results/clientpositive/exchange_partition3.q.out 72ac6bd Diff: https://reviews.apache.org/r/16600/diff/ Testing --- Thanks, Navis Ryu

Review Request 16558: LongWritable.compareTo needs shimming

2014-01-01 Thread Navis Ryu
/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 0d5615c Diff: https://reviews.apache.org/r/16558/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2014-01-01 Thread Navis Ryu
sitive/infer_bucket_sort_convert_join.q.out 7d06739 ql/src/test/results/clientpositive/mapjoin_hook.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15873: Query cancel should stop running MR tasks

2013-12-29 Thread Navis Ryu
62fc150 ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1c84523 ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java ead7b59 Diff: https://reviews.apache.org/r/15873/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-29 Thread Navis Ryu
rc/test/results/clientpositive/mapjoin_hook.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-26 Thread Navis Ryu
> > > Is this one necessary? changed to debug message - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16172/#review30612 ---------

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-26 Thread Navis Ryu
.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-17 Thread Navis Ryu
--- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-17 Thread Navis Ryu
://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-17 Thread Navis Ryu
c/test/results/clientpositive/infer_bucket_sort_convert_join.q.out 7d06739 ql/src/test/results/clientpositive/mapjoin_hook.q.out d60d16e Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-17 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16172/#review30594 --- On Dec. 11, 2013, 2:12 a.m., Navis Ryu wrote: > >

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-17 Thread Navis Ryu
/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d Diff: https://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Review Request 16281: Predicates following UDTF operator are removed by PPD

2013-12-15 Thread Navis Ryu
e00 ql/src/test/results/compiler/plan/join6.q.xml a354e4b ql/src/test/results/compiler/plan/join7.q.xml ac41995 ql/src/test/results/compiler/plan/join8.q.xml 569cf6e Diff: https://reviews.apache.org/r/16281/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-15 Thread Navis Ryu
/org/apache/hive/service/cli/operation/SQLOperation.java 296f8b3 Diff: https://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-15 Thread Navis Ryu
/results/clientpositive/stats_publisher_error_1.q.out a122b83 ql/src/test/results/clientpositive/truncate_column.q.out a247c4a Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Review Request 16172: ql.plan.ConditionalResolverCommonJoin.resolveMapJoinTask also sums those tables which are not used in the child of this conditional task.

2013-12-10 Thread Navis Ryu
plan/TestConditionalResolverCommonJoin.java 67203c9 ql/src/test/results/clientpositive/auto_join25.q.out 7427239 Diff: https://reviews.apache.org/r/16172/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-09 Thread Navis Ryu
a247c4a Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-09 Thread Navis Ryu
removed. Soley used in getHashedStatsPrefix(). I've inlined that. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15993/#review30071 -

Re: Review Request 16034: Add explain authorize for checking privileges

2013-12-09 Thread Navis Ryu
hive/ql/security/authorization/DelegatableAuthorizationProvider.java PRE-CREATION ql/src/test/queries/clientpositive/authorization_explain.q PRE-CREATION ql/src/test/results/clientpositive/authorization_explain.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16034/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-09 Thread Navis Ryu
a247c4a Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-08 Thread Navis Ryu
/src/test/results/clientpositive/stats_counter.q.out f15d8c5 ql/src/test/results/clientpositive/stats_noscan_1.q.out 054ca38 ql/src/test/results/clientpositive/stats_noscan_2.q.out e55fa94 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Review Request 16076: Fix HS2 ResultSet Serialization Performance Regression

2013-12-05 Thread Navis Ryu
://reviews.apache.org/r/16076/diff/ Testing --- Thanks, Navis Ryu

Review Request 16034: Add explain authorize for checking privileges

2013-12-04 Thread Navis Ryu
a PRE-CREATION ql/src/test/queries/clientpositive/authorization_explain.q PRE-CREATION ql/src/test/results/clientpositive/authorization_explain.q.out PRE-CREATION Diff: https://reviews.apache.org/r/16034/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-04 Thread Navis Ryu
993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 16026: No need to aggregate statistics collected via counter mechanism

2013-12-04 Thread Navis Ryu
org/r/16026/#comment57280> comments might be fixed accordantly trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java <https://reviews.apache.org/r/16026/#comment57281> would it better to just adding ", e)" in the end? nit: formats - Navis Ryu On Dec

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-04 Thread Navis Ryu
st/results/clientpositive/stats_noscan_1.q.out 054ca38 ql/src/test/results/clientpositive/stats_noscan_2.q.out e55fa94 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-03 Thread Navis Ryu
/StatsFactory.java 8ae32f0 ql/src/test/queries/clientpositive/stats_counter.q 20769e4 ql/src/test/results/clientpositive/stats_counter.q.out f15d8c5 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Review Request 15993: analyze command failing to collect stats with counter mechanism

2013-12-03 Thread Navis Ryu
f15d8c5 Diff: https://reviews.apache.org/r/15993/diff/ Testing --- Thanks, Navis Ryu

Review Request 15873: Query cancel should stop running MR tasks

2013-11-27 Thread Navis Ryu
/hadoop/hive/ql/exec/TaskRunner.java ead7b59 service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java ecbf3cd Diff: https://reviews.apache.org/r/15873/diff/ Testing --- Thanks, Navis Ryu

Review Request 15855: Check DATABASES/TABLE privilege for metastore authorizer

2013-11-26 Thread Navis Ryu
horization/AuthorizationPreEventListener.java 9a90549 Diff: https://reviews.apache.org/r/15855/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 15820: HIVE-5839: BytesRefArrayWritable compareTo violates contract

2013-11-24 Thread Navis Ryu
tps://reviews.apache.org/r/15820/#comment56556> Took some time to get why this is changed. Could you add some comments on this? - Navis Ryu On Nov. 23, 2013, 4:42 a.m., Xuefu Zhang wrote: > > --- > This is an automatically g

Re: Review Request 15816: HIVE-3181 getDatabaseMajor/Minor version does not return values

2013-11-24 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15816/#review29348 --- Ship it! Ship It! - Navis Ryu On Nov. 23, 2013, 1:40 a.m

Re: Review Request 15449: session/operation timeout for hiveserver2

2013-11-17 Thread Navis Ryu
/service/cli/session/HiveSessionImpl.java cfda752 service/src/java/org/apache/hive/service/cli/session/SessionManager.java e262b72 Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Re: Review Request 15449: session/operation timeout for hiveserver2

2013-11-12 Thread Navis Ryu
/service/cli/session/HiveSessionImpl.java cfda752 service/src/java/org/apache/hive/service/cli/session/SessionManager.java 25c6f38 Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Review Request 15449: session/operation timeout for hiveserver2

2013-11-11 Thread Navis Ryu
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 25c6f38 Diff: https://reviews.apache.org/r/15449/diff/ Testing --- Confirmed in the local environment. Thanks, Navis Ryu

Review Request 15389: Skip useless string encoding stage for hiveserver2

2013-11-09 Thread Navis Ryu
/session/HiveSessionImpl.java cfda752 Diff: https://reviews.apache.org/r/15389/diff/ Testing --- Thanks, Navis Ryu

Re: Review Request 11326: HIVE-4588: Support session level hooks for HiveServer2

2013-08-22 Thread Navis Ryu
-- > > (Updated Aug. 22, 2013, 8:03 a.m.) > > > Review request for hive and Navis Ryu. > > > Bugs: HIVE-4588 > https://issues.apache.org/jira/browse/HIVE-4588 > > > Repository: hive-git > > > Description > --- > >

Re: Review Request: HIVE-4708: Fix TestCliDriver.combine2.q on 0.23

2013-06-11 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11795/#review21775 --- Ship it! Ship It! - Navis Ryu On June 11, 2013, 4:20 a.m

Re: Review Request: HIVE-2503: create per-session HiveConf instance

2012-01-03 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2012-01-04 05:08:24.994913) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-2586 Implement literal float/double type and make possible to compare

2011-12-19 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3073/ --- (Updated 2011-12-20 07:22:34.645716) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2586 Implement literal float/double type and make possible to compare

2011-12-19 Thread Navis Ryu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3073/#review3982 ------- On 2011-12-08 09:33:37, Navis Ryu wrote: > > -

Re: Review Request: HIVE-2503: create per-session HiveConf instance

2011-12-19 Thread Navis Ryu
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/#review3986 ------- On 2011-12-16 05:44:15, Navis Ryu wrote: > > ---

Re: Review Request: HIVE-2503: create per-session HiveConf instance

2011-12-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- (Updated 2011-12-16 05:44:15.242903) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-16 04:23:03.804398) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/#review3943 --- On 2011-12-16 02:09:08, Navis Ryu wrote: > > --- > This

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-16 02:09:08.375278) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-15 Thread Navis Ryu
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/#review3923 ------- On 2011-12-08 04:21:44, Navis Ryu wrote: > > --- > This i

Review Request: HIVE-2586 Implement literal float/double type and make possible to compare

2011-12-08 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3073/ --- Review request for hive, John Sichi and Carl Steinbach. Summary --- Is ther

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-07 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-08 04:21:44.611068) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2329 RS dedup optimization shoud be avoided in some cases

2011-12-07 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1313/ --- (Updated 2011-12-07 08:15:06.858543) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-07 07:43:39.996429) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2332 If all of the parameters of distinct functions are exists in group by columns, query fails in runtime

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1314/ --- (Updated 2011-12-07 07:01:30.547976) Review request for hive, John Sichi and Car

Re: Review Request: HIVE-2340: optimizer for RS-RS-GBY case

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2991/ --- (Updated 2011-12-06 11:02:00.777597) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-06 Thread Navis Ryu
target expression(A) evaluated twice which made some queries slow. But I agree on the 'syntactic sugar' part. Making system functions not visible was requested before (to me). Would it be useful for the problem? - Navis --------

Review Request: HIVE-2264 Hive server is SHUTTING DOWN when invalid queries beeing executed

2011-12-06 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3025/ --- Review request for hive, John Sichi and Carl Steinbach. Summary --- Current

Re: Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- (Updated 2011-12-06 00:17:31.391722) Review request for hive, John Sichi and Car

Review Request: HIVE-2005 Implement BETWEEN operator

2011-12-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/ --- Review request for hive, John Sichi and Carl Steinbach. Summary --- Revised

Review Request: HIVE-2340: optimizer for RS-RS-GBY case

2011-12-02 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2991/ --- Review request for hive. Summary --- Mostly copied from existing code. Not

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-15 Thread Navis Ryu
patch. - Navis --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/#review3281 --- On 2011-11-15 07:06:04, Navis Ryu wrote: > > ---

Re: Review Request: HIVE-2332 If all of the parameters of distinct functions are exists in group by columns, query fails in runtime

2011-11-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1314/ --- (Updated 2011-11-15 08:56:07.599798) Review request for hive and Ashutosh Chauha

Re: Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

2011-11-15 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1304/ --- (Updated 2011-11-15 08:13:13.468713) Review request for hive and namit jain. C

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- (Updated 2011-11-15 07:06:04.002057) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- (Updated 2011-11-15 02:14:32.702033) Review request for hive and Carl Steinbach.

Review Request: HIVE-2573: create per-session function registry

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/ --- Review request for hive and Carl Steinbach. Summary --- Extension from HIVE

Review Request: HIVE-2503: create per-session HiveConf instance

2011-11-14 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2820/ --- Review request for hive and Carl Steinbach. Summary --- We uses multiple Hi

Review Request: HIVE-2332 If all of the parameters of distinct functions are exists in group by columns, query fails in runtime

2011-08-08 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1314/ --- Review request for hive. Summary --- If all of the distinct params are in g

Review Request: HIVE-2329 RS dedup optimization shoud be avoided in some cases

2011-08-07 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1313/ --- Review request for hive. Summary --- If map aggregation is set to false, DI

Re: Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

2011-08-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1304/ --- (Updated 2011-08-05 08:33:16.910890) Review request for hive. Changes ---

Re: Review Request: HIVE-2283 Explain column expressions in *Desc with real table column names

2011-08-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1303/ --- (Updated 2011-08-05 08:31:01.18) Review request for hive. Summary (updated

Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

2011-08-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1304/ --- Review request for hive. Summary --- It's very very rare case.. just for co

Review Request: HIVE-2283 explain column expressions in *Desc with real table column names

2011-08-05 Thread Navis Ryu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1303/ --- Review request for hive. Summary --- clients always wants to know from wher

<    1   2   3   4   5   >