Re: event MPM works with mod_ssl

2005-06-27 Thread Cliff Woolley
On Mon, 27 Jun 2005, Greg Ames wrote: my biggest hurdle in getting the event MPM to work with mod_ssl was learning how to create a self signed server cert with openssl. http://httpd.apache.org/docs-2.0/ssl/ssl_faq.html#ownca is very good but refers to a sign.sh script that I couldn't find

Re: error

2005-06-27 Thread Cliff Woolley
On Mon, 27 Jun 2005, Gustavo A. Baratto wrote: prefork.c:103: error: syntax error before '*' token prefork.c:103: warning: data definition has no type or storage class gmake[4]: *** [prefork.lo] Error 1 gmake[4]: Leaving directory `/home/admin2/src/httpd-2.0.54/server/mpm/prefork' Hmm, I'm

Re: error

2005-06-27 Thread Cliff Woolley
On Mon, 27 Jun 2005, Joe Orton wrote: mpm_common.h does itself include mpm.h fortunately, otherwise the ceiling would indeed have fallen in ;) Naturally, the one place I didn't look. :) Yeah that explains the lack of cave-ins. ;) Thanks Joe.

Re: Running unit test on mod_rewrite

2005-06-10 Thread Cliff Woolley
On Fri, 10 Jun 2005 [EMAIL PROTECTED] wrote: Does anyone know of a way to run unit tests against mod_rewrite? Our unit tests are all in the httpd-test module, which you can check out from our repository. The tests are a bit more heavyweight than what you asked for, but they can still get the

Re: RFC: Who owns a passed brigade?

2005-04-25 Thread Cliff Woolley
On Mon, 25 Apr 2005, Joe Orton wrote: 1. update the util_filter.h documentation 2. add some APR_BUCKET_DEBUG code to abort() when brigades are used after being destroyed 3. adjust all filters to work with this model 4. switch to allocate brigades out of the bucket allocator Didn't we try #4

Re: File attachments...

2005-04-25 Thread Cliff Woolley
On Mon, 25 Apr 2005, Nathanael Noblet wrote: Just curious, is there any reason someone on this list would intentionally attach a file with a .scr ending? Periodically I get the ezmlm program emailing me and complaining that sometimes my address bounces messages back. I've looked and it

Re: Pool buckets, transient buckets and bucket_setaside

2005-04-25 Thread Cliff Woolley
On Mon, 25 Apr 2005, Rici Lake wrote: Why do pool buckets do an automatic setaside? Should they? They set themselves aside when the pool in which their data was allocated is in the process of being destroyed. This is necessary because no other bucket type has a similarly unpredictable

Re: Pool buckets, transient buckets and bucket_setaside

2005-04-25 Thread Cliff Woolley
On Mon, 25 Apr 2005, Rici Lake wrote: Surely this is equally true of any pool-related resource. For example, a file which has been opened and has a pool cleanup registered would have exactly the same lifetime as a pool-allocated string. Hmm... for some reason I thought file buckets morphed

Re: RFC: Who owns a passed brigade?

2005-04-21 Thread Cliff Woolley
On Thu, 21 Apr 2005, Paul Querna wrote: I agree that not having a clear rule has led to some possible leaks in many filters. If some people think there has always been a 'rule', I contend that it has never been documented. That may be. I *believe* the rule was supposed to be that once you

Re: RFC: Who owns a passed brigade?

2005-04-21 Thread Cliff Woolley
On Thu, 21 Apr 2005, Paul Querna wrote: I agree that not having a clear rule has led to some possible leaks in many filters. If some people think there has always been a 'rule', I contend that it has never been documented. FWIW, the documentation says:

Re: RFC: Who owns a passed brigade?

2005-04-21 Thread Cliff Woolley
On Thu, 21 Apr 2005, Cliff Woolley wrote: The caller relinquishes ownership of the brigade. So that documentation came about because of this thread: http://marc.theaimsgroup.com/?l=apache-httpd-devm=106952637722748w=2 I'm not sure that the thread reflected reality, though. Perhaps

Re: Renaming mod_imap - mod_imagemap

2005-04-06 Thread Cliff Woolley
Paul Querna wrote: From the 'Default Modules' thread for renaming mod_imap: +1 Dirk, nd, justin. If there are no objections I will rename mod_imap to mod_imagemap and all the documentation later tonight. +1

Re: Http/APR

2005-03-21 Thread Cliff Woolley
On Mon, 21 Mar 2005, Nathanael Noblet wrote: Just wondering, if I install APR 1.X and then attempt to compile apache 2.0.X, can it use the newer APR? or does it use the built in 0.9.X version of apr? Apache 2.0.x is tied to APR 0.9.x for backward compatibility reasons. That doesn't stop

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Cliff Woolley
On Fri, 18 Mar 2005, Ryan Bloom wrote: disabling sendfile solved it immediately. Seems to me that until our sendfile support is better, we should err on the side of always sending the data correctly instead of absolutely as fast as possible. I would much rather have APR default to not using

Re: Mod_MEM_cache doesn't use Pools to allocate cache objects???

2005-03-08 Thread Cliff Woolley
On Tue, 8 Mar 2005, Bill Stoddard wrote: luca regini wrote: Taking a look at mod_mem_cache source code i have seen that it doesn't use pools to allocate cache objects but i does so by means of reference counting and simple calloc/free calls. I have also seen that this module requires a

Re: Use of brigade_split...

2005-02-18 Thread Cliff Woolley
On Fri, 18 Feb 2005, Paul Querna wrote: First, let me say that apr_brigade_split is evil. It is used in several filters to break up input, or temporarily store some buckets. The problem is that it allocates a new brigade, commonly out of the request pool. Feel free to write a variant that

Re: Permissions

2005-01-16 Thread Cliff Woolley
On Sun, 16 Jan 2005, Jason Rigby wrote: Allow from all computers on the Internet, Deny from the 10.x.x.x subnet, Allow from a particular IP address within the 10.x.x.x subnet (ie 10.0.0.14) Sure, it's possible. Normally this is the kind of question that would be answered on the users's

Re: Dumb APR_BUCKET_BUFF_SIZE question

2005-01-08 Thread Cliff Woolley
On Fri, 7 Jan 2005, Rasmus Lerdorf wrote: I still think it would be worthwhile to make it configurable. Linux or FreeBSD5 on IA64 with 16k pages, for example, might show some decent gains by setting that to 15000. Or do a getpagesize() call on startup to determine it dynamically. It might

Re: Dumb APR_BUCKET_BUFF_SIZE question

2005-01-07 Thread Cliff Woolley
On Fri, 7 Jan 2005, Rasmus Lerdorf wrote: Why is it hardcoded to be 8000? It would seem like you could easily be unlucky and just miss the cutoff and end up with a 6000 byte heap bucket followed by a 3000 byte transient bucket, for example, as a result of 3 3000 byte ap_rwrites. For that

Re: C-L or T-E: chunked for proxied request bodies

2005-01-01 Thread Cliff Woolley
On Sat, 1 Jan 2005, Roy T.Fielding wrote: On Jan 1, 2005, at 1:38 PM, Justin Erenkrantz wrote: Apache 1.3 does not support chunked request bodies. (All 2.x GA releases do though.) So, that factors very much in the reason that I don't think we should send chunks by default: all

Re: Client Authentication POST Problem (fwd)

2004-12-25 Thread Cliff Woolley
This bug was filed a long time ago... http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12355 Can somebody familiar with this part of mod_ssl do me a favor and take a look at it? Thank you! Merry Christmas, everyone. :) --Cliff -- Forwarded message -- Date: Sat, 25 Dec

Re: [STATUS] (httpd-2.0) Wed Dec 15 23:45:15 EST 2004

2004-12-15 Thread Cliff Woolley
I fixed it in SVN trunk. Ken's scripts are still checking this all out from the old CVS repository, which is now closed. Ken, please update your scripts. --Cliff On Thu, 16 Dec 2004, hutuworm wrote: 2.0.52 : released September 28, 2005 as GA. Sorry again. ;) On Wed, 15 Dec 2004

Re: svn commit: r111830 - /httpd/httpd/trunk/modules/proxy/mod_proxy.c /httpd/httpd/trunk/modules/proxy/mod_proxy.h /httpd/httpd/trunk/modules/proxy/proxy_ajp.c /httpd/httpd/trunk/modules/proxy/proxy_http

2004-12-14 Thread Cliff Woolley
On Tue, 14 Dec 2004 [EMAIL PROTECTED] wrote: ap_rputs(apr_strfsize(worker-s-transfered, fbuf), r); trthWr/thtdNumber of bytes transfered/td/tr\n Furthermore, it's transferred. --Cliff

Re: mod_actions 1.32 patch never made it to 2.0

2004-12-13 Thread Cliff Woolley
On Mon, 13 Dec 2004, Ryan Bloom wrote: A co-worker of mine pointed out that the following works in Apache 1.3, but not 2.0 if the location /foo, doesn't exist on the disk: AddHandler foobar /cgi-bin/printenv Location /foo SetHandler foobar /Location This patch ports this behavior

Re: svn commit: r111516 - /httpd/httpd/trunk/support/htcacheclean.c

2004-12-10 Thread Cliff Woolley
On Fri, 10 Dec 2004, Jim Jagielski wrote: I just *hate* ^V-TAB to get real tabs though :) real tabs? feh. no such thing. ;)

Re: svn commit: r111516 - /httpd/httpd/trunk/support/htcacheclean.c

2004-12-10 Thread Cliff Woolley
On Fri, 10 Dec 2004, Jim Jagielski wrote: Dang vi auto-tabbing :) set expandtab :)

Re: [STATUS] (httpd-2.0) Wed Dec 8 23:45:10 EST 2004

2004-12-08 Thread Cliff Woolley
On Thu, 9 Dec 2004, hutuworm wrote: 2.0.52 : released September 28, 2005 as GA. should be 2.0.52 : released September 28, 2004 as GA. LOL. :) There's been a new breakthrough in home video marketing. Instant cassettes. They're out in stores before the movie is finished. I'll go fix

Re: mod_dumpio

2004-12-07 Thread Cliff Woolley
On Tue, 7 Dec 2004, Jim Jagielski wrote: On Dec 6, 2004, at 5:28 PM, Cliff Woolley wrote: On Mon, 6 Dec 2004, William A. Rowe, Jr. wrote: Same location as mod_log_forensic? If you want to move them both into a modules/debug/ location, ++1. mod_bucketeer would be classified

Re: MPM and AcceptMutex questions

2004-12-03 Thread Cliff Woolley
On Fri, 3 Dec 2004, Andy Armstrong wrote: Kristina Clair wrote: I'm running apache2 on redhat 7.3 servers with very heavy http traffic. I'm wondering if it might be wise for me to try to use the worker MPM rather than the default prefork. Does anyone have any real-world experience with

Re: SVN problem

2004-12-02 Thread Cliff Woolley
On Thu, 2 Dec 2004, Andy Armstrong wrote: This isn't supposed to happen is it? :) [EMAIL PROTECTED] apache]$ svn co \ http://svn.apache.org/repos/asf/httpd/httpd/trunk httpd-trunk svn: REPORT request failed on '/repos/asf/!svn/vcc/default' svn: REPORT of '/repos/asf/!svn/vcc/default':

Re: SVN problem

2004-12-02 Thread Cliff Woolley
On Thu, 2 Dec 2004, Garrett Rooney wrote: That is often the result of an uncooperative proxy in the middle, which doesn't understand (or pass through) the HTTP methods used in DAV. Try checking out via https:// (assuming you have a version of Subversion that has ssl support) and see if that

Re: VirtualHost trafic

2004-12-01 Thread Cliff Woolley
On Wed, 1 Dec 2004, [iso-8859-15] André Malo wrote: Furthermore I think you would need to donate the copyright to ASF (but I'm not sure about the latter). No. As long as it's licensed under the Apache License version 2, that gives us the right to redistribute it under the same terms, without

Re: signals under worker mpm?

2004-11-29 Thread Cliff Woolley
On Mon, 29 Nov 2004, Stas Bekman wrote: ./include/ap_mpm.h unix/posix notes: - The MPM does not set a SIGALRM handler, user code may use SIGALRM. But the preferred method of handling timeouts is to use the timeouts provided by the BUFF abstraction. That's an ancient

Re: signals under worker mpm?

2004-11-29 Thread Cliff Woolley
On Mon, 29 Nov 2004, Stas Bekman wrote: nuke it? So this is incorrect? - The MPM does not set a SIGALRM handler, user code may use SIGALRM. It can use it if it knows what it's doing. A mod_perl module that's expected to work on any MPM (which is I'm assuming what you're talking about)

Re: SVN broken?

2004-11-26 Thread Cliff Woolley
On Fri, 26 Nov 2004, Mladen Turk wrote: Trying to: http://svn.apache.org/ or... https://svn.apache.org/ could not connect to server (http://svn.apache.org) Just me or thanksgiving :) I'm working on it. PS, Mladen: in the future, send things like this to infrastructure@ instead of [EMAIL

RE: SVN server down? (fwd)

2004-11-26 Thread Cliff Woolley
-- Forwarded message -- Date: Fri, 26 Nov 2004 13:06:19 -0500 From: Noel J. Bergman [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: Sylvain Wallez [EMAIL PROTECTED], [EMAIL PROTECTED], Shinobu Kawai [EMAIL PROTECTED], Jakarta General List [EMAIL PROTECTED] Subject: RE: SVN

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-26 Thread Cliff Woolley
On Thu, 25 Nov 2004, Joe Orton wrote: Or if it does, -1 veto on either bumping the APR major version or creating a branch or making toast with jam before Allan submits a patch for review on [EMAIL PROTECTED] Okay, well, that means that for progress to be made, some form of patch needs to get

RE: svn down? (fwd)

2004-11-26 Thread Cliff Woolley
It's back. Have fun. :) -- Forwarded message -- Date: Fri, 26 Nov 2004 15:18:08 -0500 From: Noel J. Bergman [EMAIL PROTECTED] To: Daniel John Debrunner [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: RE: svn down? SVN was down for database maintanence. Is back up now.

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-24 Thread Cliff Woolley
On Wed, 24 Nov 2004, Allan Edwards wrote: First order of business now that we are on SVN is to focus on the APR changes that are needed. It's not clear to me though, now that we have an APR 1.0 branch, is the trunk open for API-breaking changes or do we need a separate branch for that work?

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-24 Thread Cliff Woolley
On Wed, 24 Nov 2004, William A. Rowe, Jr. wrote: Allan - your last patches were to try to -wedge- the current API into httpd. Can you share the patch just to fix APR? Then we can start to comprehend scope. NO CASTS - just the correct declarations in the first place. Since this is obviously

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-24 Thread Cliff Woolley
On Wed, 24 Nov 2004, Garrett Rooney wrote: I guess I'm just arguing for a single branch that's the target of the current development, as opposed to one 64 bit dev branch and one trunk which holds other changes, thus requiring us to either invest constant effort in merging changes from the

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-24 Thread Cliff Woolley
On Wed, 24 Nov 2004, Justin Erenkrantz wrote: Oh, please don't. We have *no* idea what the changes are or whether we'll even ultimately accept them. Please branch Allen's changes off in a sandbox (cp trunk branches/64-bit-changes) - let him get a workable version that we can then review,

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-24 Thread Cliff Woolley
On Wed, 24 Nov 2004, Justin Erenkrantz wrote: To be clear, I'm perfectly happy with merging to trunk in Allen's changes *once* completed and reviewed and moving trunk to 2.x if need be - but I Nevertheless, the question at hand is what action to take RIGHT NOW. Let's just wait for... with no

Re: [PATCH] another mod_deflate vs 304 response case

2004-11-23 Thread Cliff Woolley
On Mon, 22 Nov 2004, Roy T. Fielding wrote: Quoting William A. Rowe, Jr. [EMAIL PROTECTED]: Okay, but why the next three lines? Why would Content-Encoding: gzip *ever* be set on a 304? Because Content-* header fields in a 304 response describe what the response entity would contain if

Re: Possible leak in core_output_filter()

2004-11-23 Thread Cliff Woolley
On Tue, 23 Nov 2004, Ronald Park wrote: Now, for the bad news: we don't know if there's a specific single request that creates the problem. In fact, given that it mostly runs Blah, I was afraid of that. :-/ Now for the good news: we can probably run in production with debugging enabled

Re: Possible leak in core_output_filter()

2004-11-23 Thread Cliff Woolley
On Tue, 23 Nov 2004, Jim Jagielski wrote: http://www.apache.org/~jim/mod_dumpio.c Yeah. :-) But mod_dumpio calls apr_bucket_read() unconditionally on data buckets, which is exactly what I *don't* want it to do. Because that modifies the contents of the brigade. The module I'm looking for

Re: [PATCH] another mod_deflate vs 304 response case

2004-11-22 Thread Cliff Woolley
On Mon, 22 Nov 2004, Joe Orton wrote: There's another mod_deflate vs 304 response problem which is being triggered by ViewCVS on svn.apache.org: when a CGI script gives a Status: 304 response the brigade contains a CGI bucket then the EOS, so fails the if this brigade begins with EOS do

Re: [PATCH] another mod_deflate vs 304 response case

2004-11-22 Thread Cliff Woolley
On Mon, 22 Nov 2004, Joe Orton wrote: Okay, but why the next three lines? Why would Content-Encoding: gzip *ever* be set on a 304? I was wondering that too. The answer to the latter is that it *won't* be sent for a 304 because the http_header filter knows better than that. Well, okay.

Re: 2.2 roadmap with respect to APR was Re: [NOTICE] CVS to SVN migration complete

2004-11-22 Thread Cliff Woolley
On Mon, 22 Nov 2004, William A. Rowe, Jr. wrote: Yes - I understand that this means 1.x will never be used by httpd. Version numbers are cheap. The APR project should become used to this, if they are active, and httpd moves at it's normal pace, it would be easy to go through APR 2.x, 3.x,

Re: Whitespace strip filter for httpd v2.1

2004-11-22 Thread Cliff Woolley
On Mon, 22 Nov 2004, Graham Leggett wrote: I have attached a small filter module that strips leading whitespace from text files. This would typically be used to remove the indenting whitespace found inside HTML files, resulting in a significant reduction in network traffic for some sites. I

Re: Possible leak in core_output_filter()

2004-11-22 Thread Cliff Woolley
On Mon, 22 Nov 2004, Ronald Park wrote: I'm investigating a difficult to diagnose problem and I came across the following code in core_output_filter(): Yuck. I HATE the core_output_filter. I probably know that code as well as anybody, and yet every time I look at it, it makes my brain hurt

Re: svn commit: r106072 - httpd/httpd/trunk/modules/http

2004-11-21 Thread Cliff Woolley
On Sun, 21 Nov 2004 [EMAIL PROTECTED] wrote: Author: pquerna Date: Sat Nov 20 21:53:38 2004 New Revision: 106072 Modified: httpd/httpd/trunk/modules/http/http_request.c Log: Compile Fix for Netware Port with CodeWarrior. FYI, this would not be just a CodeWarrior thing... declaring

Re: People still using v1.3 - finding out why

2004-11-19 Thread Cliff Woolley
On Fri, 19 Nov 2004, Peter Friend wrote: I don't work in the same group anymore, so I am not sure where we are with the 2. versions. I do know that we have large number of custom hacks in there, including one I did many moons ago for supporting hundreds of thousands of name based virtual

2.2 roadmap meeting tomorrow

2004-11-14 Thread Cliff Woolley
For any committers interested: we're going to do a lunch meeting tomorrow (Monday) over lunch. Place TBA. I propose Hamburger Mary's since it's close and I haven't been there yet this year. --Cliff

Re: Apr array functions

2004-11-08 Thread Cliff Woolley
On Mon, 8 Nov 2004, Nathanael Noblet wrote: so that someone can use the array elements without removing them? Is there something I don't know that gives a reason why this is bad? You don't have to remove elements to get at them... the array header structure is visible to the application, so it

Re: Apr array functions

2004-11-08 Thread Cliff Woolley
Btw: didn't notice ahead of time that this discussion was on [EMAIL PROTECTED] instead of [EMAIL PROTECTED] Oh well. On Mon, 8 Nov 2004, Cliff Woolley wrote: You don't have to remove elements to get at them... the array header structure is visible to the application, so it can just do arr

Re: Apr array functions

2004-11-08 Thread Cliff Woolley
On Mon, 8 Nov 2004, Nathanael Noblet wrote: Though your assumption about the function I typed in my email, I did type it off the top of my head thus the typos, lots of logic in there is actually from the apr_array_pop() function. If you didn't like the arithmetic on those structure members,

Re: suggestion: strip comments from served html pages

2004-11-07 Thread Cliff Woolley
On Sun, 7 Nov 2004, Nick Kew wrote: On Sun, 7 Nov 2004, Tobias Skytte wrote: Why not introduce and option to remove the comments from the served file? You have that option from mod_xmlns, mod_proxy_html or mod_publisher, to name but three. Along with caveats about why it's not

Re: Use threaded MPM by default was Re: cvs commit: httpd-2.0 STATUS

2004-11-06 Thread Cliff Woolley
On Sat, 6 Nov 2004, Geoffrey Young wrote: MPM on a platform that does not support it, the build process silently switches to prefork (or whatever the default is for the platform, I guess) now, I haven't seen this myself, so I don't want to propagate FUD, but if it's true I might suggest that

Re: [PATCH] add ap_brigade_insert_file()

2004-11-06 Thread Cliff Woolley
On Sat, 6 Nov 2004, Justin Erenkrantz wrote: Point to note that if it goes into APR, it'd have to be in APR-util 1.1. I'd be fine with making httpd depend on 1.1+, but... So, perhaps httpd is 'right' after all. -- justin Well, there's no reason it can't go into apu 1.1 and be backported to

Re: [PATCH] add ap_brigade_insert_file()

2004-11-04 Thread Cliff Woolley
On Thu, 4 Nov 2004, Joe Orton wrote: This factors out the logic for correctly inserting a file into a brigade, doing the special little dance for large files if necessary; the code was already duplicated twice and it's needed in other places too. (pervasive largefile support being my top 2.1

Re: cvs commit: httpd-test/perl-framework/t/security CAN-2004-0940.t

2004-10-28 Thread Cliff Woolley
On Thu, 28 Oct 2004, Geoffrey Young wrote: I get the following failures on 1.3.32 but not on 1.3.33. t/modules/rewrite.t 222 9.09% 18 20 t/security/CAN-2004-0940.t11 100.00% 1 t/security/CAN-2004-0958.t92 22.22% 1 3 I

Re: Test suite for SSI

2004-10-23 Thread Cliff Woolley
On Sat, 23 Oct 2004, Nick Kew wrote: Before proceeding further, I'd like to validate it against any available test suite for SSI/mod_include. Does such a thing exist? Yes, there's a fairly extensive (though certainly not exhaustive) set of mod_include tests in

Re: OpenSSL with Security Processor

2004-10-21 Thread Cliff Woolley
On Thu, 21 Oct 2004, Gurpreet Grewal wrote: Any clues where in the OpenSSL code I should be looking for ensuring that SSL card is actually being used for processing? Looking into openssl-0.9.7d\crypto\engine\hw_ubsec.c didn't help much? You should direct this question to the openssl mailing

Re: [PATCH] Site, ApacheCon 2004

2004-10-16 Thread Cliff Woolley
On Sat, 16 Oct 2004, Sander Striker wrote: I did some mods to the site, highlighting all sessions about httpd, but frankly, it looks totally messy. If someone with a bright idea on how to make this look better wants to take a stab at it, that would be much appreciated. I table-ized it and I

[announce] APR 1.0 Tutorial at ApacheCon

2004-10-14 Thread Cliff Woolley
altogether. Hope to see you there, Cliff T03: Apache Portable Runtime 1.0 Tutorial Day: Sat Time: 09h00 Session chair: None assigned Duration: 180 minutes Style: Tutorial Level: Experienced Audience: Developer Categories: Speaker: Cliff Woolley Speaker: Sander Striker As any systems programmer

Re: mod_status idea

2004-10-08 Thread Cliff Woolley
On Fri, 8 Oct 2004, Eli Marmor wrote: Please check, before adding dependencies on internal data of mod_status, if APR_OPTIONAL_HOOK can help here; mod_status.c defines a status_hook, and maybe it can be used to help. Actually, we would want in this case would be an optional function, not an

Re: Capturing a Subrequest

2004-10-08 Thread Cliff Woolley
On Fri, 8 Oct 2004, Paul Querna wrote: So, I think something about my manually adding my output filter to the subrequest is wrong: Ya, that doesn't look right. There a function that's called (or at least used to be called ;) ap_add_output_filter(). That's probably what you want. --Cliff

Re: Bye bye welcome page

2004-10-06 Thread Cliff Woolley
On Wed, 6 Oct 2004, [ISO-8859-15] André Malo wrote: - there are 1000 people with 1000 other opinions. For that reason, I'm ++1 for taking this minimalistic variant. Otherwise we get never a consensus about this darn dummy page. That's an exceedingly good point. Make it so. :) +1. --Cliff

RE: Bye bye welcome page

2004-10-06 Thread Cliff Woolley
On Wed, 6 Oct 2004, Sander Striker wrote: We can always go with simply displaying a meaningless word like 'Waboozle'. I can see the bugtraq advisory now: Waboozle virus on the loose. ;)

Re: Bye bye welcome page

2004-10-05 Thread Cliff Woolley
On Tue, 5 Oct 2004, Graham Leggett wrote: Point... How about The website you have accessed has not yet been Or: The website you have accessed is running but has not yet been... that speaks to both. configured. Please try to access this website again later.? It's directed at end users, and

Re: segfault in worker mpm

2004-10-03 Thread Cliff Woolley
On Sun, 3 Oct 2004, Stas Bekman wrote: modperl-2.0 'make test' running under worker mpm (linux) always fails in t/filter/both_str_req_add.t and dumps core: #0 0xe410 in ?? () (gdb) bt #0 0xe410 in ?? () #1 0xbfffeff8 in ?? () #2 0x0001 in ?? () #3 0xbfffeff7 in ?? () #4

Re: ap_save_brigade vs ENOTIMPL setaside

2004-10-01 Thread Cliff Woolley
On Fri, 1 Oct 2004, Joe Orton wrote: current mod_perl installations. The mod_perl guys know that the lack of -setaside() is a bug and are working on that for future releases. So a better proposal is this: if setaside() == ENOTIMPL, read() == OK, and then setaside() still == ENOTIMPL, then

Re: cvs commit: httpd-2.0/modules/proxy mod_proxy.c proxy_balancer.c proxy_util.c mod_proxy.h

2004-09-28 Thread Cliff Woolley
On Tue, 28 Sep 2004, Graham Leggett wrote: I'm sorry guys, I've committed those two with CR-LF line endings, and figure out that after the commit. Will be more careful in the future. Not my day obviously :(. No big deal, thanks for fixing it. In theory, the only way CRLF would be a

Re: EOS bucket data?

2004-09-24 Thread Cliff Woolley
On Fri, 24 Sep 2004, Brian Akins wrote: Can an EOS bucket ever have data a filter needs to read? Nope. :) That's what the APR_BUCKET_IS_METADATA flag (or whatever we ended up calling it) is supposed to tell you. --Cliff

Re: EOS bucket data?

2004-09-24 Thread Cliff Woolley
On Fri, 24 Sep 2004, Brian Akins wrote: So read from any thing !APR_BUCKET_IS_METADATA Yep. It doesn't hurt anything to read from a metadata bucket, you just don't *have* to do it. --Cliff

Re: [OT] Developer lists and Reply-To header

2004-09-23 Thread Cliff Woolley
On Thu, 23 Sep 2004, Mladen Turk wrote: I found myself couple of times replying to the original sender by default, while my intention was to reply to the list. The solution is either to 'reply to all' (why would anyone wish to receive two messages about the same subject?) or doing that by

Re: ap_save_brigade vs ENOTIMPL setaside

2004-09-23 Thread Cliff Woolley
On Thu, 23 Sep 2004, Joe Orton wrote: /* ### this ENOTIMPL will go away once we implement setaside ### for all bucket types. */ then that would surely work correctly. Or will I find a massive flameware about this 3 years ago if I search the list archives, I dread

Re: ap_save_brigade vs ENOTIMPL setaside

2004-09-23 Thread Cliff Woolley
On Thu, 23 Sep 2004, Joe Orton wrote: I committed a hacky workaround for this to HEAD, but I think the real bug is that nobody fixed this TODO in ap_save_brigade: /* ### this ENOTIMPL will go away once we implement setaside ### for all bucket types. */ Take a look

Re: [PATCH] APR_BUCKET_INSERT_BEFORE in mod_logio.c

2004-09-20 Thread Cliff Woolley
On Sun, 19 Sep 2004, Joe Schaefer wrote: Index: modules/loggers/mod_logio.c === RCS file: /home/cvspublic/httpd-2.0/modules/loggers/mod_logio.c,v retrieving revision 1.8 diff -u -r1.8 mod_logio.c --- modules/loggers/mod_logio.c

Re: [PATCH] APR_BUCKET_INSERT_BEFORE in mod_logio.c

2004-09-20 Thread Cliff Woolley
On Mon, 20 Sep 2004, Cliff Woolley wrote: (ie, you're inserting it onto brigade b before removing it from brigade a). PS: I should mention that in this case, it's brigade a that will be corrupt, not brigade b, since the inserted bucket's prev and next pointers will simply be overwritten

Re: [PATCH] APR_BUCKET_INSERT_BEFORE in mod_logio.c

2004-09-20 Thread Cliff Woolley
On Mon, 20 Sep 2004, Joe Schaefer wrote: Thanks, Cliff. I guess I was getting confused by the warnings in the apr_ring.h docs. If you can be more specific about what part confused you, I'd be happy to rewrite said docs. If they're confusing as they stand, it's probably my fault anyway. :)

Re: [PATCH] APR_BUCKET_INSERT_BEFORE in mod_logio.c

2004-09-20 Thread Cliff Woolley
On Mon, 20 Sep 2004, Joe Schaefer wrote: Pretty much all the @warning sections that begin with This doesn't work..., i.e. /** * Insert the element nep into the ring before element lep * (..lep.. becomes ..nep..lep..) * @warning This doesn't work for inserting before the first element

Re: Bug 18388: cookies

2004-08-31 Thread Cliff Woolley
On Tue, 31 Aug 2004, Jim Jagielski wrote: Personally, I think that if Roy said that it would cause non-compliance then, unless he changed his mind, that's good enough for me to veto any change that would add Set-Cookie. I strongly agree. Roy? --Cliff

Re: [PATCH] mod_cache fixes: #9

2004-08-02 Thread Cliff Woolley
On Mon, 2 Aug 2004, Roy T.Fielding wrote: Hmm, IIRC, loading a cache means writing to it, not reading from it. Doh. That does ring a bell in the back of my (usually lousy) memory. :) Why not just change them to cache_write and cache_read? Or store and recall? store and recall seem

Re: [PATCH] mod_cache fixes: #9

2004-08-02 Thread Cliff Woolley
On Mon, 2 Aug 2004, Bill Stoddard wrote: How 'bout 2.2 GA for ApacheCon? Seems reasonable to me. ;-) -- justin +1, sounds like a good target to shoot for. +1

Re: Advice on bumping the mmn

2004-06-18 Thread Cliff Woolley
On Fri, 18 Jun 2004, Jean-Jacques Clar wrote: A new API was added in APR (apr_procattr_addrspace_set()) with changes bubbling up in httpd-2.0-head.The API is relevant on NetWare and a no-op on all other platforms. This alone would not require a MMN bump. new field in apr_procattr_t and

Re: dynamic hook ordering

2004-06-18 Thread Cliff Woolley
On Fri, 18 Jun 2004, Geoffrey Young wrote: any feedback on this? the original patch is here: http://marc.theaimsgroup.com/?l=apache-httpd-devm=108693011011443w=2 Sorry, had forgotten to go back and review. I'm forwarding it to my at-work email addr (which doesn't have 59,000 msgs in the

Re: huge memory leak in 2.0.x

2004-06-15 Thread Cliff Woolley
On Tue, 15 Jun 2004, Joe Orton wrote: 2) allocate brigade structures using the bucket allocator If you're going to do this, then surely you need to call apr_pool_cleanup_register() somewhere? === RCS file:

Re: huge memory leak in 2.0.x

2004-06-15 Thread Cliff Woolley
On Tue, 15 Jun 2004, Joe Orton wrote: apr_brigade_create() does that already. Oh, duh, of course it does. As many times as I've looked at that line, you'd think I'd have it memorized by now. :)

Re: cvs commit: httpd-2.0/modules/echo mod_echo.c

2004-06-15 Thread Cliff Woolley
On Tue, 15 Jun 2004 [EMAIL PROTECTED] wrote: * modules/echo/mod_echo.c (process_echo_connection): Fix brigade handling: don't re-use a passed brigade. Hang on.. why is the passed brigade getting destroyed? You're supposed to be able to reuse your brigades after the call stack has returned

Re: cvs commit: httpd-2.0/modules/echo mod_echo.c

2004-06-15 Thread Cliff Woolley
On Tue, 15 Jun 2004, Joe Orton wrote: Hmmm, doing anything with a brigade after you pass it on to the next filter surely breaks the golden caller relinquishes ownership of the brigade rule for using ap_pass_brigade()? I'm saying I thought the rule was expressly opposite that. :)

Re: Accept Filter Backport Request

2004-06-10 Thread Cliff Woolley
On Thu, 10 Jun 2004, Paul Querna wrote: Pretty simple change, is there any chance someone can start a vote on getting it backported to the 2.0 Branch? done. i'll review it myself sometime tonight.

Re: [PATCH] mod_deflate + mod_proxy bug

2004-06-09 Thread Cliff Woolley
On Wed, 9 Jun 2004, Allan Edwards wrote: +} +else { +/* this was a zero length response, remove gzip header bucket then pass down the EOS */ +APR_BUCKET_REMOVE(APR_BRIGADE_FIRST(ctx-bb)); +APR_BUCKET_REMOVE(e); +

Re: [PATCH] mod_deflate + mod_proxy bug

2004-06-09 Thread Cliff Woolley
On Wed, 9 Jun 2004, Allan Edwards wrote: Also just realized I need to add a call to deflateEnd(). Oh right, that too. :-) e is on the brigade passed into deflate_out_filter and the gzip header bucket is in ctx-bb so that is not a problem. Ah, yeah, that would make sense. Cool.

Re: dynamic hook ordering

2004-06-09 Thread Cliff Woolley
On Wed, 9 Jun 2004, Geoffrey Young wrote: I wanted to ping everyone about an idea I've been throwing around for a few months now. I'd like the ability to shuffle the declared hook ordering around, most likely during the post-config phase. There was some discussion about this or something at

Re: reading string in apache

2004-06-04 Thread Cliff Woolley
On Fri, 4 Jun 2004 [EMAIL PROTECTED] wrote: Who write or modificate code mod_ssl or other module? Respond to me, please. A number of people have contributed to the mod_ssl that ships with Apache 2.0. How can read string, if standart C function not work in apache. What is method read? I'm

Re: is it possible to mark buckets to be copied only when to be set-aside?

2004-05-19 Thread Cliff Woolley
On Wed, 19 May 2004, William A. Rowe, Jr. wrote: It's a bug in mod_xslt, if that module trys to set aside a transient bucket. Huh? No it isn't. Half of the reason setaside() even exists is to handle transient buckets. static apr_status_t transient_bucket_setaside(apr_bucket *b, apr_pool_t

Re: is it possible to mark buckets to be copied only when to be set-aside?

2004-05-19 Thread Cliff Woolley
On Wed, 19 May 2004, Cliff Woolley wrote: Note: ap_save_brigade() handles the setaside and brigade concatenation for you. I suspect there are a number of places in the code that we are incorrectly calling APR_BRIGADE_CONCAT() instead of ap_save_brigade(). That's bug city right there. Worse

Re: is it possible to mark buckets to be copied only when to be set-aside?

2004-05-19 Thread Cliff Woolley
On Wed, 19 May 2004, Cliff Woolley wrote: can't just ignore APR_ENOTIMPL for bucket types, because pipe and socket buckets never had setaside implemented on them. I thought I remembered that that was because Greg and Ryan and I had some huge debate about it and it was decided for some reason

  1   2   3   4   5   6   7   8   9   10   >