Re: vote on concept of ServerTokens Off

2006-12-05 Thread Joe Orton
On Tue, Dec 05, 2006 at 06:39:30AM -0500, Jeff Trawick wrote: > A lot of opinions were offered back in August. Some were negative but > I don't see anything that looks like a veto. > > (http://mail-archives.apache.org/mod_mbox/httpd-dev/200608.mbox/[EMAIL > PROTECTED]) > > A concern with the lo

Re: svn commit: r480135 - /httpd/httpd/trunk/modules/http/http_filters.c

2006-11-28 Thread Joe Orton
On Tue, Nov 28, 2006 at 05:36:55PM -, Jim Jagielski wrote: > Author: jim > Date: Tue Nov 28 09:36:45 2006 > New Revision: 480135 > > URL: http://svn.apache.org/viewvc?view=rev&rev=480135 > Log: > Apply patch for PR 41056 (19954) to fix chunk > filter. Now flushes work better. This looks wrong

Re: [PATCH] segfault in httpd-2.0.59, probably namespace conflict between libpcre and libc

2006-11-22 Thread Joe Orton
On Wed, Nov 22, 2006 at 02:15:06PM +0100, François wrote: > On Debian Sarge 3.1 rev2, httpd compiled with external libpcre 4.x and some > RewriteRules segfault occurs every time we start the daemon. 2.0.x doesn't support use of external PCRE, this should be reported to Debian directly since it's

Re: svn commit: r478141 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2006-11-22 Thread Joe Orton
On Wed, Nov 22, 2006 at 06:41:07AM -0600, William Rowe wrote: > Offhand, doesn't ctx pool span the connection? ... > > @@ -1469,8 +1468,7 @@ > > * containing a setaside pool and a brigade which constrain the > > * lifetime of the buffered data. */ > > ctx = apr_palloc(r->pool, siz

Re: [PATCH] log path to config file during startup

2006-11-16 Thread Joe Orton
On Thu, Nov 16, 2006 at 07:45:08AM -0500, Jeff Trawick wrote: > On 10/16/06, Eric Covener <[EMAIL PROTECTED]> wrote: > >Patch below logs the path to the config file just before ap_mpm_run() > > > >Can help clear up some mysteries when posthumously analyzing an ErrorLog > > as a further aid, is it

Re: Time for 2.2.4?

2006-11-08 Thread Joe Orton
On Wed, Nov 08, 2006 at 12:27:31PM -0500, Jim Jagielski wrote: > Mladen Turk wrote: > > > > Jim Jagielski wrote: > > > Looking over CHANGES and STATUS, I think we should > > > start thinking about a 2.2.4 release. Comments? > > > > I would like to propose the backport of proxy alternate > > is_so

Re: cache: the store_body interface

2006-10-31 Thread Joe Orton
On Tue, Oct 31, 2006 at 03:17:18PM +0200, Graham Leggett wrote: > On Tue, October 31, 2006 2:31 pm, Joe Orton wrote: > > > To determine writability of the output filter chain is not as simple as > > exposing writability of the socket. An output filter may block on > &

Re: cache: the store_body interface

2006-10-31 Thread Joe Orton
On Tue, Oct 31, 2006 at 10:59:49AM +, Joe Orton wrote: > On Mon, Oct 30, 2006 at 02:56:24PM -0700, Justin Erenkrantz wrote: > > On 10/30/06, Nick Kew <[EMAIL PROTECTED]> wrote: > > >What does that [#1] break? > > > > > >Seems an easy/low-level solutio

Re: cache: the store_body interface

2006-10-31 Thread Joe Orton
On Tue, Oct 31, 2006 at 02:11:47PM +0200, Graham Leggett wrote: > On Tue, October 31, 2006 2:02 pm, Joe Orton wrote: > > > Being able to determine writability from the output filter chain means > > redesigning the output filtering interface, there is nothing simple > > ab

Re: cache: the store_body interface

2006-10-31 Thread Joe Orton
On Tue, Oct 31, 2006 at 01:49:10PM +0200, Graham Leggett wrote: > On Tue, October 31, 2006 12:59 pm, Joe Orton wrote: > > > I very much sympathise with this argument. But it does mean that the > > storage provider cannot break any of the assumptions mentioned in the > > o

Re: cache: the store_body interface

2006-10-31 Thread Joe Orton
On Mon, Oct 30, 2006 at 02:56:24PM -0700, Justin Erenkrantz wrote: > On 10/30/06, Nick Kew <[EMAIL PROTECTED]> wrote: > >What does that [#1] break? > > > >Seems an easy/low-level solution. Does the provider return a > >status value to say "I have/haven't passed this stuff down the > >chain"? It h

Re: cache: the store_body interface

2006-10-31 Thread Joe Orton
On Mon, Oct 30, 2006 at 10:13:09PM +0100, Ruediger Pluem wrote: > >>> 2) keep the interface as-is, but read buckets in mod_cache and partition > >>> the brigade manually; only pass a "small" brigade with known-length > >>> buckets to the provider. (so no morphing and no arbitrary memory > >>> consu

cache: the store_body interface

2006-10-30 Thread Joe Orton
The existing 2.x store_body interface passed a brigade to the storage provider's store_body() callback. It is impossible for the provider to store all of such a brigade without consuming an arbitrary amount of RAM, since the brigade may contain morphing buckets (a CGI/PIPE bucket is the pathol

Re: mod_cache and its ilk

2006-10-30 Thread Joe Orton
On Mon, Oct 30, 2006 at 10:26:18AM -0700, Justin Erenkrantz wrote: > On 10/30/06, Joe Orton <[EMAIL PROTECTED]> wrote: > >1) cannot write entire response to disk for any content type before > >sending anything to the client; filter acts by writing to cache and > >c

cache API visibility (was Re: svn commit: r468373...)

2006-10-30 Thread Joe Orton
On Mon, Oct 30, 2006 at 09:51:30AM -0700, Justin Erenkrantz wrote: > >It would make > >custom 3rd party modules easier to write too; we could define, say 1 > >as PROVIDER_ID_CUSTOM, making it easier to write add-ons to modules > >which use the provider interface to just write new providers with

Re: mod_cache and its ilk

2006-10-30 Thread Joe Orton
On Mon, Oct 30, 2006 at 12:18:30PM +0200, Graham Leggett wrote: > On Mon, October 30, 2006 12:07 pm, Joe Orton wrote: > > 1) cannot write entire response to disk for any content type before > > sending anything to the client; filter acts by writing to cache and > > client sync

Re: mod_cache and its ilk

2006-10-30 Thread Joe Orton
Thanks Roy. So, the goals for mod_disk_cache as I see it: A simple general-purpose disk cache which makes no assumptions about speed of backend, speed of storage or speed of clients; is single-threaded and does not involve any multi-process synchronisation beyond open/O_EXCL. Specifically: 1

Re: svn commit: r468373 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h modules/cache/mod_mem_cache.c

2006-10-27 Thread Joe Orton
On Fri, Oct 27, 2006 at 11:38:02AM -0300, Davi Arnaut wrote: > > +/* Is our network connection still alive? > > + * If not, we must continue caching the file, so keep > > looping. > > + * We will return the error at the end when caching is > > done.

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-26 Thread Joe Orton
On Thu, Oct 26, 2006 at 05:20:10PM +0200, Plüm, Rüdiger, VF EITO wrote: > > Index: modules/cache/mod_disk_cache.c > > === > > --- modules/cache/mod_disk_cache.c (revision 450104) > > +++ modules/cache/mod_disk_cache.c (working copy)

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-26 Thread Joe Orton
On Thu, Oct 26, 2006 at 11:02:40AM +0200, Graham Leggett wrote: > On Thu, October 26, 2006 10:50 am, Joe Orton wrote: > > > I'm not sure how that is relevant. The core output filter writes to the > > socket directly - it can use non-blocking writes or whatever it likes to

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-26 Thread Joe Orton
On Wed, Oct 25, 2006 at 10:21:26PM +0200, Graham Leggett wrote: > Joe Orton wrote: > > >There is no other acceptable solution AFAICS. Buffering the entire > >brigade (either to disk, or into RAM as the current code does) before > >writing to the client is not OK, p

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-25 Thread Joe Orton
On Wed, Oct 25, 2006 at 01:54:04PM -0300, Davi Arnaut wrote: > Joe Orton wrote: > > Another couple of hundred lines of code and even a new config directive, > > and this still doesn't get close to actually fixing the problem! -1 > > already, this code is just not getti

Re: svn commit: r467655 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h

2006-10-25 Thread Joe Orton
On Wed, Oct 25, 2006 at 01:44:48PM -, Graham Leggett wrote: > Author: minfrin > Date: Wed Oct 25 06:44:47 2006 > New Revision: 467655 > > URL: http://svn.apache.org/viewvc?view=rev&rev=467655 > Log: > mod_cache: Fix an out of memory condition that occurs when the > cache tries to save huge fil

Re: cgi: KILL_AFTER_TIMEOUT vs KILL_ALWAYS

2006-10-25 Thread Joe Orton
On Wed, Oct 25, 2006 at 08:17:22AM +0200, Plüm, Rüdiger, VF EITO wrote: > > > I believe that the parent process, which is supposed to have a 7 > > > second space between its own SIGTERM and SIGKILL, is getting the > > > SIGKILL before it has slept for 3 seconds *and* sent the final > > > SIGKILL

Re: cgi: KILL_AFTER_TIMEOUT vs KILL_ALWAYS

2006-10-24 Thread Joe Orton
On Tue, Oct 24, 2006 at 09:38:07AM -0700, Paul Querna wrote: > Currently, mod_cgi{d} sets APR_KILL_AFTER_TIMEOUT. It appears however, > on a server under high load (>100 load average), it is possible for only > the initial SIGTERM to be sent. It appears that the SIGKILL was never > sent to the

Re: mod_disk_cache summarization

2006-10-24 Thread Joe Orton
On Tue, Oct 24, 2006 at 02:47:09PM +0200, Graham Leggett wrote: > On Tue, October 24, 2006 2:22 pm, Joe Orton wrote: > > Neither is it appropriate to have any process do the "sleep and stat" > > loop waiting for some other process to finish writing a cache file. > >

Re: mod_disk_cache summarization

2006-10-24 Thread Joe Orton
On Mon, Oct 23, 2006 at 10:11:58PM +0200, Graham Leggett wrote: > Brian Akins wrote: > > >Can someone please summarize the various patches for mod_disk_cache that > >have been floating around in last couple weeks? I have looked at the > >patches but wasn't real sure of the general philosophy/me

Re: svn commit: r467014 - in /httpd/httpd/trunk/modules/proxy: ajp.h

2006-10-24 Thread Joe Orton
On Mon, Oct 23, 2006 at 02:45:45PM -0400, Jim Jagielski wrote: > [EMAIL PROTECTED] wrote: > > > > Modified: httpd/httpd/trunk/modules/proxy/ajp.h > > URL: > > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/ajp.h?view=diff&rev=467014&r1=467013&r2=467014 > > ==

Re: Coding style

2006-10-04 Thread Joe Orton
On Mon, Oct 02, 2006 at 05:01:51PM -0700, Roy T. Fielding wrote: > In any case, I prefer the style of C code that more directly reflects > the underlying assembly, even if an optimizing compiler would produce > the same assembler for both. It is just natural to read "use the result > of this save

Re: svn commit: r451006 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c

2006-09-29 Thread Joe Orton
On Thu, Sep 28, 2006 at 08:15:44PM -, [EMAIL PROTECTED] wrote: > --- httpd/httpd/trunk/modules/generators/mod_cgi.c (original) > +++ httpd/httpd/trunk/modules/generators/mod_cgi.c Thu Sep 28 13:15:42 2006 > @@ -837,6 +837,11 @@ > APR_BLOCK_READ, HUGE_STRING_LEN); >

Re: svn commit: r450105 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-09-27 Thread Joe Orton
On Wed, Sep 27, 2006 at 02:41:11PM +0200, Graham Leggett wrote: > On Wed, September 27, 2006 2:31 pm, Joe Orton wrote: > > > The new approach is exactly the same for other bucket types, FILE should > > not be treated as special just to avoid that. Other bucket types will

Re: svn commit: r450105 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-09-27 Thread Joe Orton
On Wed, Sep 27, 2006 at 01:31:05PM +0200, Graham Leggett wrote: > On Wed, September 27, 2006 11:37 am, Joe Orton wrote: > > > I don't get it - as discussed, this approach is completely unsound. > > There is no reason to assume it's possible to copy the entire conte

Re: svn commit: r450105 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c modules/cache/mod_disk_cache.h

2006-09-27 Thread Joe Orton
On Tue, Sep 26, 2006 at 04:26:57PM -, Graham Leggett wrote: > Author: minfrin > Date: Tue Sep 26 09:26:56 2006 > New Revision: 450105 > > URL: http://svn.apache.org/viewvc?view=rev&rev=450105 > Log: > mod_disk_cache: Make caching of large files possible on 32bit machines > by determining wheth

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-09-26 Thread Joe Orton
On Tue, Sep 26, 2006 at 02:20:35PM +0200, Niklas Edmundsson wrote: > On Tue, 26 Sep 2006, Graham Leggett wrote: > > >On Tue, September 26, 2006 1:00 pm, Joe Orton wrote: > > > >>This was discussed a while back. I think this is an API problem which > >>

Re: [PATCH] mod_disk_cache working LFS (filecopy)

2006-09-26 Thread Joe Orton
On Tue, Sep 26, 2006 at 10:52:18AM +0200, Niklas Edmundsson wrote: > > This patch depends on "mod_disk_cache LFS-aware config" submitted > earlier and is for trunk. > > It makes caching of large files possible on 32bit machines by: > > * Realising that a file is a file and can be copied as such

Re: [patch 10/16] fix up coding style issues

2006-09-20 Thread Joe Orton
Hi Davi, On Tue, Sep 19, 2006 at 11:34:03PM -0300, Davi Arnaut wrote: > Clean up code style in the cache code and shrink the mod_mem_cache > store_body function. The casts to/from void * are unnecessary and could just be removed rather than being whitespace-adjusted. > --- modules/cache/mod_mem

Re: [PATCH] split ap_get_server_version() into two functions...

2006-09-01 Thread Joe Orton
On Wed, Aug 30, 2006 at 09:18:02AM -0400, Jeff Trawick wrote: > ... so that ServerTokens doesn't affect what gets logged to the error > log at startup (or any other place where we want the description of > the server instead of the banner to be written over the network). > > This patch axes ap_get

Re: svn commit: r437781 - /httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c

2006-09-01 Thread Joe Orton
On Tue, Aug 29, 2006 at 09:12:02AM -0400, Jim Jagielski wrote: > Joe Orton wrote: > > On Mon, Aug 28, 2006 at 06:57:09PM -, Jim Jagielski wrote: > > > Author: jim > > > Date: Mon Aug 28 11:57:09 2006 > > > New Revision: 437781 > > > > > >

Re: svn commit: r437781 - /httpd/httpd/branches/2.2.x/modules/proxy/mod_proxy_http.c

2006-08-29 Thread Joe Orton
On Mon, Aug 28, 2006 at 06:57:09PM -, Jim Jagielski wrote: > Author: jim > Date: Mon Aug 28 11:57:09 2006 > New Revision: 437781 > > URL: http://svn.apache.org/viewvc?rev=437781&view=rev > Log: > Merge r437768 from trunk: > > Minor nit: why make the logic more complex than it needs to > be ?

Re: svn commit: r429879 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2006-08-09 Thread Joe Orton
On Tue, Aug 08, 2006 at 11:27:25PM -, [EMAIL PROTECTED] wrote: > Author: niq > Date: Tue Aug 8 16:27:25 2006 > New Revision: 429879 > > URL: http://svn.apache.org/viewvc?rev=429879&view=rev > Log: > PR#38448: don't URLencode tilde in path component There is a standard for changelog entries w

Re: [VOTES] please, 2.2.3, 2.0.59, 1.3.37 releases ASAP

2006-07-27 Thread Joe Orton
+1 for release for the 2.0.59 and 2.2.3 tarballs - thanks for RMing! testall passes for both on: PASS: RHEL3/i686 RHEL4/i686 FC4/i686 FC5/i686 RHEL4/x86_64 FC5/x86_64 joe

Re: svn commit: r425677 - /httpd/httpd/branches/2.2.x/STATUS

2006-07-27 Thread Joe Orton
On Thu, Jul 27, 2006 at 10:36:00AM -0700, Sander Temme wrote: ... > The real solution of course, is to upgrade to the current release of > PCRE, version 6.7. However, we should probably not do that on the > stable branches. Agreed. Given that the pcre already shipped and in the tree is patche

Re: svn commit: r425454 - in /httpd/httpd/trunk: CHANGES modules/proxy/NWGNUproxyajp modules/proxy/ajp_utils.c modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules

2006-07-26 Thread Joe Orton
On Tue, Jul 25, 2006 at 04:50:07PM -, Mladen Turk wrote: > Author: mturk > Date: Tue Jul 25 09:50:07 2006 > New Revision: 425454 > > URL: http://svn.apache.org/viewvc?rev=425454&view=rev > Log: > Added cping/cpong support for the AJP protocol. This is missing a prototype in ajp.h: mod_proxy_

Re: svn commit: r424674 - /httpd/httpd/branches/2.0.x/STATUS

2006-07-25 Thread Joe Orton
On Sun, Jul 23, 2006 at 10:58:39PM +0200, Ruediger Pluem wrote: > On 07/23/2006 09:59 PM, William A. Rowe, Jr. wrote: > > Ruediger Pluem wrote: > >> While we are at it. There is another related report (39243, > >> http://issues.apache.org/bugzilla/show_bug.cgi?id=39243). Some > >> people feel unh

Re: svn commit: r424584 - in /httpd/httpd/branches/2.2.x/modules/ssl: mod_ssl.c ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h ssl_util.c

2006-07-24 Thread Joe Orton
On Sun, Jul 23, 2006 at 06:54:33PM +0100, Ben Laurie wrote: > Ruediger Pluem wrote: > > On 07/23/2006 02:10 PM, Ben Laurie wrote: > >> Joe Orton wrote: > >>> - use APR apr_file_* not ANSI C fopen, > >> > >> I need a FILE *. > > > > Ma

Re: svn commit: r424584 - in /httpd/httpd/branches/2.2.x/modules/ssl: mod_ssl.c ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h ssl_util.c

2006-07-23 Thread Joe Orton
On Sat, Jul 22, 2006 at 02:27:44PM -, [EMAIL PROTECTED] wrote: > Author: ben > Date: Sat Jul 22 07:27:43 2006 > New Revision: 424584 > > URL: http://svn.apache.org/viewvc?rev=424584&view=rev > Log: > Add PKCS#7 support. -1. We've had an RTC policy on the stable branch for many years: please

Re: svn commit: r423886 - in /httpd/httpd/trunk: CHANGES server/request.c

2006-07-20 Thread Joe Orton
On Thu, Jul 20, 2006 at 11:01:08AM -, [EMAIL PROTECTED] wrote: > Author: rpluem > Date: Thu Jul 20 04:01:07 2006 > New Revision: 423886 > > URL: http://svn.apache.org/viewvc?rev=423886&view=rev > Log: > * Check for symbolic links of the target file in the optimized case that we > had already

Re: svn commit: r422298 - in /httpd/httpd/trunk/support: ./ Makefile.in

2006-07-17 Thread Joe Orton
On Sun, Jul 16, 2006 at 12:22:32AM +0200, André Malo wrote: > * [EMAIL PROTECTED] wrote: > > > Modified: httpd/httpd/trunk/support/Makefile.in > > > +ifneq (win32,${OS}) > > + PROGRAMS += checkgid fcgistarter > > +endif > > + > > I'm not a Makefile guru, but that doesn't look really portable (o

Re: svn commit: r421686 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_proxy.xml modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/proxy_util.c

2006-07-14 Thread Joe Orton
On Fri, Jul 14, 2006 at 03:35:53PM +0100, Nick Kew wrote: > On Friday 14 July 2006 14:16, Joe Orton wrote: > > > This introduced compiler warnings: > > > > cc1: warnings being treated as errors > > mod_proxy.c: In function `proxy_interpolate': > > m

Re: svn commit: r421686 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_proxy.xml modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h modules/proxy/proxy_util.c

2006-07-14 Thread Joe Orton
On Thu, Jul 13, 2006 at 07:00:26PM -, [EMAIL PROTECTED] wrote: > Author: niq > Date: Thu Jul 13 12:00:26 2006 > New Revision: 421686 > > URL: http://svn.apache.org/viewvc?rev=421686&view=rev > Log: > Support environment variable interpolation in reverse proxy configuration This introduced com

Re: HTTP messages

2006-06-30 Thread Joe Orton
On Thu, Jun 29, 2006 at 07:59:25PM -0700, Paul Adamczyk wrote: > While testing HTTP messages on popular Web sites, I've > observed that the same message sent to the same > version of the Apache server can return completely > different results. Obviously, most of the results are > due to user confi

Re: svn commit: r416265 - in /httpd/httpd/trunk/modules/ssl: mod_ssl.c ssl_engine_config.c ssl_engine_io.c ssl_private.h

2006-06-22 Thread Joe Orton
On Thu, Jun 22, 2006 at 06:13:08AM -, William Rowe wrote: > Author: wrowe > Date: Wed Jun 21 23:13:07 2006 > New Revision: 416265 > > URL: http://svn.apache.org/viewvc?rev=416265&view=rev > Log: > > New SSLLogLevelDebugDump [ None (default) | IO (not bytes) | Bytes ] > configures the I/O

Re: Trouble with the bundled PCRE

2006-06-20 Thread Joe Orton
On Tue, Jun 20, 2006 at 11:39:29AM +0100, Ivan Ristic wrote: > I have a problem with the bundled PCRE that I am not sure how to > resolve. Basically, in a module I need to access more functionality > than provided by the Apache PCRE wrapper. (More specifically, I need > to perform matching against

Re: svn commit: r413861 - /httpd/httpd/trunk/support/ab.c

2006-06-14 Thread Joe Orton
On Tue, Jun 13, 2006 at 12:28:20PM +0100, Colm MacCarthaigh wrote: > On Tue, Jun 13, 2006 at 12:11:38PM +0100, Joe Orton wrote: > > On Tue, Jun 13, 2006 at 10:51:55AM -, [EMAIL PROTECTED] wrote: > > > Author: colm > > > Date: Tue Jun 13 03:51:54 2006 > > > N

Re: svn commit: r413861 - /httpd/httpd/trunk/support/ab.c

2006-06-13 Thread Joe Orton
On Tue, Jun 13, 2006 at 10:51:55AM -, [EMAIL PROTECTED] wrote: > Author: colm > Date: Tue Jun 13 03:51:54 2006 > New Revision: 413861 > > URL: http://svn.apache.org/viewvc?rev=413861&view=rev > Log: > A keepalive response need not neccessarily have included any content-length > header, handle

Re: restructuring mod_ssl as an overlay

2006-06-09 Thread Joe Orton
On Thu, Jun 08, 2006 at 02:47:59PM -0700, Roy T. Fielding wrote: > to with a URL. That is no big deal. The big deal is that 5D002 > classification also means that it is illegal for the ASF to knowingly > allow anyone residing in, or a citizen of, the T-8 countries, or anyone > on the "denied pers

Re: AW: restructuring mod_ssl as an overlay

2006-06-08 Thread Joe Orton
On Thu, Jun 08, 2006 at 07:00:29AM -0500, William Rowe wrote: > Plüm wrote: > >>Von: Joe Orton > >>On Wed, Jun 07, 2006 at 02:03:33PM -0700, Roy T. Fielding wrote: > >>>Okay, let me put it in a different way. The alternatives are > >>> > >

Re: restructuring mod_ssl as an overlay

2006-06-08 Thread Joe Orton
Thanks for doing the research, Roy. On Wed, Jun 07, 2006 at 02:03:33PM -0700, Roy T. Fielding wrote: > Okay, let me put it in a different way. The alternatives are > > 1) retain the status quo, forbid distributing ssl binaries, and > include in our documentation that people in banned countries

Re: svn commit: r410757 - /httpd/httpd/trunk/docs/conf/extra/httpd-info.conf.in

2006-06-01 Thread Joe Orton
On Thu, Jun 01, 2006 at 09:17:27AM -0400, Joshua Slive wrote: > On 6/1/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Add example/default allow-from for localhost, please??? > > > > > SetHandler server-status > > Require host .example.com > >+Allow from 127 > > > > I think yo

Re: svn commit: r395211 - /httpd/httpd/trunk/configure.in

2006-06-01 Thread Joe Orton
On Thu, Jun 01, 2006 at 12:27:33PM +0200, Plüm, Rüdiger, VF EITO wrote: > > The "1" requirement is hardcoded in the APR_FIND_APx calls > > anyway, so I > > don't think this is a big deal. They could all be replaced with some > > variable I suppose. > > Can you replace them with a variable, suc

Re: svn commit: r395211 - /httpd/httpd/trunk/configure.in

2006-06-01 Thread Joe Orton
On Thu, May 25, 2006 at 09:01:44PM +0200, Ruediger Pluem wrote: > On 04/19/2006 12:57 PM, > > Author: jorton > > Date: Wed Apr 19 03:57:20 2006 > > New Revision: 395211 ... > > +if test "x$with_included_apr" = "xyes"; then > > + apr_found=reconfig > > + apr_config="$srcdir/srclib/apr/apr-1-conf

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-22 Thread Joe Orton
On Sun, May 21, 2006 at 12:31:00PM +0200, Ruediger Pluem wrote: > On 05/18/2006 10:50 AM, Joe Orton wrote: > > cache_storage.c: In function `cache_generate_key_default': > > cache_storage.c:383: warning: assignment discards qualifiers from pointer > > target type >

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-18 Thread Joe Orton
On Wed, May 17, 2006 at 07:16:43PM -, [EMAIL PROTECTED] wrote: > --- httpd/httpd/trunk/modules/cache/cache_storage.c (original) > +++ httpd/httpd/trunk/modules/cache/cache_storage.c Wed May 17 12:16:43 2006 ... > @@ -375,15 +380,18 @@ > } > } > else { > -scheme = "htt

Re: svn commit: r406716 - /httpd/httpd/branches/2.2.x/STATUS

2006-05-17 Thread Joe Orton
On Mon, May 15, 2006 at 06:56:35PM -, [EMAIL PROTECTED] wrote: > Author: sctemme > Date: Mon May 15 11:56:34 2006 > New Revision: 406716 > > URL: http://svn.apache.org/viewcvs?rev=406716&view=rev > Log: > Propose backport of ServerName directive enhancement Hey, let's put new features in the

Re: [Q] is this kind of patches interesting ?

2006-05-17 Thread Joe Orton
On Mon, May 08, 2006 at 10:49:38PM +0200, Christophe Jaillet wrote: > from time to time, I spend time to look at apache code source to see if > something can be cleaned up a bit in the hope either to speed it up or, at > least, to make it more readable. > > For example : > http://issues.apache.org

Re: [PATCH] aborting on OOM

2006-05-11 Thread Joe Orton
On Wed, May 10, 2006 at 07:11:42PM +0100, Colm MacCarthaigh wrote: > On Wed, May 10, 2006 at 10:53:50AM -0700, Garrett Rooney wrote: > > I would personally prefer abort to exit... > > is write()'ing a static error message an option too? I don't know if more effort than this is required to make wr

[PATCH] aborting on OOM

2006-05-10 Thread Joe Orton
There a few choices for what to do in the oom handler: 1.3 fprintf's to stderr, then does exit(1), which doesn't seem particularly wise since fprintf can itself malloc; could do similarly, could just exit(1) or even just exit(APEXIT_CHILDSICK); but then nothing gets logged. With abort() at lea

Re: Dealing with Regressions

2006-05-09 Thread Joe Orton
On Mon, May 08, 2006 at 10:12:58AM -0400, Jim Jagielski wrote: > > On May 8, 2006, at 7:36 AM, Nick Kew wrote: > > >OK, we all know we get some embarrassing regressions in our new > >releases. PR#39490 in 1.3.35. > > That is an unexpected and unwelcome regression. If I had > known about it I wo

Re: apr_brigade_insert_file() LFS/Linux issues

2006-05-04 Thread Joe Orton
On Thu, May 04, 2006 at 01:04:08PM +0200, Niklas Edmundsson wrote: > On Thu, 4 May 2006, Joe Orton wrote: > > >>This was on XFS and on an NFS mount. It should be noted that this > >>works on a 32bit (also Ubuntu Breezy) machine with identical config. > > >

Re: apr_brigade_insert_file() LFS/Linux issues

2006-05-04 Thread Joe Orton
On Thu, May 04, 2006 at 10:26:56AM +0200, Niklas Edmundsson wrote: > On Thu, 4 May 2006, Joe Orton wrote: > >OK, what filesystem? Colm had reported the same thing on Debian/IA64, > >which was on an NFS mount, IIRC. If you adjust apr_brigade_insert_file > >to only allow bucke

Re: Possible new cache architecture

2006-05-03 Thread Joe Orton
On Wed, May 03, 2006 at 02:07:44PM +0200, Plüm, Rüdiger, VF EITO wrote: > > -Ursprüngliche Nachricht- > > Von: Joe Orton > > > > The way I would expect it to work would be by passing f->next in to > > the store_body callback, it looks doomed to e

Re: apr_brigade_insert_file() LFS/Linux issues

2006-05-03 Thread Joe Orton
On Wed, May 03, 2006 at 05:46:09PM +0200, Niklas Edmundsson wrote: > On Wed, 3 May 2006, Joe Orton wrote: > > >>I've run into apr_brigade_insert_file() creating brigades that's not > >>possible to sendfile() (EINVAL), this is with httpd-2.2.2 on Ubuntu > >

Re: apr_brigade_insert_file() LFS/Linux issues

2006-05-03 Thread Joe Orton
On Wed, May 03, 2006 at 02:39:33PM +0200, Niklas Edmundsson wrote: > I've run into apr_brigade_insert_file() creating brigades that's not > possible to sendfile() (EINVAL), this is with httpd-2.2.2 on Ubuntu > Breezy Linux amd64 (64bit). The file in question is 4.3GB, and it > seems that sendfil

Re: r382799 - /httpd/httpd/trunk/modules/ssl/ssl_scache_shmcb.c

2006-05-03 Thread Joe Orton
On Sun, Mar 05, 2006 at 01:21:08AM -0500, Geoff Thorpe wrote: > On March 3, 2006 08:11 am, Joe Orton wrote: > [snip] > > Log: > > * modules/ssl/ssl_scache_shmcb.c (shmcb_safe_clear): Mark with > > "noinline" attribute for GCC > 3. > [snip] > >

Re: Possible new cache architecture

2006-05-03 Thread Joe Orton
On Tue, May 02, 2006 at 02:21:27PM +0200, Plüm, Rüdiger, VF EITO wrote: > Another thing: I guess on systems with no mmap support the current > implementation > of mod_disk_cache will eat up a lot of memory if you cache a large local file, > because it transforms the file bucket(s) into heap bucket

Re: svn commit: r396063 - in /httpd/httpd/trunk: modules/proxy/config.m4 modules/proxy/fcgi_protocol.h modules/proxy/mod_proxy_balancer.c modules/proxy/mod_proxy_fcgi.c support/ support/Makefile.in su

2006-04-28 Thread Joe Orton
On Sat, Apr 22, 2006 at 03:44:07AM -, [EMAIL PROTECTED] wrote: > Author: rooneg > Date: Fri Apr 21 20:44:05 2006 > New Revision: 396063 > > URL: http://svn.apache.org/viewcvs?rev=396063&view=rev > Log: > Merge the fcgi-proxy-dev branch to trunk, adding a FastCGI back end for > mod_proxy. This

Re: [VOTE] 2.2.2 Candidate

2006-04-27 Thread Joe Orton
On Fri, Apr 21, 2006 at 09:35:23PM -0700, Paul Querna wrote: > Please test and vote on releasing httpd 2.2.2, bundling APR and APR-Util > 1.2.7. Belatedly +1, testall passes for: PASS: RHEL4/ppc64 RHEL3/i686 RHEL4/i686 FC5/i686 FC4/i686 RHEL3/ppc64 FC3/i686 RHEL3/x86_64 FC5/x86_64

Re: Large file support in 2.0.56?

2006-04-18 Thread Joe Orton
On Mon, Apr 17, 2006 at 02:40:13PM +0100, Colm MacCarthaigh wrote: > On Mon, Apr 17, 2006 at 09:09:12AM -0400, Jeff Trawick wrote: > > On 4/15/06, Brandon Fosdick <[EMAIL PROTECTED]> wrote: > > > I might have asked this before, but I've forgotten the answer, and so has > > > google. Has any of the

pcre (was Re: [VOTE] Release 2.2.1 as GA)

2006-04-08 Thread Joe Orton
On Fri, Apr 07, 2006 at 02:47:22PM -0500, William Rowe wrote: > It brings up a good question, which contributors are monitoring our > flavor of pcre for updates from the pcre community, and liasoning back > our changes to pcre to it's project? I would expect that anybody who commits local changes

Re: When did this break?

2006-04-03 Thread Joe Orton
On Mon, Apr 03, 2006 at 08:53:24AM +0100, Joe Orton wrote: > What's really needed here is a "--with-included-apr"-type flag which > forces use of the bundled sources over installed versions, rather than > trying to overload --with-apr to do that. e.g. this, slightly hac

Re: When did this break?

2006-04-03 Thread Joe Orton
On Fri, Mar 31, 2006 at 03:23:11PM -0600, William Rowe wrote: > It seems this can be trivially solved by ensuring we defer this test until > after we invoke the sub-configure of apr and apr-util. The "sufficient version" test is currently only used if the sub-configure of ap[ru] is *not* invoked

Re: SSL_CLIENT_CERT header bad format

2006-03-22 Thread Joe Orton
On Wed, Mar 22, 2006 at 11:44:08AM +0100, Marc Stern wrote: > I use %{SSL_CLIENT_CERT}e with 2.0.54 (patched to get mod_ssl headers). > Is this the problem ? Was it fixed after 2.0.54 ? Yes, 2.2.0 has the %{...}s support which does this properly. There's a backport for 2.0 here: http://people.ap

Re: SSL_CLIENT_CERT header bad format

2006-03-22 Thread Joe Orton
On Wed, Mar 22, 2006 at 08:28:35AM +0100, Marc Stern wrote: > It seems that the PEM-encoded certificate coming out of OpenSSL (0.9.8a in > my case) contains new lines without leading space, which is interpreted as a > new HTTP header. In what configuration does this happen? If you are using %{SS

Re: svn commit: r386792 - /httpd/httpd/trunk/acinclude.m4

2006-03-21 Thread Joe Orton
On Sat, Mar 18, 2006 at 02:26:21AM -, Justin Erenkrantz wrote: > Author: jerenkrantz > Date: Fri Mar 17 18:26:19 2006 > New Revision: 386792 > > URL: http://svn.apache.org/viewcvs?rev=386792&view=rev > Log: > * acinclude.m4: When enabling a static library, ensure that the module's > dependen

mod_authz_core:check_provider_list bug?

2006-03-09 Thread Joe Orton
Found by the Coverity report, this one looks like a real bug: check_provider_list has a if() branch to handle the passed-in current_provider being NULL, but never sets it to anything else; current_provider is later dereferenced unconditionally. joe

Re: [Bug 38070] - httpd returns status code 200 instead 304, but logged 304 in log.

2006-02-28 Thread Joe Orton
On Wed, Feb 22, 2006 at 12:53:25PM +, Joe Orton wrote: > On Tue, Feb 21, 2006 at 03:45:39PM +, Nick Kew wrote: > > Not as such. It doesn't need to: it's a MUST in CGI: > > > > 7.2.1.3. Status > > The "Status" header field is used

proxy keepalive handling

2006-02-27 Thread Joe Orton
(somewhat more appropriate $SUBJECT now ;) On Thu, Feb 23, 2006 at 10:20:08PM +0100, Ruediger Pluem wrote: > There is an interesting bug regarding this topic: > > http://issues.apache.org/bugzilla/show_bug.cgi?id=38763 > > It seems that we do not have to worry about resending POSTs at all becaus

Re: [Bug 38070] - httpd returns status code 200 instead 304, but logged 304 in log.

2006-02-22 Thread Joe Orton
On Tue, Feb 21, 2006 at 03:45:39PM +, Nick Kew wrote: > On Tuesday 21 February 2006 14:56, Joe Orton wrote: > > > > > >I've prepared a (simpler) alternative patch, which fixes the real > > > > > issue and will make packages available for testing. &

Re: [Bug 38070] - httpd returns status code 200 instead 304, but logged 304 in log.

2006-02-21 Thread Joe Orton
On Tue, Feb 21, 2006 at 11:32:07AM +, Nick Kew wrote: > On Tuesday 21 February 2006 09:49, [EMAIL PROTECTED] wrote: > > >The fix committed upstream prevents handling of conditional requests with > > > a CGI script which outputs an explicit (albeit redundant) "Status: 200" > > > header. This wo

Re: svn commit: r378032 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2006-02-21 Thread Joe Orton
On Tue, Feb 21, 2006 at 12:32:32AM +0100, Ruediger Pluem wrote: > > > On 02/20/2006 11:50 AM, Joe Orton wrote: > > >> > >>Maybe. Got another idea in the meantime. Maybe it is because we use the same > >>socket to a backend, but we create a new conn_rec

Re: svn commit: r378032 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2006-02-20 Thread Joe Orton
On Mon, Feb 20, 2006 at 12:52:31PM +0100, Plüm, Rüdiger, VIS wrote: > > I found only one pertinent error message in the log: > > > > [Mon Feb 20 10:40:08 2006] [debug] proxy_util.c(2118): proxy: HTTP: > > connection complete to 127.0.0.1:8529 (localhost.localdomain) > > But this is HTTP to the

Re: svn commit: r378032 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2006-02-20 Thread Joe Orton
On Mon, Feb 20, 2006 at 11:30:02AM +0100, Plüm, Rüdiger, VIS wrote: > > > >> -Ursprüngliche Nachricht----- > >> Von: Joe Orton > >> > > >> http://mail-archives.apache.org/mod_mbox/httpd-dev/200602.mbox > /ajax/[EMAIL PROTECTED] > >>

Re: svn commit: r378032 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2006-02-20 Thread Joe Orton
On Mon, Feb 20, 2006 at 10:53:27AM +0100, Plüm, Rüdiger, VIS wrote: > > Von: Joe Orton > > > New Revision: 378032 > > > > > > URL: http://svn.apache.org/viewcvs?rev=378032&view=rev > > > Log: > > > *) mod_proxy: Fix KeepAlives not being

Re: svn commit: r378032 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c

2006-02-20 Thread Joe Orton
On Wed, Feb 15, 2006 at 04:44:43PM -, Jim Jagielski wrote: > Author: jim > Date: Wed Feb 15 08:44:42 2006 > New Revision: 378032 > > URL: http://svn.apache.org/viewcvs?rev=378032&view=rev > Log: > *) mod_proxy: Fix KeepAlives not being allowed and set to > backend servers. PR38602. [Rue

Re: Change in how to configure authorization

2006-02-17 Thread Joe Orton
On Tue, Feb 14, 2006 at 11:11:22AM -0700, Brad Nicholes wrote: > >>> On 2/14/2006 at 3:50 am, in message > <[EMAIL PROTECTED]>, > [EMAIL PROTECTED] wrote: > > On Mon, Feb 13, 2006 at 03:42:27PM -0700, Brad Nicholes wrote: > >> > >> The other problem that I see in the configuration is that the > >

Re: filters that change r->status[_line]

2006-02-17 Thread Joe Orton
On Fri, Feb 17, 2006 at 11:03:54AM -0500, Jeff Trawick wrote: > On 2/16/06, Jeff Trawick <[EMAIL PROTECTED]> wrote: ... > > The range support right now isn't smart enough to clear r->status_line > > when it sets a new status code (206, 416). That needs to be fixed to > > avoid breaking range reque

Re: Change in how to configure authorization

2006-02-14 Thread Joe Orton
On Mon, Feb 13, 2006 at 03:42:27PM -0700, Brad Nicholes wrote: > >>> On 2/13/2006 at 8:39:41 am, in message > <[EMAIL PROTECTED]>, > [EMAIL PROTECTED] wrote: > > On Mon, Feb 13, 2006 at 08:26:39AM -0700, Brad Nicholes wrote: > >> Yes, we do need to make this change. With the provider based > >> r

Re: svn commit: r377053 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2006-02-14 Thread Joe Orton
On Tue, Feb 14, 2006 at 12:02:24AM +0100, Ruediger Pluem wrote: > On 02/13/2006 04:37 PM, Joe Orton wrote: > > On Sat, Feb 11, 2006 at 08:57:14PM -, [EMAIL PROTECTED] wrote: > > This change (I think) is triggering the bad pool ancestry abort() in the > > tables code: t

Re: Change in how to configure authorization

2006-02-13 Thread Joe Orton
On Mon, Feb 13, 2006 at 08:26:39AM -0700, Brad Nicholes wrote: > Yes, we do need to make this change. With the provider based > rearchitecting of authentication in httpd 2.2, this left authorization > in an unpredictable state especially when using multiple authorization > types. You were neve

Re: svn commit: r377053 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2006-02-13 Thread Joe Orton
On Sat, Feb 11, 2006 at 08:57:14PM -, [EMAIL PROTECTED] wrote: > Author: rpluem > Date: Sat Feb 11 12:57:12 2006 > New Revision: 377053 > > URL: http://svn.apache.org/viewcvs?rev=377053&view=rev > Log: > * Do not remove the connection headers from r->headers_in. They are needed > by the http

<    5   6   7   8   9   10   11   12   13   14   >